[PATCH] D38446: update comments in clang-format.py for python3 compatibility

2019-09-17 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/ https://reviews.llvm.org/D38446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

2019-11-08 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert added a comment. thanks for the ping. looking back at Code Reviews with Phabricator , the following applies to me: "If you do not have commit access, someone has to commit the change for you (with attribution)." so, yes I need help landing. Rep

[PATCH] D70664: update string comparison in clang-format.py

2019-11-25 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert created this revision. pseyfert added reviewers: MyDeveloperDay, klimek, llvm-commits, cfe-commits. pseyfert added a project: clang-format. Herald added a project: clang. Python 3.8 introduces a SyntaxWarning about string comparisons with 'is'. This commit updates the string comparison i

[PATCH] D70664: update string comparison in clang-format.py

2019-11-25 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert added a comment. PS: I do not have commit access, so someone with the rights would need to land this for me. Thanks in advance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70664/new/ https://reviews.llvm.org/D70664 __

[PATCH] D70864: update trailing newline treatment in clang-format.py

2019-11-29 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert created this revision. pseyfert added reviewers: klimek, MyDeveloperDay. pseyfert added projects: clang-format, clang. The current clang-format.py does not handle trailing newlines at the end of a file correctly. Trailing empty lines get removed except one. As far as I understand this is

[PATCH] D70864: update trailing newline treatment in clang-format.py

2019-11-29 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert updated this revision to Diff 231568. pseyfert added a comment. added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864 Files: clang/tools/clang-format/clang-format.py Index: clang/tools/clang-format/clang-format.py =

[PATCH] D70864: update trailing newline treatment in clang-format.py

2019-12-04 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert added a comment. As a demonstrator I put this docker image together: docker run -it --rm gitlab-registry.cern.ch/pseyfert/vim-clang-format-docker:latest open `vim Chi2PerDoF.h` and hit Ctrl+I. There is a b