probinson created this revision.
probinson added reviewers: dblaikie, aprantl.
probinson added a subscriber: cfe-commits.
'nodebug' on a function will currently suppress all debug info for the function
and its contents.
'nodebug on a static-duration variable will currently suppress debug info for
probinson accepted this revision.
probinson added a reviewer: probinson.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D19003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
probinson added inline comments.
Comment at: include/clang/Basic/Attr.td:976
@@ -975,3 +975,3 @@
let Spellings = [GCC<"nodebug">];
- let Documentation = [Undocumented];
+ let Documentation = [NoDebugDocs];
}
aaron.ballman wrote:
> This isn't your problem to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267746: PR21823: 'nodebug' attribute on global/static
variables. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D19567?vs=55116&id=55260#toc
Repository:
rL LLVM
http://rev
Author: probinson
Date: Wed Apr 27 12:37:12 2016
New Revision: 267746
URL: http://llvm.org/viewvc/llvm-project?rev=267746&view=rev
Log:
PR21823: 'nodebug' attribute on global/static variables.
Make 'nodebug' on a global/static variable suppress all debug info
for the variable. Previously it would
probinson added a comment.
In http://reviews.llvm.org/D19567#413997, @dblaikie wrote:
> For 3 code paths (that seem fairly independent from one another) I'd only
> really expect to see 3 variables in the test - one to exercise each codepath.
> What's the reason for the larger set of test cases?
Author: probinson
Date: Wed Apr 27 17:18:46 2016
New Revision: 267804
URL: http://llvm.org/viewvc/llvm-project?rev=267804&view=rev
Log:
Minor test simplification (per David Blaikie suggestion).
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-nodebug.cpp
Modified: cfe/trunk/test/CodeGenCXX/deb
probinson added a subscriber: probinson.
Comment at: test/Modules/getSourceDescriptor-crash.cpp:1
@@ +1,2 @@
+// RUN: %clang -I %S/Inputs/getSourceDescriptor-crash -c -g
-fimplicit-module-maps %s
+
Should run %clang_cc1 not the driver.
http://reviews.llvm.org/
Author: probinson
Date: Thu Apr 28 12:52:28 2016
New Revision: 267909
URL: http://llvm.org/viewvc/llvm-project?rev=267909&view=rev
Log:
Make the test exercise all paths modified in r267746.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-nodebug.cpp
Modified: cfe/trunk/test/CodeGenCXX/debug-i
probinson created this revision.
probinson added a reviewer: aaron.ballman.
probinson added a subscriber: cfe-commits.
The 'nodebug' attribute had hand-coded constraints; replace those with a
Subjects line in Attr.td.
Also add a missing test to verify the attribute is okay on an Objective-C
meth
probinson added a comment.
I'll proceed from here without doing anything about the inconsistencies,
because this particular one should go away and you're already doing something
about the rest of it.
Comment at: include/clang/Basic/Attr.td:977
@@ -976,1 +976,3 @@
+ let Subjec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268065: Add a Subjects line to NoDebugAttr [NFC]. (authored
by probinson).
Changed prior to commit:
http://reviews.llvm.org/D19689?vs=55482&id=55618#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: probinson
Date: Fri Apr 29 12:03:34 2016
New Revision: 268065
URL: http://llvm.org/viewvc/llvm-project?rev=268065&view=rev
Log:
Add a Subjects line to NoDebugAttr [NFC].
The 'nodebug' attribute had hand-coded constraints; replace those with
a Subjects line in Attr.td.
Also add a missing t
probinson created this revision.
probinson added reviewers: aaron.ballman, dblaikie, aprantl.
probinson added a subscriber: cfe-commits.
Expand the purview of the 'nodebug' attribute from functions/methods and
static-storage variables to include local variables. Parameters and members of
aggreg
probinson added inline comments.
Comment at: include/clang/Basic/Attr.td:86-88
@@ -85,1 +85,5 @@
+def NonParmVar : SubsetSubjectgetKind() != Decl::ImplicitParam &&
+ S->getKind() != Decl::ParmVar &&
+ S->getKind() !=
probinson marked 2 inline comments as done.
Comment at: include/clang/Basic/Attr.td:86-88
@@ -85,1 +85,5 @@
+def NonParmVar : SubsetSubjectgetKind() != Decl::ImplicitParam &&
+ S->getKind() != Decl::ParmVar &&
+ S->ge
probinson updated this revision to Diff 56079.
probinson marked an inline comment as done.
probinson added a comment.
Correct the attribute condition, and refine the Objective-C test.
http://reviews.llvm.org/D19754
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Cod
probinson added a subscriber: probinson.
probinson added a comment.
In http://reviews.llvm.org/D20136#426586, @amccarth wrote:
> now using wide-chars for WinAPI calls,
Dōmo arigatō gozaimashita!
http://reviews.llvm.org/D20136
___
cfe-commits mail
probinson added a subscriber: probinson.
probinson added a comment.
Please make sure the test files have newlines at the end.
"touch-pragma-once.cpp" should probably be named something like
"pragma-once-timestamp.cpp".
http://reviews.llvm.org/D20243
__
Author: probinson
Date: Mon May 16 12:22:25 2016
New Revision: 269671
URL: http://llvm.org/viewvc/llvm-project?rev=269671&view=rev
Log:
[PS4] Change the names of some "environmental" things to what our
licensees actually see in the toolchain we deliver to them. This will
reduce the set of local p
Author: probinson
Date: Mon May 16 16:25:15 2016
New Revision: 269709
URL: http://llvm.org/viewvc/llvm-project?rev=269709&view=rev
Log:
[PS4] Tighten up a test (noticed in passing)
Modified:
cfe/trunk/test/Driver/ps4-linker-win.c
Modified: cfe/trunk/test/Driver/ps4-linker-win.c
URL:
http://
Author: probinson
Date: Wed May 18 10:35:58 2016
New Revision: 269941
URL: http://llvm.org/viewvc/llvm-project?rev=269941&view=rev
Log:
[PS4] Clean up some test commentary. NFC
Modified:
cfe/trunk/test/Driver/ps4-sdk-root.c
Modified: cfe/trunk/test/Driver/ps4-sdk-root.c
URL:
http://llvm.org
probinson added a comment.
This is fine as far as I'm concerned, but I think somebody more familiar with
the area ought to chime in.
http://reviews.llvm.org/D20243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: probinson
Date: Wed Mar 30 17:24:57 2016
New Revision: 264941
URL: http://llvm.org/viewvc/llvm-project?rev=264941&view=rev
Log:
Docs: keep copyright years up-to-date.
Modified:
cfe/trunk/docs/analyzer/conf.py
Modified: cfe/trunk/docs/analyzer/conf.py
URL:
http://llvm.org/viewvc/llvm
Author: probinson
Date: Wed Mar 30 17:38:44 2016
New Revision: 264946
URL: http://llvm.org/viewvc/llvm-project?rev=264946&view=rev
Log:
Update copyright year to 2016.
Modified:
cfe/trunk/LICENSE.TXT
Modified: cfe/trunk/LICENSE.TXT
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/LICENSE.T
Author: probinson
Date: Wed Mar 30 17:38:47 2016
New Revision: 264947
URL: http://llvm.org/viewvc/llvm-project?rev=264947&view=rev
Log:
Update copyright year to 2016.
Modified:
clang-tools-extra/trunk/LICENSE.TXT
Modified: clang-tools-extra/trunk/LICENSE.TXT
URL:
http://llvm.org/viewvc/llvm
Author: probinson
Date: Wed Mar 30 17:39:03 2016
New Revision: 264949
URL: http://llvm.org/viewvc/llvm-project?rev=264949&view=rev
Log:
Update copyright year to 2016.
Modified:
libclc/trunk/LICENSE.TXT
Modified: libclc/trunk/LICENSE.TXT
URL:
http://llvm.org/viewvc/llvm-project/libclc/trunk/
Author: probinson
Date: Wed Mar 30 17:39:53 2016
New Revision: 264950
URL: http://llvm.org/viewvc/llvm-project?rev=264950&view=rev
Log:
Update copyright year to 2016.
Modified:
libcxx/trunk/LICENSE.TXT
Modified: libcxx/trunk/LICENSE.TXT
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/
Author: probinson
Date: Wed Mar 30 17:40:47 2016
New Revision: 264952
URL: http://llvm.org/viewvc/llvm-project?rev=264952&view=rev
Log:
Update copyright year to 2016.
Modified:
libcxxabi/trunk/LICENSE.TXT
Modified: libcxxabi/trunk/LICENSE.TXT
URL:
http://llvm.org/viewvc/llvm-project/libcxxa
probinson added a subscriber: probinson.
probinson added a comment.
In http://reviews.llvm.org/D18752#390906, @RedX2501 wrote:
> Somebody else needs to commit this as I don't have any rights for it.
When someone else commits for you, our practice is to attribute the correct
author in the commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265314: Document standard substitutions defined by lit.
(authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D18752?vs=52531&id=52578#toc
Repository:
rL LLVM
http://reviews.llvm
probinson added a subscriber: probinson.
probinson added a comment.
In http://reviews.llvm.org/D18708#390166, @rsmith wrote:
> we'll likely be changing the default C++ language mode soon.)
Privately, PS4 defaults to C++11; we haven't sent that patch upstream because
it would make tests fail
probinson added a subscriber: probinson.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do
probinson added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not sup
probinson added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not sup
probinson added a subscriber: probinson.
Comment at: test/Sema/attr-deprecated.c:124
@@ -123,1 +123,3 @@
+// This note requires C11.
+#if __STDC_VERSION__ > 199901L
Just the note? Or the warning?
Comment at: test/Sema/nullability.c:30
@@ -25,1
probinson added a subscriber: probinson.
probinson added a comment.
Do I remember that somebody was working on a more generic expression-like
syntax for REQUIRES? If that's been abandoned, then Never Mind.
Repository:
rL LLVM
http://reviews.llvm.org/D20757
___
probinson created this revision.
probinson added reviewers: chh, ismail.
probinson added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
Capture the resource directory and use it for subsequent checks.
This is the same tactic used in linux-header-search.cpp.
http://r
Author: probinson
Date: Mon Jun 13 12:41:05 2016
New Revision: 272568
URL: http://llvm.org/viewvc/llvm-project?rev=272568&view=rev
Log:
Capture the resource directory and use it for subsequent checks.
This is the same tactic used in linux-header-search.cpp.
Modified:
cfe/trunk/test/Driver/and
probinson closed this revision.
probinson added a comment.
r272568, thanks!
http://reviews.llvm.org/D21250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson updated this revision to Diff 60930.
probinson added a comment.
Removed the apparently redundant test for a const local variable.
Yes, I'm back to this after way longer than expected. I believe, for this
patch specifically, the extra const local variable was the only identifiable
pro
probinson marked an inline comment as done.
Comment at: test/CodeGenCXX/debug-info-nodebug.cpp:50
@@ -49,2 +49,3 @@
NODEBUG static int static_local = 6;
+ NODEBUGint normal_local = 7;
}
const case removed.
http://reviews.llvm.org/D19754
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272859: Allow 'nodebug' on local variables. (authored by
probinson).
Changed prior to commit:
http://reviews.llvm.org/D19754?vs=60930&id=60940#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19754
Author: probinson
Date: Wed Jun 15 19:42:36 2016
New Revision: 272859
URL: http://llvm.org/viewvc/llvm-project?rev=272859&view=rev
Log:
Allow 'nodebug' on local variables.
Parameters and non-static members of aggregates are still excluded,
and probably should remain that way.
Differential Revisio
probinson added a subscriber: probinson.
probinson added a comment.
I'm still bemused that Clang thinks of a defined-in-class method and a method
marked with 'inline' as significantly different things. But given that it
does, a way to make them be treated the same will be nice.
==
Author: probinson
Date: Sat Jun 18 18:26:37 2016
New Revision: 273101
URL: http://llvm.org/viewvc/llvm-project?rev=273101&view=rev
Log:
Make test less sensitive to the resource directory.
Like linux-header-search.cpp and android-ndk-standalone.cpp.
Modified:
cfe/trunk/test/Driver/windows-cros
probinson created this revision.
probinson added reviewers: rsmith, ogoffart.
probinson added a subscriber: cfe-commits.
Test fails if Clang defaults to C++11. I didn't track down exactly which RUN
lines needed this, seemed simplest to put it on all of them.
http://reviews.llvm.org/D21497
Fil
Author: probinson
Date: Sat Jun 18 20:14:35 2016
New Revision: 273102
URL: http://llvm.org/viewvc/llvm-project?rev=273102&view=rev
Log:
Revert "Make test less sensitive to the resource directory."
Will need to try this on an actual Windows system.
Modified:
cfe/trunk/test/Driver/windows-cros
probinson abandoned this revision.
probinson added a comment.
A proper fix is obviously better than patching the test!
http://reviews.llvm.org/D21497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: probinson
Date: Mon Jun 20 09:33:49 2016
New Revision: 273158
URL: http://llvm.org/viewvc/llvm-project?rev=273158&view=rev
Log:
Make test less sensitive to the resource directory.
Same tactic as linux-header-search.cpp and android-ndk-standalone.cpp.
Modified:
cfe/trunk/test/Driver/w
probinson added a comment.
In http://reviews.llvm.org/D20647#462797, @Ilod wrote:
> There is no longer a flag to treat implicit and explicit inline functions
> exactly the same way, I don't kow if it's really useful (it can be if we want
> to use the threshold difference between InlineHint and
probinson created this revision.
probinson added a reviewer: rsmith.
probinson added a subscriber: cfe-commits.
We have a C test that now gets a warning about a C++1z extension, which seems
inappropriate.
http://reviews.llvm.org/D22113
Files:
lib/Sema/SemaDecl.cpp
test/Sema/inline.c
Index
probinson added a comment.
Ping.
https://reviews.llvm.org/D22113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a subscriber: probinson.
probinson added a comment.
On the thread you suggested it would affect out-of-tree targets, so this
probably deserves a release note?
https://reviews.llvm.org/D22290
___
cfe-commits mailing list
cfe-commits@
probinson marked an inline comment as done.
Comment at: lib/Sema/SemaDecl.cpp:6189-6191
@@ -6188,2 +6188,5 @@
<< FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
+} else if (!getLangOpts().CPlusPlus) {
+ Diag(D.getDeclSpec().getInlineSpecLoc(), diag:
probinson updated this revision to Diff 64053.
probinson marked an inline comment as done.
probinson added a comment.
Reorder the checks. I didn't see any tests for the adjacent (C++) diagnostics
so I added some.
https://reviews.llvm.org/D22113
Files:
lib/Sema/SemaDecl.cpp
test/Sema/inlin
Author: probinson
Date: Thu Jul 14 17:22:58 2016
New Revision: 275493
URL: http://llvm.org/viewvc/llvm-project?rev=275493&view=rev
Log:
C does not have inline variables.
Add a few missing tests for related C++ diagnostics.
Differential Revision: http://reviews.llvm.org/D22113
Modified:
cfe/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275493: C does not have inline variables. (authored by
probinson).
Changed prior to commit:
https://reviews.llvm.org/D22113?vs=64053&id=64057#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22113
probinson added a subscriber: probinson.
probinson added a comment.
I'm seeing a different set of diagnostics in two of these tests, because we
default to C+11, which makes them fail for us. Ideally you'd conditionalize
the tests on the value of `__cplusplus` (like Charles Li has been doing for
Author: probinson
Date: Mon Jul 18 12:19:12 2016
New Revision: 275817
URL: http://llvm.org/viewvc/llvm-project?rev=275817&view=rev
Log:
Release note for 'nodebug' on variables
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262052: Fix Clang tests that used CHECK-NEXT-NOT and
CHECK-DAG-NOT. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D17589?vs=48999&id=49217#toc
Repository:
rL LLVM
http://
Author: probinson
Date: Fri Feb 26 13:34:01 2016
New Revision: 262052
URL: http://llvm.org/viewvc/llvm-project?rev=262052&view=rev
Log:
Fix Clang tests that used CHECK-NEXT-NOT and CHECK-DAG-NOT.
FileCheck actually doesn't support combo suffixes.
Differential Revision: http://reviews.llvm.org/D17
Author: probinson
Date: Mon Jan 4 11:03:58 2016
New Revision: 256762
URL: http://llvm.org/viewvc/llvm-project?rev=256762&view=rev
Log:
Add some overlooked optnone tests, and tighten up an existing test.
Differential Revision: http://reviews.llvm.org/D15704
Added:
cfe/trunk/test/CodeGenCXX/o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256762: Add some overlooked optnone tests, and tighten up an
existing test. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D15704?vs=43416&id=43891#toc
Repository:
rL LLVM
probinson created this revision.
probinson added reviewers: echristo, dblaikie, aprantl.
probinson added a subscriber: cfe-commits.
GDB and LLDB don't mind if we omit the explicit import of an anonymous
namespace.
http://reviews.llvm.org/D15881
Files:
lib/Frontend/CompilerInvocation.cpp
te
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D15882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
probinson added a comment.
Ping. I did want to get this finished off (moving all triple-based decisions to
tuning-based decisions) before 3.8 branches.
http://reviews.llvm.org/D15881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
probinson added a comment.
Sure, I was just making it the same as LLVM's default.
Now that it's wired up through clang, people who want LLDB can use -glldb to
get the same effect.
http://reviews.llvm.org/D15967
___
cfe-commits mailing list
cfe-comm
probinson updated this revision to Diff 44278.
probinson marked an inline comment as done.
http://reviews.llvm.org/D15881
Files:
lib/Frontend/CompilerInvocation.cpp
test/CodeGenCXX/debug-info-anon-namespace.cpp
Index: test/CodeGenCXX/debug-info-anon-namespace.cpp
probinson added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:363-370
@@ -362,2 +362,10 @@
+// Convenience functions for debugger tuning.
+static bool tuneForGDB(CodeGenOptions &Opts) {
+ return Opts.getDebuggerTuning() == CodeGenOptions::DebuggerKindGDB;
+}
probinson added a comment.
FTR, the previous wiring-up-thru-Clang patches put the there-must-be-a-tuning
decision in the driver; CC1 does not assume or require a non-default tuning.
http://reviews.llvm.org/D15881
___
cfe-commits mailing list
cfe-co
probinson added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning()
probinson created this revision.
probinson added a reviewer: echristo.
probinson added a subscriber: cfe-commits.
Herald added a subscriber: joker.eph.
LTO via the gold plugin needs to be told about debugger tuning.
http://reviews.llvm.org/D16094
Files:
lib/Driver/Tools.cpp
test/Driver/lto.c
probinson added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning()
probinson added a comment.
Looks like this was never committed?
http://reviews.llvm.org/D9929
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
I don't feel comfortable enough with Clang to review the code part.
The tests are generally good (one inline comment) but it seems like they could
be done all in one test file, which is more efficient in terms of test run time.
Comment at: test/CodeGe
probinson added a comment.
Ping.
http://reviews.llvm.org/D16094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
Ping.
http://reviews.llvm.org/D15881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258712: LTO via the gold plugin needs to be told about
debugger tuning. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D16094?vs=44575&id=45893#toc
Repository:
rL LLVM
htt
Author: probinson
Date: Mon Jan 25 13:46:40 2016
New Revision: 258712
URL: http://llvm.org/viewvc/llvm-project?rev=258712&view=rev
Log:
LTO via the gold plugin needs to be told about debugger tuning.
Differential Revision: http://reviews.llvm.org/D16094
Modified:
cfe/trunk/lib/Driver/Tools.c
probinson added a comment.
Subscribed the reviewers of http://reviews.llvm.org/D14980, which had fixed the
alignment-attribute layout bug.
http://reviews.llvm.org/D16607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
probinson added a comment.
Ping. FWIW in today's DWARF meeting, we agreed that the Appendix D example of
an anonymous namespace should have an explicit import from the containing scope
(see DWARF v4, Figure 57 on p.233; it was essentially unchanged in the v5
draft).
http://reviews.llvm.org/D
probinson added a subscriber: probinson.
probinson added a comment.
Not sure what the exact problem is, but we still have one bot using
configure/make, and it dies with this on the install step unless we use -j1. I
know the hand-written Makefiles are deprecated and we've worked around it, but
probinson added a comment.
The problem is that making the install-local target will try to create the
PROJ_sharedir directory in parallel with trying to copy DESTFILES to that
directory. You need to set up the dependencies such that the directory is
guaranteed to be created first. If you move
probinson added a subscriber: probinson.
probinson added a comment.
Regarding _mm[256]_cvtps_ph and ...cvtph_ps, I can find an Intel doc that say
the _mm_* functions are in emmintrin.h and the _mm256_* are in immintrin.h, so
putting them all with emmintrin.h is not consistent with what Intel say
probinson added a comment.
Thanks Michael! Moving the mm256 stuff to immintrin.h ought to work. What
actually motivates this is mucking around with modularizing the intrinsic
headers, and the immediate problem is the duplicate typedefs for __v8sf and
__m256 (which are in both f16cintrin.h and
probinson created this revision.
probinson added a reviewer: mkuper.
probinson added a subscriber: cfe-commits.
This more closely matches their locations as described by Intel documentation,
and lets us remove a pair of redundant typedefs.
http://reviews.llvm.org/D15127
Files:
lib/Headers/f16
probinson added a comment.
Patch posted as http://reviews.llvm.org/D15127. please follow up there.
Repository:
rL LLVM
http://reviews.llvm.org/D13015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254528: Move _mm256_cvtps_ph and _mm256_cvtph_ps to
immintrin.h. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D15127?vs=41555&id=41647#toc
Repository:
rL LLVM
http://rev
Author: probinson
Date: Wed Dec 2 12:41:52 2015
New Revision: 254528
URL: http://llvm.org/viewvc/llvm-project?rev=254528&view=rev
Log:
Move _mm256_cvtps_ph and _mm256_cvtph_ps to immintrin.h.
This more closely matches their locations as described by Intel
documentation, and lets us remove a pair
probinson added a comment.
PS4 rejects -static unconditionally, so in that sense changing what it means
doesn't matter to us. (But I really appreciate being asked!)
Still, abstractly it seems like -static doesn't really imply noPIC.
http://reviews.llvm.org/D15455
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255784: [PS4][Profile] add
"--dependent-lib=libclang_rt.profile-x86_64.a" to (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D15222?vs=42874&id=43020#toc
Repository:
rL LLVM
Author: probinson
Date: Wed Dec 16 11:25:27 2015
New Revision: 255784
URL: http://llvm.org/viewvc/llvm-project?rev=255784&view=rev
Log:
[PS4][Profile] add "--dependent-lib=libclang_rt.profile-x86_64.a" to
the CC1 command line when enabling code coverage.
Patch by Ying Yi!
Differential Revision:
probinson added a comment.
In http://reviews.llvm.org/D15222#311896, @MaggieYi wrote:
> Could someone commit it for me please (as I do not have commit access)? Thanks
Done. Thanks Maggie!
Repository:
rL LLVM
http://reviews.llvm.org/D15222
___
probinson added a subscriber: probinson.
probinson added a comment.
So, mainly you want calls to GetProgramPath not to provide the .exe extension,
even on Windows?
Comment at: test/Driver/sanitizer-ld.c:382
@@ -381,3 +381,3 @@
// RUN: | FileCheck --check-prefix=CHECK-UBSAN-P
probinson accepted this revision.
probinson added a reviewer: probinson.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
probinson abandoned this revision.
probinson added a comment.
Split into separate CC1 and Driver parts for easier reviewing.
http://reviews.llvm.org/D8599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
probinson created this revision.
probinson added reviewers: echristo, dblaikie, aprantl, dougk.
probinson added a subscriber: cfe-commits.
Adds driver options named -glldb and -gsce to mean -g plus tuning for
lldb and SCE debuggers respectively; the existing -ggdb option does
the same for gdb. Exi
probinson added a comment.
As the only effect is to set a field in the options struct passed down to LLVM,
no idea how to test this.
http://reviews.llvm.org/D15650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256063: CC1 part of debugger tuning; pass through setting
from driver to LLVM. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D15650?vs=43257&id=43280#toc
Repository:
rL LL
201 - 300 of 316 matches
Mail list logo
