[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

2019-11-19 Thread Paul Mulders via Phabricator via cfe-commits
justinkb reopened this revision. justinkb added a comment. This revision is now accepted and ready to land. Herald added a project: LLVM. The check doesn't work correctly if LLVM is built as a dylib and the LLVMTestingSupport static library isn't installed (which it normally wouldn't be) On my

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

2019-11-19 Thread Paul Mulders via Phabricator via cfe-commits
justinkb added a comment. In D55891#1751610 , @mgorny wrote: > That sounds like a bug in llvm-config. It shouldn't really return dylib for > components that aren't part of it. I don't disagree. Still, the check is relying on correct behavior the tool a