https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/119814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/119815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/119815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/119813
>From e83d6d47cc414860bbb991e023e70a1071ca27eb Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 12 Dec 2024 20:26:53 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
=?UTF-
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/119814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/119810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/119812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/119812
>From 1f547dbf7787db21e15524c10c45b685bbe651d5 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 12 Dec 2024 20:26:47 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?=
=?UTF-
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/119811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/119813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/119811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,731 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/ilovepi commented:
LGTM from me, and thanks for cleaning this up so promptly. Also, for the
record, if you want to put things in MD_prof, please do add support to
ProfDataUtils. We're happy to support all the various usecases, so if your
stuff belongs there, please add it.
@@ -0,0 +1,731 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,731 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,731 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/116938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
This seems to have broken build bot and Fuchsia's Linux CI
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-host-linux-x64/b8729261510660874657/overview.
Would you mind reverting until a fix is ready?
https://github.com/llvm/llvm-project/pull/116642
_
ilovepi wrote:
@uweigand Thanks for the prompt revert.
For reference the Fuchsia bot is just a normal Linux build configured for
building Fuchsia in a debian container. The toolchain isn't novel in anyway,
except it normally builds with a recent toolchain, and uses the full runtimes
build. T
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
ilovepi wrote:
> Should I open a new issue for this? Since it won't actually happen in reality
> unless libunwind does switch to use `-fexceptions` to compile the whole
> library, I'm not sure what to do.
I think its fine to file an issue like this to track that we know this is a
limitation.
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/122565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/122565
We test the `--repository` output in the unit tests, but that option fails to
change the HTML output in the end-to-end tests. Upcoming patches will address
the incorrect behavior.
>From fcf9e19991a989911860e9b3b
ilovepi wrote:
* **#122566** https://app.graphite.dev/github/pr/llvm/llvm-project/122566?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/>
* **#122565** https://app.graphite.dev/github/pr/llvm/llvm-
ilovepi wrote:
> @ilovepi Hi Paul sorry I was on break the past month, I have the bandwidth to
> work this
Great. Let me know if you want/need help. We're hoping to start using this
quite soon, and I don't mind devoting cycles to get this landed sooner.
https://github.com/llvm/llvm-project/pu
ilovepi wrote:
@PeterChou1 We're looking at using clang-doc's HTML output more seriously for
Fuchsia's official documentation. If you don't have time to work on this I can
devote some cycles to addressing the existing review comments and get this
landed, so that we can use the new template out
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/121820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/124824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi commented:
This patch needs a test for the new driver logic. I'd also suggest adding some
error handling in LLVM, so that it isn't possible to try an generate wrong code
if this triple is supplied somewhere else (e.g. by another frontend or through
opt).
https://git
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/124824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6677,6 +6677,9 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::UEFI:
+ if (Target.getArch() != llvm::Triple::x86_64)
+llvm::report_fatal_error("Currently the onl
ilovepi wrote:
* **#124990** https://app.graphite.dev/github/pr/llvm/llvm-project/124990?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1249
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/124990
Fuchsia uses TLSDESC by default for all target architectures.
>From 6b6eb8cb15b8af034d6d79cbd28e9e5d31916f86 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 29 Jan 2025 19:12:17 +
Subject: [PATCH] [llv
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/124990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
> Any progress on this PR? I'm using Fuchsia Clang as CI compiler and PGO will
> be able to save a lot of time.
Ah sorry I missed the Fuchsia bit in this comment. We should be landing
something along these lines soon.
https://github.com/llvm/llvm-project/pull/120323
__
https://github.com/ilovepi approved this pull request.
LGTM. Lets try to follow up w/ something on the llvm side too though.
https://github.com/llvm/llvm-project/pull/124824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/ilovepi approved this pull request.
LGTM. W/ a rebase, this seems to work fine locally. I'll start following up w/
a larger corpus.
https://github.com/llvm/llvm-project/pull/120323
___
cfe-commits mailing list
cfe-commits@lists.llv
ilovepi wrote:
Are there lingering concerns here or are we OK landing this?
https://github.com/llvm/llvm-project/pull/121819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/121819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
ilovepi wrote:
Hmm, the failing bot seems to be some kind of configuration error on the bot
(or issue w/ the docker daemon?)
https://github.com/llvm/llvm-project/actions/runs/12775719644/job/35614829092
https://github.com/llvm/llvm-project/pull/121819
__
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121819
>From 9f952de3cb3e973f17121c057089a28bf4c6e5e0 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 6 Jan 2025 11:15:35 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/123258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121819
>From 9f952de3cb3e973f17121c057089a28bf4c6e5e0 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 6 Jan 2025 11:15:35 -0800
Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/121820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121819
>From 9f952de3cb3e973f17121c057089a28bf4c6e5e0 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 6 Jan 2025 11:15:35 -0800
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/121819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/121820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/121820
>From 2035ab40f01fd10b91f48be9c921039fa12805c4 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 6 Jan 2025 11:15:42 -0800
Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
=?UTF-8
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/123258
None
>From 28bf9373f5296f848f614b665bf494267a1bf40f Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 16 Jan 2025 23:48:24 +
Subject: [PATCH] [fuchsia][cmake] Add runtimes for cortex-m4 for the Fuchsia
ilovepi wrote:
* **#123258** https://app.graphite.dev/github/pr/llvm/llvm-project/123258?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1232
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/123258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/125911
>From f0c397ed6a1d85fe2830ebd84033e51516d57d07 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 30 Jan 2025 16:44:15 +
Subject: [PATCH] [llvm][fatlto] Add FatLTOCleanup pass
When using FatLTO, it is com
ilovepi wrote:
> Just out of curiosity, is this corpus or its end product a single huge source
> file? If so it would also be very useful for BOLT especially instrumentation.
> The alternative I'm currently using is sqlite3.c
The corpus won't be a single file. We'll need C, C++, and a couple o
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/125911
>From 4f86d4f5e2a39414bf0f59e18e2723b9fc0595cc Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 30 Jan 2025 16:44:15 +
Subject: [PATCH] [llvm][fatlto] Add FatLTOCleanup pass
When using FatLTO, it is com
@@ -969,6 +969,10 @@ def Xlinker : Separate<["-"], "Xlinker">,
Flags<[LinkerInput, RenderAsInput]>,
Visibility<[ClangOption, CLOption, FlangOption]>,
HelpText<"Pass to the linker">, MetaVarName<"">,
Group;
+def Xdist : Separate<["-"], "Xdist">, Flags<[LinkOption]>,
@@ -240,6 +240,38 @@ The ``BOOTSTRAP_LLVM_ENABLE_LTO=Thin`` will enable ThinLTO
for stage 2 and
stage 3 in case the compiler used for stage 1 does not support the ThinLTO
option.
+Distributed ThinLTO (DTLTO)
+---
+
+DTLTO allows for the distribution of
@@ -1702,6 +1703,38 @@ static uint8_t getOsAbi(const Triple &t) {
}
}
+namespace dtlto {
+// Check if an archive file is a thin archive.
+bool isThinArchive(Ctx &ctx, StringRef archiveFilePath) {
+ const size_t thinArchiveMagicLen = sizeof(ThinArchiveMagic) - 1;
+
+ ErrorO
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/131939
>From d7fe558c1c7a3f18bc4019e6edcd86e2a98a46a0 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 18 Mar 2025 23:38:09 +
Subject: [PATCH] [clang-doc] Avoid deref of invalid std::optional
Since our existin
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/131183
>From 30a2a3bc95ff18653e3e26bc7b138bfb6ac62391 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Thu, 13 Mar 2025 10:19:56 -0700
Subject: [PATCH] [clang][driver] Use rva22u64_v as the default march for
Fuchsia ta
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/131939
>From 215f9a312eaaedd4278006a6f4857ab4702ed38e Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 18 Mar 2025 23:38:09 +
Subject: [PATCH] [clang-doc] Avoid deref of invalid std::optional
Since our existin
ilovepi wrote:
hey, sorry, I ended up landing
https://github.com/llvm/llvm-project/pull/131939. There are two reasons: 1) I
really wanted to fix that crash ASAP. 2) I made the mistake of stacking other
patches on top of it with graphite, and it turns out it isn't easy to reorder
them. As a re
ilovepi wrote:
> @ilovepi About `writeFileDefiniation`, what's your opinion about making it
> similar to the markdown generator like this?
>
> ```c++
> static void writeFileDefinition(const ClangDocContext &CDCtx, const Location
> &L);
> ```
>
> I think it's more better
That would probably b
ilovepi wrote:
### Merge activity
* **Mar 20, 5:02 PM EDT**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/131939).
https://github.com/llvm/llvm-project/pull/131939
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/132101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/132103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -518,10 +519,12 @@ struct ClangDocContext {
// the file is in this dir.
// URL of repository that hosts code used for links to definition locations.
std::optional RepositoryUrl;
+ // Prefix of line code for repository.
+ std::optional Reposi
ilovepi wrote:
Thanks for the PR.
https://github.com/llvm/llvm-project/pull/132310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/132310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/132310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
* **#132482** https://app.graphite.dev/github/pr/llvm/llvm-project/132482?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1324
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/132482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132482
>From 1a9d8768e61e4e69560cff228eacee81e61d9764 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Fri, 21 Mar 2025 22:29:14 +
Subject: [PATCH] [clang-doc] Allow setting a base directory for hosted pages
Curren
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/132428
Many of the test files had an inconsistent formatting. This patch ran
clang-format over them using the project's .clang-format file, with
column limit = 0, to prevent test directives from being split over
multipl
ilovepi wrote:
* **#132428** https://app.graphite.dev/github/pr/llvm/llvm-project/132428?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1324
@@ -0,0 +1,32 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s
+// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md
--check-prefix=MD
@@ -0,0 +1,32 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s
+// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md
--check-prefix=MD
ilovepi wrote:
Also, please change the PR title to
```
[clang-doc] Add regression test for test comments in macros
```
The body should contain `Fixes #59819. The underlying problem was fixed in
https://reviews.llvm.org/D142560, but this patch adds a proper regression test.`
https://github.
@@ -0,0 +1,32 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s
+// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s
ilovepi wrote:
Lets move this down w/ the HTML FileChe
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/132103
>From a21532214bdc02cf929777324a72749e957ab9b9 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Wed, 19 Mar 2025 21:07:22 +
Subject: [PATCH] [clang-doc] Correct improper file paths in HTML output
In index.js
ilovepi wrote:
> @ilovepi I am not familiar with PR, so accidentally closed the previous PR.
> This is a new one. Sorry for that.
It's fine. IIRC you can reopen one pretty easily, but 🤷 Its no problem.
https://github.com/llvm/llvm-project/pull/132510
__
ilovepi wrote:
Ah, I see you deleted your repository, then yeah, that would make it hard to
reopen.
https://github.com/llvm/llvm-project/pull/132510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
ilovepi wrote:
>I am not familiar with PR, so accidentally closed the previous PR
>https://github.com/llvm/llvm-project/pull/132360. This is a new one.
You can remove this part from the description. It isn't relevant to the rest of
the project, and doesn't belong in the commit log.
https://gi
https://github.com/ilovepi ready_for_review
https://github.com/llvm/llvm-project/pull/132428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/132482
Currently, when we set URLs from JS, we set them only using the protocol
and host locations. This works fine when docs are served from the base
directory of the site, but if you want to nest it under another
dire
@@ -490,15 +490,17 @@ genReferencesBlock(const std::vector
&References,
}
return Out;
}
-
static std::unique_ptr
-writeFileDefinition(const Location &L,
-std::optional RepositoryUrl = std::nullopt) {
- if (!L.IsFileInRootDir && !RepositoryUrl)
+writeF
@@ -749,13 +752,8 @@ genHTML(const EnumInfo &I, const ClangDocContext &CDCtx) {
Out.emplace_back(std::move(Table));
- if (I.DefLoc) {
-if (!CDCtx.RepositoryUrl)
- Out.emplace_back(writeFileDefinition(*I.DefLoc));
-else
- Out.emplace_back(
- write
@@ -57,11 +58,13 @@ static void writeFileDefinition(const ClangDocContext
&CDCtx, const Location &L,
OS << "*Defined at " << L.Filename << "#" << std::to_string(L.LineNumber)
<< "*";
} else {
-OS << "*Defined at [" << L.Filename << "#" << std::to_string(L.Line
@@ -276,6 +286,62 @@
// HTML-CIRCLE: return
// HTML-CIRCLE: double The perimeter of the circle.
+// HTML-SHAPE-PREFIX: class Shape
+// HTML-SHAPE-PREFIX-NEXT:
+// HTML-SHAPE-PREFIX-NEXT: Defined at line
+// HTML-SHAPE-PREFIX-NEXT: https://repository.com/./incl
@@ -383,4 +449,4 @@
// MD-ALL-FILES: ## [GlobalNamespace](GlobalNamespace{{[\/]}}index.md)
// MD-INDEX: # C/C++ Reference
-// MD-INDEX: * Namespace: [GlobalNamespace](GlobalNamespace)
+// MD-INDEX: * Namespace: [GlobalNamespace](GlobalNamespace)
ilovepi wrote
ilovepi wrote:
Yeah that seems reasonable. You'll still want to check the validity of the
optionals, which could make the logic a bit less nice, but overall I expect the
code to be cleaner than what we have in a lot of places, right now.
https://github.com/llvm/llvm-project/pull/131280
___
@@ -749,13 +752,8 @@ genHTML(const EnumInfo &I, const ClangDocContext &CDCtx) {
Out.emplace_back(std::move(Table));
- if (I.DefLoc) {
-if (!CDCtx.RepositoryUrl)
- Out.emplace_back(writeFileDefinition(*I.DefLoc));
-else
- Out.emplace_back(
- write
@@ -516,15 +518,16 @@ writeFileDefinition(const Location &L,
std::make_unique(HTMLTag::TAG_A, std::to_string(L.LineNumber));
// The links to a specific line in the source code use the github /
// googlesource notation so it won't work for all hosting pages.
- // FIXM
@@ -57,11 +58,13 @@ static void writeFileDefinition(const ClangDocContext
&CDCtx, const Location &L,
OS << "*Defined at " << L.Filename << "#" << std::to_string(L.LineNumber)
<< "*";
} else {
-OS << "*Defined at [" << L.Filename << "#" << std::to_string(L.Line
@@ -3,6 +3,16 @@
// RUN: clang-doc --format=html --output=%t/docs --executor=all-TUs
%t/build/compile_commands.json
// RUN: FileCheck %s -input-file=%t/docs/index_json.js -check-prefix=JSON-INDEX
+// RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Shape.html
-check-pre
@@ -165,33 +175,57 @@ endif()
set(BOOTSTRAP_LLVM_ENABLE_LLD ON CACHE BOOL "")
set(BOOTSTRAP_LLVM_ENABLE_LTO ON CACHE BOOL "")
-set(_FUCHSIA_BOOTSTRAP_TARGETS
- check-all
- check-clang
- check-lld
- check-llvm
- check-polly
- llvm-config
- clang-test-depends
- lld-test-
@@ -165,33 +175,57 @@ endif()
set(BOOTSTRAP_LLVM_ENABLE_LLD ON CACHE BOOL "")
set(BOOTSTRAP_LLVM_ENABLE_LTO ON CACHE BOOL "")
-set(_FUCHSIA_BOOTSTRAP_TARGETS
- check-all
- check-clang
- check-lld
- check-llvm
- check-polly
- llvm-config
- clang-test-depends
- lld-test-
ilovepi wrote:
### Merge activity
* **Mar 17, 7:02 PM EDT**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/131183).
https://github.com/llvm/llvm-project/pull/131183
801 - 900 of 1207 matches
Mail list logo
