[clang] [llvm] [llvm][fatlto] Add FatLTOCleanup pass (PR #125911)

2025-02-13 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,123 @@ +//===- FatLtoCleanup.cpp - clean up IR for the FatLTO pipeline --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [llvm][fatlto] Add FatLTOCleanup pass (PR #125911)

2025-02-13 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/125911 >From 2f9ca16068f2c9a14d73aa0a3302da070ccebe6a Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Thu, 30 Jan 2025 16:44:15 + Subject: [PATCH] [llvm][fatlto] Add FatLTOCleanup pass When using FatLTO, it is com

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-12 Thread Paul Kirth via cfe-commits
ilovepi wrote: Any progress to report? https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][perf-training] Support excluding LLVM build from PGO training (PR #126876)

2025-02-14 Thread Paul Kirth via cfe-commits
ilovepi wrote: @tstellar We're still developing the corpus ATM, but contributing it upstream is something we've discussed and would like to do. https://github.com/llvm/llvm-project/pull/126876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [FatLTO] Allow -fno-fat-lto-objects to override -ffat-lto-objects (PR #128157)

2025-02-21 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/128157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Support PGO (PR #128680)

2025-02-25 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM. This seems to work locally for me, but I haven't tested w/ cross compiling. Is that still potentially an issue? https://github.com/llvm/llvm-project/pull/128680 ___ cfe-commits mailing list

[clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-03-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,32 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md --check-prefix=MD

[clang] [llvm] [fatlto] Use the ThinLTO default pipeline for FatLTO (PR #134434)

2025-04-04 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/134434 When coroutines are used w/ both -ffat-lto-objects and -flto=thin, the coroutine passes are not added to the optimization pipelines. Instead, just use the default ThinLTO pipeline to generate the ELF. Fixes #134

[clang] [llvm] [fatlto] Use the ThinLTO default pipeline for FatLTO (PR #134434)

2025-04-04 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#134434** https://app.graphite.dev/github/pr/llvm/llvm-project/134434?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> ๐Ÿ‘ˆ https://app.graphite.dev/github/pr/llvm/llvm-project/1344

[clang] [llvm] [fatlto] Use the ThinLTO default pipeline for FatLTO (PR #134434)

2025-04-04 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi ready_for_review https://github.com/llvm/llvm-project/pull/134434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] [feat] add --repository-line-prefix argument (PR #131280)

2025-03-22 Thread Paul Kirth via cfe-commits
@@ -3,6 +3,16 @@ // RUN: clang-doc --format=html --output=%t/docs --executor=all-TUs %t/build/compile_commands.json // RUN: FileCheck %s -input-file=%t/docs/index_json.js -check-prefix=JSON-INDEX +// RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Shape.html -check-pre

[clang-tools-extra] [clang-doc] Avoid deref of invalid std::optional (PR #131939)

2025-03-24 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [llvm] Add test to clang-doc, it can test comments in macro. Original issue is #59819. (PR #132360)

2025-03-24 Thread Paul Kirth via cfe-commits
ilovepi wrote: The test output isn't appropriate for the commit body, so please remove that. I also see many files were changed in this PR that aren't related. Many of them seem to be changes to the line endings in files. Please double check your editor and git settings to be sure they follow

[clang-tools-extra] [clang-doc] [feat] add --repository-line-prefix argument (PR #131280)

2025-03-28 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/131280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-03-28 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,34 @@ +// Fixes #59819. The underlying problem was fixed in https://reviews.llvm.org/D142560, but this patch adds a proper regression test. +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: FileChec

[clang] [llvm] Add clang driver changes to support MTI RISC-V (PR #134065)

2025-04-03 Thread Paul Kirth via cfe-commits
@@ -424,8 +432,19 @@ std::string Linux::computeSysRoot() const { const StringRef InstallDir = GCCInstallation.getInstallPath(); const StringRef TripleStr = GCCInstallation.getTriple().str(); const Multilib &Multilib = GCCInstallation.getMultilib(); + std::string Path; +

[clang-tools-extra] [llvm] [llvm] add tool to verify mustache library (PR #111487)

2025-04-03 Thread Paul Kirth via cfe-commits
ilovepi wrote: ah, right. I forgot we build things under `utils` that's a much better place for this. Overall the patch is much better. Once it's moved to `utils` I think it will be good. @nikic I seem to recall that we now prefer markdown over `.rst` files. Is that correct? I tried to find

[clang-tools-extra] [clang-doc][NFC] refactor out file helpers (PR #134298)

2025-04-03 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. Since this just moves common code I think this is fine for now. We should revisit some of the interfaces though, especially the ones that return SmallString<128>. I think there is also a Path API that handles relative paths, so we can per

[clang-tools-extra] [clang-doc][NFC] refactor out file helpers (PR #134298)

2025-04-03 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,25 @@ +//===-- File.h --- File Helpers ---*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLV

[clang-tools-extra] [clang-doc][NFC] refactor out file helpers (PR #134298)

2025-04-03 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/134298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][NFC] refactor out file helpers (PR #134298)

2025-04-03 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,25 @@ +//===-- File.h --- File Helpers ---*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLV

[clang] [llvm] [fatlto] Use the ThinLTO default pipeline for FatLTO (PR #134434)

2025-04-04 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/134434 >From 6c3ea0b212b3bdafcbec0fda9af56f00d8b1451b Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Fri, 4 Apr 2025 11:49:02 -0700 Subject: [PATCH] [fatlto] Use the ThinLTO default pipeline for FatLTO When coroutine

[clang] [llvm] [fatlto] Use the ThinLTO default pipeline for FatLTO (PR #134434)

2025-04-04 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/134434 >From a013418d71fc18387ec70c4ab64f611334d3a531 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Fri, 4 Apr 2025 11:49:02 -0700 Subject: [PATCH] [fatlto] Use the ThinLTO default pipeline for FatLTO When coroutine

[clang] [llvm] [fatlto] Use the ThinLTO default pipeline for FatLTO (PR #134434)

2025-04-04 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/134434 >From a4919243c4dc2cfebb1494d0f46529b858c52ea0 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Fri, 4 Apr 2025 11:49:02 -0700 Subject: [PATCH] [fatlto] Use the ThinLTO default pipeline for FatLTO When coroutine

[clang] [llvm] [fatlto] Use the ThinLTO default pipeline for FatLTO (PR #134434)

2025-04-04 Thread Paul Kirth via cfe-commits
@@ -1692,6 +1692,19 @@ PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO, if (ThinLTO && PGOOpt && PGOOpt->Action == PGOOptions::SampleUse) MPM.addPass(buildThinLTODefaultPipeline(Level, /*ImportSummary=*/nullptr)); else { +// ModuleSimp

[clang] [llvm] [fatlto] Use the ThinLTO default pipeline for FatLTO (PR #134434)

2025-04-04 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/134434 >From 80c36153e55398bee01e0167e722c930732b48e7 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Fri, 4 Apr 2025 11:49:02 -0700 Subject: [PATCH] [fatlto] Add coroutine passes when using FatLTO with ThinLTO When c

[clang-tools-extra] [clang-doc] [feat] add --repository-line-prefix argument (PR #131280)

2025-04-04 Thread Paul Kirth via cfe-commits
@@ -516,15 +518,16 @@ writeFileDefinition(const Location &L, std::make_unique(HTMLTag::TAG_A, std::to_string(L.LineNumber)); // The links to a specific line in the source code use the github / // googlesource notation so it won't work for all hosting pages. - // FIXM

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138060 >From 88e705710a6c25eee3468dc51ade3b1e274eb7be Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 07:59:01 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator.cpp Split from #133161. This

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138060 Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// ilovepi wrote: Ah, good catch. https://github.com/llvm/llvm-project/pull/138060 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] [clang-doc] Add missing comment for Base (PR #138053)

2025-05-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,87 @@ +//===-- clang-doc/HTMLMustacheGeneratorTest.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
@@ -535,6 +535,8 @@ struct ClangDocContext { // JavaScript files that will be imported in all HTML files. std::vector JsScripts; StringRef Base; + // Mustache Template files ilovepi wrote: My understanding is that it provides a mapping to of a template

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-doc][NFC] Add TODO for future work (PR #138052)

2025-05-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138052 >From 3e612b30626cfe3963fdbed341c028a8a8f0917e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 29 Apr 2025 18:11:55 -0700 Subject: [PATCH 1/2] [clang-doc][NFC] Add TODO for future work --- clang-tools-ext

[clang-tools-extra] [clang-doc] Add missing comment for Base (PR #138053)

2025-05-07 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 7, 7:22 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138053). https://github.com/llvm/llvm-project/pull/138053 _

[clang-tools-extra] [clang-doc][NFC] Add TODO for future work (PR #138052)

2025-05-07 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 7, 7:22 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138052). https://github.com/llvm/llvm-project/pull/138052 _

[clang-tools-extra] [clang-doc][NFC] Add TODO for future work (PR #138052)

2025-05-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138060 >From ba7721e9a60a466966a0e10a59491ba4e59b86a3 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 07:59:01 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator.cpp Split from #133161. This

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
@@ -535,6 +535,8 @@ struct ClangDocContext { // JavaScript files that will be imported in all HTML files. std::vector JsScripts; StringRef Base; + // Mustache Template files ilovepi wrote: done. LMK if something is unclear. https://github.com/llvm/llvm

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-12 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 12, 9:52 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138060). https://github.com/llvm/llvm-project/pull/138060

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138061 >From 1925647e9577d827a87d1c7ac4326836928f90e0 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:09:41 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator methods Split from #133161.

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/132510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/132510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-05-06 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 6, 11:12 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138058). https://github.com/llvm/llvm-project/pull/138058

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138058 Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [clang-doc] Add Mustache template assets (PR #138059)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138059 Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add Mustache template assets (PR #138059)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
@@ -70,18 +70,116 @@ class MustacheTemplateFile : public Template { MustacheTemplateFile(StringRef TemplateStr) : Template(TemplateStr) {} }; +static std::unique_ptr NamespaceTemplate = nullptr; + +static std::unique_ptr RecordTemplate = nullptr; + +static Error setupTemplat

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
@@ -70,18 +70,116 @@ class MustacheTemplateFile : public Template { MustacheTemplateFile(StringRef TemplateStr) : Template(TemplateStr) {} }; +static std::unique_ptr NamespaceTemplate = nullptr; + +static std::unique_ptr RecordTemplate = nullptr; + +static Error setupTemplat

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138061 >From de0222f0459bb6c5832ccdbe70b19f5ea8b0cd98 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:09:41 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator methods Split from #133161.

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 16, 8:28 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138061). https://github.com/llvm/llvm-project/pull/138061

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138061 >From 187b130d43c4470768b3885cb9c333b9edfb3897 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:09:41 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator methods Split from #133161.

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 442fe2fd1353c540bc0ec39ec913e7e414def6bc Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -57,18 +57,118 @@ class MustacheTemplateFile : public Template { MustacheTemplateFile(StringRef TemplateStr) : Template(TemplateStr) {} }; +static std::unique_ptr NamespaceTemplate = nullptr; + +static std::unique_ptr RecordTemplate = nullptr; + +static Error setupTemplat

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 3d870717fdc1a35f3fc28e7fa74b763362f98c19 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang-tools-extra] [clang-doc][NFC] Fix missing documentation for EndLineNumber (PR #138051)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -262,8 +262,8 @@ struct Location { std::tie(Other.StartLineNumber, Other.EndLineNumber, Other.Filename); } - int StartLineNumber = 0; // Line number of this Location. - int EndLineNumber = 0; + int StartLineNumber = 0; // Line number of this Location.

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -3006,6 +3006,10 @@ static LValue EmitFunctionDeclLValue(CodeGenFunction &CGF, const Expr *E, GlobalDecl GD) { const FunctionDecl *FD = cast(GD.getDecl()); llvm::Constant *V = CGF.CGM.getFunctionPointer(GD); + if (E->getType()->isCF

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -693,6 +693,18 @@ CGCallee ItaniumCXXABI::EmitLoadOfMemberFunctionPointer( llvm::Constant *CheckTypeDesc; bool ShouldEmitCFICheck = CGF.SanOpts.has(SanitizerKind::CFIMFCall) && CGM.HasHiddenLTOVisibility(RD); + + if (ShouldEmitCFICheck) { +

[clang] Revert "[Clang] Fix missed initializer instantiation bug for variable templates" (PR #140930)

2025-05-21 Thread Paul Kirth via cfe-commits
ilovepi wrote: I've updated https://github.com/llvm/llvm-project/issues/140773 with a reproducer. https://github.com/llvm/llvm-project/pull/140930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/141139 This patch re-enables -ftime-trace support in clang-doc. Initial support in #97644 was reverted, and never relanded. This patch adds back the command line option, and leverages the RAII tracing infrastructure mor

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#141139** https://app.graphite.dev/github/pr/llvm/llvm-project/141139?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> ๐Ÿ‘ˆ https://app.graphite.dev/github/pr/llvm/llvm-project/1411

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: I'm not sure I want to land this before I land the main support for Mustache templates. I think its easier to rebase this patch, than that whole stack. https://github.com/llvm/llvm-project/pull/141139 ___ cfe-comm

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/141139 >From 7f51d821b16e71a8834f7560c25268bd02c264df Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 21 May 2025 09:50:32 -0700 Subject: [PATCH] [clang-doc] Reenable time trace support This patch re-enables -fti

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 86dc2be43374138ecea82f0266f8b8ae7ac17f4e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 22, 9:19 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138062). https://github.com/llvm/llvm-project/pull/138062

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138063 >From afa7c63c997dcfee4b50a0b5a4aa0f17b74a0ac1 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:11:39 -0700 Subject: [PATCH] [clang-doc] Extract Info into JSON values Split from #133161. This

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Fix missed initializer instantiation bug for variable templates" (PR #140930)

2025-05-21 Thread Paul Kirth via cfe-commits
ilovepi wrote: Well, its not the easiest case to reduce, since there's lots of ways the two errors in question could happen. That code has been accepted by both GCC and clang for some time though, so at the very least we need guidance on what is wrong with it. >From what I've been able to tel

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: Sorry, I mean committing a test w/ the current in-tree behavior, and then this patch would have your fix and a small delta to the test showing the new behavior. Some information on that can be found here: https://llvm.org/docs/TestingGuide.html#precommit-workflow-for-tests http

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: You can find a stack where I did that here: https://app.graphite.dev/github/pr/llvm/llvm-project/135705/%5Bllvm%5D%5Blto%5D-Precommit-test-for-libcall-internalization Those aren't landed, since we're hashing out the proper way to fix things, but I added a test w/ the behavior to

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: > Reading files from unit tests is a bit of an anti-pattern: It requires > putting the absolute path to the tests somewhere (you're doing this with a > config file here), and it means you easily run tests on a different machine > than the one you're building on. Could you restru

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/141269 In #138062 it was brought up that this was an anti-pattern. We'll need to Migrate all of the mustache unittests to lit tests, and disable them until tool support lands. >From a675e0827d8bee1cfff9e095bc7eb394f520

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi ready_for_review https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#141269** https://app.graphite.dev/github/pr/llvm/llvm-project/141269?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> ๐Ÿ‘ˆ https://app.graphite.dev/github/pr/llvm/llvm-project/1412

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: #141269 should fix the issue for now. I'll clean up the rest of the stack to avoid reintroducing this problem. https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 23, 6:45 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/141269). https://github.com/llvm/llvm-project/pull/141269

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM, but would you mind pre-committing the test so its easy to see what's changing in the output with this patch? I've been trying to get more of that done when we're changing clang-doc output. Otherwise it's hard to know exactly what we'

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: stacked PRs are still not as nice as phabricator or gerrit, but Graphite is a lot more firendly than I found spr, or winging it w/ github PRs. For a precommit test, it isn't too hard to upload a patch for before and then rebase the "after" patch after it lands. https://github.c

[clang-tools-extra] [clang-doc] Precommit test for correct conversion function names (PR #141168)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. Perfect. LGTM. https://github.com/llvm/llvm-project/pull/141168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Fix missed initializer instantiation bug for variable templates" (PR #140930)

2025-05-21 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/140930 Reverts llvm/llvm-project#138122 The patch causes a regression and prevents compiling valid C++ code. The code was accepted by earlier versions of clang and GCC. See https://github.com/llvm/llvm-project/issues

[clang] [Clang] Fix missed initializer instantiation bug for variable templates (PR #138122)

2025-05-21 Thread Paul Kirth via cfe-commits
ilovepi wrote: I have a revert up for this in #140930, due to the regressions reported in #140773, which breaks Fuchsia builds with new toolchains. We're fairly certain that changing the instantiation order as done in the patch is the root cause of the regression. https://github.com/llvm/llv

[clang-tools-extra] [clang-doc] Update serializer for improved template handling (PR #138065)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138065 >From 515b014f4a3b39ff6fa742de095cddbc375f5a3e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 29 Apr 2025 18:31:54 -0700 Subject: [PATCH] [clang-doc] Update serializer for improved template handling This

[clang-tools-extra] [clang-doc] Implement setupTemplateValue for HTMLMustacheGenerator (PR #138064)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Update serializer for improved template handling (PR #138065)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138063 >From 03f3e44aa97edb5cceda728d7318251ccca19cd0 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:11:39 -0700 Subject: [PATCH] [clang-doc] Extract Info into JSON values Split from #133161. This

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 23, 10:52 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138063). https://github.com/llvm/llvm-project/pull/138063 ___

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138063 >From 0c7122c91b45548a6401be465d1c94452a96cf53 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:11:39 -0700 Subject: [PATCH] [clang-doc] Extract Info into JSON values Split from #133161. This

<    7   8   9   10   11   12   13   >