Author: Owen Pan
Date: 2023-03-06T13:07:23-08:00
New Revision: a02c3af9f19d805411364e7a0de785c1d1c4e348
URL:
https://github.com/llvm/llvm-project/commit/a02c3af9f19d805411364e7a0de785c1d1c4e348
DIFF:
https://github.com/llvm/llvm-project/commit/a02c3af9f19d805411364e7a0de785c1d1c4e348.diff
LOG:
Author: Owen Pan
Date: 2023-03-07T14:42:22-08:00
New Revision: bb70dacd60b54d39ca144cf91d47d6c04404b816
URL:
https://github.com/llvm/llvm-project/commit/bb70dacd60b54d39ca144cf91d47d6c04404b816
DIFF:
https://github.com/llvm/llvm-project/commit/bb70dacd60b54d39ca144cf91d47d6c04404b816.diff
LOG:
Author: Owen Pan
Date: 2023-03-07T15:15:37-08:00
New Revision: f6e7a5c29221f445e4cbddc32667a1e12a1446db
URL:
https://github.com/llvm/llvm-project/commit/f6e7a5c29221f445e4cbddc32667a1e12a1446db
DIFF:
https://github.com/llvm/llvm-project/commit/f6e7a5c29221f445e4cbddc32667a1e12a1446db.diff
LOG:
Author: Owen Pan
Date: 2023-06-20T08:30:09-07:00
New Revision: bca11bafba9788dd80135b76a187c5f00e64f735
URL:
https://github.com/llvm/llvm-project/commit/bca11bafba9788dd80135b76a187c5f00e64f735
DIFF:
https://github.com/llvm/llvm-project/commit/bca11bafba9788dd80135b76a187c5f00e64f735.diff
LOG:
Author: Owen Pan
Date: 2023-06-21T15:15:57-07:00
New Revision: 8e85739a5f24e34cb22768fe6ef33b593ed054df
URL:
https://github.com/llvm/llvm-project/commit/8e85739a5f24e34cb22768fe6ef33b593ed054df
DIFF:
https://github.com/llvm/llvm-project/commit/8e85739a5f24e34cb22768fe6ef33b593ed054df.diff
LOG:
Author: Owen Pan
Date: 2023-06-27T16:16:36-07:00
New Revision: 7a4cdbeafb4c2c9fae2ac69d362d22d431404bbe
URL:
https://github.com/llvm/llvm-project/commit/7a4cdbeafb4c2c9fae2ac69d362d22d431404bbe
DIFF:
https://github.com/llvm/llvm-project/commit/7a4cdbeafb4c2c9fae2ac69d362d22d431404bbe.diff
LOG:
Author: Owen Pan
Date: 2023-03-31T16:13:03-07:00
New Revision: 2a42a7b4e87395ae2a4321292f0fd9dce401b4e1
URL:
https://github.com/llvm/llvm-project/commit/2a42a7b4e87395ae2a4321292f0fd9dce401b4e1
DIFF:
https://github.com/llvm/llvm-project/commit/2a42a7b4e87395ae2a4321292f0fd9dce401b4e1.diff
LOG:
Author: Owen Pan
Date: 2023-03-31T17:14:33-07:00
New Revision: 253985d58caf95db8a84632d5a761b96fb7cd7d6
URL:
https://github.com/llvm/llvm-project/commit/253985d58caf95db8a84632d5a761b96fb7cd7d6
DIFF:
https://github.com/llvm/llvm-project/commit/253985d58caf95db8a84632d5a761b96fb7cd7d6.diff
LOG:
Author: Jon Phillips
Date: 2023-04-01T19:35:49-07:00
New Revision: 1dd31ebe5418d9581f152dcb6cbc4aed66ac9472
URL:
https://github.com/llvm/llvm-project/commit/1dd31ebe5418d9581f152dcb6cbc4aed66ac9472
DIFF:
https://github.com/llvm/llvm-project/commit/1dd31ebe5418d9581f152dcb6cbc4aed66ac9472.diff
Author: Jon Phillips
Date: 2023-04-05T14:38:38-07:00
New Revision: 5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2
URL:
https://github.com/llvm/llvm-project/commit/5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2
DIFF:
https://github.com/llvm/llvm-project/commit/5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2.diff
Author: Owen Pan
Date: 2023-04-14T13:58:38-07:00
New Revision: 293e4da32b1d823e63b2614e626bcd22649a8a15
URL:
https://github.com/llvm/llvm-project/commit/293e4da32b1d823e63b2614e626bcd22649a8a15
DIFF:
https://github.com/llvm/llvm-project/commit/293e4da32b1d823e63b2614e626bcd22649a8a15.diff
LOG:
Author: Jorge Pinto Sousa
Date: 2023-04-16T03:23:53-07:00
New Revision: 9db2a0454815979bc8e0f65e830ab9051b4ff5d2
URL:
https://github.com/llvm/llvm-project/commit/9db2a0454815979bc8e0f65e830ab9051b4ff5d2
DIFF:
https://github.com/llvm/llvm-project/commit/9db2a0454815979bc8e0f65e830ab9051b4ff5d2.d
Author: Owen Pan
Date: 2023-04-16T18:52:17-07:00
New Revision: 2bcfff6708d293abab87a4d5a1dff25950d55d91
URL:
https://github.com/llvm/llvm-project/commit/2bcfff6708d293abab87a4d5a1dff25950d55d91
DIFF:
https://github.com/llvm/llvm-project/commit/2bcfff6708d293abab87a4d5a1dff25950d55d91.diff
LOG:
Author: Galen Elias
Date: 2023-05-22T20:25:55-07:00
New Revision: 6dcde658b2380d7ca1451ea5d1099af3e294ea16
URL:
https://github.com/llvm/llvm-project/commit/6dcde658b2380d7ca1451ea5d1099af3e294ea16
DIFF:
https://github.com/llvm/llvm-project/commit/6dcde658b2380d7ca1451ea5d1099af3e294ea16.diff
L
Author: Owen Pan
Date: 2023-05-23T18:48:52-07:00
New Revision: dc4ab97085c052e99cb4218f8250ee8d064c1be3
URL:
https://github.com/llvm/llvm-project/commit/dc4ab97085c052e99cb4218f8250ee8d064c1be3
DIFF:
https://github.com/llvm/llvm-project/commit/dc4ab97085c052e99cb4218f8250ee8d064c1be3.diff
LOG:
Author: Galen Elias
Date: 2023-05-23T18:50:41-07:00
New Revision: d39929b925ff45348645669e5091bdb03396384b
URL:
https://github.com/llvm/llvm-project/commit/d39929b925ff45348645669e5091bdb03396384b
DIFF:
https://github.com/llvm/llvm-project/commit/d39929b925ff45348645669e5091bdb03396384b.diff
L
Author: Sedenion
Date: 2023-05-23T19:40:24-07:00
New Revision: 72ab89e3197cc1bee3b9774edb504690e3e43ed0
URL:
https://github.com/llvm/llvm-project/commit/72ab89e3197cc1bee3b9774edb504690e3e43ed0
DIFF:
https://github.com/llvm/llvm-project/commit/72ab89e3197cc1bee3b9774edb504690e3e43ed0.diff
LOG:
Author: Owen Pan
Date: 2023-05-23T22:18:13-07:00
New Revision: 8e16365cb6162a29a2a8d26f2d5f0081a651d73a
URL:
https://github.com/llvm/llvm-project/commit/8e16365cb6162a29a2a8d26f2d5f0081a651d73a
DIFF:
https://github.com/llvm/llvm-project/commit/8e16365cb6162a29a2a8d26f2d5f0081a651d73a.diff
LOG:
Author: Mike Matthews
Date: 2023-05-26T01:58:57-07:00
New Revision: 10518feaf33760e77be46af62c41a1caf4ef1da2
URL:
https://github.com/llvm/llvm-project/commit/10518feaf33760e77be46af62c41a1caf4ef1da2
DIFF:
https://github.com/llvm/llvm-project/commit/10518feaf33760e77be46af62c41a1caf4ef1da2.diff
Author: Owen Pan
Date: 2023-05-26T02:11:42-07:00
New Revision: aed795942b78876d004c146133d9077012256aff
URL:
https://github.com/llvm/llvm-project/commit/aed795942b78876d004c146133d9077012256aff
DIFF:
https://github.com/llvm/llvm-project/commit/aed795942b78876d004c146133d9077012256aff.diff
LOG:
Author: Owen Pan
Date: 2023-06-03T12:33:03-07:00
New Revision: 4b9764959dc4b8783e18747c1742ab164e4bc4ee
URL:
https://github.com/llvm/llvm-project/commit/4b9764959dc4b8783e18747c1742ab164e4bc4ee
DIFF:
https://github.com/llvm/llvm-project/commit/4b9764959dc4b8783e18747c1742ab164e4bc4ee.diff
LOG:
Author: Owen Pan
Date: 2023-02-09T13:34:57-08:00
New Revision: b4e35c63711b4bde10b83607d04dab4bfdb86482
URL:
https://github.com/llvm/llvm-project/commit/b4e35c63711b4bde10b83607d04dab4bfdb86482
DIFF:
https://github.com/llvm/llvm-project/commit/b4e35c63711b4bde10b83607d04dab4bfdb86482.diff
LOG:
Author: Owen Pan
Date: 2023-02-14T14:27:53-08:00
New Revision: b4243bb611a30137f3f1a7f0e531f91d331ab4be
URL:
https://github.com/llvm/llvm-project/commit/b4243bb611a30137f3f1a7f0e531f91d331ab4be
DIFF:
https://github.com/llvm/llvm-project/commit/b4243bb611a30137f3f1a7f0e531f91d331ab4be.diff
LOG:
Author: Owen Pan
Date: 2023-02-14T18:58:01-08:00
New Revision: aef76fe554ee9426b8915e67ae50cecb8dba2e0e
URL:
https://github.com/llvm/llvm-project/commit/aef76fe554ee9426b8915e67ae50cecb8dba2e0e
DIFF:
https://github.com/llvm/llvm-project/commit/aef76fe554ee9426b8915e67ae50cecb8dba2e0e.diff
LOG:
Author: Owen Pan
Date: 2023-02-16T20:25:39-08:00
New Revision: b05dc1b8766a47482cae432011fd2faa04c83a3e
URL:
https://github.com/llvm/llvm-project/commit/b05dc1b8766a47482cae432011fd2faa04c83a3e
DIFF:
https://github.com/llvm/llvm-project/commit/b05dc1b8766a47482cae432011fd2faa04c83a3e.diff
LOG:
Author: Michael Kirk
Date: 2023-02-18T12:56:46-08:00
New Revision: c31bc7bdf8108fae490585763bf69a1b51327954
URL:
https://github.com/llvm/llvm-project/commit/c31bc7bdf8108fae490585763bf69a1b51327954
DIFF:
https://github.com/llvm/llvm-project/commit/c31bc7bdf8108fae490585763bf69a1b51327954.diff
Author: Taymon A. Beal
Date: 2023-02-21T02:51:56-08:00
New Revision: 801bd3265362389a7125051128fdd3e6e85cc37b
URL:
https://github.com/llvm/llvm-project/commit/801bd3265362389a7125051128fdd3e6e85cc37b
DIFF:
https://github.com/llvm/llvm-project/commit/801bd3265362389a7125051128fdd3e6e85cc37b.diff
Author: Owen Pan
Date: 2023-02-21T02:56:27-08:00
New Revision: 0ef289e5b24b531d920894f909fe31b009f1
URL:
https://github.com/llvm/llvm-project/commit/0ef289e5b24b531d920894f909fe31b009f1
DIFF:
https://github.com/llvm/llvm-project/commit/0ef289e5b24b531d920894f909fe31b009f1.diff
LOG:
Author: Owen Pan
Date: 2023-05-08T19:45:30-07:00
New Revision: a4c87f8ccaccc76fd7d1c6c2e639ca84b9ec7794
URL:
https://github.com/llvm/llvm-project/commit/a4c87f8ccaccc76fd7d1c6c2e639ca84b9ec7794
DIFF:
https://github.com/llvm/llvm-project/commit/a4c87f8ccaccc76fd7d1c6c2e639ca84b9ec7794.diff
LOG:
Author: Owen Pan
Date: 2023-05-09T14:42:32-07:00
New Revision: e9acf001e98b22ad4127155a5756402101c47795
URL:
https://github.com/llvm/llvm-project/commit/e9acf001e98b22ad4127155a5756402101c47795
DIFF:
https://github.com/llvm/llvm-project/commit/e9acf001e98b22ad4127155a5756402101c47795.diff
LOG:
Author: Owen Pan
Date: 2023-05-16T13:17:31-07:00
New Revision: a72b064acf9546ee41c67c77ed8662d5d3b2fadc
URL:
https://github.com/llvm/llvm-project/commit/a72b064acf9546ee41c67c77ed8662d5d3b2fadc
DIFF:
https://github.com/llvm/llvm-project/commit/a72b064acf9546ee41c67c77ed8662d5d3b2fadc.diff
LOG:
Author: Owen Pan
Date: 2023-04-20T04:31:55-07:00
New Revision: 51f6a16646b76152d1b91ed68d018d306f7ab2fc
URL:
https://github.com/llvm/llvm-project/commit/51f6a16646b76152d1b91ed68d018d306f7ab2fc
DIFF:
https://github.com/llvm/llvm-project/commit/51f6a16646b76152d1b91ed68d018d306f7ab2fc.diff
LOG:
Author: Jon Phillips
Date: 2023-04-29T00:36:19-07:00
New Revision: c12aa69a0be9acd0c751bf92318050d2b3730f9b
URL:
https://github.com/llvm/llvm-project/commit/c12aa69a0be9acd0c751bf92318050d2b3730f9b
DIFF:
https://github.com/llvm/llvm-project/commit/c12aa69a0be9acd0c751bf92318050d2b3730f9b.diff
Author: Colin Ogilvie
Date: 2023-05-04T02:59:05-07:00
New Revision: f3dcd3ad992c82be4f652fd2aac6b0ef414566a2
URL:
https://github.com/llvm/llvm-project/commit/f3dcd3ad992c82be4f652fd2aac6b0ef414566a2
DIFF:
https://github.com/llvm/llvm-project/commit/f3dcd3ad992c82be4f652fd2aac6b0ef414566a2.diff
Author: Owen Pan
Date: 2023-06-07T14:17:58-07:00
New Revision: d2627cf88d2553a4c2e850430bdb908a4b7d2e52
URL:
https://github.com/llvm/llvm-project/commit/d2627cf88d2553a4c2e850430bdb908a4b7d2e52
DIFF:
https://github.com/llvm/llvm-project/commit/d2627cf88d2553a4c2e850430bdb908a4b7d2e52.diff
LOG:
Author: Owen Pan
Date: 2023-06-13T10:02:10-07:00
New Revision: 829ed96b779c10cb023d7e3dbcfad22413979ec4
URL:
https://github.com/llvm/llvm-project/commit/829ed96b779c10cb023d7e3dbcfad22413979ec4
DIFF:
https://github.com/llvm/llvm-project/commit/829ed96b779c10cb023d7e3dbcfad22413979ec4.diff
LOG:
Author: Owen Pan
Date: 2023-06-16T16:03:19-07:00
New Revision: 20b4df1ed611517d2c964dbade3e61aff4be2e87
URL:
https://github.com/llvm/llvm-project/commit/20b4df1ed611517d2c964dbade3e61aff4be2e87
DIFF:
https://github.com/llvm/llvm-project/commit/20b4df1ed611517d2c964dbade3e61aff4be2e87.diff
LOG:
Author: Owen Pan
Date: 2023-06-16T16:44:06-07:00
New Revision: 926e1faabc6f6fd4c2fc208fc416c80eff3c05a5
URL:
https://github.com/llvm/llvm-project/commit/926e1faabc6f6fd4c2fc208fc416c80eff3c05a5
DIFF:
https://github.com/llvm/llvm-project/commit/926e1faabc6f6fd4c2fc208fc416c80eff3c05a5.diff
LOG:
Author: Owen Pan
Date: 2023-06-16T17:00:12-07:00
New Revision: 441108ccba948d76e7002c61236e3bcbca0203ce
URL:
https://github.com/llvm/llvm-project/commit/441108ccba948d76e7002c61236e3bcbca0203ce
DIFF:
https://github.com/llvm/llvm-project/commit/441108ccba948d76e7002c61236e3bcbca0203ce.diff
LOG:
Author: Owen Pan
Date: 2023-06-17T15:25:59-07:00
New Revision: 8411bdb0acde8569c9bfcd08401fa587f7dea834
URL:
https://github.com/llvm/llvm-project/commit/8411bdb0acde8569c9bfcd08401fa587f7dea834
DIFF:
https://github.com/llvm/llvm-project/commit/8411bdb0acde8569c9bfcd08401fa587f7dea834.diff
LOG:
Author: Owen Pan
Date: 2022-12-04T12:01:26-08:00
New Revision: e33243c950ac40d027ad8facbf7ccf0624604a16
URL:
https://github.com/llvm/llvm-project/commit/e33243c950ac40d027ad8facbf7ccf0624604a16
DIFF:
https://github.com/llvm/llvm-project/commit/e33243c950ac40d027ad8facbf7ccf0624604a16.diff
LOG:
Author: Gedare Bloom
Date: 2022-12-06T01:04:51-08:00
New Revision: b40e9dce0a67beab352f7b7be43f13190f69b69c
URL:
https://github.com/llvm/llvm-project/commit/b40e9dce0a67beab352f7b7be43f13190f69b69c
DIFF:
https://github.com/llvm/llvm-project/commit/b40e9dce0a67beab352f7b7be43f13190f69b69c.diff
Author: Owen Pan
Date: 2022-12-06T14:14:20-08:00
New Revision: 15f121e853846d7c74c243a4249a069dd67ca166
URL:
https://github.com/llvm/llvm-project/commit/15f121e853846d7c74c243a4249a069dd67ca166
DIFF:
https://github.com/llvm/llvm-project/commit/15f121e853846d7c74c243a4249a069dd67ca166.diff
LOG:
Author: Owen Pan
Date: 2022-12-10T02:31:53-08:00
New Revision: 91b5d508e350a26028b7fc1397f21334e49dda5d
URL:
https://github.com/llvm/llvm-project/commit/91b5d508e350a26028b7fc1397f21334e49dda5d
DIFF:
https://github.com/llvm/llvm-project/commit/91b5d508e350a26028b7fc1397f21334e49dda5d.diff
LOG:
Author: Owen Pan
Date: 2022-12-14T10:27:05-08:00
New Revision: 0e89f1cca495055795d97b17cb38d43d0c9a7ec1
URL:
https://github.com/llvm/llvm-project/commit/0e89f1cca495055795d97b17cb38d43d0c9a7ec1
DIFF:
https://github.com/llvm/llvm-project/commit/0e89f1cca495055795d97b17cb38d43d0c9a7ec1.diff
LOG:
Author: Owen Pan
Date: 2022-12-15T19:48:26-08:00
New Revision: 240e29c5015d246de7fb5e4421aa93042fada59b
URL:
https://github.com/llvm/llvm-project/commit/240e29c5015d246de7fb5e4421aa93042fada59b
DIFF:
https://github.com/llvm/llvm-project/commit/240e29c5015d246de7fb5e4421aa93042fada59b.diff
LOG:
Author: Owen Pan
Date: 2024-02-13T21:02:14-08:00
New Revision: 61c83e9491b2be71a54b255cdb11f65365245953
URL:
https://github.com/llvm/llvm-project/commit/61c83e9491b2be71a54b255cdb11f65365245953
DIFF:
https://github.com/llvm/llvm-project/commit/61c83e9491b2be71a54b255cdb11f65365245953.diff
LOG:
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/81578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1871,10 +1869,10 @@ FormatStyle getWebKitStyle() {
FormatStyle getGNUStyle() {
FormatStyle Style = getLLVMStyle();
Style.AlwaysBreakAfterDefinitionReturnType = FormatStyle::DRTBS_All;
- Style.AlwaysBreakAfterReturnType = FormatStyle::RTBS_AllDefinitions;
Style.Break
@@ -1130,14 +1129,13 @@ template <> struct MappingTraits {
// AlwaysBreakAfterReturnType was not, initialize the latter from the
// former for backwards compatibility.
owenca wrote:
```suggestion
// BreakAfterReturnType was not, initialize the latte
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/81591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/81591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-02-14T21:40:07-08:00
New Revision: 6087d7bc0a9d7d4ad2c94a131c2bc427b767c9d7
URL:
https://github.com/llvm/llvm-project/commit/6087d7bc0a9d7d4ad2c94a131c2bc427b767c9d7
DIFF:
https://github.com/llvm/llvm-project/commit/6087d7bc0a9d7d4ad2c94a131c2bc427b767c9d7.diff
LOG:
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/81958
Fixes #80579.
>From 13614f5760a26ba6134abdd555176a1aa2ed3974 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 15 Feb 2024 17:37:44 -0800
Subject: [PATCH] [clang-format] Don't sort qualifiers across preprocessor
Author: Owen Pan
Date: 2024-02-16T01:47:49-08:00
New Revision: 92ef40874d58d4fca4b7657c31ab2538e1301f26
URL:
https://github.com/llvm/llvm-project/commit/92ef40874d58d4fca4b7657c31ab2538e1301f26
DIFF:
https://github.com/llvm/llvm-project/commit/92ef40874d58d4fca4b7657c31ab2538e1301f26.diff
LOG:
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/81848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/81848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22893,6 +22893,19 @@ TEST_F(FormatTest, FormatsLambdas) {
LLVMWithBeforeLambdaBody);
verifyFormat("FctWithTwoParams_SLS_All([]() { return 43; }, 87);",
LLVMWithBeforeLambdaBody);
+ verifyFormat(
+ "FctWithTwoParams_SLS_All(\n"
+ "
owenca wrote:
> LGTM, as long as someone doesn't say it should be
>
> ```c++
> #if FOO
>constexpr
> #endif
>inline
>int i = 0;
> ```
>
> but I think this change is fine..I would rather we didn't try and support
> that.. thank you.
Yep! Otherwise, you would have to handle the follo
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/81958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/82097
Also reformat polly.
Fixes #79834.
>From f02c1acefe642065cae01ced98b168ce33b98d47 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 16 Feb 2024 23:27:12 -0800
Subject: [PATCH] [clang-format] Correctly annotate
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/82097
>From f02c1acefe642065cae01ced98b168ce33b98d47 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 16 Feb 2024 23:27:12 -0800
Subject: [PATCH 1/2] [clang-format] Correctly annotate block braces of empty
ctors/dtor
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/82097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/82278
Fixes #79833.
>From 4bcf6dba8b97096801be550c4a8d1626ed57e475 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 19 Feb 2024 13:11:29 -0800
Subject: [PATCH] [clang-format] Fix RemoveSemicolon for empty ctors/dtors
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/82278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/81848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-02-20T00:28:26-08:00
New Revision: 119a72866f0e143127355fe6e03f57c4f8bab1ae
URL:
https://github.com/llvm/llvm-project/commit/119a72866f0e143127355fe6e03f57c4f8bab1ae
DIFF:
https://github.com/llvm/llvm-project/commit/119a72866f0e143127355fe6e03f57c4f8bab1ae.diff
LOG:
owenca wrote:
> > couldn't we just use the .clang-format-ignore file to say... hey don't
> > bother with this file, we can't do it...
>
> I think that's a good solution for avoiding the OOM when actually trying to
> format the file, in combination with this patch for avoiding the OOM in
> `gu
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/82278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3817,7 +3817,7 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const {
do {
Tok = Tok->Next;
} while (Tok && Tok->isNot(TT_OverloadedOperatorLParen));
-if (!Tok)
+if (!Tok || !Tok->Next)
@@ -13503,6 +13503,9 @@ TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) {
verifyFormat("{");
verifyFormat("#})");
verifyNoCrash("(/**/[:!] ?[).");
+ verifyNoCrash("struct X{"
+" operator iunt("
owenca wrote:
```suggestion
verifyNoCr
owenca wrote:
> However, for clangd users, a crucial difference between `guessLanguage()` vs.
> other code in libFormat that uses `UnwrappedLineParser`, is that
> `guessLanguage()` gets called as soon as a file is opened in the editor,
> while the other code is only called if the user explicit
@@ -3123,6 +3123,7 @@ static void sortCppIncludes(const FormatStyle &Style,
}
std::string result;
+ unsigned NewCursor = UINT_MAX;
owenca wrote:
```suggestion
const auto OldCursor = Cursor ? *Cursor : 0;
```
https://github.com/llvm/llvm-project/pull/7
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/77456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3134,20 +3135,24 @@ static void sortCppIncludes(const FormatStyle &Style,
}
result += Includes[Index].Text;
if (Cursor && CursorIndex == Index)
- *Cursor = IncludesBeginOffset + result.size() - CursorToEOLOffset;
+ NewCursor = IncludesBeginOffset + res
@@ -3134,20 +3135,24 @@ static void sortCppIncludes(const FormatStyle &Style,
}
result += Includes[Index].Text;
if (Cursor && CursorIndex == Index)
- *Cursor = IncludesBeginOffset + result.size() - CursorToEOLOffset;
+ NewCursor = IncludesBeginOffset + res
https://github.com/owenca commented:
`git diff Format.cpp` output:
```
--- a/clang/lib/Format/Format.cpp
+++ b/clang/lib/Format/Format.cpp
@@ -3116,6 +3116,7 @@ static void sortCppIncludes(const FormatStyle &Style,
return;
}
+ const auto OldCursor = Cursor ? *Cursor : 0;
std::string
@@ -3134,20 +3135,24 @@ static void sortCppIncludes(const FormatStyle &Style,
}
result += Includes[Index].Text;
if (Cursor && CursorIndex == Index)
- *Cursor = IncludesBeginOffset + result.size() - CursorToEOLOffset;
+ NewCursor = IncludesBeginOffset + res
owenca wrote:
> As a side note, I tried adding these two tests but they fail, meaning the
> cursor is still incorrectly computed with CRLF when replacing lines.
>
> This is due to adding lines between the include groups (with Regroup option),
> as this new line is added with only the character
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/82349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/82735
Also insert separators for decimal integers longer than 4 digits.
>From e0a9d61283276bddda8231b599697cf4d497ff0a Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 22 Feb 2024 20:56:47 -0800
Subject: [PATCH] [cla
owenca wrote:
> > If we add a `bool GuessObjC` parameter to `guessLanguage()`, would that
> > solve the problem?
>
> I assume you mean making it so that when clangd calls into `guessLanguage()`,
> the ObjC guessing algorithm is skipped entirely.
I'm not familiar with clangd use cases, but I t
@@ -420,6 +420,8 @@ struct UnwrappedLineNode {
SmallVector Children;
};
+std::ostream &operator<<(std::ostream &Stream, const UnwrappedLine &Line);
+
owenca wrote:
Delete.
https://github.com/llvm/llvm-project/pull/82523
@@ -19,6 +19,7 @@
#include "clang/Basic/TokenKinds.h"
#include "llvm/ADT/DenseSet.h"
#include "llvm/Support/Debug.h"
+#include
owenca wrote:
Not needed explicitly.
https://github.com/llvm/llvm-project/pull/82523
__
@@ -287,6 +287,21 @@ TEST_F(FormatTestMacroExpansion,
Style);
}
+TEST_F(FormatTestMacroExpansion, IndentChildrenWithinMacroCall) {
+ FormatStyle Style = getGoogleStyleWithColumns(22);
+ Style.Macros.push_back("MACRO(a, b)=a=(b)");
+ verifyFormat("void f() {\n
@@ -90,6 +90,12 @@ class ScopedDeclarationState {
} // end anonymous namespace
+std::ostream &operator<<(std::ostream &Stream, const UnwrappedLine &Line) {
+ llvm::raw_os_ostream OS(Stream);
+ printLine(OS, Line);
+ return Stream;
+}
+
owenca wrote:
Delet
@@ -420,6 +420,8 @@ struct UnwrappedLineNode {
SmallVector Children;
};
+std::ostream &operator<<(std::ostream &Stream, const UnwrappedLine &Line);
+
owenca wrote:
Ah, thanks for the explanation.
https://github.com/llvm/llvm-project/pull/82523
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/77522
>From 4a7489251b842da778dd839bd5af3db12ba0fe0b Mon Sep 17 00:00:00 2001
From: Gedare Bloom
Date: Mon, 17 Jul 2023 18:24:30 -0600
Subject: [PATCH 1/5] Add SpaceInParensOption ExceptDoubleParentheses
This change al
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/77522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/93439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/97787
Fixes #97539.
>From 73d92b38268e5b44d6ed7e6ac9219267003cc7fb Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 4 Jul 2024 21:39:38 -0700
Subject: [PATCH] [clang-format] Skip block commented out includes when sor
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/97787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/97938
None
>From eb53318b3c5dec2452c4a0d5aed7944ebdd99380 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 6 Jul 2024 22:21:26 -0700
Subject: [PATCH] [clang-format][NFC] Annotate function decl l_paren
---
clang/lib
@@ -803,6 +803,60 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState
&State, bool DryRun,
return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while,
tok::kw_switch);
};
+ // Detecting functions is brittle. It wo
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/107041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/107021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/107074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-09-03T22:54:50-07:00
New Revision: 3449ed8dece600f387357b71ff74ae4bc46828b6
URL:
https://github.com/llvm/llvm-project/commit/3449ed8dece600f387357b71ff74ae4bc46828b6
DIFF:
https://github.com/llvm/llvm-project/commit/3449ed8dece600f387357b71ff74ae4bc46828b6.diff
LOG:
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/107352
Also add a test case for #106418.
Fixes #107096.
>From 8b359c9ab7e2b119383235c042f9804136ee172e Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 4 Sep 2024 21:41:28 -0700
Subject: [PATCH] [clang-format] Corre
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/107352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
901 - 1000 of 2315 matches
Mail list logo
