[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

2023-10-10 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

2023-10-13 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-15 Thread Owen Pan via cfe-commits
=?utf-8?q?Björn_Schäpers?= Message-ID: In-Reply-To: @@ -182,7 +182,7 @@ TEST_F(FormatTestComments, UnderstandsSingleLineComments) { "int a; // This is unrelated")); EXPECT_EQ("class C {\n" " void f() { // This does something ..\n" -

[clang] 6f46bcc - [clang-format] Treat AttributeMacro more like __attribute__

2023-10-15 Thread Owen Pan via cfe-commits
Author: Jared Grubb Date: 2023-10-15T15:44:57-07:00 New Revision: 6f46bcc609f14121e6942763ba9871f98541ea0e URL: https://github.com/llvm/llvm-project/commit/6f46bcc609f14121e6942763ba9871f98541ea0e DIFF: https://github.com/llvm/llvm-project/commit/6f46bcc609f14121e6942763ba9871f98541ea0e.diff L

[clang] 6c7cf74 - Revert "[clang-format] Treat AttributeMacro more like __attribute__"

2023-10-15 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-15T15:52:17-07:00 New Revision: 6c7cf74a75572c3cc5d9979f02b67a7357e9c656 URL: https://github.com/llvm/llvm-project/commit/6c7cf74a75572c3cc5d9979f02b67a7357e9c656 DIFF: https://github.com/llvm/llvm-project/commit/6c7cf74a75572c3cc5d9979f02b67a7357e9c656.diff LOG:

[clang] 7f881a2 - [clang-format] Treat AttributeMacro more like __attribute__

2023-10-15 Thread Owen Pan via cfe-commits
Author: Jared Grubb Date: 2023-10-15T15:58:24-07:00 New Revision: 7f881a2abe2c3eceeae0272fc41ba0a237770450 URL: https://github.com/llvm/llvm-project/commit/7f881a2abe2c3eceeae0272fc41ba0a237770450 DIFF: https://github.com/llvm/llvm-project/commit/7f881a2abe2c3eceeae0272fc41ba0a237770450.diff L

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -20794,7 +20794,7 @@ TEST_F(FormatTest, CatchAlignArrayOfStructuresRightAlignment) { verifyFormat("int a[][] = {\n" "{\n" " {0, 2}, //\n" - " {1, 2} //\n" + " {1, 2} //\n" owenca wrote: W

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -3191,20 +3191,120 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments) { "}\n" "// Comment"; -#if 0 - // FIXME: The following comment is aligned with the namespace comment. verifyFormat("namespace A {\n" " int Foo;\n"

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -2268,6 +2265,12 @@ bool UnwrappedLineParser::tryToParseLambda() { parseRequiresClause(RequiresToken); break; } +case tok::equal: + if (InTemplateParameterList) { +nextToken(); +break; + } + return true; owe

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -2268,6 +2265,12 @@ bool UnwrappedLineParser::tryToParseLambda() { parseRequiresClause(RequiresToken); break; } +case tok::equal: + if (InTemplateParameterList) { +nextToken(); +break; + } + return true; owe

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/69249 Skip TrailingAnnotation when looking for TrailingReturnArrow. Fixes #69234. >From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 16 Oct 2023 13:38:09 -0700 Subject: [

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) owenca wrote: Because `TT_Traili

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/69249 >From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 16 Oct 2023 13:38:09 -0700 Subject: [PATCH 1/2] [clang-format] Fix a bug in annotating TrailingReturnArrow Skip T

[clang] [clang-format] Fix a bug in mis-annotating arrows (PR #67780)

2023-10-16 Thread Owen Pan via cfe-commits
owenca wrote: See #69249. https://github.com/llvm/llvm-project/pull/67780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-16 Thread Owen Pan via cfe-commits
owenca wrote: > This allows git-clang-format to be used on a Windows terminal without > manually needing to find the path and invoke the python interpreter. We have > a similar script for `scan-build`. Can you open an issue and link to it from here? It seems `git clang-format` works in Comman

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-17 Thread Owen Pan via cfe-commits
owenca wrote: @HazardyKnusperkeks any other concerns? https://github.com/llvm/llvm-project/pull/69249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-17 Thread Owen Pan via cfe-commits
@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) owenca wrote: Before: look for _

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-17 Thread Owen Pan via cfe-commits
@@ -3191,20 +3191,146 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments) { "}\n" "// Comment"; -#if 0 - // FIXME: The following comment is aligned with the namespace comment. verifyFormat("namespace A {\n" " int Foo;\n"

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-17 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,35 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] adece4e - [clang-format][NFC] Remove superfluous code in UnwrappedLineParser

2023-08-01 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-01T13:31:24-07:00 New Revision: adece4e452e88f47e1b2b7971286906ae5246fb8 URL: https://github.com/llvm/llvm-project/commit/adece4e452e88f47e1b2b7971286906ae5246fb8 DIFF: https://github.com/llvm/llvm-project/commit/adece4e452e88f47e1b2b7971286906ae5246fb8.diff LOG:

[clang] 400da11 - [clang-format] Fix braced initializer with templated base class

2023-08-01 Thread Owen Pan via cfe-commits
Author: Galen Elias Date: 2023-08-01T13:53:22-07:00 New Revision: 400da115c58ae19445cfdc871a3f559f160fc5c6 URL: https://github.com/llvm/llvm-project/commit/400da115c58ae19445cfdc871a3f559f160fc5c6 DIFF: https://github.com/llvm/llvm-project/commit/400da115c58ae19445cfdc871a3f559f160fc5c6.diff L

[clang] 70d7ea0 - [clang-format] Handle goto labels preceded by C++11 attributes

2023-08-02 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-02T22:48:48-07:00 New Revision: 70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5 URL: https://github.com/llvm/llvm-project/commit/70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5 DIFF: https://github.com/llvm/llvm-project/commit/70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5.diff LOG:

[clang] 58a71c6 - [clang-format] Handle "// clang-format on" for SeparateDefinitionBlocks

2023-08-05 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-05T12:31:27-07:00 New Revision: 58a71c66db85f65bb6cdefe314f62318b95e9fc4 URL: https://github.com/llvm/llvm-project/commit/58a71c66db85f65bb6cdefe314f62318b95e9fc4 DIFF: https://github.com/llvm/llvm-project/commit/58a71c66db85f65bb6cdefe314f62318b95e9fc4.diff LOG:

[clang] a0b1c23 - [clang-format] Currectly handle PCIS_CurrentLine with no column limit

2023-08-06 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-06T12:14:23-07:00 New Revision: a0b1c235afab4743cf31e4ac4509120d3c156e60 URL: https://github.com/llvm/llvm-project/commit/a0b1c235afab4743cf31e4ac4509120d3c156e60 DIFF: https://github.com/llvm/llvm-project/commit/a0b1c235afab4743cf31e4ac4509120d3c156e60.diff LOG:

[clang] a8fbc16 - Revert "[git-clang-format] Fix typo in help message"

2023-09-07 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-07T15:05:46-07:00 New Revision: a8fbc16ebebedce98d06782680fcafae0cf06e7d URL: https://github.com/llvm/llvm-project/commit/a8fbc16ebebedce98d06782680fcafae0cf06e7d DIFF: https://github.com/llvm/llvm-project/commit/a8fbc16ebebedce98d06782680fcafae0cf06e7d.diff LOG:

[clang] 210e7b3 - [clang-format] Improve line-breaking in LambdaBodyIndentation: OuterScope

2023-09-08 Thread Owen Pan via cfe-commits
Author: Jon Phillips Date: 2023-09-08T14:34:00-07:00 New Revision: 210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc URL: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc DIFF: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc.diff

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

2023-09-08 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
@@ -1599,6 +1600,15 @@ unsigned ContinuationIndenter::moveStateToNextToken(LineState &State, State.Column += Current.ColumnWidth; State.NextToken = State.NextToken->Next; + // Verilog case labels are are on the same unwrapped lines as the statements + // that follow. T

[clang] 9ae41a1 - [clang-format][doc] Fix a '' (in c669541c969c) that meant to be ``

2023-09-10 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-10T12:52:49-07:00 New Revision: 9ae41a1472b2529a9028d003ca0e8e3812348742 URL: https://github.com/llvm/llvm-project/commit/9ae41a1472b2529a9028d003ca0e8e3812348742 DIFF: https://github.com/llvm/llvm-project/commit/9ae41a1472b2529a9028d003ca0e8e3812348742.diff LOG:

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-10 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-10 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-10 Thread Owen Pan via cfe-commits
@@ -3369,9 +3369,13 @@ bool clang::format::UnwrappedLineParser::parseRequires() { case tok::kw_volatile: case tok::kw_const: case tok::comma: - FormatTok = Tokens->setPosition(StoredPosition); - parseRequiresExpression(RequiresToken); - return false;

[clang] b908123 - [clang-format][NFC] Minor cleanup of token annotator and test cases

2023-09-11 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-11T00:18:57-07:00 New Revision: b908123c3c1934c03b5183318a47d321fb796260 URL: https://github.com/llvm/llvm-project/commit/b908123c3c1934c03b5183318a47d321fb796260 DIFF: https://github.com/llvm/llvm-project/commit/b908123c3c1934c03b5183318a47d321fb796260.diff LOG:

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/65933: Fixes #65877. >From 86b83692a9f13b8c608190f6abc3111719583730 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 11 Sep 2023 01:00:24 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating '&&' enclosed in

[clang] [clang-format] Fix a bug in annotating `&&` enclosed in `<` and `>` (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65933: >From 70aafbc4717264205796fa2ea67d78482f9f2a0d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 11 Sep 2023 01:00:24 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` F

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

2023-09-13 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66354: See https://reviews.llvm.org/D136154#3890747 for context. Fixes part of #58592. >From 9a15ec3256e2d380d5eb70f0751ea1bb457895dd Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 14 Sep 2023 02:59:43 -0700 Subje

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66354: >From 73669f7d04070feade2282384478e96b8bc6d727 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 14 Sep 2023 02:59:43 -0700 Subject: [PATCH] [clang-format] Fix a bug in ContinuationIndenter See https://reviews.

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
@@ -2783,17 +2783,17 @@ the configuration (without a prefix: ``Auto``). const char* x = "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; - In C#, Java, and JavaScript: + In C# and Java: .. code-block:: c++ true: - var x = "veryVery

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
@@ -2237,15 +2237,10 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, LineState &State, bool AllowBreak) { unsigned StartColumn = State.Column - Current.ColumnWidth; if (Current.isStringLiteral()) { -/

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-15 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-15 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66569 None >From d570d3bb4d0bf9a49b51c25857958988329d398f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From 83b81df954391c38c123a116ab5c39acd29a3a87 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions Remo

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions Remo

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: Nits. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1135,6 +1145,14 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresExpressions) { EXPECT_TOKEN(Tokens[3], tok::kw_requires, TT_RequiresExpression); EXPECT_TOKEN(Tokens[4], tok::l_paren, TT_RequiresExpressionLParen); EXPECT_TOKEN(Tokens[14], tok::l_brace, TT_RequiresExp

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause); EXPECT_TOKEN(Tokens[

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause); EXPECT_TOKEN(Tokens[

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH 1/2] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -370,9 +364,9 @@ bool UnwrappedLineParser::parseLevel(const FormatToken *OpeningBrace, else if (FormatTok->getType() == TT_MacroBlockEnd) kind = tok::r_brace; -auto ParseDefault = [this, OpeningBrace, NextLevelLBracesType, IfKind, +auto ParseDefault = [th

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3f3620e - [clang-format] Correctly annotate */&/&& in operator function calls

2023-07-03 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-03T17:49:10-07:00 New Revision: 3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37 URL: https://github.com/llvm/llvm-project/commit/3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37 DIFF: https://github.com/llvm/llvm-project/commit/3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37.diff LOG:

[clang] 6b8a9ff - [clang-format] Fix RAS reference alignment when PAS is left or middle

2023-07-06 Thread Owen Pan via cfe-commits
Author: Gedare Bloom Date: 2023-07-06T01:41:16-07:00 New Revision: 6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2 URL: https://github.com/llvm/llvm-project/commit/6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2 DIFF: https://github.com/llvm/llvm-project/commit/6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2.diff

[clang] a84e0b4 - [clang-format] Fix align consecutive declarations over function pointers

2023-07-06 Thread Owen Pan via cfe-commits
Author: Gedare Bloom Date: 2023-07-06T02:17:32-07:00 New Revision: a84e0b4bdc872adbdaafbade8164b197784b URL: https://github.com/llvm/llvm-project/commit/a84e0b4bdc872adbdaafbade8164b197784b DIFF: https://github.com/llvm/llvm-project/commit/a84e0b4bdc872adbdaafbade8164b197784b.diff

[clang] 413a7cb - [clang-format] Support block indenting array/struct list initializers

2023-07-06 Thread Owen Pan via cfe-commits
Author: Gedare Bloom Date: 2023-07-06T13:42:11-07:00 New Revision: 413a7cb6e0db96b29bda0dab8541e225193ad139 URL: https://github.com/llvm/llvm-project/commit/413a7cb6e0db96b29bda0dab8541e225193ad139 DIFF: https://github.com/llvm/llvm-project/commit/413a7cb6e0db96b29bda0dab8541e225193ad139.diff

[clang] 0556ab3 - [clang-format][NFC] Improve efficiency of isFunctionDeclarationName

2023-07-07 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-07T16:29:36-07:00 New Revision: 0556ab33532964dd8720b3b3ebd87dfe459d81d2 URL: https://github.com/llvm/llvm-project/commit/0556ab33532964dd8720b3b3ebd87dfe459d81d2 DIFF: https://github.com/llvm/llvm-project/commit/0556ab33532964dd8720b3b3ebd87dfe459d81d2.diff LOG:

[clang] 9ec5dc6 - [clang-format] Add note directive generation for docs

2023-07-09 Thread Owen Pan via cfe-commits
Author: Gedare Bloom Date: 2023-07-09T12:24:55-07:00 New Revision: 9ec5dc6944781b0c233e874a4ed8d12106df14ac URL: https://github.com/llvm/llvm-project/commit/9ec5dc6944781b0c233e874a4ed8d12106df14ac DIFF: https://github.com/llvm/llvm-project/commit/9ec5dc6944781b0c233e874a4ed8d12106df14ac.diff

[clang] 3a6a070 - [clang-format] Add an option to remove redundant parentheses

2023-07-11 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-11T16:33:19-07:00 New Revision: 3a6a0702c2a4c2290f0b55b0451a9f97d7592baf URL: https://github.com/llvm/llvm-project/commit/3a6a0702c2a4c2290f0b55b0451a9f97d7592baf DIFF: https://github.com/llvm/llvm-project/commit/3a6a0702c2a4c2290f0b55b0451a9f97d7592baf.diff LOG:

[clang] 875b881 - [clang-format][NFC] Remove redundant parentheses in the source code

2023-07-11 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-11T17:05:00-07:00 New Revision: 875b881186c4eb146e77e76ad72ee0a356d7c69f URL: https://github.com/llvm/llvm-project/commit/875b881186c4eb146e77e76ad72ee0a356d7c69f DIFF: https://github.com/llvm/llvm-project/commit/875b881186c4eb146e77e76ad72ee0a356d7c69f.diff LOG:

[clang] cc2ff02 - [clang-format] Correctly annotate overloaded operator function name

2023-07-15 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-15T11:02:31-07:00 New Revision: cc2ff02eadede988ab890b2d0f428bd1531a3803 URL: https://github.com/llvm/llvm-project/commit/cc2ff02eadede988ab890b2d0f428bd1531a3803 DIFF: https://github.com/llvm/llvm-project/commit/cc2ff02eadede988ab890b2d0f428bd1531a3803.diff LOG:

[clang] d06b923 - [clang-format] Fix a bug that wraps before function arguments

2023-08-23 Thread Owen Pan via cfe-commits
Author: Jon Phillips Date: 2023-08-23T11:18:23-07:00 New Revision: d06b923915137c86e9f281e7fce28240e13665ea URL: https://github.com/llvm/llvm-project/commit/d06b923915137c86e9f281e7fce28240e13665ea DIFF: https://github.com/llvm/llvm-project/commit/d06b923915137c86e9f281e7fce28240e13665ea.diff

[clang] 91c4db0 - [clang-format][NFC] Replace !is() with isNot()

2023-08-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-24T01:27:24-07:00 New Revision: 91c4db00612b205c6d0f56990b657c5646ad2a3b URL: https://github.com/llvm/llvm-project/commit/91c4db00612b205c6d0f56990b657c5646ad2a3b DIFF: https://github.com/llvm/llvm-project/commit/91c4db00612b205c6d0f56990b657c5646ad2a3b.diff LOG:

[clang] 0e63f1a - [clang-format] Annotate constructor/destructor names

2023-08-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-24T01:32:52-07:00 New Revision: 0e63f1aacc0040e9a16fa2fab15a140b1686e2ab URL: https://github.com/llvm/llvm-project/commit/0e63f1aacc0040e9a16fa2fab15a140b1686e2ab DIFF: https://github.com/llvm/llvm-project/commit/0e63f1aacc0040e9a16fa2fab15a140b1686e2ab.diff LOG:

[clang] c852145 - [clang-format][NFC] Skip stability test if input is pre-formatted

2023-08-26 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-26T14:48:04-07:00 New Revision: c8521451708a49a5a55cf02c28189efac11b779e URL: https://github.com/llvm/llvm-project/commit/c8521451708a49a5a55cf02c28189efac11b779e DIFF: https://github.com/llvm/llvm-project/commit/c8521451708a49a5a55cf02c28189efac11b779e.diff LOG:

[clang] 19e3dfa - [clang-format][NFC] Chang some verifyFormat() to verifyNoChange()

2023-08-26 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-26T19:44:05-07:00 New Revision: 19e3dfad58d36ed5aee798fc1b0af2a449002afc URL: https://github.com/llvm/llvm-project/commit/19e3dfad58d36ed5aee798fc1b0af2a449002afc DIFF: https://github.com/llvm/llvm-project/commit/19e3dfad58d36ed5aee798fc1b0af2a449002afc.diff LOG:

[clang] 6982f1f - [clang-format][NFC] Test formatting the input before messing it up

2023-08-29 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-29T00:59:33-07:00 New Revision: 6982f1fc2e750cfbb4b0098a6294d341238656ca URL: https://github.com/llvm/llvm-project/commit/6982f1fc2e750cfbb4b0098a6294d341238656ca DIFF: https://github.com/llvm/llvm-project/commit/6982f1fc2e750cfbb4b0098a6294d341238656ca.diff LOG:

[clang] 0863051 - Reland "[clang-format] Annotate constructor/destructor names"

2023-08-29 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-29T13:14:52-07:00 New Revision: 0863051208870b284a1ee899defc0ba2b6e53fc4 URL: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4 DIFF: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4.diff LOG:

[clang] 14feca5 - [clang-format][NFC] Replace EXPECT_EQ() with verifyFormat()

2023-08-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-30T14:55:26-07:00 New Revision: 14feca5d14f1b158f468f01039302da2ca396b14 URL: https://github.com/llvm/llvm-project/commit/14feca5d14f1b158f468f01039302da2ca396b14 DIFF: https://github.com/llvm/llvm-project/commit/14feca5d14f1b158f468f01039302da2ca396b14.diff LOG:

[clang] 77b2fc8 - [clang-format][NFC] Reformat and fix file mode

2023-08-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-30T18:35:24-07:00 New Revision: 77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec URL: https://github.com/llvm/llvm-project/commit/77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec DIFF: https://github.com/llvm/llvm-project/commit/77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec.diff LOG:

[clang] 58c67e7 - [clang-format] Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

2023-08-31 Thread Owen Pan via cfe-commits
Author: Galen Elias Date: 2023-08-31T14:21:19-07:00 New Revision: 58c67e724f718be06ea43c766871135a338c2d55 URL: https://github.com/llvm/llvm-project/commit/58c67e724f718be06ea43c766871135a338c2d55 DIFF: https://github.com/llvm/llvm-project/commit/58c67e724f718be06ea43c766871135a338c2d55.diff L

[clang] f465a48 - [clang-format] Fix segmentation fault when formatting nested namespaces

2023-09-05 Thread Owen Pan via cfe-commits
Author: Arkadiy Yudintsev Date: 2023-09-05T11:12:14-07:00 New Revision: f465a482caa94d01a2dd74e4c673adeb1f222f2f URL: https://github.com/llvm/llvm-project/commit/f465a482caa94d01a2dd74e4c673adeb1f222f2f DIFF: https://github.com/llvm/llvm-project/commit/f465a482caa94d01a2dd74e4c673adeb1f222f2f.d

[clang] 4146b30 - Revert "[Format] Modernize SpaceBeforeParensCustom (NFC)"

2023-09-05 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-05T12:03:14-07:00 New Revision: 4146b30785fb5db6fa4da47e6198f7bd961559c5 URL: https://github.com/llvm/llvm-project/commit/4146b30785fb5db6fa4da47e6198f7bd961559c5 DIFF: https://github.com/llvm/llvm-project/commit/4146b30785fb5db6fa4da47e6198f7bd961559c5.diff LOG:

[clang] c22c0c4 - [clang-format][NFC] Change conjunction of isNot() with one !isOneOf()

2023-09-07 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-07T00:20:02-07:00 New Revision: c22c0c4769da8084378675fe58fd033dfa73ad1e URL: https://github.com/llvm/llvm-project/commit/c22c0c4769da8084378675fe58fd033dfa73ad1e DIFF: https://github.com/llvm/llvm-project/commit/c22c0c4769da8084378675fe58fd033dfa73ad1e.diff LOG:

[clang] 92bccf5 - [clang-format] Don't use PPIndentWidth inside multi-line macros

2022-11-19 Thread Owen Pan via cfe-commits
Author: Noah Goldstein Date: 2022-11-19T23:53:48-08:00 New Revision: 92bccf5d3d2122d57f12dc07d4781e90edefd7ef URL: https://github.com/llvm/llvm-project/commit/92bccf5d3d2122d57f12dc07d4781e90edefd7ef DIFF: https://github.com/llvm/llvm-project/commit/92bccf5d3d2122d57f12dc07d4781e90edefd7ef.diff

[clang] 4daeb8c - [clang-format] Fix a crash due to dereferencing null MatchingParen

2022-11-21 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2022-11-21T12:33:51-08:00 New Revision: 4daeb8c7335439e2ab43d66acfed087c417a7314 URL: https://github.com/llvm/llvm-project/commit/4daeb8c7335439e2ab43d66acfed087c417a7314 DIFF: https://github.com/llvm/llvm-project/commit/4daeb8c7335439e2ab43d66acfed087c417a7314.diff LOG:

[clang] ad83bea - [clang-format] Don't move comments if AlignTrailingComments: Leave

2022-12-01 Thread Owen Pan via cfe-commits
Author: Maíra Canal Date: 2022-12-01T16:07:06-08:00 New Revision: ad83bead3d42082f858d810a5b9f43ed096a6e3c URL: https://github.com/llvm/llvm-project/commit/ad83bead3d42082f858d810a5b9f43ed096a6e3c DIFF: https://github.com/llvm/llvm-project/commit/ad83bead3d42082f858d810a5b9f43ed096a6e3c.diff L

[clang] 682808d - Reland [clang-format] Add a space between an overloaded operator and '>'

2023-03-20 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-03-20T03:01:22-07:00 New Revision: 682808d9c9c81306c0a08a1fdb496b4f572566b4 URL: https://github.com/llvm/llvm-project/commit/682808d9c9c81306c0a08a1fdb496b4f572566b4 DIFF: https://github.com/llvm/llvm-project/commit/682808d9c9c81306c0a08a1fdb496b4f572566b4.diff LOG:

[clang] 5b5c49a - [clang-format] Don't format already formatted integer literals

2023-03-26 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-03-26T13:25:41-07:00 New Revision: 5b5c49ad4563f75debccbc6c3017d27a47ca217d URL: https://github.com/llvm/llvm-project/commit/5b5c49ad4563f75debccbc6c3017d27a47ca217d DIFF: https://github.com/llvm/llvm-project/commit/5b5c49ad4563f75debccbc6c3017d27a47ca217d.diff LOG:

[clang] 767aee1 - [clang-format] Don't annotate left brace of struct as FunctionLBrace

2023-03-27 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-03-27T14:07:15-07:00 New Revision: 767aee1de9e98256a62ae8b4c2f84381203613c3 URL: https://github.com/llvm/llvm-project/commit/767aee1de9e98256a62ae8b4c2f84381203613c3 DIFF: https://github.com/llvm/llvm-project/commit/767aee1de9e98256a62ae8b4c2f84381203613c3.diff LOG:

[clang] 4d21868 - [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

2023-03-28 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-03-28T13:13:02-07:00 New Revision: 4d21868b09681dffb9997f1a8d0c0dac12a226d3 URL: https://github.com/llvm/llvm-project/commit/4d21868b09681dffb9997f1a8d0c0dac12a226d3 DIFF: https://github.com/llvm/llvm-project/commit/4d21868b09681dffb9997f1a8d0c0dac12a226d3.diff LOG:

[clang] 95c3c2b - [clang-format] clang-format.el: fix warnings

2023-02-27 Thread Owen Pan via cfe-commits
Author: Augustin Fabre Date: 2023-02-27T01:56:24-08:00 New Revision: 95c3c2b8570d307ad91c603856336acf32e5021f URL: https://github.com/llvm/llvm-project/commit/95c3c2b8570d307ad91c603856336acf32e5021f DIFF: https://github.com/llvm/llvm-project/commit/95c3c2b8570d307ad91c603856336acf32e5021f.diff

[clang] d14e7ee - [clang-format] Add -j to clang-format-diff to speed up formatting

2023-03-02 Thread Owen Pan via cfe-commits
Author: Sean Maher Date: 2023-03-02T11:59:11-08:00 New Revision: d14e7ee3d17cfa60d44256d742c10e9949a6048f URL: https://github.com/llvm/llvm-project/commit/d14e7ee3d17cfa60d44256d742c10e9949a6048f DIFF: https://github.com/llvm/llvm-project/commit/d14e7ee3d17cfa60d44256d742c10e9949a6048f.diff LO

<    4   5   6   7   8   9   10   11   12   13   >