[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -0,0 +1,77 @@ + +// RUN: %clang_cc1 -gkey-instructions -x c++ %s -debug-info-kind=line-tables-only -gno-column-info -emit-llvm -o - -ftrivial-auto-var-init=zero -fenable-matrix -disable-llvm-passes \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not

[clang] [KeyInstr][Clang] Reset atomGroup number for each function (PR #141607)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/141607 CGDebugInfo::completeFunction was added previously but mistakenly not called (dropped through the cracks while putting together the patch stack). Moved out of #134652 and #134654. >From 510cb679b679f7265107127

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134646 >From 510cb679b679f7265107127cc3d57a76b576e42d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 27 May 2025 14:57:12 +0100 Subject: [PATCH 1/7] [KeyInstr][Clang] Reset atomGroup number for each f

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134646 >From 510cb679b679f7265107127cc3d57a76b576e42d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 27 May 2025 14:57:12 +0100 Subject: [PATCH 1/8] [KeyInstr][Clang] Reset atomGroup number for each f

[clang] [KeyInstr][Clang] Reset atomGroup number for each function (PR #141607)

2025-05-28 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/141607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

2025-05-28 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134651 >From bf3a37df3a82797227e476485f6cf4c0c9a7c912 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Fri, 4 Apr 2025 14:36:43 +0100 Subject: [PATCH 1/5] [KeyInstr][Clang] Store-like builtin atoms --- clan

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

2025-05-28 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -4466,7 +4473,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Value *SizeVal = EmitScalarExpr(E->getArg(2)); EmitNonNullArgCheck(Dest, E->getArg(0)->getType(), E->getArg(0)->getExprLoc(), FD, 0); -Bui

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-05-28 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134646 >From 0c7a83007e218dd7338b92f1d50319b0f35cf55f Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 19:12:47 +0100 Subject: [PATCH 1/7] [KeyInstr][Clang] For stmt atom This patch is part o

[clang] [KeyInstr][Clang] Atomic ops atoms (PR #141624)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/141624 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The feature is only functional in LLVM if LLVM is built with CMake flag LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs.

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134648 >From 76d8a4306760fba28fc22c936b46d98263c37971 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 19:57:39 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] Bitfield atom This patch is part o

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: You were right about any ctrl-flow breaking the br-to-cond atom group. Fixed, improved testing, and follow up with additional work for continue/break in https://github.com/llvm/llvm-project/pull/141618 n.b. this is now based on top of https://github.com/llvm/llvm-project/pull/1

[clang] [llvm] [not for merge][RFC] Key Instructions front end demo (PR #130943)

2025-05-27 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/130943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 894a0dd - Revert "[KeyIntsr][Clang] Builtins atoms (#134651)"

2025-05-28 Thread Orlando Cazalet-Hyams via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-05-28T18:31:08+01:00 New Revision: 894a0dd57f81211f9e431d9e84f2856d34f46993 URL: https://github.com/llvm/llvm-project/commit/894a0dd57f81211f9e431d9e84f2856d34f46993 DIFF: https://github.com/llvm/llvm-project/commit/894a0dd57f81211f9e431d9e84f2856d34f469

[clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134635 >From c4029c3503f565ab6c2faa9cdec129c79133ff4f Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 15:40:58 +0100 Subject: [PATCH 1/7] [KeyInstr][Clang] Agg init atom This patch is part o

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134636 >From b1b2e0d6e0924ac273c832696ddcc233cd18aa24 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 2 Apr 2025 17:42:48 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Static variable init atom This pat

[clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134637 >From 5f5c881e69776978ef8e237932feed403cc2 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 2 Apr 2025 18:01:48 +0100 Subject: [PATCH 01/12] [KeyInstr][Clang] Assignment atom group This patch

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-05-22 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134644 >From fece69dc87e3c303aaba742f322377fd361e21ce Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:53:31 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] Do stmt atom See test comment for

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -1242,9 +1242,17 @@ void CodeGenFunction::EmitDoStmt(const DoStmt &S, // As long as the condition is true, iterate the loop. if (EmitBoolCondBranch) { uint64_t BackedgeCount = getProfileCount(S.getBody()) - ParentCount; -Builder.CreateCondBr( +auto *I = Build

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s -debug-info-kind=line-tables-only -emit-llvm -o - \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank + +// RUN: %clang_cc1 -gkey-instructions -x c %s -debug-info-kin

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s -debug-info-kind=line-tables-only -emit-llvm -o - \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank + +// RUN: %clang_cc1 -gkey-instructions -x c %s -debug-info-kin

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -1242,9 +1242,17 @@ void CodeGenFunction::EmitDoStmt(const DoStmt &S, // As long as the condition is true, iterate the loop. if (EmitBoolCondBranch) { uint64_t BackedgeCount = getProfileCount(S.getBody()) - ParentCount; -Builder.CreateCondBr( +auto *I = Build

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134651 >From bf3a37df3a82797227e476485f6cf4c0c9a7c912 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Fri, 4 Apr 2025 14:36:43 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Store-like builtin atoms --- clan

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134645 >From 984039ede0eb3626feaeaa74f875165f4c5d91d1 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:49:32 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] While stmt atom See test comment f

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams converted_to_draft https://github.com/llvm/llvm-project/pull/134645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams converted_to_draft https://github.com/llvm/llvm-project/pull/134646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134646 >From 8be98dcf4e19f1971a03ad072336f0e0e9c67a55 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 19:12:47 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] For stmt atom This patch is part o

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For range stmt atoms (PR #134647)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assign vector element atom (PR #134649)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For range stmt atoms (PR #134647)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assign vector element atom (PR #134649)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 123bf5f - [KeyInstr][Clang] If stmt atom (#134642)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-05-23T13:46:37+01:00 New Revision: 123bf5f46c31a016768b7ecd9b164bde5ef881d9 URL: https://github.com/llvm/llvm-project/commit/123bf5f46c31a016768b7ecd9b164bde5ef881d9 DIFF: https://github.com/llvm/llvm-project/commit/123bf5f46c31a016768b7ecd9b164bde5ef881

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134644 >From fece69dc87e3c303aaba742f322377fd361e21ce Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:53:31 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Do stmt atom See test comment for

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134645 >From 984039ede0eb3626feaeaa74f875165f4c5d91d1 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:49:32 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] While stmt atom See test comment f

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134638 >From fa1c06148d4f79e9464d92ab5c26d9a22c5bf41d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 13:36:59 +0100 Subject: [PATCH 1/8] [KeyInstr] Complex assignment atoms This patch is pa

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: Sorry I misunderstood what you were saying. Fixed, this should now have symmetry with prior patches. Expanded the test coverage. There's 4 binop assign calls that are instrumented individually which reflects the previous patch's macro usage. The expanded test coverage identified

[clang] [KeyInstr][Clang] Switch stmt atom (PR #134643)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Switch stmt atom (PR #134643)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134641 >From ae032c5dd3537662508d77bbb447808f52481f5d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 11:59:24 +0100 Subject: [PATCH 01/33] [KeyInstr][Clang] Add ApplyAtomGroup This is a sco

[clang] [KeyInstr][Clang] Member initalization atom (PR #134640)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: Sorry to all that were added... grappling with messed-up graphite internal state, GitHub enjoys adding reviewers for me when I change base. https://github.com/llvm/llvm-project/pull/134638 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Member initalization atom (PR #134640)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134640 >From 58615d2b93f4644bc7574d86b580d05edf1ca03c Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 17:00:09 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Member initalization atom This pat

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134644 >From 1219e5b01cd9cc38fe85d3377354c6e56e51134a Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:53:31 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Do stmt atom See test comment for

[clang] 435a542 - [KeyInstr] Fix clang tests

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-05-23T11:19:30+01:00 New Revision: 435a542009d45d85fbd9a2ff0df735572d5cc276 URL: https://github.com/llvm/llvm-project/commit/435a542009d45d85fbd9a2ff0df735572d5cc276 DIFF: https://github.com/llvm/llvm-project/commit/435a542009d45d85fbd9a2ff0df735572d5cc2

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134641 >From 7c86cc1b0b0bfaba4c304a31b5b0f2a1f391ad63 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 17:31:32 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Catch variable init atom This patc

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams converted_to_draft https://github.com/llvm/llvm-project/pull/134641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -5055,6 +5055,7 @@ void ItaniumCXXABI::emitBeginCatch(CodeGenFunction &CGF, // Emit the local. CodeGenFunction::AutoVarEmission var = CGF.EmitAutoVarAlloca(*CatchParam); + ApplyAtomGroup Grp(CGF.getDebugInfo()); InitCatchParam(CGF, *CatchParam, var.getObjectAddress(

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

2025-05-23 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

2025-05-21 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134633 >From c64f3e7363dae15d09188ec22d618be9841d8784 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 14:50:41 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Scalar init atom This patch is par

[clang] 351f15b - Reapply "[KeyIntsr][Clang] Builtins atoms (#134651)"

2025-05-29 Thread Orlando Cazalet-Hyams via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-05-29T10:40:34+01:00 New Revision: 351f15ba82f861cd7441f613db8317c353ca79c2 URL: https://github.com/llvm/llvm-project/commit/351f15ba82f861cd7441f613db8317c353ca79c2 DIFF: https://github.com/llvm/llvm-project/commit/351f15ba82f861cd7441f613db8317c353ca79

[clang] [NFC][KeyInstr][Clang] Add some additional tests (PR #134654)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134654 >From e8a5ebb08165c6d9b0ac6b518b4ad3d1abd1fa4b Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Mon, 7 Apr 2025 12:18:48 +0100 Subject: [PATCH 1/4] [NFC][KeyInstr][Clang] Add some additional tests Thi

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][KeyInstr][Clang] Add some additional tests (PR #134654)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134654 >From 79d3f9c4eb1491789aa288c2b379e85736d8ce74 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Mon, 7 Apr 2025 12:18:48 +0100 Subject: [PATCH 1/5] [NFC][KeyInstr][Clang] Add some additional tests Thi

[clang] [NFC][KeyInstr][Clang] Add some additional tests (PR #134654)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Ret atom (PR #134652)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams commented: Ready for review * Add parameter `RetKeyInstructionsSourceAtom` in `EmitFunctionEpilog` to request a `ret` gets a specific atomGroup number through `addInstToSpecificSourceAtom` Most of the updated tests just check for any atom on the ret, but the two tes

[clang] 8e50e88 - [KeyInstr][Clang] Break and Continue stmt atoms

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-06-03T14:25:48+01:00 New Revision: 8e50e882a847a8fd51ee8ec22fea5df192b14c06 URL: https://github.com/llvm/llvm-project/commit/8e50e882a847a8fd51ee8ec22fea5df192b14c06 DIFF: https://github.com/llvm/llvm-project/commit/8e50e882a847a8fd51ee8ec22fea5df192b14c

[clang] [KeyInstr][Clang] Ret atom (PR #134652)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134652 >From fc97db31e40af460d2d6a2ba6df94f932cb1c8cb Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Fri, 4 Apr 2025 16:28:39 +0100 Subject: [PATCH 01/11] [KeyInstr][Clang] Ret atom This patch is part of a

[clang] [KeyInstr][Clang] Ret atom (PR #134652)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134652 >From fc97db31e40af460d2d6a2ba6df94f932cb1c8cb Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Fri, 4 Apr 2025 16:28:39 +0100 Subject: [PATCH 01/10] [KeyInstr][Clang] Ret atom This patch is part of a

[clang] [KeyInstr][Clang] Ret atom (PR #134652)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][KeyInstr][Clang] Add some additional tests (PR #134654)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134654 >From e8a5ebb08165c6d9b0ac6b518b4ad3d1abd1fa4b Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Mon, 7 Apr 2025 12:18:48 +0100 Subject: [PATCH 1/3] [NFC][KeyInstr][Clang] Add some additional tests Thi

[clang] [KeyInstr][Clang] Coerced store atoms (PR #134653)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Coerced store atoms (PR #134653)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][KeyInstr][Clang] Add some additional tests (PR #134654)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -1418,6 +1427,12 @@ void CodeGenFunction::EmitForStmt(const ForStmt &S, if (CGM.shouldEmitConvergenceTokens()) ConvergenceTokenStack.pop_back(); + + if (FinalBodyBB) { +// Key Instructions: We want the for closing brace to be step-able on to +// match existin

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-06-16 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: Ping, and updated based on PR #144104 https://github.com/llvm/llvm-project/pull/137991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

2025-06-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/137991 >From cb89d1f1bb60db07743f1973f9b263424fab9f6d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 30 Apr 2025 15:19:03 +0100 Subject: [PATCH 1/4] [KeyInstr] Add docs --- clang/docs/KeyInstructions

[clang] [KeyInstr][Clang] Atomic ops atoms (PR #141624)

2025-06-24 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -0,0 +1,162 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -gkey-instructions -x c++ -std=c++17 %s -debug-info-kind=line-tables-only -emit-llvm -o - -gno-column-info \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank +// RUN: %clang_cc1 -

[clang] [KeyInstr][Clang] Atomic ops atoms (PR #141624)

2025-06-24 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/141624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 75cf826 - [KeyInstr][Clang] Fix atomic ops atoms test

2025-06-24 Thread Orlando Cazalet-Hyams via cfe-commits
Author: Orlando Cazalet-Hyams Date: 2025-06-24T14:37:21+01:00 New Revision: 75cf826849713c00829cdf657e330e24c1a2fd03 URL: https://github.com/llvm/llvm-project/commit/75cf826849713c00829cdf657e330e24c1a2fd03 DIFF: https://github.com/llvm/llvm-project/commit/75cf826849713c00829cdf657e330e24c1a2fd

[clang] [llvm] [KeyInstr] Add DISubprogram::keyInstructions bit (PR #144107)

2025-06-23 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -922,8 +922,8 @@ template <> struct MDNodeKeyImpl { MDString *LinkageName; Metadata *File; unsigned Line; - Metadata *Type; unsigned ScopeLine; + Metadata *Type; OCHyams wrote: Yep, 136 -> 128 bytes (144 -> 136 with the new bool). I don't think i

[clang] [llvm] [KeyInstr] Add DISubprogram::keyInstructions bit (PR #144107)

2025-06-23 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: > LGTM, I think this raises a few questions about whether we're going to > support non-key-instructions code forever more. AFAIUI the premise is that > the debugging behaviour is worse if you've got groupless instructions in a > key-instructions program? Worse is an understatem

[clang] [libc] [llvm] [DebugInfo][RemoveDIs] Suppress getNextNonDebugInfoInstruction (PR #144383)

2025-06-17 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams approved this pull request. This LGTM besides the one nit, but we should probably give @WenleiHe some time to respond before landing. https://github.com/llvm/llvm-project/pull/144383 ___ cfe-commits mailing list cfe-commits@

[clang] [libc] [llvm] [DebugInfo][RemoveDIs] Suppress getNextNonDebugInfoInstruction (PR #144383)

2025-06-17 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -29,7 +29,7 @@ to learn about the defaults for your platform and target. - ``LIBC_CONF_ENABLE_STRONG_STACK_PROTECTOR``: Enable -fstack-protector-strong to defend against stack smashing attack. - ``LIBC_CONF_KEEP_FRAME_POINTER``: Keep frame pointer in functions for b

[clang] [libc] [llvm] [DebugInfo][RemoveDIs] Suppress getNextNonDebugInfoInstruction (PR #144383)

2025-06-17 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/144383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang][NFC] Don't set -dwarf-use-key-instructions (PR #144115)

2025-06-13 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/144115 Once #144104 lands the flag is true by default (because each DISubprogram will track whether or not it's using key instructions). >From 748d6d5a7c53b21e6fe1170a8c0793e91196a507 Mon Sep 17 00:00:00 2001 From: Or

[clang] [llvm] [KeyInstr] Add DISubprogram::keyInstructions bit (PR #144107)

2025-06-13 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/144107 Patch 1/4 adding bitcode support. Store whether or not a function is using Key Instructions in its DISubprogram so that we don't need to rely on the -mllvm flag -dwarf-use-key-instructions to determine whether

[clang] [KeyInstr][Clang] Ctor memcpy-able members init source atom (PR #144346)

2025-06-16 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/144346 None >From 99c40d7c7eeaf8f1a58b7223491abe0e4ad9936a Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Mon, 16 Jun 2025 12:07:08 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Memcopyable members init - s

[clang] [KeyInstr][Clang] Atomic ops atoms (PR #141624)

2025-06-10 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: Ping https://github.com/llvm/llvm-project/pull/141624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For range stmt atoms (PR #134647)

2025-06-03 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134647 >From 5c7ac16d5099b192f25f17ec58dbe89cb43a7bca Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 19:46:01 +0100 Subject: [PATCH 1/4] [KeyInstr][Clang] For range stmt atoms This patch is

<    1   2   3   >