Re: [PATCH] D21667: [analyzer] Add rudimentary handling of AtomicExpr.

grandinj added a subscriber: grandinj. Comment at: test/Analysis/atomics.c:4 @@ +3,3 @@ +// Tests for c11 atomics. Many of these tests currently yield unknown +// because we don't folly model the atomics and instead imprecisely +// treat their arguments as escaping. --

Re: [PATCH] D21673: [libcxx] guard throw with exception enabling check

grandinj added a subscriber: grandinj. Comment at: include/experimental/optional:524 @@ -521,1 +523,3 @@ +assert(!"bad optional access"); +#endif return this->__val_; If this kind of code is going to show up in lots of places, then maybe wrap

Re: [PATCH] D21706: [libcxx] refactor for throw

grandinj added inline comments. Comment at: include/array:209 @@ -211,7 +208,3 @@ if (__n >= _Size) -#ifndef _LIBCPP_NO_EXCEPTIONS -throw out_of_range("array::at"); -#else -assert(!"array::at out_of_range"); -#endif +__libcpp_throw(out_of_range("array: