Re: [libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-05 Thread Nirav Davé via cfe-commits
https://bugs.llvm.org/show_bug.cgi?id=36241 On Mon, Feb 5, 2018 at 10:20 AM Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This broke the Chromium build, see > https://bugs.chromium.org/p/chromium/issues/detail?id=809050#c2 > > I see there were a lot of changes landed aroun

Re: [libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-05 Thread Nirav Davé via cfe-commits
It looks like we need to revert 324182 and 324194. I'll revert on I reverify on trunk. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-05 Thread Nirav Davé via cfe-commits
I reverted r324182, r324185, and r324192 in r324309. Things should be unstuck now. -Nirav On Mon, Feb 5, 2018 at 9:06 PM, Nirav Davé wrote: > It looks like we need to revert 324182 and 324194. I'll revert on I > reverify on trunk. > > ___ cfe-commits

Re: r276907 - Add flags to toggle preservation of assembly comments

2016-07-27 Thread Nirav Davé via cfe-commits
Looks like I missed the target triple. Should work now. Thanks, -Nirav On Wed, Jul 27, 2016 at 4:41 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Nirav, > > This test is failing on darwin: > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574 > >