nik added a comment.
Can you submit this for me? I don't have the permissions.
Repository:
rC Clang
https://reviews.llvm.org/D39903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
> I can merge this for you.
> Please add me as reviewer in any follow-up patches and we can turn them
> around more quickly.
That would be nice, thanks! I don't have any follow-up patches right now.
Repository:
rC Clang
https://reviews.llvm.org/D39903
__
nik created this revision.
Herald added a subscriber: cfe-commits.
nik added reviewers: yvvan, jbcoe.
...otherwise the build fails on Windows.
Repository:
rC Clang
https://reviews.llvm.org/D42099
Files:
include/clang-c/Index.h
Index: include/clang-c/Index.h
==
nik added a comment.
This was one was already submitted/merged by yvvan. Hmm, this review does not
reflect that yet?
Repository:
rC Clang
https://reviews.llvm.org/D42099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
nik added a comment.
Ping!
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Hmm, nothing changed. So how to get rid of this correctly. Is "Abandon
Revision" the right thing to do?
Repository:
rC Clang
https://reviews.llvm.org/D42099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
nik abandoned this revision.
nik added a comment.
Abandoning since the change is already in.
Repository:
rC Clang
https://reviews.llvm.org/D42099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
nik created this revision.
Herald added a subscriber: klimek.
A suspended translation unit uses significantly less memory but on the other
side does not support any other calls than clang_reparseTranslationUnit to
resume it or clang_disposeTranslationUnit to dispose it completely.
This helps IDEs
nik updated this revision to Diff 98461.
https://reviews.llvm.org/D33042
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
tools/c-index-test/c-index-test.c
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
Index: tools/libclang/libclang
nik added a comment.
Hmm, looks like libclang/libclangTests/LibclangReparseTest.ReparseWithModule is
flaky?
FAIL: Clang-Unit ::
libclang/libclangTests/LibclangReparseTest.ReparseWithModule (10699 of 10701)
- TEST 'Clang-Unit ::
libclang/libclangTests/LibclangReparseTest.ReparseWithModule' FAI
nik added a comment.
Ping :)
https://reviews.llvm.org/D33045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Ping :)
https://reviews.llvm.org/D33042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Ping?!
https://reviews.llvm.org/D15994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik marked an inline comment as done.
nik added a comment.
Adapted to the changes that happened in the meanwhile (CINDEX_VERSION_MINOR
increased, CleanTemporaryFiles got removed).
https://reviews.llvm.org/D33042
___
cfe-commits mailing list
cfe-com
nik updated this revision to Diff 99718.
nik edited the summary of this revision.
https://reviews.llvm.org/D33042
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
tools/c-index-test/c-index-test.c
tools/libclang/CIndex.cpp
tools/libclang/libclan
nik added a comment.
In https://reviews.llvm.org/D33045#759436, @ilya-biryukov wrote:
> Are there any other callers to getMainBufferWithPrecompiledPreamble?
Yes. Huch, right... don't know why I didn't adapted those. Done now.
> Maybe they cause LibclangReparseTest.ReparseWithModule to fail?
S
nik updated this revision to Diff 99740.
https://reviews.llvm.org/D33045
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
tools/libclang/CIndexCodeCompletion.cpp
Index: tools/libclang/CIndexCodeCompletion.cpp
=
201 - 217 of 217 matches
Mail list logo