[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

nik created this revision. Herald added subscribers: cfe-commits, jfb, xazax.hun. Herald added a project: clang. ...in case the clang tidy plugin is linked into the clang binary. Valgrind's memcheck reports: 8949== Invalid read ==8866== Invalid read of size 4

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

This revision was automatically updated to reflect the committed changes. Closed by commit rL363067: [libclang] Allow skipping warnings from all included files (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D63129: [clang-tidy] Fix invalid read on destruction

This revision was automatically updated to reflect the committed changes. Closed by commit rL363068: [clang-tidy] Fix invalid read on destruction (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D63193: [clangd] Fix typo in GUARDED_BY()

nik created this revision. nik added reviewers: ilya-biryukov, kadircet, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, javed.absar. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63193 Files: clang-tools-extra/clan

[PATCH] D63193: [clangd] Fix typo in GUARDED_BY()

This revision was automatically updated to reflect the committed changes. Closed by commit rL363139: [clangd] Fix typo in GUARDED_BY() (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6319

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik created this revision. nik added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, javed.absar, mgorny. Herald added a project: clang. TODO: Is the visitor the right approach? TODO: Add tests TODO: Test that only highlightings

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik added a comment. Any interest in having the *proposal* implemented? While there is a client implementation available in the theia ide (https://github.com/theia-ide/theia/pull/2332), I have only tested this against Qt Creator's client implementation (also work in progress). Repository: r

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nik added a comment. In D63331#1543441 , @hokein wrote: > Yeah, we definitely have interest in this feature, and our intern @jvikstrom > will work on this feature this summer. "this summer" depends on the location, so can you concretize this? :) > You

[PATCH] D53191: [clang] Introduce new completion context types

nik added a comment. Herald added a project: clang. I've bisected https://bugs.llvm.org/show_bug.cgi?id=42646 to this change. Reverting it fixes the issue. Please look into it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53191/new/ https://reviews.llvm.org/D5

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

nik added a comment. Herald added a subscriber: arphaman. Herald added a project: clang. I've bisected https://bugs.llvm.org/show_bug.cgi?id=42649 to this change. Reverting this change fixes the issue. Please look into it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D61842: [clangd] [WIP] [Not ready for review] Semantic highlighting

nik added a comment. Some general notes regarding the current state of this patch as I was testing it with a language client: - It still applies for current trunk, except for a *Tests* file. - Note that a VersionedTextDocumentIdentifier has to be used, e.g. a "version" must be included in the r

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

nik created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63763 Files: clang-tools-extra/docs/clang-tidy/Integrations.rst Index: clang-tools-extra/docs/clang-tidy/Integrations.rs

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

nik added a comment. In D63763#1557398 , @gribozavr wrote: > LGTM, assuming you know what's new in QtCreator. Sure, I'm involved in Qt Creator development :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG181f252d5373: [clang-tidy] Update documentation for Qt Creator integration. (authored by nik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63763/new/ http

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

nik added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:60 + // Called by ClangdServer when some \p Highlightings for \p File are ready. + virtual void onHighlightingsReady(PathRef File, + std::vector Highlightings) = 0; -

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

nik added a comment. In D63482#1567897 , @yvvan wrote: > I have a commit access but I don't understand how am I supposed to commit > (haven't done that for a while). There's no clang svn repo anymore. Do you > know what's the current state of repositorie

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

nik added a comment. In D63482#1567927 , @nik wrote: > In D63482#1567897 , @yvvan wrote: > > > I have a commit access but I don't understand how am I supposed to commit > > (haven't done that for a while). There's

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198997. nik marked an inline comment as done and an inline comment as not done. nik added a comment. Renamed to err_pp_including_mainfile_in_preamble. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik closed this revision. nik added a comment. Huch, I forgot to add "Differential Revision: " to the commit message, so I'll close this manually once I know how to add the svn revision number to this. https://llvm.org/docs/Phabricator.html states: > In the web UI, under “Leap Into Action” put

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik marked 4 inline comments as done. nik added inline comments. Herald added a subscriber: dexonsmith. Comment at: lib/Frontend/ASTUnit.cpp:682 + auto &M = D.getSourceManager(); + return M.isInMainFile(M.getExpansionLoc(D.getLocation())); +} ilya-biryukov wrot

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik updated this revision to Diff 199015. nik marked 2 inline comments as done. nik added a comment. Addressed inline comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 Files: include/clang-c/Index.h include/cl

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Sorry for the pointless ping, haven't seen the inline comments. They are addressed now. I've also increased CINDEX_VERSION_MINOR so clients can detect availability of this new flag. > It's been a while since I've looked at the ASTUnit code, though, would be > good if some

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping. alexfh? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

This revision was automatically updated to reflect the committed changes. Closed by commit rC361226: [Preamble] Reuse preamble even if an unsaved file does not exist (authored by nik, committed by ). Changed prior to commit: https://reviews.llvm.org/D41005?vs=198809&id=200415#toc Repository:

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

nik added a comment. > Are you sure you have compiled this patch? If I comment out the visit of the > InitExpr in CIndex.cpp again, then I get the same failure as you... Huch, I've indeed somehow missed to compile. Sorry for that. Works fine after compilation :) LGTM. Repository: rG LLVM G

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC361234: [libclang] visit c++14 lambda capture init expressions (authored by nik, committed by ). Changed prior to commit:

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Jan? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik marked 4 inline comments as done. nik added a comment. As I've commented on, this change is not finished. However, I've addressed the inline comments nevertheless. There is one TODO left for which I would like to have an opinion. Comment at: clang-tidy/ClangTidyDiagnostic

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 200736. nik marked an inline comment as done. nik added a comment. Addressed comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 Files: clang-tidy/ClangTidyDiagnosti

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Ping :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

nik requested changes to this revision. nik added inline comments. This revision now requires changes to proceed. Comment at: test/Index/print-type.cpp:202 // CHECK: CallExpr=Bar:17:3 [type=outer::inner::Bar] [typekind=Elaborated] [canonicaltype=outer::inner::Bar] [canonicaltyp

[PATCH] D38615: [libclang] Only mark CXCursors for explicit attributes with a type

nik added a comment. Ping https://reviews.llvm.org/D38615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

nik added a comment. Herald added a subscriber: llvm-commits. Ping Repository: rL LLVM https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

nik added a comment. Huch, seems already submitted. Ignore :> Repository: rL LLVM https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai, klimek. As an addition to CXTranslationUnit_SkipFunctionBodies, provide the new options CXTranslationUnit_LimitSkipFunctionBodiesToPreamble CXTranslationUnit_LimitSkipFunctionBodiesToNonTemplates. The first

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik added a comment. @ilya: Using SkipFunctionBodies_AllExceptTemplates for the preamble might be also useful for clangd. Repository: rC Clang https://reviews.llvm.org/D45815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Sorry for the delay, I think I'll come back to this one soon. Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. This one still applies and tests pass. Please review. https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik added a comment. In https://reviews.llvm.org/D45815#1073418, @ilya-biryukov wrote: > In https://reviews.llvm.org/D45815#1072094, @nik wrote: > > > @ilya: Using SkipFunctionBodies_AllExceptTemplates for the preamble might > > be also useful for clangd. > > > Unfortunately, that's also the big

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik marked 3 inline comments as done. nik added a comment. In https://reviews.llvm.org/D45815#1076434, @ilya-biryukov wrote: > In https://reviews.llvm.org/D45815#1073581, @nik wrote: > > > Hmm, that indicates that template function bodies are actually not that > > dominant, which I also haven't

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik updated this revision to Diff 143738. nik marked 2 inline comments as done. nik added a comment. Herald added a subscriber: eraman. Addressed inline comments. Repository: rC Clang https://reviews.llvm.org/D45815 Files: include/clang-c/Index.h include/clang/Frontend/ASTUnit.h includ

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik created this revision. Herald added a subscriber: cfe-commits. The parsing that is done for code completion is a special case that will discard any generated diagnostics, so avoid running plugins for this case in the first place to avoid performance penalties due to the plugins. Repository:

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 143894. nik added a comment. only clang-format fixes Repository: rC Clang https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp Index: lib/Frontend/FrontendAction.cpp === --

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. In https://reviews.llvm.org/D46050#1078112, @thakis wrote: > Seems reasonable; can you add a test for this (maybe somewhere in > clang/test/Frontend/plugin*)? Done. In https://reviews.llvm.org/D46050#1078155, @john.brawn wrote: > I know very little about how code complet

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 144084. nik added a comment. Added a test and clarified scenario in commit message. Repository: rC Clang https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp test/Frontend/plugins.c Index: test/Frontend/plugins.c =

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added inline comments. Comment at: test/Frontend/plugins.c:7 + +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-PLUGINS %s +// REQUIRES: plugins, ex

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik updated this revision to Diff 144303. nik added a comment. Reduction to skip-in-preamble-only functionality. Repository: rC Clang https://reviews.llvm.org/D45815 Files: include/clang-c/Index.h include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp test/Parser/skip-function-bod

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

nik added a comment. In https://reviews.llvm.org/D45815#1079327, @ilya-biryukov wrote: > > OK, I've rechecked this change. I don't see any obvious mistake :) > > I think I got to the bottom of it. We didn't expect a big win, because we > expect people to not put their non-template code into the

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added inline comments. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:104 - if (SkipFunctionBodies && (!FnD || Actions.canSkipFunctionBody(FnD)) && - trySkippingFunctionBody()) { + if (SkipFunctionBodies != SkipFunctionBodiesKind::None && + (!FnD || Actions.can

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added a comment. OK, to skip all function bodies in the preamble except for template functions and functions within a template class, I've amended the previous diff with: - a/lib/Parse/ParseCXXInlineMethods.cpp +++ b/lib/Parse/ParseCXXInlineMethods.cpp @@ -102,9 +102,14 @@ NamedDecl *Parse

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added a comment. Trying to format the diff in the previous comment: --- a/lib/Parse/ParseCXXInlineMethods.cpp +++ b/lib/Parse/ParseCXXInlineMethods.cpp @@ -102,9 +102,14 @@ NamedDecl *Parser::ParseCXXInlineMethodDef(AccessSpecifier AS, } if (SkipFunctionBodies != SkipFunc

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added a comment. Do I miss something? I've uploaded a new diff/version and state is still "(X) Requested Changes to Prior Diff". Waiting for review. Repository: rC Clang https://reviews.llvm.org/D45815 ___ cfe-commits mailing list cfe-commi

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik marked an inline comment as done. nik added inline comments. Comment at: test/Frontend/plugins.c:8 +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-P

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 145430. nik added a comment. Moved the test to "Index". https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp test/Index/complete-and-plugins.c Index: test/Index/complete-and-plugins.c =

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping. https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. OK, the issue with the test dependencies I've had is resolved by https://reviews.llvm.org/D46514 https://reviews.llvm.org/D46050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik updated this revision to Diff 145648. nik marked 3 inline comments as done. nik edited the summary of this revision. nik added a comment. Addressed comments. Repository: rC Clang https://reviews.llvm.org/D45815 Files: include/clang-c/Index.h include/clang/Frontend/ASTUnit.h lib/Fro

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:370 + IntrusiveRefCntPtr VFS, + SkipFunctionBodiesScope SkipFunctionBodiesScp = + SkipFunctionBodiesScope::None, ilya-biryukov wrote: > NIT: Maybe keep the name `SkipFuncti

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

nik added a comment. @jkorous: Please submit. I can't as my svn account is still not ported to github... :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279 ___

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. Ping, please review or add more appropriate reviewers. https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik created this revision. The DeclRefExpr of CXXOperatorCallExpr refering to the custom operator is visited before the arguments to the operator call. For the Call and Subscript operator the range of this DeclRefExpr includes the whole call expression, so that all tokens in that range were mapped

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik updated this revision to Diff 124341. nik added a comment. Addressed coding style issues. https://reviews.llvm.org/D40481 Files: test/Index/annotate-operator-call-expr.cpp tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp ===

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik marked 4 inline comments as done. nik added inline comments. Comment at: tools/libclang/CIndex.cpp:6888 + const SourceLocation fixedEnd = + RefNameRange.getEnd().getLocWithOffset(-1); + RefNameRange = SourceRange(RefNameRange.getBegin(), fixedEnd);

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

nik added a comment. Could you elaborate on "the client will be able to use it to generate a reproducer for the crash"? Having the json file, what would I need to do in order to reproduce the crash? Repository: rC Clang https://reviews.llvm.org/D40527

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik added a comment. Ping https://reviews.llvm.org/D40072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. Ping III - is there anything I can do to get this reviewed faster? 3 weeks passed. https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik updated this revision to Diff 124550. nik marked an inline comment as done. nik added a comment. Rebaed and clarified the documentation only. Please submit as I don't have the permissions. https://reviews.llvm.org/D40072 Files: include/clang-c/Index.h test/Index/print-type-size.cpp t

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

nik created this revision. For the function declaration auto foo5(Foo) -> Foo; the parameter tokens were mapped to cursors representing the FunctionDecl: Keyword: "auto" [1:1 - 1:5] FunctionDecl=test5:1:6 Identifier: "test5" [1:6 - 1:11] FunctionDecl=test5:1:6 Punctuation: "(" [1:11 - 1:12]

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added reviewers: ilya-biryukov, cameron314. nik added a comment. Anyone? https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 125129. nik added a comment. Rebased only. Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libclang/libclang.ex

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

nik added a comment. In https://reviews.llvm.org/D20124#943592, @cameron314 wrote: > Here's the final patch that fixes `clang_getSkippedRegions` with regions in > the preamble (as well as serializing the skipped regions in the PCH file). Works fine for me, thanks! Test from the bug report is f

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

nik added a comment. Ping https://reviews.llvm.org/D40561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. In https://reviews.llvm.org/D39903#944182, @cameron314 wrote: > Locally we've done something similar (adding a > `clang_getCursorPrettyPrintedDeclaration` function, though without exposing > the `PrintingPolicy`) and overhauled `DeclPrinter` to produce proper pretty > name

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik created this revision. When a preamble is created an unsaved file not existing on disk is already part of PrecompiledPreamble::FilesInPreamble. However, when checking whether the preamble can be re-used, a failed stat of such an unsaved file invalidated the preamble, which led to pointless and

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

nik added a comment. Thanks for the review. Please submit as I don't have the permissions for this. https://reviews.llvm.org/D40561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik marked 2 inline comments as done. nik added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:109 + std::chrono::steady_clock::time_point getCreationTimePoint() const { +return CreationTimePoint; ilya-biryukov wrote: > Having th

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 126353. nik marked 2 inline comments as done. nik added a comment. Addressed Ilya's comments. Repository: rC Clang https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp lib/Frontend/PrecompiledPreamble.cpp u

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:196 + /// \brief Counter indicating how often the preamble was build in total. + unsigned PreambleCounter; + Any better name for this one? Otherwise I would suggest renaming PreambleRebuil

[PATCH] D35200: Don't use mmap on Windows

nik added a reviewer: ilya-biryukov. nik added a comment. Ping. I guess locking the file less helps also clangd?! https://reviews.llvm.org/D35200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

nik created this revision. Looks like this one was forgotten for clang_parseTranslationUnit*, as LIBCLANG_NOTHREADS is checked for/in: clang_saveTranslationUnit() clang_reparseTranslationUnit() clang_codeCompleteAt() clang_indexTranslationUnit() clang_indexSourceFile() https://reviews

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

nik added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6342 +&& !isa(FD)) { + Args = Args.slice(1); +} bkramer wrote: > assert that FD is a static method. Just stumbled here because I was looking into https://bugs.llvm.

[PATCH] D36872: Fixed a crash on replaying Preamble's PP conditional stack.

nik added a reviewer: hans. nik added a comment. I see this in trunk/master submitted, but not in the release_50 branch. Could this be cherry-picked to 5.0? Repository: rL LLVM https://reviews.llvm.org/D36872 ___ cfe-commits mailing list cfe-com

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

nik added a reviewer: erikjv. nik added a comment. Please submit as I do not have the necessary permissions. https://reviews.llvm.org/D36821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added reviewers: ddunbar, krememek. nik added a comment. ...added some more reviewers that I've found with git blame. Ping to the new ones :) https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added a comment. Ping... https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added a comment. I don't get a review and I also don't know who should I add further to this change. What now? https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

nik added a comment. Here are my observations: - Your test case works fine for me even without having this change applied/build. Looks like this is already fixed in current trunk. Please confirm/test. - Can you come up with another test case that fixes something that is not yet addressed in tr

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. Ping, please review :) https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik added a comment. Ping https://reviews.llvm.org/D40072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40013: [DeclPrinter] Allow printing fully qualified name of function declaration

nik added a comment. Please submit/land this for me. I don't have the necessary permissions. https://reviews.llvm.org/D40013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33045: [libclang] Avoid more stats than necessary for reparse.

nik abandoned this revision. nik added a comment. I do not have time to work on this right now, Abandoning. https://reviews.llvm.org/D33045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. > It might be worth adding some very simple get/set tests to ensure that > properties are set as intended. clang_PrintingPolicy_setProperty is already called in c-index-test.c and covered with test/Index/print-display-names.cpp. Do you have another kind of test in mind? I

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129591. nik added a comment. Addressed comments. Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libclang/libcl

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik marked an inline comment as done. nik added inline comments. Comment at: tools/libclang/CIndex.cpp:4782 + + return 0; +} jbcoe wrote: > Might be worth asserting here. Good idea. I've done the same for the setter. Comment at: unittests/libc

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129600. nik marked an inline comment as done. nik added a comment. Added assert() for getter/setter. Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index-test.

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129635. nik added a comment. What about this? :) Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libclang/libcl

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129805. nik added a comment. Addressed inline comment. Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libclang

<    1   2   3   >