[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. Ping https://reviews.llvm.org/D46050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik updated this revision to Diff 146999. nik added a comment. Addressed inline nit. Repository: rC Clang https://reviews.llvm.org/D46050 Files: lib/Frontend/FrontendAction.cpp test/Index/complete-and-plugins.c Index: test/Index/complete-and-plugins.c ==

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

nik added a comment. If this is fine now, please submit as I don't have the permissions to do so. Repository: rC Clang https://reviews.llvm.org/D46050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

nik requested changes to this revision. nik added a comment. This revision now requires changes to proceed. Generates build errors here: In file included from /d2/llvm/qtc/source/tools/clang/tools/c-index-test/c-index-test.c:4:0: /d2/llvm/qtc/source/tools/clang/include/clang-c/Index.h:1332:62: w

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added a comment. Ping 4 https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

nik added a comment. This fixes the reported bug for me :) There is another related issue that is not addressed by this change. I've reported it as [preamble] Skipped ranges vanish after reparse (#ifdef with #include) https://bugs.llvm.org/show_bug.cgi?id=34971 https://reviews.llvm.org/D385

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik updated this revision to Diff 119823. nik added a comment. Rebased and took over better wording/description from Ilya. https://reviews.llvm.org/D37554 Files: tools/libclang/CIndex.cpp tools/libclang/CIndexCodeCompletion.cpp tools/libclang/Indexing.cpp Index: tools/libclang/Indexing.

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added a comment. Hmm, apparently "arc diff --update https://reviews.llvm.org/D37554"; did not take the new commit message into account. Changed it manually with the web interface. Ilya, I hope it's OK if I take your description :) > That said, I am not familiar with the code you're changin

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping... https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33042: [libclang] Allow to suspend a translation unit.

nik added a comment. I'm new to this review tool. I've addressed the comments and rebased. Does this needs a re-review? Note that this is my first change and I probably do not have any permissions to submit this change. https://reviews.llvm.org/D33042 ___

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik added a comment. Ping... "Please submit as I don't have the permissions." https://reviews.llvm.org/D40072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

nik added a comment. Ping..."Please submit as I don't have the permissions for this." https://reviews.llvm.org/D40561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping. https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:196 + /// \brief Counter indicating how often the preamble was build in total. + unsigned PreambleCounter; + ilya-biryukov wrote: > nik wrote: > > Any better name for this one? Otherwise I

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

nik added a comment. Hmm, could libclang profit from something like this, too? (or does it already?) Repository: rL LLVM https://reviews.llvm.org/D41495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:461 std::map::iterator Overridden = OverriddenFiles.find(Status.getUniqueID()); nik wrote: > ilya-biryukov wrote: > > Will anything fail if we remove the map from `UniqueI

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 128416. nik added a comment. Rebased and renamed the counter variable only. I do not feel comfortable changing the "std::map OverriddenFiles". I can do this in a follow-up change if you want. @Ivan: Coul you please run the tests with this change on Windows?! If

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. New year, new hope - ping :) https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik updated this revision to Diff 128491. nik added a comment. Had to rebase. Repository: rC Clang https://reviews.llvm.org/D40072 Files: include/clang-c/Index.h test/Index/print-type-size.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libclang/libclang.expor

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. Ping... Repository: rC Clang https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping... https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129258. nik added a comment. Rebased only, please review. Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libcl

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129426. nik added a comment. > Could one use an enum to get/set different properties of the policy? > > I've seen other C-API's (for Linear and Quadratic programming) follow a > similar approach quite extensibly. > > It would significantly reduce the size of th

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik updated this revision to Diff 129427. nik added a comment. Used macros as in a previous version to make it less verbose and error prone. Repository: rC Clang https://reviews.llvm.org/D39903 Files: include/clang-c/Index.h test/Index/print-display-names.cpp tools/c-index-test/c-index

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

nik added a comment. I've stumbled about this bug too and was looking into it and then I saw the mail about this change being submitted :) I've ended up with a slightly different change (https://dpaste.de/PSpM/raw , instead of FD->getReturnType()->getContainedDeducedType() I have FD->getReturn

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

nik added a comment. In https://reviews.llvm.org/D44480#1117147, @cpplearner wrote: > Does `getAs()` work correctly with function returning `auto&`? No. For class Foo {} foo; auto& return_auto_ref() { return foo; } auto r6 = return_auto_ref(); the "getAs()" version will skip the functi

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

nik requested changes to this revision. nik added inline comments. This revision now requires changes to proceed. Comment at: include/clang-c/Index.h:5264 + * FixIts that *must* be applied before inserting the text for the + * corresponding completion item. + * y

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

nik added a comment. - Sometimes you refer to "fixits", sometimes "fix-its" and some times "FixIts". Unify to what is already there. - The term "completion items" is new so far. Use "completions" for consistency. https://reviews.llvm.org/D46862 ___

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik created this revision. Herald added a subscriber: cfe-commits. Depending on the included files and the used warning flags, e.g. - Weverything, a huge number of warnings can be reported for included files. As processing that many diagnostics comes with a performance impact and not all clients a

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik updated this revision to Diff 151116. nik added a comment. Addressed comments. Repository: rC Clang https://reviews.llvm.org/D48116 Files: include/clang-c/Index.h include/clang/Basic/Diagnostic.h lib/Basic/DiagnosticIDs.cpp test/Index/ignore-warnings-from-headers.cpp test/Index

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

nik added inline comments. Comment at: include/clang-c/Index.h:5302 +CXCodeCompleteResults *results, unsigned completion_index, +unsigned fixit_index, CXSourceRange *replacement_range); + Please document the parameters. It's more important here than for a

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik created this revision. Herald added subscribers: cfe-commits, arphaman. If a header file was processed for the second time, we could end up with a wrong conditional stack and skipped ranges: In the particular example, if the header guard is evaluated the second time and it is decided to skip

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. In https://reviews.llvm.org/D53866#1281978, @ilya-biryukov wrote: > Why does resetting the conditional stack is the right thing to do here? Because this case can be detected and handled without loosing the benefits of the preamble. > Failing to build the preamble in that

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. I've only the minimal example at hand right know - I'm waiting for feedback about the real world case. Repository: rC Clang https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D54077: [clangd] Implemented DraftFileSystem

nik added a comment. In https://reviews.llvm.org/D54077#1288404, @ioeric wrote: > I would be very happy if `A.cc` can see the unsaved `A.h` when I am editing > `A.cc`. We have that in Qt Creator (with libclang) and that's quite handy as it can save you some build cycles. > Not sure if I want

[PATCH] D54077: [clangd] Implemented DraftFileSystem

nik added a comment. In https://reviews.llvm.org/D54077#1288413, @nik wrote: > If it helps (and the LSP allows it): In case A.h is edited, we flag it dirty. > If the user makes some file depending on it visible (or the current file), we > trigger a reparse for that. Not sure whether the LSP has

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Coming back to this one, I see a failing test: PCHPreambleTest.ReparseWithOverriddenFileDoesNotInvalidatePreamble Note that PCHPreambleTest.ReparseWithOverriddenFileDoesNotInvalidatePreamble references the header paths in different ways ("//./header1.h" vs "//./foo/../head

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. In https://reviews.llvm.org/D41005#1295632, @ilya-biryukov wrote: > > Before this change, this was not a problem because OverriddenFiles were > > keyed on Status.getUniqueID(). Starting with this change, the key is the > > file path. > > I suggest keeping two maps for overr

[PATCH] D54523: [Preamble] Reuse preamble even if an unsaved file does not exist

nik created this revision. Herald added a subscriber: cfe-commits. When a preamble is created an unsaved file not existing on disk is already part of PrecompiledPreamble::FilesInPreamble. However, when checking whether the preamble can be re-used, a failed stat of such an unsaved file invalidated

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 174022. nik added a comment. Addressed comments. Repository: rC Clang https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp lib/Frontend/PrecompiledPreamble.cpp unittests/Frontend/PCHPreambleTest.cpp Index:

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. I still don't have feedback for a real world case except "unintentional #include". Unfortunately, in real world cases the cyclic include might be not obvious at all. @ilya: As far as I understand you prefer to make the preamble generation rather fail as long as we don't ha

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik updated this revision to Diff 175210. nik added a comment. > Maybe produce a **fatal** error in the preprocessor? That seems to be the > simplest option: the preprocessor is aware it's building the preamble and > there's definitely some logic to produce fatal errors in other cases (include

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D55139: [clangd] Avoid memory-mapping files on Windows

nik added a comment. Please fix this also for libclang clients. I think it's safe to assume that files might be edited once CXTranslationUnit_PrecompiledPreamble or CXTranslationUnit_CacheCompletionResults is set as flag - that's what clang_defaultEditingTranslationUnitOptions() returns. Repo

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik updated this revision to Diff 176826. nik added a comment. Addressed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 Files: include/clang/Lex/Preprocessor.h include/clang/Serialization/ASTWriter.h lib/

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik marked 2 inline comments as done. nik added inline comments. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false; ilya-biryukov wrote: > There's a mechanism to handle preamble with errors,

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik marked 2 inline comments as done and an inline comment as not done. nik added inline comments. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false; ilya-biryukov wrote: > nik wrote: > > il

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik updated this revision to Diff 176941. nik added a comment. Added a dedicated diagnostic. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/Preproces

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 176962. nik marked an inline comment as done. nik added a comment. Addressed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h lib/Fron

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik marked 4 inline comments as done. nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:581 + unsigned getPreambleCounter() const { return PreambleCounter; } + ilya-biryukov wrote: > NIT: `getPreambleCounterForTests()`? This is clearly an

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Herald added a subscriber: arphaman. In D48116#1144732 , @ilya-biryukov wrote: > Have you considered doing the same filtering in ASTUnit's > `StoredDiagnosticConsumer`? It should not be more difficult and allows to > avoid changing

[PATCH] D55415: Revert removal of tidy plugin support from libclang

nik added a comment. +1 as this seems to fix the regression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ https://reviews.llvm.org/D55415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. In D48116#1144732 , @ilya-biryukov wrote: > Have you considered doing the same filtering in ASTUnit's > `StoredDiagnosticConsumer`? It should not be more difficult and allows to > avoid changing the clang's diagnostic interfaces. Th

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Ilya? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D61486: [Basic] Introduce active dummy DiagnosticBuilder

nik created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...which does not emit anything. This dummy is useful for filtering. Code expecting a DiagnosticBuilder object can get a dummy and report further details, without knowing/checking whether this is nee

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The clang-tidy standalone tool implements the NOLINT filtering in ClangTidyDiagnosticConsumer::HandleDiagnostic. For the plugin case no ClangTidyDiagnosticConsumer is set up as it would have

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. This one depends on https://reviews.llvm.org/D61486 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik added a comment. Did you forget to push the change to c-index-test.c? Otherwise fine with me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Thanks for the fast comments! In D61487#1489308 , @alexfh wrote: > I suspect that we're missing proper test coverage here. True, ideally all the test scripts would also trigger the plugin case code path. I've started with a modifie

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik added a comment. ...and increased CINDEX_VERSION_MINOR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik updated this revision to Diff 198403. nik added a comment. Herald added a project: clang. Adapted c-index-test.c and added function to libclang.exports. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 Files: include

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik accepted this revision. nik added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 198637. nik added a comment. The plugin makes use of ClangTidyDiagnosticConsumer and forwards diagnostics to the external diagnostic engine. @alexfh: What do you think? If that looks roughly OK for you, I'll finish it. Repository: rCTE Clang Tools Extra CHAN

[PATCH] D60672: [libclang] visit c++14 lambda capture init expressions

nik added a comment. Tests do not pass on current trunk: /d2/llvm/trunk/builds/DebugShared % bin/llvm-lit -a /d2/llvm/trunk/source/tools/clang/test/Index/cxx14-lambdas.cpp llvm-lit: /d2/llvm/trunk/source/utils/lit/lit/llvm/config.py:341: note: using clang: /d2/llvm/trunk/builds/DebugShared/

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198654. nik edited the summary of this revision. nik added a comment. Rebased for current trunk. If I miss something obvious, please tell me. Otherwise I'm waiting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https:

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 198656. nik added a comment. Herald added a subscriber: dexonsmith. Minor diff update fixing indentation and removing not needed include. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D4

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +if

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik updated this revision to Diff 198799. nik added a comment. Moved the MainFile / MainContentCache->OrigEntry check a bit further up, for consistency with the same test further down in SourceManager::translateFile(). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 198809. nik added a comment. Addressed inline comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp lib/Frontend

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1594 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +if

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 186429. nik marked an inline comment as done. nik added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Addressed comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.l

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Meh, something changed in the meanwhile. ReparseReusesPreambleAfterUnsavedFileWasRemovedFromDisk fails now. Looking into it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 186436. nik added a comment. > Meh, something changed in the meanwhile. > ReparseReusesPreambleAfterUnsavedFileWasRemovedFromDisk fails now. Looking > into it. No, it's just me ;) I've referenced the header file wrong. Repository: rC Clang CHANGES SINCE LA

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik marked 2 inline comments as done. nik added inline comments. Herald added a subscriber: jdoerfert. Herald added a project: clang. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false; ilya-

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik updated this revision to Diff 186813. nik added a comment. Addressed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Basic/SourceManager.cpp lib/Lex

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik marked an inline comment as done. nik added inline comments. Comment at: lib/Basic/SourceManager.cpp:1592 SourceFileName = llvm::sys::path::filename(SourceFile->getName()); -if (*SourceFileName == llvm::sys::path::filename(MainFile->getName())) { +if

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Herald added a project: clang. >> For filtering in StoredDiagnosticConsumer one needs to pass the new bool >> everywhere along where "bool CaptureDiagnostics" is already passed on (to >> end up in the StoredDiagnosticConsumer constructor) . Also, >> ASTUnit::CaptureDiagnost

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik updated this revision to Diff 187318. nik added a comment. Herald added a subscriber: jdoerfert. OK, filtering happens now in FilterAndStoreDiagnosticConsumer, the former StoredDiagnosticConsumer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https

[PATCH] D58501: [libclang] Fix CXTranslationUnit_KeepGoing

nik created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Since commit 56f5487e4387a69708f70724d00e9e076153 [modules] Round-trip -Werror flag through explicit module build. the behavior of CXTranslationUnit_KeepGoing changed: Unresolved #i

[PATCH] D58501: [libclang] Fix CXTranslationUnit_KeepGoing

nik updated this revision to Diff 187765. nik added a comment. Fixed minor typo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58501/new/ https://reviews.llvm.org/D58501 Files: include/clang/Basic/Diagnostic.h lib/Basic/DiagnosticIDs.cpp test/Index/Inputs/

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

nik added inline comments. Comment at: include/clang-c/Index.h:2840 +/** + * \brief Describe the "TLS kind" of the declaration referred to by a cursor. + */ I was wondering what "TLS" is and had to look it up. If not adapting the function and enum name, then may

[PATCH] D37700: Fix recording preamble's conditional stack in skipped PP branches.

nik added a comment. Fixes the reported issue, thanks! I still run into another case that is not yet properly covered. The reported issue was extracted from the following case. If you prefer, I'll create a separate report for the remaining issues. The follow code outlines the problems in the c

[PATCH] D37700: Fix recording preamble's conditional stack in skipped PP branches.

nik added a comment. In https://reviews.llvm.org/D37700#867646, @ilya-biryukov wrote: > @nik, could you file a separate bug so that we won't forget about it? Done, it's https://bugs.llvm.org/show_bug.cgi?id=34570 . Repository: rL LLVM https://reviews.llvm.org/D37700

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added a comment. Ping https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added a comment. Ping 2 https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48116/new/ https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 203306. nik marked 2 inline comments as done. nik added a comment. Addressed inline comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 Files: clang-tidy/ClangTidyDi

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik marked 4 inline comments as done. nik added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:207 CheckNamesByDiagnosticID.try_emplace(ID, CheckName); + CustomDiagIdParamsByDiagnosticID.try_emplace( + ID, CustomDiagIdParams(Level, FormatString))

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

This revision was automatically updated to reflect the committed changes. Closed by commit rL362702: [clang-tidy] Make the plugin honor NOLINT (authored by nik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D61486: [Basic] Introduce active dummy DiagnosticBuilder

nik added a comment. In D61486#1532272 , @gribozavr wrote: > Is this patch still needed? Nope, abandoning it now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61486/new/ https://reviews.llvm.org/D61486 _

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik added a comment. Thanks Dmitri! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

  1   2   3   >