[PATCH] D24193: Allow variables with asm labels in naked functions

2016-09-02 Thread Nikola Smiljanić via cfe-commits
nikola created this revision. nikola added reviewers: hans, rnk, compnerd. nikola added a subscriber: cfe-commits. Herald added a subscriber: aemerson. I think the current mode is too restrictive, it will emit error for any statement inside a naked function. Code I'm trying to compile for ARM dec

[PATCH] D24395: Align declarations that are preceded by different number of commas.

2016-09-09 Thread Nikola Smiljanić via cfe-commits
nikola created this revision. nikola added a reviewer: djasper. nikola added a subscriber: cfe-commits. Herald added a subscriber: klimek. Having a template with more than one template argument breaks alignment of consecutive declarations. Something like this won't be correctly aligned: int x; s

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

2016-09-11 Thread Nikola Smiljanić via cfe-commits
nikola added a subscriber: nikola. Comment at: lib/Format/WhitespaceManager.cpp:356 @@ -273,3 +355,3 @@ // If there is more than one matching token per line, or if the number of // preceding commas, or the scope depth, do not match anymore, end the // sequence.

Re: [PATCH] D24395: Align declarations that are preceded by different number of commas.

2016-09-11 Thread Nikola Smiljanić via cfe-commits
nikola abandoned this revision. nikola added a comment. Thanks for letting me know, that patch looks more complete so I'll abandon this. I hope it lands soon! https://reviews.llvm.org/D24395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: [PATCH] D24193: Allow variables with asm labels in naked functions

2016-09-12 Thread Nikola Smiljanić via cfe-commits
nikola updated this revision to Diff 70985. nikola added a comment. This should address Hans' comments, as for the code get I have no idea. I was hoping someone more knowledgeable would tell me if this made sense or not? https://reviews.llvm.org/D24193 Files: lib/Sema/SemaDecl.cpp test/Sem

Re: [PATCH] D24193: Allow variables with asm labels in naked functions

2016-09-13 Thread Nikola Smiljanić via cfe-commits
nikola closed this revision. nikola added a comment. r281298 https://reviews.llvm.org/D24193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15588: PR25356 - False positive with -Wreturn-stack-address

2016-02-15 Thread Nikola Smiljanić via cfe-commits
nikola added a comment. Ping. http://reviews.llvm.org/D15588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15509: Suggest missing 'template' for dependent member templates

2016-02-15 Thread Nikola Smiljanić via cfe-commits
nikola added a comment. Ping. http://reviews.llvm.org/D15509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15509: Suggest missing 'template' for dependent member templates

2016-04-15 Thread Nikola Smiljanić via cfe-commits
nikola added a comment. Would anyone be kind enough to review this? http://reviews.llvm.org/D15509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15509: Suggest missing 'template' for dependent member templates

2015-12-14 Thread Nikola Smiljanić via cfe-commits
nikola created this revision. nikola added a reviewer: rsmith. nikola added a subscriber: cfe-commits. Current diagnostic says "expected expression" or "reference to non-static member function must be called". This should fix PR13566 and PR18995 http://reviews.llvm.org/D15509 Files: lib/Parse