nkakuev created this revision.
nkakuev added reviewers: alexfh, mgehre.
nkakuev added a subscriber: cfe-commits.
When clang-tidy suppresses a warning, ignored by NOLINT, it doesn't suppress
related notes. This leads to an assertion/crash, as described in this bug:
https://llvm.org/bugs/show_bug.
nkakuev added a reviewer: malcolm.parsons.
nkakuev updated this revision to Diff 76718.
nkakuev added a comment.
Fixed review comments: replaced a static variable with a class member.
https://reviews.llvm.org/D26218
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagn
nkakuev updated this revision to Diff 76769.
nkakuev marked an inline comment as done.
nkakuev added a comment.
Fix a typo.
https://reviews.llvm.org/D26218
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/nolint/trigger_warn
nkakuev added a comment.
@malcolm.parsons, can you please commit this patch? I don't have commit rights.
https://reviews.llvm.org/D26218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
nkakuev added a comment.
@alexfh I'll fix it in a separate review.
https://reviews.llvm.org/D26218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nkakuev created this revision.
nkakuev added reviewers: malcolm.parsons, alexfh.
nkakuev added a subscriber: cfe-commits.
Currently clang-tidy doesn't provide a practical way to suppress diagnostics
from headers you don't have control over. If using a function defined in such
header causes a fal
nkakuev added a comment.
In https://reviews.llvm.org/D26418#590170, @alexfh wrote:
> I also don't understand the use case for turning off only some checks for
> third-party headers. Either you care about third-party stuff or not, why only
> switch off certain checks?
The use case is ignoring
nkakuev added a comment.
In https://reviews.llvm.org/D26418#590168, @alexfh wrote:
> What's the biggest complexity with -header-filter? Lack of way to specify
> ? Will it help to make -header-filter a
> GlobList?
See my previous comment. Header filter isn't to help when a (false positive)
wa
nkakuev added a comment.
In https://reviews.llvm.org/D26418#590417, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D26418#590383, @nkakuev wrote:
>
> > The warning is caused by a third-party code, but header filter won't help
> > you to suppress it since it now relates to your sources.
>
nkakuev added a comment.
In https://reviews.llvm.org/D26418#590417, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D26418#590383, @nkakuev wrote:
>
> > The warning is caused by a third-party code, but header filter won't help
> > you to suppress it since it now relates to your sources.
>
nkakuev created this revision.
nkakuev added a reviewer: alexfh.
nkakuev added a subscriber: cfe-commits.
Test cases I've added in review https://reviews.llvm.org/D26218 were too
brittle and weren't working properly.
This patch fixes this.
https://reviews.llvm.org/D26466
Files:
test/clang-ti
nkakuev marked an inline comment as done.
nkakuev added inline comments.
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a
garbage value
+// CHECK-NOT: :[[@LINE-4]]:{{.*}} note
alexfh wrote
nkakuev added a comment.
@alexfh, you're welcome!
Can you please commit this patch?
https://reviews.llvm.org/D26466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nkakuev added a comment.
Ping.
Ignoring note locations is a coarse-grained solution that will suppress both
false and //true// positives. Suppress-checks-filter is a finer-grained
instrument that can be targetted on particular false positives precisely.
My sympathies are with suppress-checks-f
14 matches
Mail list logo
