[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. Ping. Just a polite ping to keep it alive. I hope that's all right. Not urgent at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 ___

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. Ping. I made the change suggested by @erichkeane . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos marked an inline comment as done. nigelp-xmos added inline comments. Comment at: clang/test/CodeGen/xcore-unused-inline.c:4 + +inline void dead_function(void) {} erichkeane wrote: > What is this test validating? It should likely have a check line of s

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

nigelp-xmos updated this revision to Diff 273100. nigelp-xmos retitled this revision from "[XCore] fix crash on unused inline in EmitTargetMetadata" to "Fix crash on XCore on unused inline in EmitTargetMetadata". nigelp-xmos added a comment. Added explanatory comment and CHECK lines to test case

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. I do not have commit access, so if this is approved, please could it be committed against author "Nigel Perks" nig...@xmos.com ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. This patches fixes two Clang tests which are failing for XCore target on 2020-04-27 with "unexpected null value" assert failures: CodeGen/2003-12-14-ExternInlineSupport.c CoverageMapping/unused_names.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added reviewers: jasonliu, erichkeane, RKSimon, jhibbits, ctetreau, george.burgess.iv, efriedma. nigelp-xmos added a comment. Adding code reviewer suggestions from git history. I would be grateful for review and/or reviewer suggestions. Many thanks. Repository: rG LLVM Github Mon

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. Thanks for the comment, I will look into that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 ___ cfe-commits mailing list cfe-com

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos updated this revision to Diff 264827. nigelp-xmos added a comment. As suggested by FIXME comment in code, and review comment, moved the EmitTargetMetadata loop into XCore target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 Files

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos added a comment. Many thanks for review and approval. Please could it be committed as I do not have commit access? (I will request.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nigelp-xmos requested review of this revision. Function Parser::ParseAvailabilityAttribute checks that the message string of an availability attribute is not a wide string literal. Test case c

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos added a comment. Alternatively, if all 1-byte-character strings are acceptable, should I remove the check that the first token is a string literal, and omit the failing test case on XCore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos updated this revision to Diff 307636. nigelp-xmos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Parser/att

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos updated this revision to Diff 307638. nigelp-xmos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Parser/att

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos created this revision. nigelp-xmos added a reviewer: rsmith. nigelp-xmos added a project: clang. EmitTargetMetadata passes to emitTargetMD a null pointer as returned from GetGlobalValue for an unused inline function which has been removed from the module at that point. Richard Smith

[PATCH] D144195: [XCore] Adapt Clang tests to opaque pointers.

nigelp-xmos created this revision. Herald added a project: All. nigelp-xmos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144195 Files: clang/test/CodeGen/xcore-abi.c c

[PATCH] D144195: [XCore] Adapt Clang tests to opaque pointers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0871337d97f7: [XCore] Adapt Clang tests to opaque pointers. (authored by nigelp-xmos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT