[PATCH] D60934: [clang] adding explicit(bool) from c++2a

2019-04-30 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2579 +assert( +!ES.getExpr() || +CXXConstructorDeclBits.HasTrailingExplicitSpecifier && Your or needs parens or the disambiguation is wrong. Com

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

2019-05-01 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2579 +assert( +!ES.getExpr() || +CXXConstructorDeclBits.HasTrailingExplicitSpecifier && Tyker wrote: > Rakete wrote: > > Your or needs parens or the disambigua

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

2019-05-03 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. Can you add tests for the bugs you fixed? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61522/new/ https://reviews.llvm.org/D61522 ___ cfe-commits mailing list cfe-co

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-05-04 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 198139. Rakete added a comment. Don't leak memory and friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/include/clang/Basic/Diagnos

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-04 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 198142. Rakete added a comment. friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36357/new/ https://reviews.llvm.org/D36357 Files: clang/include/clang/Basic/DiagnosticParseKinds.td cla

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-05 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. @rsmith One last question: The fixit diagnostic seems to be inconsistent with the rest? main.cpp:2:3: error: '[]' after delete interpreted as 'delete[]' delete[] { return new int; } ^~~~ ( ) Shouldn't the `^~~` be start

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-05 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. Is this also okay? main.cpp:2:9: warning: lambda expressions are incompatible with C++98 [-Wc++98-compat] delete[] { return new int; } ^ main.cpp:2:3: error: '[]' after delete interpreted as 'delete[]'; add parentheses to treat this as a lambda-expr

[PATCH] D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture

2019-05-05 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. You might want to consider getting commit access . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61556/new/ https://reviews.llvm.org/D61556 ___

[PATCH] D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture

2019-05-05 Thread Nicolas Lesser via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC359980: [clang] fixing -ast-print for variadic parameter pack in lambda capture (authored by Rakete, committed by ). Changed prior to commit: https://reviews.llvm.org/D61556?vs=198155&id=198172#toc

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

2019-05-06 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. @Tyker This broke the Chromium build, could you investigate please? http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190506/270340.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934

[PATCH] D52791: [Diagnostics] Check for misleading pointer declarations

2018-10-03 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. There's a false positive. int **A, *B; // false positive: declaring a variable of type 'int *'; did you mean to declare a pointer? And IMO this should also warn: int **A, B; // no warning currently https://reviews.llvm.org/D52791 ___

[PATCH] D52750: [Diagnostics] Check for integer overflow in array size expressions

2018-10-06 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added inline comments. Comment at: lib/Sema/SemaType.cpp:2232 + + if (isa(ArraySize)) +ArraySize->EvaluateForOverflow(Context); What's up with this statement? Why is it needed? This won't handle overflows for unary expression for example.

[PATCH] D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide.

2019-02-02 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete marked an inline comment as done. Rakete added inline comments. Comment at: test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:360-361 + struct Type { +Typo(); // expected-error{{deduction guide must be declared in the same scope}} +// expected-erro

[PATCH] D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide.

2019-02-18 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete abandoned this revision. Rakete added a comment. Herald added a subscriber: jdoerfert. This revision has been superseded :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57540/new/ https://reviews.llvm.org/D57540

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-09-19 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 115842. Rakete added a project: clang. Rakete added a comment. Added the tests to the existing test file for fold operators that I didn't notice before :) https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-09-19 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 115846. Rakete added a comment. Used the correct return type, even if it doesn't really matter to the compiler. https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expressions.cpp Index: test/Parser/cxx1z-fold-

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2017-09-19 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 115881. Rakete added a project: clang. Rakete added a comment. Used better diagnostic id. https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp

[PATCH] D38075: Fix PR34668 - P0704R1 implementation is too permissive

2017-09-20 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. Thanks! That was an oversight on my part, sorry. Comment at: lib/Sema/SemaExprCXX.cpp:5185 if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) { // C++2a allows functions with ref-qualifier & if they are also 'const'. +

[PATCH] D38075: Fix PR34668 - P0704R1 implementation is too permissive

2017-09-21 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:5185 if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) { // C++2a allows functions with ref-qualifier & if they are also 'const'. +if (Proto->isConst() && !Proto->isVolatile

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-09-25 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete created this revision. Rakete added a project: clang. As the title says, this makes following code compile: template struct Foo {}; Foo() -> Foo; Foo f; // ok https://reviews.llvm.org/D38216 Files: lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.cl

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-14 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete marked 3 inline comments as done. Rakete added a comment. > we could perform a tentative parse and skip to the } of the lambda. How should I do this? Do I just skip to the next `}`, or also take into account any additional scopes? Also does this mean that I skip and then revert,

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-14 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 199380. Rakete added a comment. - Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36357/new/ https://reviews.llvm.org/D36357 Files: clang/include/clang/Basic/DiagnosticParseKin

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-14 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete marked 2 inline comments as done. Rakete added a comment. In D36357#1501961 , @rsmith wrote: > In D36357#1500949 , @Rakete > wrote: > > > How should I do this? Do I just skip to the next `}`, or

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-14 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 199528. Rakete marked an inline comment as done. Rakete added a comment. Nevermind, seems to be working fine even with. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36357/new/ https://reviews.llvm.o

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-15 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 199566. Rakete added a comment. - Use TryConsumeToken Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36357/new/ https://reviews.llvm.org/D36357 Files: clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-15 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 199565. Rakete added a comment. - Fix crash with invalid postfix expr - Don't emit FixIt when using < Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36357/new/ https://reviews.llvm.org/D36357 Files: cl

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2019-05-19 Thread Nicolas Lesser via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361119: Added a better diagnostic when using the delete operator with lambdas (authored by Rakete, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-05-21 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 200423. Rakete marked 10 inline comments as done. Rakete added a comment. - Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files:

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-05-21 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete marked an inline comment as done. Rakete added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4859 // recurse to handle whatever we get. -if (TryAnnotateTypeOrScopeToken()) +if (TryAnnotateTypeOrScopeToken(!getCurScope()->isTemplateParamSco

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-05-21 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 200440. Rakete added a comment. Add support for implicit typenames of the form T::template U Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/inclu

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-05-22 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 200767. Rakete marked 11 inline comments as done. Rakete added a comment. - rebased - addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D5384

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-05-22 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4321 + isCXXDeclarationSpecifier(ITC_Never, TPResult::True) != + TPResult::True) || +(!getLangOpts().CPlusPlus && !isDeclarationSpecifier(ITC_Yes))) { -

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-05-22 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete marked an inline comment as done. Rakete added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3377-3379 // FIXME: This is not quite correct recovery as we don't transform SS // into the corresponding dependent form (and we don't diagnose

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-05-27 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete marked an inline comment as done. Rakete added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3377-3379 // FIXME: This is not quite correct recovery as we don't transform SS // into the corresponding dependent form (and we don't diagnose

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2018-12-14 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 178289. Rakete added a comment. @rsmith do you have any more comments? ping/rebase. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: include/clang/Basic/DiagnosticSema

[PATCH] D55039: [sema] Warn of mangling change if function parameters are noexcept.

2018-12-18 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. Apart from the comments I think your patch LGTM, but I'll let someone else hav the final say. Comment at: lib/Sema/SemaDecl.cpp:10266 auto *FPT = NewFD->getType()->castAs(); - bool AnyNoexcept = HasNoexcept(FPT->getReturnType()); -

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

2019-01-10 Thread Nicolas Lesser via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC350874: Fix false positive unsequenced access and modification warning in array… (authored by Rakete, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5076

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

2018-06-27 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 153149. Rakete added a comment. Added expression evaluation context to TreeTransform :) https://reviews.llvm.org/D37442 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseDeclCXX

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2018-06-28 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 153271. Rakete added a comment. Addressed review comments :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp test/SemaCXX/new-delete-0x.cpp

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

2018-07-10 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 154875. Rakete added a comment. Rebased + friendly ping :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp ==

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

2018-07-10 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 154880. Rakete added a comment. Rebased + friendly ping https://reviews.llvm.org/D37442 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseDeclCXX.cpp lib/Parse/ParseStmt.cpp

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2018-07-10 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 154882. Rakete added a comment. Rebased + friendly ping :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp test/SemaCXX/new-delete-0x.cpp

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

2018-07-12 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete closed this revision. Rakete added a comment. Committed in r336922 :) https://reviews.llvm.org/D39679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

2018-07-12 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 155240. Rakete added a comment. Format lines longer than 80 characters correctly. Repository: rC Clang https://reviews.llvm.org/D37442 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

2018-07-12 Thread Nicolas Lesser via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC336930: [C++17] Disallow lambdas in template parameters (PR33696). (authored by Rakete, committed by ). Changed prior to commit: https://reviews.llvm.org/D37442?vs=155240&id=155243#toc Repository:

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

2018-07-12 Thread Nicolas Lesser via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336930: [C++17] Disallow lambdas in template parameters (PR33696). (authored by Rakete, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D37442

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2018-07-13 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 155336. Rakete edited the summary of this revision. Rakete added a comment. Addressed review comments. Repository: rC Clang https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp tes

[PATCH] D38075: Fix PR34668 - P0704R1 implementation is too permissive

2018-07-13 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete accepted this revision. Rakete added a comment. This revision is now accepted and ready to land. LGTM with a small change in the error message that needs fixing. Do you need someone to commit it? https://reviews.llvm.org/D38075 ___ c

[PATCH] D38075: Fix PR34668 - P0704R1 implementation is too permissive

2018-07-13 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 155410. Rakete added a comment. Change error message to reflect the new update error message since the last revision. Repository: rC Clang https://reviews.llvm.org/D38075 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/cxx2a-pointer-to-const-ref

[PATCH] D38075: Fix PR34668 - P0704R1 implementation is too permissive

2018-07-13 Thread Nicolas Lesser via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337017: Fix PR34668 - P0704R1 implementation is too permissive (authored by Rakete, committed by ). Changed prior to commit: https://reviews.llvm.org/D38075?vs=155410&id=155412#toc Repository: rC

[PATCH] D40381: Parse concept definition

2017-11-24 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added inline comments. Comment at: lib/Parse/ParseTemplate.cpp:161 // Parse the actual template declaration. - return ParseSingleDeclarationAfterTemplate(Context, - ParsedTemplateInfo(&ParamLists, -

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

2017-11-24 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete created this revision. Rakete added a project: clang. This fixes PR35381 . https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/CXX/stmt.stmt/stmt.select/p3.cpp Index: test/CXX/stmt.stmt/stmt.select/p3.cpp

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

2017-11-24 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 124235. Rakete added a comment. Added a test for the switch statement and added full context to the diff. https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/CXX/stmt.stmt/stmt.select/p3.cpp Index: test/CXX/stmt.stmt/stmt.sel

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

2017-11-24 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 124236. Rakete added a comment. Addressed final review comments by adding the appropriate warnings that were missing previously. https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/CXX/stmt.stmt/stmt.select/p3.cpp Index: test

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

2017-11-24 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 124237. Rakete marked an inline comment as done. Rakete added a comment. Moved the while test outside of the #ifdef region for better coverage :) https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/CXX/stmt.stmt/stmt.select

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

2017-11-24 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 124239. Rakete edited the summary of this revision. Rakete added a comment. Added more test coverage for compatibility warnings, and fixed a bug at the same time :). https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/CXX/

[PATCH] D40381: Parse concept definition

2017-11-26 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7693 +Decl *Sema::ActOnConceptDefinition(Scope *S, + MultiTemplateParamsArg TemplateParameterLists, + IdentifierInfo *Name, SourceLocation L, ---

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2017-12-01 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 125189. Rakete added a comment. Updated error message, added a FixItHint + a rebase and friendly ping :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expr

[PATCH] D39360: [C++11] Don't put empty quotes in static_assert diagnostic.

2017-10-26 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete created this revision. Rakete added a project: clang. This patch removes the empty `""` when using `static_assert(1 + 1 == 3, "");` in the diagnostic: main.cpp:1:1: error: static_assert failed static_assert(1 + 1 == 3, ""); ^ ~~ https://reviews.llvm.org

[PATCH] D39360: [C++11] Don't put empty quotes in static_assert diagnostic.

2017-10-27 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete abandoned this revision. Rakete added a comment. @kimgr Well, mostly because they bother me a bit, don't know what others think though. I just thought it would be nice if they didn't appear, mainly because there is no need to show empty quotes in the error message. Hmm, you have a

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-10-31 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 120966. Rakete added a comment. Used Parser's `GreaterThanIsOperator` just to be sure. :) https://reviews.llvm.org/D36101 Files: include/clang/Parse/Parser.h lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expressions.cpp Index: test/Parser/cx

[PATCH] D36101: Fix usage of right shift operator in fold expressions

2017-10-31 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 120977. Rakete added a comment. Added some more tests. If this patch is still ok can you please commit it @rsmith ? Thanks! https://reviews.llvm.org/D36101 Files: include/clang/Parse/Parser.h lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expre

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

2017-11-06 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete created this revision. Rakete added a project: clang. This fixes PR34912 :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

2017-11-06 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 121712. https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp === --- test/SemaCXX/references.cpp +++ test/SemaCXX/r

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-11-11 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 122576. Rakete added a comment. Slight change + rebased + friendly ping :) https://reviews.llvm.org/D38216 Files: lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp test/Parser/cxx1z-class-template-argument-de

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-11-11 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. @lichray Isn't [dcl.type.auto.deduct] only for `auto` and `decltype(auto)`? Class template argument deduction is in [dcl.type.class.deduct], which doesn't seem to disallow declarations without an initializer. About that `extern` business, yes that's indeed counter in

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

2017-11-13 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 122708. Rakete added a comment. Made `DeduceInits` empty instead of a workaround somewhere else. Is it still ok, @rsmith ? https://reviews.llvm.org/D38216 Files: lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.c

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

2018-01-16 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 130014. Rakete added a comment. I put the enum in `ExpressionEvaluationContextRecord` now, and fixed the `Type` -> `Kind` issue. If it's still ok, could you please commit it @rsmith? Thanks :) https://reviews.llvm.org/D37442 Files: include/clang/

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

2018-01-16 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 130020. Rakete added a comment. Addressed review comments :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp test/SemaCXX/new-delete-0x.cpp

<    1   2