On Tue, Apr 10, 2018 at 12:13 PM, David Blaikie wrote:
> It's more the fact that that's /all/ the warning improvement has found so
> far. If it was 8 false positives & also found 80 actionable bugs/bad code,
> that'd be one thing.
>
Right. We used to hold ourselves to very high standards for war
On Tue, Apr 10, 2018 at 12:59 PM, John McCall wrote:
> Also, the standard for the static analyzer is not lower than it is for the
> compiler.
>
> The static analyzer tries to catch a much larger class of bugs, but it
> also tries very hard to make all the warnings it emits count. There’s a
> real
Author: nico
Date: Tue Apr 10 11:53:28 2018
New Revision: 329739
URL: http://llvm.org/viewvc/llvm-project?rev=329739&view=rev
Log:
Revert r329684 (and follow-ups 329693, 329714). See discussion on
https://reviews.llvm.org/D43578.
Modified:
cfe/trunk/include/clang/Frontend/FrontendAction.h
On Wed, Apr 11, 2018 at 6:18 AM, Andrew V. Tischenko via Phabricator via
cfe-commits wrote:
> avt77 added a comment.
>
> In https://reviews.llvm.org/D43578#1062950, @thakis wrote:
>
> > @davezarzycki remarks in https://reviews.llvm.org/D45485 that this
> breaks the shared build. The proposed fix
Hm, that's a lot of overhead. Granted, it's a synthetic benchmark, but I
think it'd be good to try this on some real codebase to make sure it really
is negligible overhead in real-world scenarios.
On Wed, Oct 25, 2017 at 3:09 PM, Roman Lebedev via Phabricator via
cfe-commits wrote:
> lebedev.ri
*the wrong thing
On Thu, Oct 26, 2017 at 12:43 PM, Nico Weber wrote:
> I don't know of one. ruiu said he's considering making lld error out on
> mixed init_array + ctors instead of having it silently do the same thing.
>
> On Thu, Oct 26, 2017 at 12:28 PM, Shoaib Meenai via Phabricator via
> cfe
I don't know of one. ruiu said he's considering making lld error out on
mixed init_array + ctors instead of having it silently do the same thing.
On Thu, Oct 26, 2017 at 12:28 PM, Shoaib Meenai via Phabricator via
cfe-commits wrote:
> smeenai added a comment.
>
> > And lld currently silently mis
Author: nico
Date: Thu Oct 26 16:26:29 2017
New Revision: 316713
URL: http://llvm.org/viewvc/llvm-project?rev=316713&view=rev
Log:
Use -fuse-init-array if no gcc installation is found.
clang currently uses .init_array instead of .ctors on Linux if it detects gcc
4.7+. Make it so that it also uses
Author: Nico Weber
Date: 2023-03-07T22:14:11-05:00
New Revision: 2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd
URL:
https://github.com/llvm/llvm-project/commit/2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd
DIFF:
https://github.com/llvm/llvm-project/commit/2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd.diff
LO
Author: Nico Weber
Date: 2023-06-25T14:32:36-04:00
New Revision: b851308b870a67ccb606d0d33f159a70fd3522c7
URL:
https://github.com/llvm/llvm-project/commit/b851308b870a67ccb606d0d33f159a70fd3522c7
DIFF:
https://github.com/llvm/llvm-project/commit/b851308b870a67ccb606d0d33f159a70fd3522c7.diff
LO
Author: Nico Weber
Date: 2023-05-10T16:49:18+02:00
New Revision: 56bac6c87a2d9046dbac36aae4910b4b90edf643
URL:
https://github.com/llvm/llvm-project/commit/56bac6c87a2d9046dbac36aae4910b4b90edf643
DIFF:
https://github.com/llvm/llvm-project/commit/56bac6c87a2d9046dbac36aae4910b4b90edf643.diff
LO
Author: Nico Weber
Date: 2023-05-17T11:01:33-04:00
New Revision: cf8c358dc9414e3de9f65eebdfdcb66dd5817857
URL:
https://github.com/llvm/llvm-project/commit/cf8c358dc9414e3de9f65eebdfdcb66dd5817857
DIFF:
https://github.com/llvm/llvm-project/commit/cf8c358dc9414e3de9f65eebdfdcb66dd5817857.diff
LO
Author: Nico Weber
Date: 2023-04-27T10:12:39-04:00
New Revision: 843450b9a67c57f134913a2b90dcb5ba95114e0f
URL:
https://github.com/llvm/llvm-project/commit/843450b9a67c57f134913a2b90dcb5ba95114e0f
DIFF:
https://github.com/llvm/llvm-project/commit/843450b9a67c57f134913a2b90dcb5ba95114e0f.diff
LO
Author: Nico Weber
Date: 2023-06-14T16:17:42-07:00
New Revision: dbdd6372b7af2f6df5f41d19d966e6bac1b30208
URL:
https://github.com/llvm/llvm-project/commit/dbdd6372b7af2f6df5f41d19d966e6bac1b30208
DIFF:
https://github.com/llvm/llvm-project/commit/dbdd6372b7af2f6df5f41d19d966e6bac1b30208.diff
LO
Author: Nico Weber
Date: 2023-06-14T16:19:48-07:00
New Revision: 9c560350dd57d0dcb849c5915fa7c50b139ce671
URL:
https://github.com/llvm/llvm-project/commit/9c560350dd57d0dcb849c5915fa7c50b139ce671
DIFF:
https://github.com/llvm/llvm-project/commit/9c560350dd57d0dcb849c5915fa7c50b139ce671.diff
LO
Author: Nico Weber
Date: 2022-12-06T08:43:48-05:00
New Revision: de4b6a1bc64db33643f001ad45fae7b92b4a4688
URL:
https://github.com/llvm/llvm-project/commit/de4b6a1bc64db33643f001ad45fae7b92b4a4688
DIFF:
https://github.com/llvm/llvm-project/commit/de4b6a1bc64db33643f001ad45fae7b92b4a4688.diff
LO
Author: Nico Weber
Date: 2022-12-06T08:50:37-05:00
New Revision: af95441ba7f3ca61c925409e58ee7e5486d84033
URL:
https://github.com/llvm/llvm-project/commit/af95441ba7f3ca61c925409e58ee7e5486d84033
DIFF:
https://github.com/llvm/llvm-project/commit/af95441ba7f3ca61c925409e58ee7e5486d84033.diff
LO
Author: Nico Weber
Date: 2022-12-06T10:22:35-05:00
New Revision: f2d878ba688adf134fd0c4ad971ada57c1898e62
URL:
https://github.com/llvm/llvm-project/commit/f2d878ba688adf134fd0c4ad971ada57c1898e62
DIFF:
https://github.com/llvm/llvm-project/commit/f2d878ba688adf134fd0c4ad971ada57c1898e62.diff
LO
Author: Nico Weber
Date: 2022-12-06T10:22:47-05:00
New Revision: 8e7994b9b513497589d4bf911f061378f517fb16
URL:
https://github.com/llvm/llvm-project/commit/8e7994b9b513497589d4bf911f061378f517fb16
DIFF:
https://github.com/llvm/llvm-project/commit/8e7994b9b513497589d4bf911f061378f517fb16.diff
LO
Author: Nico Weber
Date: 2022-12-07T15:03:35-05:00
New Revision: 6cac3dc9db57cbf5f9f9092d97f878be3db5020d
URL:
https://github.com/llvm/llvm-project/commit/6cac3dc9db57cbf5f9f9092d97f878be3db5020d
DIFF:
https://github.com/llvm/llvm-project/commit/6cac3dc9db57cbf5f9f9092d97f878be3db5020d.diff
LO
Author: Nico Weber
Date: 2022-12-09T08:57:28-05:00
New Revision: 1481fcf780bde7b115aa395064d71749b1a40889
URL:
https://github.com/llvm/llvm-project/commit/1481fcf780bde7b115aa395064d71749b1a40889
DIFF:
https://github.com/llvm/llvm-project/commit/1481fcf780bde7b115aa395064d71749b1a40889.diff
LO
If you spell it `/*IsWritten=*/foo`, then clang-format will know to not
insert a space after the comment.
On Wed, Dec 14, 2016 at 2:45 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Wed Dec 14 13:45:03 2016
> New Revision: 289698
>
> URL: http://ll
Author: nico
Date: Wed Dec 14 15:34:19 2016
New Revision: 289712
URL: http://llvm.org/viewvc/llvm-project?rev=289712&view=rev
Log:
Update MSVC compat docs about debug info
https://reviews.llvm.org/D27769
Modified:
cfe/trunk/docs/MSVCCompatibility.rst
Modified: cfe/trunk/docs/MSVCCompatibili
Author: nico
Date: Wed Dec 14 15:38:18 2016
New Revision: 289713
URL: http://llvm.org/viewvc/llvm-project?rev=289713&view=rev
Log:
Revert 289252 (and follow-up 289285), it caused PR31374
Removed:
cfe/trunk/test/CodeGenOpenCL/amdgpu-nullptr.cl
Modified:
cfe/trunk/include/clang/AST/APValue.
Are you aware that this is still failing on all the bots? (
http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/493 eg)
On Thu, Dec 15, 2016 at 11:18 PM, Akira Hatanaka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ahatanak
> Date: Thu Dec 15 22:18:53 2016
> New R
I think the problem was that you didn't pipe the output to /dev/null or -,
and so a .ll file got created which now confuses the bots.
I suggest:
1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through
magic lit vars to find one that expands to the right thing)
2. If the intent fo
On Fri, Dec 16, 2016 at 12:08 AM, Nico Weber wrote:
> I think the problem was that you didn't pipe the output to /dev/null or -,
> and so a .ll file got created which now confuses the bots.
>
> I suggest:
> 1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through
> magic lit vars
Author: nico
Date: Thu Dec 15 23:03:44 2016
New Revision: 289924
URL: http://llvm.org/viewvc/llvm-project?rev=289924&view=rev
Log:
attempt to fix bots after r289914/r289919
Modified:
cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp
Modified: cfe/trunk/test/SemaTemplate/default-expr-a
I gave this a shot in 289924. Please check that's the right thing.
On Fri, Dec 16, 2016 at 12:09 AM, Nico Weber wrote:
> On Fri, Dec 16, 2016 at 12:08 AM, Nico Weber wrote:
>
>> I think the problem was that you didn't pipe the output to /dev/null or
>> -, and so a .ll file got created which now
On Fri, Dec 16, 2016 at 12:14 AM, Akira Hatanaka
wrote:
>
> On Dec 15, 2016, at 9:08 PM, Nico Weber wrote:
>
> I think the problem was that you didn't pipe the output to /dev/null or -,
> and so a .ll file got created which now confuses the bots.
>
> I suggest:
> 1. Add `// RUN: rm -f right_path
On Fri, Dec 16, 2016 at 12:21 AM, Akira Hatanaka
wrote:
>
> On Dec 15, 2016, at 9:18 PM, Nico Weber wrote:
>
> On Fri, Dec 16, 2016 at 12:14 AM, Akira Hatanaka
> wrote:
>
>>
>> On Dec 15, 2016, at 9:08 PM, Nico Weber wrote:
>>
>> I think the problem was that you didn't pipe the output to /dev/
On Fri, Dec 16, 2016 at 12:45 AM, Akira Hatanaka
wrote:
> It looks like it failed again. I’m still looking.
>
Well, the bot needs to run once with my change in. In that run, the .ll
file is still around and the tests will still fail, but the .cpp test will
remove it. On the first build _after_ m
Thanks! The test now also includes a regression test for PR31374, yes?
On Thu, Dec 15, 2016 at 3:09 AM, Yaxun Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: yaxunl
> Date: Thu Dec 15 02:09:08 2016
> New Revision: 289787
>
> URL: http://llvm.org/viewvc/llvm-project?rev=289787&v
Won't that make is_win_fastlink builds slow to link? And if we do this,
then this change here makes a then-not-very-tested config the default.
(I don't have a problem with this patch, go ahead and land if you think
it's the way to go. Just wondering aloud.)
On Fri, Dec 16, 2016 at 4:39 PM, Reid K
https://developer.apple.com/library/content/releasenotes/General/CarbonCoreDeprecations/index.html#//apple_ref/doc/uid/TP40012224-CH1-SW16
explicitly suggests sysctl as replacement when targeting 10.8+, which
strongly suggests that it'll work.
On Fri, Dec 16, 2016 at 4:37 PM, Erik Pilkington via P
On Wed, Dec 21, 2016 at 6:42 AM, Senthil Kumar Selvaraj via Phabricator via
cfe-commits wrote:
> saaadhu added a comment.
>
> Would someone with a llvm bugzilla account please file the PR for me? New
> user registration is disabled, and I've been waiting for
> llvm-ad...@lists.llvm.org to respond
Author: nico
Date: Tue Jan 3 20:33:36 2017
New Revision: 290930
URL: http://llvm.org/viewvc/llvm-project?rev=290930&view=rev
Log:
Change clang-format's Chromium JavaScript defaults
Chromium is starting to use clang-format on more JavaScript.
In doing this, we discovered that our defaults were n
I don't see any approval after Aaron's "Please wait until someone has had
the chance to review before committing" on https://reviews.llvm.org/D20561
-- was this reviewed on IRC?
On Fri, Aug 12, 2016 at 4:04 AM, Roger Ferrer Ibanez via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rog
thakis created this revision.
thakis added a reviewer: majnemer.
thakis added a subscriber: cfe-commits.
/Brepro means we want reproducible builds, i.e. we _don't_ want the timestamp
that's needed to be compatible with the incremental linker.
https://reviews.llvm.org/D23805
Files:
include/cla
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
clang already treats all inputs as utf-8. Warn if anything but utf-8 is passed.
Do this by mapping source-charset to finput-charset, which already behaves like
this. Slightly tweak finput-charset
thakis closed this revision.
thakis added a comment.
279531, thanks!
https://reviews.llvm.org/D23807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Tue Aug 23 11:47:09 2016
New Revision: 279531
URL: http://llvm.org/viewvc/llvm-project?rev=279531&view=rev
Log:
clang-cl: Accept MSVC 2015's `/source-charset:utf-8` flag.
clang already treats all inputs as utf-8. Warn if anything but utf-8 is passed.
Do this by mapping source-
Ok, thanks!
On Tue, Aug 23, 2016 at 4:11 AM, Roger Ferrer Ibanez <
roger.ferreriba...@arm.com> wrote:
> Yes it was approved on IRC by Aaron Ballman:
>
>
>
> T 1470758009 zygoloid: do you have any further thoughts about
> https://reviews.llvm.org/D20561 ? thank you very much :)
>
> T 1470758207
Author: nico
Date: Tue Aug 23 14:32:02 2016
New Revision: 279555
URL: http://llvm.org/viewvc/llvm-project?rev=279555&view=rev
Log:
clang-cl: Make /Brepro actually work.
/Brepro means we want reproducible builds, i.e. we _don't_ want the timestamp
that's needed to be compatible with the incrementa
thakis closed this revision.
thakis added a comment.
279555, thanks!
https://reviews.llvm.org/D23805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Tue Aug 23 14:59:55 2016
New Revision: 279558
URL: http://llvm.org/viewvc/llvm-project?rev=279558&view=rev
Log:
Remove two dos line endings.
Modified:
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Author: nico
Date: Wed Aug 24 11:37:21 2016
New Revision: 279639
URL: http://llvm.org/viewvc/llvm-project?rev=279639&view=rev
Log:
fix typo "varaible"
Modified:
cfe/trunk/test/SemaCXX/warn-range-loop-analysis.cpp
Modified: cfe/trunk/test/SemaCXX/warn-range-loop-analysis.cpp
URL:
http://llvm
thakis added inline comments.
Comment at: include/clang/Driver/CLCompatOptions.td:68
@@ +67,3 @@
+def _SLASH_FC : CLFlag<"FC">,
+ HelpText<"Use absolute paths in diagnostics and __FILE__">,
+ Alias;
Hm, I'm not sure this should affect __FILE__. It sounds people
thakis added inline comments.
Comment at: include/clang/Driver/CLCompatOptions.td:68
@@ +67,3 @@
+def _SLASH_FC : CLFlag<"FC">,
+ HelpText<"Use absolute paths in diagnostics and __FILE__">,
+ Alias;
hans wrote:
> thakis wrote:
> > Hm, I'm not sure this should af
thakis added inline comments.
Comment at: include/clang/Driver/CLCompatOptions.td:68
@@ +67,3 @@
+def _SLASH_FC : CLFlag<"FC">,
+ HelpText<"Use absolute paths in diagnostics and __FILE__">,
+ Alias;
hans wrote:
> thakis wrote:
> > hans wrote:
> > > thakis wrote:
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
I like this approach.
https://reviews.llvm.org/D23816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
thakis created this revision.
thakis added a reviewer: rnk.
thakis added a subscriber: cfe-commits.
Some Windows SDK classes, for example
Windows::Storage::Streams::IBufferByteAccess, use the ATL way of spelling
attributes:
[uuid("")] class IBufferByteAccess {};
To be able to use __uuido
thakis marked an inline comment as done.
thakis added a comment.
Thanks for the fast review and the good comments! I'll leave it to y'all to
agree on some name if you don't like the one I picked.
> Also, doesn't this introduce ambiguities into the grammar? Something like
> this:
>
> void u
thakis updated this revision to Diff 69312.
thakis marked an inline comment as done.
thakis added a comment.
comments round 1
https://reviews.llvm.org/D23895
Files:
include/clang/Basic/Attr.td
include/clang/Basic/Attributes.h
include/clang/Parse/Parser.h
include/clang/Sema/AttributeList
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
Like https://reviews.llvm.org/D23807, but for execution-charset.
https://reviews.llvm.org/D23938
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-options.c
thakis updated this revision to Diff 69415.
thakis added a comment.
;-;
https://reviews.llvm.org/D23938
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
===
thakis updated this revision to Diff 69416.
thakis added a comment.
!!
https://reviews.llvm.org/D23938
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
thakis updated this revision to Diff 69419.
thakis added a comment.
Aaron's right that these are currently called "Microsoft" in the source. I
agree that that's a confusing name and we should probably rename it, but on
second thought that seems unrelated to this change. If y'all agree on a name,
thakis created this revision.
thakis added a reviewer: rsmith.
thakis added a subscriber: cfe-commits.
This is useful for creating reproducible builds. Defining these via -D triggers
warnings, and can cause bugs (presently, e.g. PR29119). It makes it also
impossible to override __DATE__ and __TI
Author: nico
Date: Fri Aug 26 16:11:43 2016
New Revision: 279866
URL: http://llvm.org/viewvc/llvm-project?rev=279866&view=rev
Log:
clang-cl: Accept MSVC 2015's `/execution-charset:utf-8` flag.
Also makes -fexec-charset accept utf-8 case-insensitively.
Like https://reviews.llvm.org/D23807, but for
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
r279866, thanks!
https://reviews.llvm.org/D23938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: nico
Date: Fri Aug 26 16:26:29 2016
New Revision: 279869
URL: http://llvm.org/viewvc/llvm-project?rev=279869&view=rev
Log:
clang-cl: Accept MSVC2015's '/utf-8' flag.
Clang always behaves as if that's passed, so just ignore the flag.
Modified:
cfe/trunk/include/clang/Driver/CLCompatOp
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
Clang always assumes that files are utf-8. If an invalidly encoded character is
used in an identifier, clang always errors. If it's used in a character
literal, clang warns Winvalid-source-encodi
Author: nico
Date: Fri Aug 26 16:51:14 2016
New Revision: 279872
URL: http://llvm.org/viewvc/llvm-project?rev=279872&view=rev
Log:
clang-cl: Support MSVC2015's /validate-charset flag.
Clang always assumes that files are utf-8. If an invalidly encoded character is
used in an identifier, clang alwa
thakis closed this revision.
thakis added a comment.
r279872, thanks!
https://reviews.llvm.org/D23945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
rnk: ping
https://reviews.llvm.org/D23895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Tue Aug 30 09:12:06 2016
New Revision: 280091
URL: http://llvm.org/viewvc/llvm-project?rev=280091&view=rev
Log:
Revert r280035 (and followups r280057, r280085), it caused PR30195
Removed:
cfe/trunk/test/Driver/modules-ts.cpp
Modified:
cfe/trunk/include/clang/Driver/CC1O
Author: nico
Date: Tue Aug 30 09:24:28 2016
New Revision: 280094
URL: http://llvm.org/viewvc/llvm-project?rev=280094&view=rev
Log:
Fix typo in comment
Modified:
cfe/trunk/test/Driver/cl-pch.cpp
Modified: cfe/trunk/test/Driver/cl-pch.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/tes
thakis marked 3 inline comments as done.
thakis added a comment.
> There are things missing from this patch as well. To wit:
>
> - Attributes.h needs to know about this attribute syntax, and
> `hasAttribute()` needs to support it (this hooks into `__has_attribute`
> support).
> - AttributeLi
thakis marked 2 inline comments as done.
thakis added a comment.
(Just wanted to ask if I'm missing something about these three bullets. I do
need to make a few other changes: More tests, parsing for uuid(1-2-3) without
quotes + tests, and I also want to add a deprecation warning with a fixit,
thakis updated this revision to Diff 70013.
thakis marked an inline comment as done.
thakis added a comment.
Sorry about the delay! Now with custom parsing code that accepts uuid() without
quotes. I thought this would be complicated, but ended up being not so bad in
the end. See the tests for se
thakis updated this revision to Diff 70036.
thakis marked 6 inline comments as done.
thakis added a comment.
Address comments.
https://reviews.llvm.org/D23895
Files:
include/clang/Basic/Attr.td
include/clang/Basic/Attributes.h
include/clang/Parse/Parser.h
include/clang/Sema/AttributeLis
thakis added inline comments.
Comment at: include/clang/Parse/Parser.h:2217
@@ -2215,1 +2216,3 @@
+ SourceLocation UuidLoc,
+ ParsedAttributes &attrs);
void ParseMicrosoftAttributes(ParsedAttributes &at
thakis added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:4031
@@ +4030,3 @@
+ ConsumeToken();
+ if (Name->getName() == "uuid" && Tok.is(tok::l_paren))
+ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs);
aaron.ballman wrote:
> Silently
thakis added inline comments.
Comment at: include/clang/Basic/Attr.td:201
@@ -200,2 +200,3 @@
class Declspec : Spelling;
+class Microsoft : Spelling;
class CXX11
rsmith wrote:
> Given that MS have deprecated this syntax and are trying to move away from it
> tow
thakis added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:4031
@@ +4030,3 @@
+ ConsumeToken();
+ if (Name->getName() == "uuid" && Tok.is(tok::l_paren))
+ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs);
aaron.ballman wrote:
> thakis w
thakis added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:4031
@@ +4030,3 @@
+ ConsumeToken();
+ if (Name->getName() == "uuid" && Tok.is(tok::l_paren))
+ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs);
aaron.ballman wrote:
> thakis w
thakis updated this revision to Diff 70197.
thakis added a comment.
Require '('.
https://reviews.llvm.org/D23895
Files:
include/clang/Basic/Attr.td
include/clang/Basic/Attributes.h
include/clang/Parse/Parser.h
include/clang/Sema/AttributeList.h
lib/Parse/ParseDecl.cpp
lib/Parse/Pars
thakis marked an inline comment as done.
Comment at: lib/Parse/ParseDeclCXX.cpp:4037
@@ -3945,1 +4036,3 @@
+}
+
T.consumeClose();
Aha, I had forgotten that SkipUntil() handles paren nesting intelligently, so I
think just requiring a '(' after 'uuid' with
Author: nico
Date: Fri Sep 2 21:41:17 2016
New Revision: 280572
URL: http://llvm.org/viewvc/llvm-project?rev=280572&view=rev
Log:
Remove function name from comment.
The comment starting with "ParseDeclarationOrFunctionDefinition -" is above
a function called ParseDeclOrFunctionDefInternal. Fix
Author: nico
Date: Fri Sep 2 21:48:03 2016
New Revision: 280574
URL: http://llvm.org/viewvc/llvm-project?rev=280574&view=rev
Log:
Move calls of MaybeParseMicrosoftAttributes() before ParseExternalDeclaration()
into ParseDeclOrFunctionDefInternal() (which is called by
MaybeParseMicrosoftAttributes
Author: nico
Date: Fri Sep 2 21:55:10 2016
New Revision: 280575
URL: http://llvm.org/viewvc/llvm-project?rev=280575&view=rev
Log:
Add plumbing for new attribute type "Microsoft".
This is for attributes in []-delimited lists preceding a class, like e.g.
`[uuid("...")] class Foo {};` Not used by
Author: nico
Date: Fri Sep 2 22:01:32 2016
New Revision: 280576
URL: http://llvm.org/viewvc/llvm-project?rev=280576&view=rev
Log:
Let Microsoft attributes apply to the type, not the variable.
There was already a function that moved attributes off the declspec into
an attribute list for attribute
Author: nico
Date: Fri Sep 2 22:25:22 2016
New Revision: 280578
URL: http://llvm.org/viewvc/llvm-project?rev=280578&view=rev
Log:
[ms] Add support for parsing uuid as a Microsoft attribute.
Some Windows SDK classes, for example
Windows::Storage::Streams::IBufferByteAccess, use the ATL way of spe
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
Thanks! Landed in r280574 r280575 r280576 280578.
https://reviews.llvm.org/D23895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: nico
Date: Fri Sep 2 23:27:14 2016
New Revision: 280580
URL: http://llvm.org/viewvc/llvm-project?rev=280580&view=rev
Log:
Add a test Aaron asked for that I forgot to add before landing r280578.
Modified:
cfe/trunk/test/Parser/ms-square-bracket-attributes.mm
Modified: cfe/trunk/test/
Renato, I remember you saying you worked around the bot problem by making
the build dir a symlink. Maybe stuff gets confused by that setup? Symlink
build dirs tend to cause trouble.
On Sep 5, 2016 8:11 PM, "Craig Topper via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> This error makes even
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Looks great, thanks!
https://reviews.llvm.org/D24286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: nico
Date: Wed Sep 7 14:41:35 2016
New Revision: 280845
URL: http://llvm.org/viewvc/llvm-project?rev=280845&view=rev
Log:
Add a few more test for []-style uuid attributes.
- Should diag on a function (clang-cl warns; it's an error in cl)
- Test the attribute on nested classes (clang-cl i
thakis added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2962
@@ -2959,1 +2961,3 @@
+ "the enum %0 an unsigned underlying type">,
+ InGroup>, DefaultIgnore;
def warn_attribute_packed_for_bitfield : Warning<
Hm, isn't the more safe de
Author: nico
Date: Sat Sep 10 08:03:59 2016
New Revision: 281136
URL: http://llvm.org/viewvc/llvm-project?rev=281136&view=rev
Log:
Add missing test coverage for an inheritance model attrib merge diag.
Without this, no tests fail if I remove the Diag() in the first if in
Sema::mergeMSInheritanceAt
The current status is that this is too slow, so for now the recommendation
is to have a case insensitive mount for the files that need it.
On Sep 9, 2016 8:18 PM, "John Sheu" wrote:
> sheu added a subscriber: sheu.
> sheu added a comment.
>
> I'd be very interested in seeing this patch happen.
thakis created this revision.
thakis added a reviewer: rnk.
thakis added subscribers: cfe-commits, aaron.ballman.
This mostly behaves cl.exe's behavior, even though clang-cl is stricter in some
corner cases and more lenient in others (see the included test).
To make the `uuid declared previously
thakis updated this revision to Diff 71049.
thakis added a comment.
Remove local XXXs I've since addressed.
https://reviews.llvm.org/D24469
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Sema/S
thakis updated this revision to Diff 71050.
thakis added a comment.
On conflict, keep first uuid in ast instead of having different uuids on
different redeclarations.
https://reviews.llvm.org/D24469
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
incl
Author: nico
Date: Tue Sep 13 10:05:04 2016
New Revision: 281345
URL: http://llvm.org/viewvc/llvm-project?rev=281345&view=rev
Log:
Traversing template paramter lists of DeclaratorDecls and/or TagDecls.
The unit tests in this patch demonstrate the need to traverse template
parameter lists of Decla
thakis added a subscriber: thakis.
thakis added a comment.
landed in r281345.
https://reviews.llvm.org/D24268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis marked 2 inline comments as done.
thakis added a comment.
In https://reviews.llvm.org/D24469#540400, @majnemer wrote:
> Does __uuidof walk bases to find [uuid] in cl.exe? They walk bases for the
> __declspec spelling.
As far as I can tell, they don't for either:
C:\src\chrome\src>type
thakis updated this revision to Diff 71181.
thakis added a comment.
comments
https://reviews.llvm.org/D24469
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDecl
Author: nico
Date: Tue Sep 13 13:55:26 2016
New Revision: 281367
URL: http://llvm.org/viewvc/llvm-project?rev=281367&view=rev
Log:
[clang-cl] Diagnose duplicate uuids.
This mostly behaves cl.exe's behavior, even though clang-cl is stricter in some
corner cases and more lenient in others (see the
801 - 900 of 1693 matches
Mail list logo
