[clang] Revert "[FMV] Emit the resolver along with the default version definition." (PR #85914)

2024-03-20 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/85914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[FMV] Emit the resolver along with the default version definition." (PR #85914)

2024-03-20 Thread Nico Weber via cfe-commits
nico wrote: Thanks for the revert! https://github.com/llvm/llvm-project/pull/85914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AsmPrinter,X86] Hard code AT&T syntax input for module-level inline assembly for MSVC triples (PR #85668)

2024-03-21 Thread Nico Weber via cfe-commits
nico wrote: Looks like we could fix code on our end and this here isn't needed. But maybe the current behavior isn't 100% ideal. Here's what I think the situation currently is (please correct me if I'm wrong): * With clang-cl, you get intel assembly output by default with `/FA`. That's good. *

[clang] [OBJC] Allow __attribute__((NSObject)) types be used as lightweight generic specifiers (PR #84593)

2024-03-21 Thread Nico Weber via cfe-commits
nico wrote: Seems alright ¯\_(ツ)_/¯ https://github.com/llvm/llvm-project/pull/84593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OBJC] Allow __attribute__((NSObject)) types be used as lightweight generic specifiers (PR #84593)

2024-03-21 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/84593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [XCOFF] Add compiler version to an auxiliary symbol table entry (PR #80162)

2024-02-06 Thread Nico Weber via cfe-commits
nico wrote: This seems to break tests, even after the spelling fix: http://45.33.8.238/linux/130117/step_12.txt Does that look related? https://github.com/llvm/llvm-project/pull/80162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [Clang][Sema] Abbreviated function templates do not append invented parameters to empty template parameter lists (PR #80864)

2024-02-08 Thread Nico Weber via cfe-commits
nico wrote: This breaks check-clang-tools: http://45.33.8.238/linux/130320/step_8.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/80864 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang] Remove #undef alloca workaround (PR #81534)

2024-02-12 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. LG, great investigation! https://github.com/llvm/llvm-project/pull/81534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix crash when declaring invalid lambda member (PR #74110)

2024-03-08 Thread Nico Weber via cfe-commits
nico wrote: Looks like the included test still makes clang crash: http://45.33.8.238/linux/132722/step_7.txt https://github.com/llvm/llvm-project/pull/74110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [clang] Fix crash when declaring invalid lambda member (PR #74110)

2024-03-08 Thread Nico Weber via cfe-commits
nico wrote: Also on the official waterfall, eg here: https://lab.llvm.org/buildbot/#/builders/188/builds/42935 Can you take a look, and revert for now if it takes a while to fix? https://github.com/llvm/llvm-project/pull/74110 ___ cfe-commits mailing

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5. (PR #82840)

2024-02-27 Thread Nico Weber via cfe-commits
nico wrote: Looks this breaks tests on macOS: http://45.33.8.238/macm1/79435/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/82840 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5. (PR #82840)

2024-02-27 Thread Nico Weber via cfe-commits
nico wrote: It's been a few hours. Time to revert and analyze offline? https://github.com/llvm/llvm-project/pull/82840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM][DWARF] Enable pubnames for -glldb when expliti flag is passed (PR #83206)

2024-02-27 Thread Nico Weber via cfe-commits
nico wrote: I don't know if this is correct. Maybe just add a triple to the problematic clang invocation for now and have this reviewed by a local expert while trunk isn't broken? https://github.com/llvm/llvm-project/pull/83206 ___ cfe-commits mailin

[openmp] [mlir] [clang] [flang] [compiler-rt] [lld] [lldb] [libcxx] [libunwind] [llvm] [libc] [clang-tools-extra] [libcxxabi] [clang] static operators should evaluate object argument (PR #68485)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: This might've broken clangd tests: http://45.33.8.238/linux/129484/step_9.txt Does that look related? If so, please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/68485 ___ cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: This seems to break tests: http://45.33.8.238/linux/129493/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/80035 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: This is with that change: http://45.33.8.238/linux/129493/step_7.txt https://github.com/llvm/llvm-project/pull/80035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: i.e. it helped with Clang :: Preprocessor/predefined-arch-macros.c but not with: Failed Tests (2): Clang :: Driver/amdgpu-macros.cl Clang :: Driver/target-id-macros.cl https://github.com/llvm/llvm-project/pull/80035 ___ cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: My bot is happy again, thanks. Please run tests before committing :) https://github.com/llvm/llvm-project/pull/80035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [LoongArch] Insert nops and emit align reloc when handle alignment directive (PR #72962)

2024-01-23 Thread Nico Weber via cfe-commits
nico wrote: Looks like this breaks check-llvm: http://45.33.8.238/macm1/77360/step_11.txt , http://45.33.8.238/linux/128902/step_12.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/72962

[clang] [RISCV] Support __riscv_v_fixed_vlen for vbool types. (PR #76551)

2024-01-25 Thread Nico Weber via cfe-commits
nico wrote: Breaks tests: http://45.33.8.238/linux/129101/step_7.txt https://github.com/llvm/llvm-project/pull/76551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Optimize processing .clang-format-ignore files (PR #76733)

2024-01-11 Thread Nico Weber via cfe-commits
nico wrote: Any reason the test can't use FileCheck like all the other tests? https://github.com/llvm/llvm-project/pull/76733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dc61ebb - [clang] Mark clang-format-ignore.cpp as unsupported on Windows

2024-01-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2024-01-11T19:26:24-05:00 New Revision: dc61ebb44c11d2f5d03b7dd9cb80a0644a30775e URL: https://github.com/llvm/llvm-project/commit/dc61ebb44c11d2f5d03b7dd9cb80a0644a30775e DIFF: https://github.com/llvm/llvm-project/commit/dc61ebb44c11d2f5d03b7dd9cb80a0644a30775e.diff LO

[clang] [clang-format] Optimize processing .clang-format-ignore files (PR #76733)

2024-01-11 Thread Nico Weber via cfe-commits
nico wrote: (The bot uses regular grep 3.1 that comes with `git bash` afaict.) https://github.com/llvm/llvm-project/pull/76733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [compiler-rt] [clang-tools-extra] [flang] [clang] Add test for CWG1807 (PR #77637)

2024-01-18 Thread Nico Weber via cfe-commits
nico wrote: This breaks tests on macOS: http://45.33.8.238/macm1/76983/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/77637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Nico Weber via cfe-commits
nico wrote: Hello, it looks like this breaks check-clang on mac: http://45.33.8.238/macm1/71368/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list

[clang] Revert [clang] Handle templated operators with reversed arguments and [STLExtras] Undo C++20 hack (PR #69937)

2023-10-23 Thread Nico Weber via cfe-commits
nico wrote: Looks like the revert broke tests: http://45.33.8.238/linux/121332/step_7.txt Please take a look. https://github.com/llvm/llvm-project/pull/69937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

r369402 - win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

2019-08-20 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Aug 20 09:28:11 2019 New Revision: 369402 URL: http://llvm.org/viewvc/llvm-project?rev=369402&view=rev Log: win: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer MSVC 2017 update 3 (_MSC_VER 1911) enables /Zc:twoPhase by default, and so should clang-c

r369536 - clang: Fix typo in comment

2019-08-21 Thread Nico Weber via cfe-commits
Author: nico Date: Wed Aug 21 08:37:27 2019 New Revision: 369536 URL: http://llvm.org/viewvc/llvm-project?rev=369536&view=rev Log: clang: Fix typo in comment Modified: cfe/trunk/lib/Basic/FileManager.cpp Modified: cfe/trunk/lib/Basic/FileManager.cpp URL: http://llvm.org/viewvc/llvm-project/

r369539 - clang: Fix typo in comment

2019-08-21 Thread Nico Weber via cfe-commits
Author: nico Date: Wed Aug 21 08:41:29 2019 New Revision: 369539 URL: http://llvm.org/viewvc/llvm-project?rev=369539&view=rev Log: clang: Fix typo in comment Modified: cfe/trunk/lib/Lex/UnicodeCharSets.h Modified: cfe/trunk/lib/Lex/UnicodeCharSets.h URL: http://llvm.org/viewvc/llvm-project/

r369540 - clang: Fix typo in comment

2019-08-21 Thread Nico Weber via cfe-commits
Author: nico Date: Wed Aug 21 08:49:21 2019 New Revision: 369540 URL: http://llvm.org/viewvc/llvm-project?rev=369540&view=rev Log: clang: Fix typo in comment (Sorry for all these commits; trying to sort out why svn doesn't want to store my password.) Modified: cfe/trunk/lib/Sema/SemaOverload

r369542 - clang: Fix typo in comment

2019-08-21 Thread Nico Weber via cfe-commits
Author: nico Date: Wed Aug 21 08:52:44 2019 New Revision: 369542 URL: http://llvm.org/viewvc/llvm-project?rev=369542&view=rev Log: clang: Fix typo in comment Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp URL: http://llvm.org/viewvc/llvm-

Re: [PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

2019-08-21 Thread Nico Weber via cfe-commits
No worries. If it takes a while to analyze, please revert while you you investigate, to keep trunk green. On Wed, Aug 21, 2019 at 10:29 PM Csaba Dabis via Phabricator via cfe-commits wrote: > Charusso added a comment. > > return C.getNoteTag( > - [=] { > + [=]() -> std::string

r369759 - clang-format: Disable across-block include reordering.

2019-08-23 Thread Nico Weber via cfe-commits
Author: nico Date: Fri Aug 23 07:04:09 2019 New Revision: 369759 URL: http://llvm.org/viewvc/llvm-project?rev=369759&view=rev Log: clang-format: Disable across-block include reordering. Differential Revision: https://reviews.llvm.org/D66650 Modified: cfe/trunk/lib/Format/Format.cpp Modified

Re: r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

2019-08-23 Thread Nico Weber via cfe-commits
On Thu, Aug 22, 2019 at 4:05 PM Matthias Gehre via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Diana, > hi Richard, > > thank you for the feedback! > > Diana, > I remember that some gcc version had issues with raw string literals > inside macros. I'll fix that to use normal > string lite

Re: r370321 - [Index] Marked a bunch of classes 'final'

2019-08-29 Thread Nico Weber via cfe-commits
Nitpick (sorry): I think common style for commit message is to describe what the change does in present tense, i.e. ""Mark a bunch of classes 'final'". On Thu, Aug 29, 2019 at 6:15 AM Dmitri Gribenko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gribozavr > Date: Thu Aug 29 03:16

r371124 - Implement Microsoft-compatible mangling for decomposition declarations.

2019-09-05 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Sep 5 14:08:50 2019 New Revision: 371124 URL: http://llvm.org/viewvc/llvm-project?rev=371124&view=rev Log: Implement Microsoft-compatible mangling for decomposition declarations. Match cl.exe's mangling for decomposition declarations. Decomposition declarations are consid

Re: r371004 - [c++20] Fix some ambiguities in our mangling of lambdas with explicit

2019-09-05 Thread Nico Weber via cfe-commits
On Wed, Sep 4, 2019 at 9:22 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed Sep 4 18:23:47 2019 > New Revision: 371004 > > URL: http://llvm.org/viewvc/llvm-project?rev=371004&view=rev > Log: > [c++20] Fix some ambiguities in our mangling of lambd

r371205 - libclang depends on ClangDriverOptions since r352803

2019-09-06 Thread Nico Weber via cfe-commits
Author: nico Date: Fri Sep 6 06:57:12 2019 New Revision: 371205 URL: http://llvm.org/viewvc/llvm-project?rev=371205&view=rev Log: libclang depends on ClangDriverOptions since r352803 Without this, the build would sometimes fail with In file included from clang/tools/libclang/CIndexer.cpp:17

Re: r371222 - [Diagnostics] Refactor code for -Wsizeof-pointer-div, catch more cases; also add -Wsizeof-array-div

2019-09-06 Thread Nico Weber via cfe-commits
This reports things like error: expresion will return the incorrect number of elements in the array; the array element type is 'const char *', not 'char *' which doesn't look quite right... On Fri, Sep 6, 2019 at 12:11 PM David Bolvansky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Au

Re: r371241 - [LifetimeAnalysis] don't use raw string literals in macros

2019-09-06 Thread Nico Weber via cfe-commits
(The slightly more usual fix is to do `const char kFoo[] = R"cpp(...)cpp"; EXPECT_TRUE(matches(kFoo...)`) On Fri, Sep 6, 2019 at 3:13 PM Matthias Gehre via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mgehre > Date: Fri Sep 6 12:15:02 2019 > New Revision: 371241 > > URL: http://llv

Re: [PATCH] D33900: Print registered targets in clang's version information

2017-07-28 Thread Nico Weber via cfe-commits
Cool, then let's revert this and add it back under a different flag. Thanks! On Fri, Jul 28, 2017 at 1:37 PM, Dimitry Andric via Phabricator via cfe-commits wrote: > dim added a comment. > > In https://reviews.llvm.org/D33900#824172, @thakis wrote: > > > dim: Does putting the target listing behi

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

2017-07-31 Thread Nico Weber via cfe-commits
Hi Vedant, after this change our ubsanvptr bot fails like so: clang-6.0: error: implicitly disabling vptr sanitizer because null checking wasn't enabled [-Werror,-Wauto-disable-vptr-sanitizer] The bot uses -fsanitize=vptr. I have no idea what this warning is supposed to tell me. Maybe it could b

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

2017-07-31 Thread Nico Weber via cfe-commits
31, 2017, at 9:37 AM, Hans Wennborg wrote: > > > > /sub > > > > I believe Vedant asked for this to be merged to 5.0, so I'd like to > > merge the resolution too. > > > > On Mon, Jul 31, 2017 at 8:51 AM, Nico Weber via cfe-commits > > wrote: &

Re: [PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

2017-08-01 Thread Nico Weber via cfe-commits
It'd be good if this could go in today. ubsanvptr has been broken for us for a while now. On Mon, Jul 31, 2017 at 4:43 PM, Vedant Kumar via Phabricator via cfe-commits wrote: > vsk created this revision. > > In r309007, I made -fsanitize=null a hard prerequisite for > -fsanitize=vptr. I did not

Re: [PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

2017-08-02 Thread Nico Weber via cfe-commits
Should clang warn if you request static libc++ on fuchsia? It now silently ignores the flag, right? On Aug 1, 2017 9:18 PM, "Petr Hosek via Phabricator via cfe-commits" < cfe-commits@lists.llvm.org> wrote: This revision was automatically updated to reflect the committed changes. Closed by commit

Re: [PATCH] D27827: [ObjC] CodeGen support for @available on macOS

2017-08-03 Thread Nico Weber via cfe-commits
On Thu, Aug 3, 2017 at 4:13 AM, Alex Lorenz via Phabricator via cfe-commits wrote: > arphaman added a comment. > > In https://reviews.llvm.org/D27827#829661, @thakis wrote: > > > We just noticed that if you call __builtin_available() for the first > time after activating your app's sandbox, the f

r309960 - Revert r304836.

2017-08-03 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Aug 3 09:46:17 2017 New Revision: 309960 URL: http://llvm.org/viewvc/llvm-project?rev=309960&view=rev Log: Revert r304836. See discussion in https://reviews.llvm.org/D33900#824172 Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL

r309984 - Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

2017-08-03 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Aug 3 14:06:36 2017 New Revision: 309984 URL: http://llvm.org/viewvc/llvm-project?rev=309984&view=rev Log: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name. This helps some tools that do things based on the output's extension. For example, we got reports

Re: r310030 - Revert r309984, "Use "foo-12345.o" instead of "foo.o-12345" as temporary file name."

2017-08-04 Thread Nico Weber via cfe-commits
Takumi provides some more details on IRC: The change broke http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux/builds/655/steps/build_stage2/logs/stdio , which uses modules. He says there's a race-condition: while clang emits ***-{tmp}.pcm, another clang collects *.pcm for the module i

r310376 - Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name.

2017-08-08 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Aug 8 09:21:23 2017 New Revision: 310376 URL: http://llvm.org/viewvc/llvm-project?rev=310376&view=rev Log: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name. This helps some tools that do things based on the output's extension. For example, we got repo

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

2017-08-09 Thread Nico Weber via cfe-commits
Any way we could put this behind a different flag (say, -Wenum-compare-switch, in the same group as -Wenum-compare, so that -W(no-)enum-compare affects both)? Our codebase was -Wenum-compare clean before this commit but is very not clean now, so we'd now have to disable -Wenum-compare altogether, b

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

2017-08-09 Thread Nico Weber via cfe-commits
On Wed, Aug 9, 2017 at 10:11 AM, Gábor Horváth wrote: > Sure! > > There was a follow-up patch that excluded anonymous enums. Is it still > that bad to introduce it under a new flag? > The follow-up was at r310468. https://build.chromium.org/p/chromium.fyi/ builders/ClangToTLinux/builds/8808 is w

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

2017-08-10 Thread Nico Weber via cfe-commits
I really believe this has way too many deps to live in the clang repro, as said on the review already. Maybe this could live in clang-extra instead? On Aug 8, 2017 4:15 PM, "Matt Morehouse via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: morehouse > Date: Tue Aug 8 13:15:04 2017 >

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

2017-08-10 Thread Nico Weber via cfe-commits
On Thu, Aug 10, 2017 at 2:04 PM, Kostya Serebryany wrote: > > > On Thu, Aug 10, 2017 at 10:56 AM, Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I really believe this has way too many deps to live in the clang repro, >> as said on the revi

Re: [clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

2017-08-10 Thread Nico Weber via cfe-commits
Not sure if you've seen it, this broke the Windows build: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/5880/steps/build%20stage%201/logs/stdio FAILED: C:\PROGRA~2\MICROS~3.0\VC\bin\amd64\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_N

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

2017-08-10 Thread Nico Weber via cfe-commits
On Thu, Aug 10, 2017 at 3:13 PM, Kostya Serebryany wrote: > > > On Thu, Aug 10, 2017 at 12:01 PM, Nico Weber wrote: > >> On Thu, Aug 10, 2017 at 2:04 PM, Kostya Serebryany >> wrote: >> >>> >>> >>> On Thu, Aug 10, 2017 at 10:56 AM, Ni

Re: r310382 - [Availability] Don't make an availability attribute imply default visibility on macOS

2017-08-15 Thread Nico Weber via cfe-commits
Do we want to merge this to 5.0? On Tue, Aug 8, 2017 at 1:09 PM, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: epilk > Date: Tue Aug 8 10:09:09 2017 > New Revision: 310382 > > URL: http://llvm.org/viewvc/llvm-project?rev=310382&view=rev > Log: > [Availability] Do

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

2017-08-21 Thread Nico Weber via cfe-commits
On Mon, Aug 21, 2017 at 12:41 PM, Reid Kleckner via Phabricator via cfe-commits wrote: > rnk added a comment. > > > Don't add any EH edges to the CFG for SEH. In practice, > BuildOpts.AddEHEdges is always false in practice from what I can tell, and > with SEH every single stmt would have to get a

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

2017-08-22 Thread Nico Weber via cfe-commits
rnk: ping :-) On Mon, Aug 21, 2017 at 1:43 PM, Nico Weber via Phabricator via cfe-commits wrote: > thakis added inline comments. > > > > Comment at: lib/Analysis/CFG.cpp:448 > +BuildOpts(buildOpts), switchExclusivelyCovered(false), > +switchCond(nullptr), cachedE

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

2017-08-22 Thread Nico Weber via cfe-commits
On Tue, Aug 22, 2017 at 5:56 PM, Reid Kleckner via Phabricator via cfe-commits wrote: > rnk added a comment. > > Looks functionally correct > > > > > Comment at: test/Sema/warn-unreachable-ms.c:42 > + } > +} > > Can we add a test to exercise that this builds the

r311561 - Implement CFG construction for __try / __except / __leave.

2017-08-23 Thread Nico Weber via cfe-commits
Author: nico Date: Wed Aug 23 08:33:16 2017 New Revision: 311561 URL: http://llvm.org/viewvc/llvm-project?rev=311561&view=rev Log: Implement CFG construction for __try / __except / __leave. This makes -Wunreachable-code work for programs containing SEH (except for __finally, which is still missin

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

2017-08-23 Thread Nico Weber via cfe-commits
On Tue, Aug 22, 2017 at 9:23 PM, Reid Kleckner via Phabricator via cfe-commits wrote: > rnk accepted this revision. > rnk added a comment. > This revision is now accepted and ready to land. > 311561, thanks! > Looks good! > > > > > Comment at: test/Sema/warn-unreachable-ms.c:4

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

2017-08-23 Thread Nico Weber via cfe-commits
On Wed, Aug 23, 2017 at 12:11 PM, Reid Kleckner via Phabricator via cfe-commits wrote: > rnk added inline comments. > > > > Comment at: test/Sema/warn-unreachable-ms.c:42 > + } > +} > > rnk wrote: > > rnk wrote: > > > Can we add a test to exercise that this buil

Re: [PATCH] D37090: Implement CFG construction for __finally.

2017-08-24 Thread Nico Weber via cfe-commits
I just realized that this doesn't do the right thing if the try body contains jumps out of the try. That's rare and the CFG is mostly used for warnings, but we should get that right anyhow I suppose. To fix this, I'd probably add a "ActiveFinally" member, and when building a node for a return, I'd

Re: [clang-tools-extra] dc93540 - Fix handling of newlines in clang-query

2019-12-29 Thread Nico Weber via cfe-commits
On Sun, Dec 29, 2019 at 6:59 AM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date: 2019-12-29T14:58:56Z > New Revision: dc93540acbf047cf54052568d2826d1a06df025e > > URL: > https://github.com/llvm/llvm-project/commit/dc93540acbf047cf54052568d2826d1a

[clang] ba3484c - [clang-format/java] format multiple qualified annotations on one declaration better

2020-01-03 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-01-03T12:11:44-05:00 New Revision: ba3484c051b62a662c555200f4a03b2e8df8e094 URL: https://github.com/llvm/llvm-project/commit/ba3484c051b62a662c555200f4a03b2e8df8e094 DIFF: https://github.com/llvm/llvm-project/commit/ba3484c051b62a662c555200f4a03b2e8df8e094.diff LO

[clang] 44e0daf - driver: Allow -fdebug-compilation-dir=foo in joined form.

2020-01-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-01-10T19:20:51-05:00 New Revision: 44e0daf16e6985eb44ea9a629402852dbff9cb0b URL: https://github.com/llvm/llvm-project/commit/44e0daf16e6985eb44ea9a629402852dbff9cb0b DIFF: https://github.com/llvm/llvm-project/commit/44e0daf16e6985eb44ea9a629402852dbff9cb0b.diff LO

Re: [clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

2020-01-13 Thread Nico Weber via cfe-commits
This breaks tests on Windows: http://45.33.8.238/win/5636/step_8.txt Likely the usual "doesn't work with delayed template parsing" thing. Can you take a look, and if it takes a while to fix, revert while you investigate? (I wouldn't said this on the phab issue, but couldn't find one.) On Mon, J

Re: [clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

2020-01-13 Thread Nico Weber via cfe-commits
Great, thanks! On Mon, Jan 13, 2020 at 4:04 PM Aaron Ballman wrote: > On Mon, Jan 13, 2020 at 2:25 PM Nico Weber wrote: > > > > This breaks tests on Windows: http://45.33.8.238/win/5636/step_8.txt > > > > Likely the usual "doesn't work with delayed template parsing" thing. > > > > Can you take

[clang] 84baf12 - try to fix InterfaceStubs/lambda.cpp on Windows after bd8c8827d96f0

2020-01-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-01-13T21:22:46-05:00 New Revision: 84baf123a5213512e92e7deca2d111e00c2b97da URL: https://github.com/llvm/llvm-project/commit/84baf123a5213512e92e7deca2d111e00c2b97da DIFF: https://github.com/llvm/llvm-project/commit/84baf123a5213512e92e7deca2d111e00c2b97da.diff LO

[clang] 8e5018e - Replace CLANG_SPAWN_CC1 env var with a driver mode flag

2020-01-15 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-01-15T12:22:40-05:00 New Revision: 8e5018e990b701391e6c33ba85b012343df67272 URL: https://github.com/llvm/llvm-project/commit/8e5018e990b701391e6c33ba85b012343df67272 DIFF: https://github.com/llvm/llvm-project/commit/8e5018e990b701391e6c33ba85b012343df67272.diff LO

[clang-tools-extra] 0ea2a57 - clangd: Make ompletionModelCodegen.py tpy2.7 compatible

2020-09-18 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-09-18T15:26:58-04:00 New Revision: 0ea2a57274225066ad81e971659222cf9ee1d12d URL: https://github.com/llvm/llvm-project/commit/0ea2a57274225066ad81e971659222cf9ee1d12d DIFF: https://github.com/llvm/llvm-project/commit/0ea2a57274225066ad81e971659222cf9ee1d12d.diff LO

[clang-tools-extra] 8077779 - CompletionModelCodegen: Remove unused import

2020-09-18 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-09-18T16:24:58-04:00 New Revision: 80913e82bece68a2f929ae17bd0e9ba38ab0 URL: https://github.com/llvm/llvm-project/commit/80913e82bece68a2f929ae17bd0e9ba38ab0 DIFF: https://github.com/llvm/llvm-project/commit/80913e82bece68a2f929ae17bd0e9ba38ab0.diff LO

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

2020-09-04 Thread Nico Weber via cfe-commits
Hi Richard, this breaks Wunreachable-code which now ignore "weak" on redeclarations: thakis@thakis:~/src/llvm-project$ cat foo.cc extern "C" void foo(void); extern "C" __attribute__((weak)) decltype(foo) foo; void g(), h(); void f() { if (foo) return g(); h(); } thakis@thakis:~/src

[clang] 7b03323 - Revert "Canonicalize declaration pointers when forming APValues."

2020-09-04 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-09-04T10:13:28-04:00 New Revision: 7b0332389afd705f46b02fcf87ec3414b8dece34 URL: https://github.com/llvm/llvm-project/commit/7b0332389afd705f46b02fcf87ec3414b8dece34 DIFF: https://github.com/llvm/llvm-project/commit/7b0332389afd705f46b02fcf87ec3414b8dece34.diff LO

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

2020-09-04 Thread Nico Weber via cfe-commits
To keep the bots greener over the long weekend, I went ahead and reverted this for now in 7b0332389afd705f46b02fcf87ec3414b8dece34. I'll add a test for this. On Fri, Sep 4, 2020 at 10:11 AM Nico Weber wrote: > Hi Richard, > > this breaks Wunreachable-code which now ignore "weak" on redeclaration

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

2020-09-04 Thread Nico Weber via cfe-commits
Test added in 85a9f6512a3cff797f1964c36c59d53e97a680c4 On Fri, Sep 4, 2020 at 10:14 AM Nico Weber wrote: > To keep the bots greener over the long weekend, I went ahead and reverted > this for now in 7b0332389afd705f46b02fcf87ec3414b8dece34. I'll add a test > for this. > > On Fri, Sep 4, 2020 at

[clang] 2a03f27 - clang: Add test for -Wunreachable-code + weak redeclaration

2020-09-04 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-09-04T10:35:50-04:00 New Revision: 2a03f270d69cf1079feb029f84727288e217588a URL: https://github.com/llvm/llvm-project/commit/2a03f270d69cf1079feb029f84727288e217588a DIFF: https://github.com/llvm/llvm-project/commit/2a03f270d69cf1079feb029f84727288e217588a.diff LO

Re: [clang] e6393ee - Canonicalize declaration pointers when forming APValues.

2020-09-04 Thread Nico Weber via cfe-commits
Actually in 2a03f270d69cf1079feb029f84727288e217588a On Fri, Sep 4, 2020 at 10:27 AM Nico Weber wrote: > Test added in 85a9f6512a3cff797f1964c36c59d53e97a680c4 > > On Fri, Sep 4, 2020 at 10:14 AM Nico Weber wrote: > >> To keep the bots greener over the long weekend, I went ahead and reverted >>

[clang-tools-extra] 9933188 - StructPackAlignCheck: Fix a -Winconsistent-missing-override warning

2020-09-08 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-09-08T10:02:00-04:00 New Revision: 9933188c90615c9c264ebb69117f09726e909a25 URL: https://github.com/llvm/llvm-project/commit/9933188c90615c9c264ebb69117f09726e909a25 DIFF: https://github.com/llvm/llvm-project/commit/9933188c90615c9c264ebb69117f09726e909a25.diff LO

[clang-tools-extra] 33c9dbb - Add an explicit toggle for the static analyzer in clang-tidy

2020-09-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-09-10T10:48:17-04:00 New Revision: 33c9dbbd380913e8ab7e5a8e82468f9f7d092187 URL: https://github.com/llvm/llvm-project/commit/33c9dbbd380913e8ab7e5a8e82468f9f7d092187 DIFF: https://github.com/llvm/llvm-project/commit/33c9dbbd380913e8ab7e5a8e82468f9f7d092187.diff LO

[clang-tools-extra] 29cecbc - Fix clangd build after 33c9dbbd380

2020-09-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-09-10T11:05:53-04:00 New Revision: 29cecbc5d6fe2ee36635d593171d59eab631639f URL: https://github.com/llvm/llvm-project/commit/29cecbc5d6fe2ee36635d593171d59eab631639f DIFF: https://github.com/llvm/llvm-project/commit/29cecbc5d6fe2ee36635d593171d59eab631639f.diff LO

Re: [clang-tools-extra] 156b127 - Add a new altera check for structure packing and alignment.

2020-09-10 Thread Nico Weber via cfe-commits
Looks like this broke the sphinx bot: http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs/builds/65757/steps/docs-clang-tools-html/logs/stdio Can you take a look? On Tue, Sep 8, 2020 at 9:36 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Frank Derry Wanye

[clang-tools-extra] de4f551 - Revert "[clangd] Extract per-dir CDB cache to its own threadsafe class. NFC"

2020-12-09 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-09T20:11:19-05:00 New Revision: de4f5519015cc97f28718d90cc6dac73c0a15161 URL: https://github.com/llvm/llvm-project/commit/de4f5519015cc97f28718d90cc6dac73c0a15161 DIFF: https://github.com/llvm/llvm-project/commit/de4f5519015cc97f28718d90cc6dac73c0a15161.diff LO

[clang] a5c65de - mac/arm: XFAIL the last 3 failing tests

2020-12-12 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-12T15:09:17-05:00 New Revision: a5c65de2953e755532da2e171e452d11e80d4714 URL: https://github.com/llvm/llvm-project/commit/a5c65de2953e755532da2e171e452d11e80d4714 DIFF: https://github.com/llvm/llvm-project/commit/a5c65de2953e755532da2e171e452d11e80d4714.diff LO

[clang] 956034c - [mac/arm] XFAIL two more tests on arm64-apple

2020-12-12 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-12T15:20:50-05:00 New Revision: 956034c6c894d1291306baed2e59e51c16e5df70 URL: https://github.com/llvm/llvm-project/commit/956034c6c894d1291306baed2e59e51c16e5df70 DIFF: https://github.com/llvm/llvm-project/commit/956034c6c894d1291306baed2e59e51c16e5df70.diff LO

[clang] c9ede6f - Revert "[amdgpu] Default to code object v3"

2020-12-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-14T22:01:26-05:00 New Revision: c9ede6f3367a627baeef78f30d18078af9a4ffca URL: https://github.com/llvm/llvm-project/commit/c9ede6f3367a627baeef78f30d18078af9a4ffca DIFF: https://github.com/llvm/llvm-project/commit/c9ede6f3367a627baeef78f30d18078af9a4ffca.diff LO

[clang-tools-extra] 7799ef7 - Revert "Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef"

2020-12-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-14T22:05:08-05:00 New Revision: 7799ef7121aa7d59f4bd95cdf70035de724ead6f URL: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f DIFF: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f.diff LO

[clang] 7799ef7 - Revert "Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef"

2020-12-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-14T22:05:08-05:00 New Revision: 7799ef7121aa7d59f4bd95cdf70035de724ead6f URL: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f DIFF: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f.diff LO

[clang] 49c248b - clang-cl: Remove /Zd flag

2020-12-17 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-17T15:39:40-05:00 New Revision: 49c248bd62a3cb2f0e7e3991ee0190943bd2bbec URL: https://github.com/llvm/llvm-project/commit/49c248bd62a3cb2f0e7e3991ee0190943bd2bbec DIFF: https://github.com/llvm/llvm-project/commit/49c248bd62a3cb2f0e7e3991ee0190943bd2bbec.diff LO

[clang] 00065d5 - Revert "-fstack-clash-protection: Return an actual error when used on unsupported OS"

2020-12-22 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-22T06:51:19-05:00 New Revision: 00065d5cbd02b0f3fccb34881b58bcd0852b3970 URL: https://github.com/llvm/llvm-project/commit/00065d5cbd02b0f3fccb34881b58bcd0852b3970 DIFF: https://github.com/llvm/llvm-project/commit/00065d5cbd02b0f3fccb34881b58bcd0852b3970.diff LO

[clang] 1876a29 - Revert more changes that landed on top of 741978d727

2020-12-23 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-23T14:20:21-05:00 New Revision: 1876a2914fe0bedf50f7be6a305f5bf35493e496 URL: https://github.com/llvm/llvm-project/commit/1876a2914fe0bedf50f7be6a305f5bf35493e496 DIFF: https://github.com/llvm/llvm-project/commit/1876a2914fe0bedf50f7be6a305f5bf35493e496.diff LO

[clang] 4c37453 - clang: Build and run FrontendTests with CLANG_ENABLE_STATIC_ANALYZER=OFF too

2020-12-23 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-23T14:27:09-05:00 New Revision: 4c37453a04f942dd676af1eda5d0760d4ffe8927 URL: https://github.com/llvm/llvm-project/commit/4c37453a04f942dd676af1eda5d0760d4ffe8927 DIFF: https://github.com/llvm/llvm-project/commit/4c37453a04f942dd676af1eda5d0760d4ffe8927.diff LO

[clang] b69af88 - [gn build] (manually) port 82f86ae01

2020-11-05 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-11-05T14:11:26-05:00 New Revision: b69af88481aa88e04ff4490dc8d420ec570ec0f1 URL: https://github.com/llvm/llvm-project/commit/b69af88481aa88e04ff4490dc8d420ec570ec0f1 DIFF: https://github.com/llvm/llvm-project/commit/b69af88481aa88e04ff4490dc8d420ec570ec0f1.diff LO

[clang] 3109ce5 - clang-cl: Expose -f[no-]delete-null-pointer-checks as clang-cl flag

2020-11-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-11-11T09:19:02-05:00 New Revision: 3109ce51d465b7c6e40f855bd88776654eaf08cc URL: https://github.com/llvm/llvm-project/commit/3109ce51d465b7c6e40f855bd88776654eaf08cc DIFF: https://github.com/llvm/llvm-project/commit/3109ce51d465b7c6e40f855bd88776654eaf08cc.diff LO

[clang] 46ca880 - clang: Don't assert on no_unique_address fields in @encode()

2020-11-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-11-13T11:39:10-05:00 New Revision: 46ca880fcae24693d381ca05c16c704675545433 URL: https://github.com/llvm/llvm-project/commit/46ca880fcae24693d381ca05c16c704675545433 DIFF: https://github.com/llvm/llvm-project/commit/46ca880fcae24693d381ca05c16c704675545433.diff LO

[clang] ba60dc0 - Revert "[Driver] Move detectLibcxxIncludePath to ToolChain"

2020-10-03 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-10-03T14:22:53-04:00 New Revision: ba60dc0aa75e86165e260b2c08afafd1c394e95a URL: https://github.com/llvm/llvm-project/commit/ba60dc0aa75e86165e260b2c08afafd1c394e95a DIFF: https://github.com/llvm/llvm-project/commit/ba60dc0aa75e86165e260b2c08afafd1c394e95a.diff LO

[clang] c473184 - [mac/arm] Fix clang/test/Sema/wchar.c on mac/arm hosts

2020-11-20 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-11-20T21:49:17-05:00 New Revision: c47318491439642ed47cb9c9098333a8199fa54a URL: https://github.com/llvm/llvm-project/commit/c47318491439642ed47cb9c9098333a8199fa54a DIFF: https://github.com/llvm/llvm-project/commit/c47318491439642ed47cb9c9098333a8199fa54a.diff LO

[clang] e91b234 - [mac/arm] Fix test/Driver/darwin-sdk-version.c on arm macs

2020-11-20 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-11-20T22:32:31-05:00 New Revision: e91b2344ad7294c47d8b10b3a84e962bc3ed4160 URL: https://github.com/llvm/llvm-project/commit/e91b2344ad7294c47d8b10b3a84e962bc3ed4160 DIFF: https://github.com/llvm/llvm-project/commit/e91b2344ad7294c47d8b10b3a84e962bc3ed4160.diff LO

Re: [clang-tools-extra] 76bd444 - Fix tests for clang-query completion

2020-11-23 Thread Nico Weber via cfe-commits
Thanks for fixing the tests, but didn't the tests point out a true regression in clang-query functionality here? On Mon, Nov 23, 2020 at 10:23 AM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date: 2020-11-23T15:23:13Z > New Revision: 76bde3619

<    1   2   3   4   5   6   7   8   9   10   >