We're looking at turning this one.
One thing that this warns about that's a false positive where we've seen it
is this code for nested arrays:
float m[4][4];
for (int i = 0; i < sizeof(m) / sizeof(**m); ++i) (&**m)[i] = 0;
(Why would anyone write code like this? It's a reduced example; consi
That was fast. Thanks much! :)
On Mon, Sep 23, 2019 at 8:52 AM Dávid Bolvanský
wrote:
> Hello,
>
> Thanks for the proposed idea, implemented in rL372600.
>
> po 23. 9. 2019 o 14:23 Nico Weber napísal(a):
>
>> We're looking at turning this one.
>>
>> One thing that this warns about that's a fals
It still warns if the inner array is in a struct. That's probably ok though.
struct Point {
int xy[2];
};
void f() {
Point points[3];
for (int i = 0; i < sizeof(points) / sizeof(int); ++i)
(&points[0].xy[0])[i] = 0;
}
On Mon, Sep 23, 2019 at 8:54 AM Nico Weber wrote:
> That was fast.
Even after all the fixup attempts, there's still a failing
clang-tools-extra test:
ninja: Entering directory `out/gn'
[0/2] ACTION
//clang-tools-extra/test:check-clang-tools(//llvm/utils/gn/build/toolchain:unix)
-- Testing: 787 tests, 64 threads --
Testing: 0 .. 10
FAIL: Clang Tools :: clang-tidy/
Is it possible that this broke Tooling/clang-diff-ast.cpp
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/11395/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aclang-diff-ast.cpp
?
On Wed, Sep 25, 2019 at 9:07 AM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org>
Author: nico
Date: Fri Sep 27 05:56:14 2019
New Revision: 373082
URL: http://llvm.org/viewvc/llvm-project?rev=373082&view=rev
Log:
clang-tidy: Don't repeat list of all checks in three places.
Instead, put all checks in a cmake variable and reference this.
Also, make clangd use the the ClangTidyF
This broke a few clangd unit tests:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/38857/steps/ninja%20check%201/logs/FAIL%3A%20Clangd%20Unit%20Tests%3A%3AHover.Structured
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/38857/steps/ninja%20check%201/logs/FAIL%3A%20Clangd
Can we move this behind a Wenum-compare subgroup, say Wenum-compare-type?
Our codebase is (well, was) Wenum-compare clean, and this new warnings
fires pretty often and from a first quick glance the warning looks pretty
low-signal anyways (*). Maybe the subgroup shouldn't even be on by default
-- do
Thanks!
Any thoughts on the true positive rate for this warning?
On Tue, Oct 1, 2019 at 11:43 AM Dávid Bolvanský
wrote:
> Yeah, I moved this warning into own subgroup in rL373345. Thanks.
>
> ut 1. 10. 2019 o 16:24 Nico Weber napísal(a):
> >
> > Can we move this behind a Wenum-compare subgroup
Chromium shouldn't be a factor for determining is a warning is on or off by
default. We can easily turn warnings off, and I had done so in
http://crrev.com/http://crrev.com/701604 (as long as warnings have a
dedicated flag -- but that's needed for every large codebase adopting a new
clang). So that
This breaks emaCXX/warn-sign-conversion.cpp -- but see other thread, maybe
just revert this for now until we know what we want to do here :)
On Tue, Oct 1, 2019 at 2:10 PM David Bolvansky via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: xbolva00
> Date: Tue Oct 1 11:12:13 2019
> Ne
All other tablegen outputs are called .inc instead of .def. Any reason this
one's different?
On Tue, Oct 1, 2019 at 7:10 PM John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rjmccall
> Date: Tue Oct 1 16:13:03 2019
> New Revision: 373407
>
> URL: http://llvm.org/viewvc/l
I think that'd be nice; I believe I renamed one .def output with the same
history for the same reason a while ago.
On Tue, Oct 1, 2019 at 9:25 PM John McCall wrote:
> On 1 Oct 2019, at 21:20, Nico Weber wrote:
> > All other tablegen outputs are called .inc instead of .def. Any reason
> > this
>
On Wed, Oct 2, 2019 at 2:33 AM John McCall wrote:
> On 1 Oct 2019, at 21:31, Nico Weber wrote:
> > I think that'd be nice; I believe I renamed one .def output with the
> > same
> > history for the same reason a while ago.
>
> r373425
>
Thanks!
>
> John.
>
> >
> > On Tue, Oct 1, 2019 at 9:25 PM
Looks like this broke a bunch of tests:
http://lab.llvm.org:8011/builders/clang-cuda-build/builds/37720/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aobject.cpp
http://lab.llvm.org:8011/builders/clang-cuda-build/builds/37720/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adriver-test.c
If i
Thanks!
If it takes a few hours to investigate, I think it's better to revert first
and then investigate while the tree is green.
On Mon, Sep 30, 2019 at 4:43 PM Keane, Erich wrote:
> Should be fixe din r373259
>
>
>
> *From:* Nico Weber
> *Sent:* Monday, September 30, 2019 12:50 PM
> *To:* Ke
Author: nico
Date: Wed Oct 2 19:38:43 2019
New Revision: 373556
URL: http://llvm.org/viewvc/llvm-project?rev=373556&view=rev
Log:
Revert 373538 and follow-ups 373549 and 373552.
They break tests on (at least) macOS.
Added:
cfe/trunk/test/InterfaceStubs/object.cpp
Removed:
cfe/trunk/lib/
../../clang/lib/Sema/SemaExpr.cpp:13481:25: error: no member named
'warn_bitwise_negation_bool' in namespace 'clang::diag'
Diag(OpLoc, diag::warn_bitwise_negation_bool)
~~^
1 error generated.
On Thu, Oct 3, 2019 at 11:16 AM David Bolvansky via cfe-commits <
cfe-commits@
Thanks for the fix!
This seems like a very safe warning from a distance, so I too hope that it
won't fire. I'll let you know how it goes.
If you're very curious,
https://ci.chromium.org/p/chromium/g/chromium.clang/console are our bots
that build trunk clang and then chromium with it.
(Currently
Looks like this fails on Windows:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio
On Thu, Oct 3, 2019 at 4:47 PM Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: abataev
> Date: Thu Oct 3 13:49:48 2019
> New Rev
In the interest of completeness, we now had our first true positive with
this warning, here:
https://github.com/KhronosGroup/VK-GL-CTS/blob/master/framework/referencerenderer/rrFragmentOperations.cpp#L603
(and another self-assign operator= unittest in that repo).
On Fri, Apr 13, 2018 at 3:00 AM, J
Also, we only use auto if the type of the variable is clear. Changes like
- for (ModuleFile &I : llvm::reverse(ModuleMgr)) {
+ for (auto &I : llvm::reverse(ModuleMgr)) {
are not desired.
On Sat, Apr 14, 2018, 11:09 AM Malcolm Parsons via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On S
On Mon, Apr 16, 2018 at 5:11 AM, Roman Lebedev via Phabricator via
cfe-commits wrote:
> lebedev.ri added a comment.
>
> Re false-positives - at least two [post-]reviewers need to agree on the
> way forward (see previous comments, mail thread), and then i will implement
> it.
>
> In https://review
+1 to just adding a dedicated Wno flag for the new warning instead of
coming up with this new spelling.
On Mon, Apr 16, 2018, 3:41 PM Roman Lebedev via Phabricator via cfe-commits
wrote:
> lebedev.ri added a comment.
>
> Uuuh, the fact that phab posts the top-postings, but silently ignores
> inl
Author: nico
Date: Fri Apr 20 06:10:44 2018
New Revision: 330427
URL: http://llvm.org/viewvc/llvm-project?rev=330427&view=rev
Log:
clang-cl: Accept (and ignore) /Zc:__cplusplus.
See
https://blogs.msdn.microsoft.com/vcblog/2018/04/09/msvc-now-correctly-reports-__cplusplus/
clang-cl already sets _
In any case, when you see a test failing on bots and the fix isn't obvious,
revert first to get the bots back green.
On Mon, Apr 23, 2018 at 8:54 AM, Andrew V. Tischenko via Phabricator via
cfe-commits wrote:
> avt77 reopened this revision.
> avt77 added a comment.
> This revision is now accepte
Author: nico
Date: Mon Apr 23 08:26:15 2018
New Revision: 330601
URL: http://llvm.org/viewvc/llvm-project?rev=330601&view=rev
Log:
Remove unused code (made unused by r161073, and later more so by r248043).
Modified:
cfe/trunk/tools/diagtool/CMakeLists.txt
Modified: cfe/trunk/tools/diagtool/C
Author: nico
Date: Mon Apr 23 08:41:08 2018
New Revision: 330604
URL: http://llvm.org/viewvc/llvm-project?rev=330604&view=rev
Log:
Fix case of LLVM library names.
Modified:
cfe/trunk/tools/clang-import-test/CMakeLists.txt
Modified: cfe/trunk/tools/clang-import-test/CMakeLists.txt
URL:
http:
Author: nico
Date: Mon Apr 23 12:22:52 2018
New Revision: 330633
URL: http://llvm.org/viewvc/llvm-project?rev=330633&view=rev
Log:
Fix typo in comment.
Modified:
cfe/trunk/tools/libclang/CMakeLists.txt
Modified: cfe/trunk/tools/libclang/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-projec
On Mon, Apr 23, 2018 at 11:53 AM, Andrew V. Tischenko via Phabricator via
cfe-commits wrote:
> avt77 added a comment.
>
> In https://reviews.llvm.org/D45619#1075437, @bjope wrote:
>
> > I can't see that it has been reverted.
> > But I guess that the table maybe is sorted based on time spent in e
Author: nico
Date: Mon Apr 23 18:30:44 2018
New Revision: 330674
URL: http://llvm.org/viewvc/llvm-project?rev=330674&view=rev
Log:
Make add_clang_tool() formatting a bit more consistent.
Modified:
cfe/trunk/tools/clang-rename/CMakeLists.txt
Modified: cfe/trunk/tools/clang-rename/CMakeLists.t
So you're happy with this opt-in version?
On Tue, Apr 24, 2018 at 1:29 PM, Marshall Clow via Phabricator via
cfe-commits wrote:
> mclow.lists added a comment.
>
> In https://reviews.llvm.org/D45179#1056183, @rjmccall wrote:
>
> > Is Marshall arguing that the standard doesn't allow compilers to w
Author: nico
Date: Wed Apr 25 09:20:43 2018
New Revision: 330839
URL: http://llvm.org/viewvc/llvm-project?rev=330839&view=rev
Log:
Make add_clang_unittest formatting a bit more consistent.
Modified:
cfe/trunk/unittests/ASTMatchers/CMakeLists.txt
cfe/trunk/unittests/ASTMatchers/Dynamic/CMa
Nit: The comment just repeats what the line below it says.
Does this have an observable effect? If so, should this have a test?
On Fri, Apr 27, 2018 at 12:11 PM, Nirav Dave via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: niravd
> Date: Fri Apr 27 09:11:24 2018
> New Revision: 3310
Author: nico
Date: Fri Apr 27 12:11:14 2018
New Revision: 331069
URL: http://llvm.org/viewvc/llvm-project?rev=331069&view=rev
Log:
s/LLVM_ON_WIN32/_WIN32/, clang
LLVM_ON_WIN32 is set exactly with MSVC and MinGW (but not Cygwin) in
HandleLLVMOptions.cmake, which is where _WIN32 defined too. Just
Author: nico
Date: Fri Apr 27 13:29:57 2018
New Revision: 331077
URL: http://llvm.org/viewvc/llvm-project?rev=331077&view=rev
Log:
Revert r329698 (and r329702).
Speculative. ClangMoveTests started failing on
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9958
after this change. I c
Looks like this helped :-/
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10262
On Fri, Apr 27, 2018, 4:33 PM Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Fri Apr 27 13:29:57 2018
> New Revision: 331077
>
> URL: h
Author: nico
Date: Sat Apr 28 16:48:36 2018
New Revision: 331124
URL: http://llvm.org/viewvc/llvm-project?rev=331124&view=rev
Log:
Remove unused includes of clang/Config/config.h
Found by opening config.h.cmake in vim, finding all defined macros with
/define\(01\)\? \zs[A-Za-z0-9_]*
:%s//\=s
Author: nico
Date: Sun Apr 29 16:05:11 2018
New Revision: 331150
URL: http://llvm.org/viewvc/llvm-project?rev=331150&view=rev
Log:
Move _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS macro to build system
_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS is currently used to
bring back std::un
This should have said "Patch from Taiju Tsuiki ",
apologies.
On Sun, Apr 29, 2018 at 7:05 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Sun Apr 29 16:05:11 2018
> New Revision: 331150
>
> URL: http://llvm.org/viewvc/l
Author: nico
Date: Mon Apr 30 06:47:04 2018
New Revision: 331176
URL: http://llvm.org/viewvc/llvm-project?rev=331176&view=rev
Log:
Remove unnecessary indirection. No behavior change.
Modified:
cfe/trunk/lib/Driver/ToolChains/MSVC.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/MSVC.cpp
URL:
h
Author: nico
Date: Mon Apr 30 06:52:15 2018
New Revision: 331177
URL: http://llvm.org/viewvc/llvm-project?rev=331177&view=rev
Log:
IWYU for llvm-config.h in clang. See r331124 for details.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
cfe/trunk/li
m.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/1304
>
> Would you please investigate?
>
> --
> Maxim Kuvyrkov
> www.linaro.org
>
>
>
> > On Apr 30, 2018, at 2:10 AM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
>
Author: nico
Date: Thu May 3 05:44:27 2018
New Revision: 331450
URL: http://llvm.org/viewvc/llvm-project?rev=331450&view=rev
Log:
Fix test failure for missing _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS
This is a follow-up change to r331150. The CL moved the macro from individual
file to b
>> - http://lab.llvm.org:8011/builders/libcxx-libcxxabi-
>> libunwind-armv7-linux/builds/87
>> - http://lab.llvm.org:8011/builders/libcxx-libcxxabi-
>> libunwind-aarch64-linux/builds/1304
>>
>> Would you please investigate?
>>
>> --
>> Maxim Kuvy
When reverting things, please say why in the commit message. (In this case,
apparently because it broke the lldb buildbots?)
On Mon, Jun 25, 2018 at 12:30 PM Gabor Marton via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: martong
> Date: Mon Jun 25 09:25:30 2018
> New Revision: 335491
Author: nico
Date: Wed Jun 27 05:05:06 2018
New Revision: 335725
URL: http://llvm.org/viewvc/llvm-project?rev=335725&view=rev
Log:
Add regression test for PR37935.
Modified:
cfe/trunk/test/SemaCXX/cxx-deprecated.cpp
Modified: cfe/trunk/test/SemaCXX/cxx-deprecated.cpp
URL:
http://llvm.org/vi
Here's another regression that was introduced by the patch:
https://bugs.llvm.org/show_bug.cgi?id=37935 I landed a test for that in
r335725 (in case you're wondering why there's a new test failure when you
reland).
Thanks for working on this!
On Tue, Jun 26, 2018 at 9:03 AM Michael Kruse via cfe-
Author: nico
Date: Mon Jul 2 05:31:20 2018
New Revision: 336097
URL: http://llvm.org/viewvc/llvm-project?rev=336097&view=rev
Log:
[ms] Fix mangling of char16_t and char32_t to be compatible with MSVC.
MSVC limits char16_t and char32_t string literal names to 32 bytes of character
data, not to 32
Author: nico
Date: Tue Jul 17 07:20:02 2018
New Revision: 337285
URL: http://llvm.org/viewvc/llvm-project?rev=337285&view=rev
Log:
Remove superfluous ; to fix -Wpedantic warning from gcc
Modified:
cfe/trunk/unittests/AST/ASTImporterTest.cpp
Modified: cfe/trunk/unittests/AST/ASTImporterTest.c
Author: nico
Date: Tue Jul 17 08:07:40 2018
New Revision: 337290
URL: http://llvm.org/viewvc/llvm-project?rev=337290&view=rev
Log:
clang-cl: Postpone Wmsvc-not-found emission until link.exe gets used.
Wmsvc-not-found was added in r297851 to help diagnose why link.exe can't be
executed. However, i
Author: nico
Date: Wed Jul 18 04:55:03 2018
New Revision: 337381
URL: http://llvm.org/viewvc/llvm-project?rev=337381&view=rev
Log:
Mention clang-cl improvements from r335466 and r336379 in ReleaseNotes.rst
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
UR
I think normally we don't set all these svn properties. Did you set them
intentionally?
On Thu, Jul 5, 2018 at 1:28 PM Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Thu Jul 5 10:23:15 2018
> New Revision: 336380
>
> URL: http://llvm.org/viewvc/llvm
FWIW I found the "always evaluates to 'true'" bit important to understand
the warning.
We did hit this (at least once) in Chromium after all [1] (looks like a
real bug – nothing for you to do about that, and thanks for the warning),
and I don't think I would've understood what the warning wanted f
I gave this another try now that we have a compiler with rL372600. Another
thing the warning currently warns on is code like this:
char memory[kOpcodeMemory];
OpcodeFactory opcode_maker(memory, sizeof(memory));
size_t count = sizeof(memory) / sizeof(PolicyOpcode);
or
int32_t fds[sizeof(b
Author: nico
Date: Mon Oct 7 10:55:05 2019
New Revision: 373932
URL: http://llvm.org/viewvc/llvm-project?rev=373932&view=rev
Log:
Try to get clangd tests passing on Windows.
Part of PR43592. See also r328645.
Modified:
clang-tools-extra/trunk/clangd/test/semantic-highlighting.test
clang
Author: nico
Date: Mon Oct 7 12:54:19 2019
New Revision: 373951
URL: http://llvm.org/viewvc/llvm-project?rev=373951&view=rev
Log:
Attempt to fix a few clang-tidy tests on Windows, see PR43593.
Modified:
clang-tools-extra/trunk/test/clang-tidy/bugprone-branch-clone.cpp
clang-tools-extra/
Almost: http://45.33.8.238/win/78/step_6.txt
C:\src\llvm-project\clang\test\CodeGen\ubsan-blacklist-vfs.c:11:25: error:
INVALID-MAPPED-FILE: expected string not found in input
// INVALID-MAPPED-FILE: invalid-virtual-file.blacklist': No such file or
directory
^
:1:1: note: s
Author: nico
Date: Tue Oct 8 12:14:34 2019
New Revision: 374103
URL: http://llvm.org/viewvc/llvm-project?rev=374103&view=rev
Log:
Try to get readability-deleted-default.cpp to pass on Windows.
In MS compatibility mode, "extern inline void g()" is not a redundant
declaration for "inline void g()"
Author: nico
Date: Tue Oct 8 12:25:49 2019
New Revision: 374105
URL: http://llvm.org/viewvc/llvm-project?rev=374105&view=rev
Log:
Try to get ubsan-blacklist-vfs.c pass more on Windows
Modified:
cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c
Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs
Looks like this breaks three clangd tests on macOS:
Failing Tests (3):
Clangd :: code-action-request.test
Clangd :: execute-command.test
Clangd :: tweaks-format.test
libc++abi.dylib: terminating with uncaught exception of type
std::__1::system_error: mutex lock failed: Invalid argumen
FWIW reverting a patch for it breaking some internal system seems like poor
form to me. It's really hard to reland in that case. Please make a reduced
repro next time.
On Wed, Oct 9, 2019 at 5:38 AM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Reverted in r374151.
>
> On W
Author: nico
Date: Thu Oct 10 14:34:32 2019
New Revision: 374456
URL: http://llvm.org/viewvc/llvm-project?rev=374456&view=rev
Log:
Revert 374450 "Fix __builtin_assume_aligned with too large values."
The test fails on Windows, with
error: 'warning' diagnostics expected but not seen:
File bu
Author: nico
Date: Thu Oct 10 19:44:20 2019
New Revision: 374503
URL: http://llvm.org/viewvc/llvm-project?rev=374503&view=rev
Log:
Revert 374481 "[tsan,msan] Insert module constructors in a module pass"
CodeGen/sanitizer-module-constructor.c fails on mac and windows, see e.g.
http://lab.llvm.org:
Author: nico
Date: Fri Oct 11 05:27:51 2019
New Revision: 374543
URL: http://llvm.org/viewvc/llvm-project?rev=374543&view=rev
Log:
[MS ABI]: Fix mangling function arguments for template types to be compatible
with MSVC
MS name mangling supports cache for first 10 distinct function
arguments. Th
It's cool we finally have a flag for this, but overloading its meaning with
the =0 behavior seems a bit strange to me. Maybe we should have a separate
-fno-gnu-extensions for that part instead?
On Thu, Oct 10, 2019 at 5:02 PM Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Au
Author: nico
Date: Sat Oct 12 15:58:34 2019
New Revision: 374688
URL: http://llvm.org/viewvc/llvm-project?rev=374688&view=rev
Log:
Revert r374663 "[clang-format] Proposal for clang-format to give compiler style
warnings"
The test fails on macOS and looks a bit wrong, see comments on the review.
Author: nico
Date: Sun Oct 13 06:15:27 2019
New Revision: 374718
URL: http://llvm.org/viewvc/llvm-project?rev=374718&view=rev
Log:
Make most clangd unittests pass on Windows
The Windows triple currently turns on delayed template parsing, which
confuses several unit tests that use templates.
For
Author: nico
Date: Sun Oct 13 10:19:00 2019
New Revision: 374727
URL: http://llvm.org/viewvc/llvm-project?rev=374727&view=rev
Log:
Make the last to clangd unit tests pass on Windows.
(Some lit tests still fail.)
See FIXME in diff for details.
Part of PR43592.
Modified:
clang-tools-extra/tr
Author: nico
Date: Sun Oct 13 10:43:16 2019
New Revision: 374730
URL: http://llvm.org/viewvc/llvm-project?rev=374730&view=rev
Log:
Add missing "REQUIRES: shell" to system-include-extractor.test
Part of PR43592.
Modified:
clang-tools-extra/trunk/clangd/test/system-include-extractor.test
Modi
Author: nico
Date: Sun Oct 13 17:45:02 2019
New Revision: 374745
URL: http://llvm.org/viewvc/llvm-project?rev=374745&view=rev
Log:
Don't run background-index.test on Windows.
The test had a "UNSUPPORTED: win32" line, but the spelling of that
changed in r339307 a year ago. Finally update this test
Author: nico
Date: Sun Oct 13 18:00:33 2019
New Revision: 374746
URL: http://llvm.org/viewvc/llvm-project?rev=374746&view=rev
Log:
Make code-action-request.test and request-reply.test pass on Windows.
clangd's test:// scheme expands to /clangd-test on non-Win and to
C:/clang-test on Win, so it ca
Author: nico
Date: Sun Oct 13 18:19:53 2019
New Revision: 374747
URL: http://llvm.org/viewvc/llvm-project?rev=374747&view=rev
Log:
Make symbols.test pass on Windows.
See commit message of r374746 for details.
Hopefully final bit of PR43592.
Modified:
clang-tools-extra/trunk/clangd/test/Inpu
Author: nico
Date: Sun Oct 13 18:41:56 2019
New Revision: 374749
URL: http://llvm.org/viewvc/llvm-project?rev=374749&view=rev
Log:
Prefer 'env not' over 'not env' in tests.
That way, lit's builtin 'env' command can be used for the 'env' bit.
Also it's clearer that way that the 'not' shouldn't co
Author: nico
Date: Sun Oct 13 18:41:56 2019
New Revision: 374749
URL: http://llvm.org/viewvc/llvm-project?rev=374749&view=rev
Log:
Prefer 'env not' over 'not env' in tests.
That way, lit's builtin 'env' command can be used for the 'env' bit.
Also it's clearer that way that the 'not' shouldn't co
Author: nico
Date: Sun Oct 13 18:44:29 2019
New Revision: 374750
URL: http://llvm.org/viewvc/llvm-project?rev=374750&view=rev
Log:
fix typo in 374747
Modified:
clang-tools-extra/trunk/clangd/test/symbols.test
Modified: clang-tools-extra/trunk/clangd/test/symbols.test
URL:
http://llvm.org/vi
Author: nico
Date: Sun Oct 13 19:14:18 2019
New Revision: 374751
URL: http://llvm.org/viewvc/llvm-project?rev=374751&view=rev
Log:
convert a test to unix line endings
Modified:
clang-tools-extra/trunk/clangd/test/symbols.test
Modified: clang-tools-extra/trunk/clangd/test/symbols.test
URL:
h
Author: nico
Date: Sun Oct 13 19:21:12 2019
New Revision: 374752
URL: http://llvm.org/viewvc/llvm-project?rev=374752&view=rev
Log:
convert another test to unix line endings
Modified:
clang-tools-extra/trunk/clangd/test/symbol-info.test
Modified: clang-tools-extra/trunk/clangd/test/symbol-inf
Author: nico
Date: Sun Oct 13 20:44:47 2019
New Revision: 374753
URL: http://llvm.org/viewvc/llvm-project?rev=374753&view=rev
Log:
clangd tests: use extended regex with sed
The escaped parens seem to confuse the combination of lit, cygwin
quoting, and cygwin's sed. unxutils sed in cmd.exe is fine
This fails on both win and mac:
http://45.33.8.238/mac/1678/step_6.txt
http://45.33.8.238/win/485/step_6.txt
On Mon, Oct 14, 2019 at 6:25 PM Jian Cai via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jcai19
> Date: Mon Oct 14 15:28:03 2019
> New Revision: 374834
>
> URL: http://llvm
Hm, this means the test can't run on non-linux, so if someone breaks it on
e.g. win they won't see the failure. Maybe add a
--target=i386-unknown-linux instead? Then it might pass on all platforms.
On Mon, Oct 14, 2019 at 6:48 PM Jian Cai via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Aut
Author: nico
Date: Tue Oct 15 07:46:39 2019
New Revision: 374899
URL: http://llvm.org/viewvc/llvm-project?rev=374899&view=rev
Log:
Revert 374882 "[Concepts] Concept Specialization Expressions"
This reverts commit ec87b003823d63f3342cf648f55a134c1522e612.
The test fails on Windows, see e.g.
http:/
Author: nico
Date: Wed Oct 16 03:23:53 2019
New Revision: 374985
URL: http://llvm.org/viewvc/llvm-project?rev=374985&view=rev
Log:
Revert 374967 "[Concepts] ConceptSpecializationExprs mangling"
This reverts commit 5e34ad109ced8dbdea9500ee28180315b2aeba3d.
The mangling test fails on Windows:
http
This breaks tests: http://45.33.8.238/linux/18215/step_7.txt
On Wed, May 20, 2020 at 7:05 PM Kirstóf Umann via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> Author: Kirstóf Umann
> Date: 2020-05-21T01:05:15+02:00
> New Revision: 1d393eac8f6907074138612e18d5d1da803b4ad0
>
> URL:
> https://g
Author: Nico Weber
Date: 2020-05-21T15:49:46-04:00
New Revision: 1108f5c737dbdab0277874a7e5b237491839c43a
URL:
https://github.com/llvm/llvm-project/commit/1108f5c737dbdab0277874a7e5b237491839c43a
DIFF:
https://github.com/llvm/llvm-project/commit/1108f5c737dbdab0277874a7e5b237491839c43a.diff
LO
Author: Nico Weber
Date: 2020-06-03T06:49:50-04:00
New Revision: fd2740143e626ca32432aac0b51b2880a3b1e0bc
URL:
https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc
DIFF:
https://github.com/llvm/llvm-project/commit/fd2740143e626ca32432aac0b51b2880a3b1e0bc.diff
LO
Author: Nico Weber
Date: 2020-04-05T12:56:41-04:00
New Revision: ccabe9329857141e0b676951ff89092d7f88bed0
URL:
https://github.com/llvm/llvm-project/commit/ccabe9329857141e0b676951ff89092d7f88bed0
DIFF:
https://github.com/llvm/llvm-project/commit/ccabe9329857141e0b676951ff89092d7f88bed0.diff
LO
Author: Nico Weber
Date: 2020-04-05T13:07:50-04:00
New Revision: e01ec11882d3a2af509ec5caf248ecd79485240c
URL:
https://github.com/llvm/llvm-project/commit/e01ec11882d3a2af509ec5caf248ecd79485240c
DIFF:
https://github.com/llvm/llvm-project/commit/e01ec11882d3a2af509ec5caf248ecd79485240c.diff
LO
The test here flakily fails, maybe 1 in 10 times:
http://45.33.8.238/mac/11180/step_7.txt
error: 'error' diagnostics seen but not expected:
File
/Users/thakis/src/llvm-project/clang/test/SemaObjC/parameterized_classes_subst.m
Line 479: type argument 'T' (aka 'id') does not satisfy the bound
('id
Author: Nico Weber
Date: 2020-04-06T18:58:27-04:00
New Revision: 7545be074d478297ac60efaee3cf919d436d6f32
URL:
https://github.com/llvm/llvm-project/commit/7545be074d478297ac60efaee3cf919d436d6f32
DIFF:
https://github.com/llvm/llvm-project/commit/7545be074d478297ac60efaee3cf919d436d6f32.diff
LO
This isn't bot-dependent, it's been flaking on many different bots over the
last few days. Here's one from just now:
http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/34705
On Mon, Apr 6, 2020 at 4:40 PM Volodymyr Sapsai wrote:
> Is there anything special in the builedbot confi
Author: Nico Weber
Date: 2020-04-07T08:20:40-04:00
New Revision: 448b777b864a312e3b2ceae1e0cd59752a1fe90e
URL:
https://github.com/llvm/llvm-project/commit/448b777b864a312e3b2ceae1e0cd59752a1fe90e
DIFF:
https://github.com/llvm/llvm-project/commit/448b777b864a312e3b2ceae1e0cd59752a1fe90e.diff
LO
Author: Nico Weber
Date: 2020-04-10T06:18:41-04:00
New Revision: 1bd70bcd50be3c55e714350e3aadfd48040581f1
URL:
https://github.com/llvm/llvm-project/commit/1bd70bcd50be3c55e714350e3aadfd48040581f1
DIFF:
https://github.com/llvm/llvm-project/commit/1bd70bcd50be3c55e714350e3aadfd48040581f1.diff
LO
Author: Nico Weber
Date: 2020-04-13T11:54:00-04:00
New Revision: a59ba3384e9d5e1cf89ddae1d14601a613b8d7b7
URL:
https://github.com/llvm/llvm-project/commit/a59ba3384e9d5e1cf89ddae1d14601a613b8d7b7
DIFF:
https://github.com/llvm/llvm-project/commit/a59ba3384e9d5e1cf89ddae1d14601a613b8d7b7.diff
LO
Author: Nico Weber
Date: 2020-04-13T17:09:21-04:00
New Revision: 4d4fef22dac75c9a9ba3e14742dd681e6c5f935d
URL:
https://github.com/llvm/llvm-project/commit/4d4fef22dac75c9a9ba3e14742dd681e6c5f935d
DIFF:
https://github.com/llvm/llvm-project/commit/4d4fef22dac75c9a9ba3e14742dd681e6c5f935d.diff
LO
Author: Nico Weber
Date: 2020-04-15T13:38:03-04:00
New Revision: 99e4061bd800a525ce1d7e2cbd6672b2fe0ec33d
URL:
https://github.com/llvm/llvm-project/commit/99e4061bd800a525ce1d7e2cbd6672b2fe0ec33d
DIFF:
https://github.com/llvm/llvm-project/commit/99e4061bd800a525ce1d7e2cbd6672b2fe0ec33d.diff
LO
Author: Nico Weber
Date: 2020-06-08T06:45:21-04:00
New Revision: abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009
URL:
https://github.com/llvm/llvm-project/commit/abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009
DIFF:
https://github.com/llvm/llvm-project/commit/abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009.diff
LO
Author: Nico Weber
Date: 2020-06-08T15:20:16-04:00
New Revision: f25e3c2d0e8553e6640ca5e0d1933c0e9455bd71
URL:
https://github.com/llvm/llvm-project/commit/f25e3c2d0e8553e6640ca5e0d1933c0e9455bd71
DIFF:
https://github.com/llvm/llvm-project/commit/f25e3c2d0e8553e6640ca5e0d1933c0e9455bd71.diff
LO
Author: Nico Weber
Date: 2020-07-01T19:20:05-04:00
New Revision: ac8d059c8e80fc84d16ad79d08e25010ffa114c2
URL:
https://github.com/llvm/llvm-project/commit/ac8d059c8e80fc84d16ad79d08e25010ffa114c2
DIFF:
https://github.com/llvm/llvm-project/commit/ac8d059c8e80fc84d16ad79d08e25010ffa114c2.diff
LO
Author: Nico Weber
Date: 2020-07-04T20:41:33-04:00
New Revision: 7e2d27bc554eb607c90e55c89d2537f5d711234c
URL:
https://github.com/llvm/llvm-project/commit/7e2d27bc554eb607c90e55c89d2537f5d711234c
DIFF:
https://github.com/llvm/llvm-project/commit/7e2d27bc554eb607c90e55c89d2537f5d711234c.diff
LO
301 - 400 of 1693 matches
Mail list logo
