[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-23 Thread Nico Weber via cfe-commits
nico wrote: This is a behavior change: In distributed build environments, neither lib file exists at compile time. Previously, this would result in the "old" style, now (together with #81037) it results in the "new" style (which we disable everywhere since it causes all kinds of issues – from

[clang] clang/win: Add a flag to disable default-linking of compiler-rt libraries (PR #89642)

2024-04-23 Thread Nico Weber via cfe-commits
https://github.com/nico updated https://github.com/llvm/llvm-project/pull/89642 >From 39bd2d2ece1f55c3c77e1f376913846fb604be27 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 22 Apr 2024 14:05:04 -0400 Subject: [PATCH] clang/win: Add a flag to disable default-linking of compiler-rt librari

[clang] clang/win: Add a flag to disable default-linking of compiler-rt libraries (PR #89642)

2024-04-23 Thread Nico Weber via cfe-commits
https://github.com/nico edited https://github.com/llvm/llvm-project/pull/89642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/win: Add a flag to disable default-linking of compiler-rt libraries (PR #89642)

2024-04-23 Thread Nico Weber via cfe-commits
nico wrote: Good call-out, thanks. I meant #87866, which is new. I also forgot that llvm-project likes to do squash commits and put the new commit message in the old commit and `git push -f`'d. But the only thing that changed in the new commit is the commit message text. https://github.com/ll

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-18 Thread Nico Weber via cfe-commits
@@ -161,6 +163,7 @@ clang_target_link_libraries(clangDaemon clangAST clangASTMatchers clangBasic + clangDependencyScanning nico wrote: This dependency makes clangd depend (transitively) on clangCodeGen, which it didn't depend on previously. This makes

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-18 Thread Nico Weber via cfe-commits
https://github.com/nico edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-18 Thread Nico Weber via cfe-commits
https://github.com/nico edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-21 Thread Nico Weber via cfe-commits
nico wrote: Independent of the other issues, it looks like this also re-introduces #98878 https://github.com/llvm/llvm-project/pull/98547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-22 Thread Nico Weber via cfe-commits
nico wrote: This seems to break tests on my Windows box: http://45.33.8.238/win/91548/step_6.txt https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-23 Thread Nico Weber via cfe-commits
nico wrote: Here's a minimal repro: ``` % cat empty.c % foo/clang --driver-mode=cl empty.c --target=x86_64-pc-windows -fprofile-instr-generate -c /Fa && rg DEFAULTLIB empty.asm 23: .ascii " /DEFAULTLIB:libcmt.lib" 24: .ascii " /DEFAULTLIB:oldnames.lib" 25: .ascii " /DEFAULTLIB:c

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-23 Thread Nico Weber via cfe-commits
nico wrote: I now did build clang at ccdebbae4d77 and ccdebbae4d77^. ccdebbae4d77 has `/DEFAULTLIB:clang_rt.profile.lib` in its output, ccdebbae4d77^ has /DEFAULTLIB:clang_rt.profile-x86_64.lib`. So definitely due to this change. It sounds like you're saying that's not intentional? (It's kind

[clang] clang/win: Add a flag to disable default-linking of compiler-rt libraries (PR #89642)

2024-04-23 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/89642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-23 Thread Nico Weber via cfe-commits
nico wrote: > I would suggest we revert this - and at least collect all the observed side > effects and declare them before considering relanding it. That sounds good to me. Do you have a list of PRs to revert? > ... then we do still get the old name embedded. Sure. The motivation on our sid

[clang] [Driver] Restore compiler-rt arch suffix for PS and Windows (PR #89775)

2024-04-24 Thread Nico Weber via cfe-commits
nico wrote: > My recollection of the past discussions is that we want users to switch to > the new hierarchy. FWIW this doesn't match my understanding. phosek added the new hierarchy to Fuchsia, maskray put in some work to enable it elsewhere, but it's a huge headache, and we've forcibly turn

[clang] [Driver] Restore compiler-rt arch suffix for PS and Windows (PR #89775)

2024-04-24 Thread Nico Weber via cfe-commits
nico wrote: Anyway, for this specific issue it sounds like the change here was unintentional. As suggested by mstorsjo at https://github.com/llvm/llvm-project/pull/87866#issuecomment-2073231116, I think it'd be good to revert these changes, and then make a mindful decision about this when rel

[clang] [Driver] Restore compiler-rt arch suffix for PS and Windows (PR #89775)

2024-04-25 Thread Nico Weber via cfe-commits
nico wrote: > Again, clangDriver does file probing in various places. This is the only place where we probe link-time inputs for compile-time decisions as far as I know. https://github.com/llvm/llvm-project/pull/89775 ___ cfe-commits mailing list cfe

[clang] [clang][X86] Fix -Wundef warning in cpuid.h (PR #89842)

2024-04-26 Thread Nico Weber via cfe-commits
nico wrote: If your project disables warning for system headers (why even do that?), I'm guessing there's going to be a bunch of other issues you'll run into. But this change here is fine, it makes cpuid.h consisten with all the other headers in clang/lib/Headers :) https://github.com/llvm/ll

[clang] [clang][X86] Fix -Wundef warning in cpuid.h (PR #89842)

2024-04-26 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/89842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous `-Wmissing-prototypes` for Win32 entry points (PR #98105)

2024-07-09 Thread Nico Weber via cfe-commits
@@ -654,6 +654,9 @@ Improvements to Clang's diagnostics - Clang now shows implicit deduction guides when diagnosing overload resolution failure. #GH92393. +- Clong no longer emits a no previous prototype warning for Win32 entry points under ``-Wmissing-prototypes``. ---

[clang] [llvm] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-07-10 Thread Nico Weber via cfe-commits
nico wrote: In addition to the test failures, this apparently also breaks building lldb on windows and Mac: http://45.33.8.238/macm1/88231/step_3.txt http://45.33.8.238/win/91235/step_3.txt Please check if that's something real or if my bots are being silly before relanding. https://github.co

[clang] [llvm] [AArch64] Add intrinsics for multi-vector to ZA array vector accumulators (PR #88266)

2024-05-09 Thread Nico Weber via cfe-commits
nico wrote: Thanks for the quick revert! Is the failure due to a conflict with another commit that landed? https://github.com/llvm/llvm-project/pull/88266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-04 Thread Nico Weber via cfe-commits
nico wrote: Looks like this breaks building on Android: https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel/680348/overview https://github.com/llvm/llvm-project/pull/99335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-05 Thread Nico Weber via cfe-commits
nico wrote: That sounds believable. We did update our compiler just an hour or so ago, so it's possible it will work for us now. However, it suggests that the assumption `defined(__ARM_FEATURE_GCS_DEFAULT)` => arm_acle.h has `__chkfeat()` isn't valid in this snippet in libunwind/src/cet_unwi

[libunwind] [libunwind] Be more careful about enabling GCS (PR #101973)

2024-08-05 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. Makes sense, thanks! https://github.com/llvm/llvm-project/pull/101973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8b4fa2c - clang: Auto-cleanup left-over file from before 3da69fb5a26c7b on bots

2022-01-20 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-01-20T14:59:30-05:00 New Revision: 8b4fa2c98e07997469f53bee30c0d24a61dc7c8c URL: https://github.com/llvm/llvm-project/commit/8b4fa2c98e07997469f53bee30c0d24a61dc7c8c DIFF: https://github.com/llvm/llvm-project/commit/8b4fa2c98e07997469f53bee30c0d24a61dc7c8c.diff LO

[clang] 1689b10 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 32b73bc6ab82

2022-02-17 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-02-17T16:33:39-05:00 New Revision: 1689b1092ebb2c630f8ef1d3880a9fb4808d16fa URL: https://github.com/llvm/llvm-project/commit/1689b1092ebb2c630f8ef1d3880a9fb4808d16fa DIFF: https://github.com/llvm/llvm-project/commit/1689b1092ebb2c630f8ef1d3880a9fb4808d16fa.diff LO

[clang] 383ed82 - [clang] Pass more flags to ld64.lld

2022-02-17 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-02-17T16:45:52-05:00 New Revision: 383ed82dd1f8c4ea7e88a4cf92dd918dda794854 URL: https://github.com/llvm/llvm-project/commit/383ed82dd1f8c4ea7e88a4cf92dd918dda794854 DIFF: https://github.com/llvm/llvm-project/commit/383ed82dd1f8c4ea7e88a4cf92dd918dda794854.diff LO

[clang] 34285bc - Reland "unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 32b73bc6ab82"

2022-02-23 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-02-23T18:41:20-05:00 New Revision: 34285bcd5ac260246c9d59708a63ea3d5972f75c URL: https://github.com/llvm/llvm-project/commit/34285bcd5ac260246c9d59708a63ea3d5972f75c DIFF: https://github.com/llvm/llvm-project/commit/34285bcd5ac260246c9d59708a63ea3d5972f75c.diff LO

[clang] e6a8b92 - [clang-format] Fix namespace end comments in ObjC++ files too

2022-03-07 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-03-07T13:30:25-05:00 New Revision: e6a8b92b8959b17a140a30b340dd59cfa8781dea URL: https://github.com/llvm/llvm-project/commit/e6a8b92b8959b17a140a30b340dd59cfa8781dea DIFF: https://github.com/llvm/llvm-project/commit/e6a8b92b8959b17a140a30b340dd59cfa8781dea.diff LO

[clang] 21da04f - [llvm, clang] Remove stdlib includes from .h files without `std::`

2021-04-27 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-04-27T12:41:39-04:00 New Revision: 21da04f701735ecd42f1d43b3f58b708ad382905 URL: https://github.com/llvm/llvm-project/commit/21da04f701735ecd42f1d43b3f58b708ad382905 DIFF: https://github.com/llvm/llvm-project/commit/21da04f701735ecd42f1d43b3f58b708ad382905.diff LO

[clang] 0f1137b - [clang/Basic] Make TargetInfo.h not use DataLayout again

2021-04-27 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-04-27T22:26:10-04:00 New Revision: 0f1137ba79c0b3f1ca638e01082443ba5ccde03c URL: https://github.com/llvm/llvm-project/commit/0f1137ba79c0b3f1ca638e01082443ba5ccde03c DIFF: https://github.com/llvm/llvm-project/commit/0f1137ba79c0b3f1ca638e01082443ba5ccde03c.diff LO

[clang] 5d49329 - [clang] remove dead code after 2a1332245fc

2021-04-28 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-04-28T10:27:31-04:00 New Revision: 5d493291bd010bbba0fdc1e7da0922fd214fdffd URL: https://github.com/llvm/llvm-project/commit/5d493291bd010bbba0fdc1e7da0922fd214fdffd DIFF: https://github.com/llvm/llvm-project/commit/5d493291bd010bbba0fdc1e7da0922fd214fdffd.diff LO

[clang] 671f0e2 - [clang] Make libBasic not depend on MC

2021-04-28 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-04-28T12:16:22-04:00 New Revision: 671f0e2e189c561512511331d95de382e2d6d15d URL: https://github.com/llvm/llvm-project/commit/671f0e2e189c561512511331d95de382e2d6d15d DIFF: https://github.com/llvm/llvm-project/commit/671f0e2e189c561512511331d95de382e2d6d15d.diff LO

[clang] f16afcd - [clang] remove an incremental build workaround

2021-05-05 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-05-05T12:21:56-04:00 New Revision: f16afcd9b5ce3054aac2b08b3a20472c07b6773a URL: https://github.com/llvm/llvm-project/commit/f16afcd9b5ce3054aac2b08b3a20472c07b6773a DIFF: https://github.com/llvm/llvm-project/commit/f16afcd9b5ce3054aac2b08b3a20472c07b6773a.diff LO

Re: [clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

2021-05-06 Thread Nico Weber via cfe-commits
Looks like this breaks tests: http://45.33.8.238/linux/45985/step_7.txt , https://lab.llvm.org/buildbot/#/builders/139/builds/3818 (Is there a phab link for this?) On Thu, May 6, 2021 at 9:37 AM Nemanja Ivanovic via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Nemanja Ivanovic >

Re: [clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

2021-05-06 Thread Nico Weber via cfe-commits
Reverted in 3761b9a2345aff197707d23a68d4a178489f60e4 for now. On Thu, May 6, 2021 at 9:58 AM Nico Weber wrote: > Looks like this breaks tests: http://45.33.8.238/linux/45985/step_7.txt , > https://lab.llvm.org/buildbot/#/builders/139/builds/3818 > > (Is there a phab link for this?) > > On Thu, M

[clang] 3761b9a - Revert "[PowerPC] Provide some P8-specific altivec overloads for P7"

2021-05-06 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-05-06T10:01:16-04:00 New Revision: 3761b9a2345aff197707d23a68d4a178489f60e4 URL: https://github.com/llvm/llvm-project/commit/3761b9a2345aff197707d23a68d4a178489f60e4 DIFF: https://github.com/llvm/llvm-project/commit/3761b9a2345aff197707d23a68d4a178489f60e4.diff LO

[clang] 08de6e3 - clang: Fix tests after 7f78e409d028 if clang is not called clang-13

2021-05-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-05-10T08:49:26-04:00 New Revision: 08de6e3adaf6e991f5a40357f4634e5b70ec3fde URL: https://github.com/llvm/llvm-project/commit/08de6e3adaf6e991f5a40357f4634e5b70ec3fde DIFF: https://github.com/llvm/llvm-project/commit/08de6e3adaf6e991f5a40357f4634e5b70ec3fde.diff LO

[clang] 7e08a12 - [clang] Fall back on Android triple w/o API level for runtimes search

2022-01-05 Thread Nico Weber via cfe-commits
Author: Collin Baker Date: 2022-01-05T16:00:48-05:00 New Revision: 7e08a1208889756bb7c44121f63a1b32f6c87ea5 URL: https://github.com/llvm/llvm-project/commit/7e08a1208889756bb7c44121f63a1b32f6c87ea5 DIFF: https://github.com/llvm/llvm-project/commit/7e08a1208889756bb7c44121f63a1b32f6c87ea5.diff

[clang-tools-extra] cf90b3c - Revert "[clangd] Enable expand-auto for decltype(auto)."

2022-01-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-01-10T12:01:42-05:00 New Revision: cf90b3cf7e467db9052a2fd392faa68ef2f175d8 URL: https://github.com/llvm/llvm-project/commit/cf90b3cf7e467db9052a2fd392faa68ef2f175d8 DIFF: https://github.com/llvm/llvm-project/commit/cf90b3cf7e467db9052a2fd392faa68ef2f175d8.diff LO

[clang] 78ff12d - Revert "[clang][dataflow] Add framework for testing analyses."

2021-12-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-12-10T11:06:40-05:00 New Revision: 78ff12da1115abcaf4cbf50b605a197011505646 URL: https://github.com/llvm/llvm-project/commit/78ff12da1115abcaf4cbf50b605a197011505646 DIFF: https://github.com/llvm/llvm-project/commit/78ff12da1115abcaf4cbf50b605a197011505646.diff LO

[clang] b6f317d - [gn build] Make arm_neon_sve_bridge.h header auto-syncable

2021-12-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-12-13T07:04:45-05:00 New Revision: b6f317d94d894142f5ab9a9e3e942acbfff1dc4b URL: https://github.com/llvm/llvm-project/commit/b6f317d94d894142f5ab9a9e3e942acbfff1dc4b DIFF: https://github.com/llvm/llvm-project/commit/b6f317d94d894142f5ab9a9e3e942acbfff1dc4b.diff LO

[clang] 45158b1 - Revert "[NFC] format .cppm files in test"

2021-12-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-12-13T07:13:17-05:00 New Revision: 45158b18041584e0056f85c04057d5098956257d URL: https://github.com/llvm/llvm-project/commit/45158b18041584e0056f85c04057d5098956257d DIFF: https://github.com/llvm/llvm-project/commit/45158b18041584e0056f85c04057d5098956257d.diff LO

[clang] b45ad73 - [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

2021-12-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-12-14T21:44:56-05:00 New Revision: b45ad7363c306e17422401f318cc243cb9fd99d4 URL: https://github.com/llvm/llvm-project/commit/b45ad7363c306e17422401f318cc243cb9fd99d4 DIFF: https://github.com/llvm/llvm-project/commit/b45ad7363c306e17422401f318cc243cb9fd99d4.diff LO

[clang] 770ef94 - Revert "[analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file"

2021-12-16 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-12-16T20:46:51-05:00 New Revision: 770ef94097c02205b3ec9e902f1d6a9c99b5189c URL: https://github.com/llvm/llvm-project/commit/770ef94097c02205b3ec9e902f1d6a9c99b5189c DIFF: https://github.com/llvm/llvm-project/commit/770ef94097c02205b3ec9e902f1d6a9c99b5189c.diff LO

Re: [clang] 874bdc8 - [Driver] Clean up Debian multiarch /usr/include/ madness

2021-03-23 Thread Nico Weber via cfe-commits
Was this reviewed anywhere? On Mon, Mar 22, 2021 at 1:40 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Fangrui Song > Date: 2021-03-21T22:40:38-07:00 > New Revision: 874bdc8e61662b5f39a9626b9132e0979fae556f > > URL: > https://github.com/llvm/llvm-project/commit/

Re: [clang] 874bdc8 - [Driver] Clean up Debian multiarch /usr/include/ madness

2021-03-23 Thread Nico Weber via cfe-commits
Yes. 1. Download https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/500976182686961e34974ea7bdc0a21fca32be06/debian_sid_amd64_sysroot.tar.xz 2. Unpack somewhere 3. Delete the lib/ folder in it 4. Try to use that sysroot like so: thakis@thakis:~/src/llvm-project$ cat test.cc #

Re: [clang] aae84b8 - Revert "[Driver] Bring back "Clean up Debian multiarch /usr/include/ madness" and restore i586-linux-gnu"

2021-03-23 Thread Nico Weber via cfe-commits
(Reduced repro: https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20210322/362775.html ) On Tue, Mar 23, 2021 at 11:14 PM Zequan Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Zequan Wu > Date: 2021-03-23T20:12:09-07:00 > New Revision: aae84b8e3939e815bbc1e64b3b30c0f10

[clang] c22b09d - Revert "[clang] Speedup line offset mapping computation"

2021-04-07 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-04-07T09:42:11-04:00 New Revision: c22b09debddbaa00be3418b47ca33446ee8a8319 URL: https://github.com/llvm/llvm-project/commit/c22b09debddbaa00be3418b47ca33446ee8a8319 DIFF: https://github.com/llvm/llvm-project/commit/c22b09debddbaa00be3418b47ca33446ee8a8319.diff LO

[clang] 2da4cee - [docs] Use make_unique in FrontendAction example

2021-04-20 Thread Nico Weber via cfe-commits
Author: Nicolás Alvarez Date: 2021-04-20T13:47:16-04:00 New Revision: 2da4ceec936e0e3ddb3028c35e97e99ab1de7484 URL: https://github.com/llvm/llvm-project/commit/2da4ceec936e0e3ddb3028c35e97e99ab1de7484 DIFF: https://github.com/llvm/llvm-project/commit/2da4ceec936e0e3ddb3028c35e97e99ab1de7484.dif

[clang] b0322a4 - [docs] Fix doxygen comments wrongly attached to the clang namespace

2021-04-20 Thread Nico Weber via cfe-commits
Author: Nicolás Alvarez Date: 2021-04-20T13:50:11-04:00 New Revision: b0322a4ed2b2d5a5b3b0ea2ef4da40606f6838d1 URL: https://github.com/llvm/llvm-project/commit/b0322a4ed2b2d5a5b3b0ea2ef4da40606f6838d1 DIFF: https://github.com/llvm/llvm-project/commit/b0322a4ed2b2d5a5b3b0ea2ef4da40606f6838d1.dif

[clang] ba7a92c - [Support] Don't include VirtualFileSystem.h in CommandLine.h

2021-04-21 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-04-21T10:19:01-04:00 New Revision: ba7a92c01e86b5048a93abe7c26c25b90ea9040a URL: https://github.com/llvm/llvm-project/commit/ba7a92c01e86b5048a93abe7c26c25b90ea9040a DIFF: https://github.com/llvm/llvm-project/commit/ba7a92c01e86b5048a93abe7c26c25b90ea9040a.diff LO

[clang-tools-extra] b4c5e19 - Temporarily disable to clang-tidy tests on Windows

2021-01-01 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-01-01T23:19:48-05:00 New Revision: b4c5e19da74773b86662cbe5a7437f72116f3615 URL: https://github.com/llvm/llvm-project/commit/b4c5e19da74773b86662cbe5a7437f72116f3615 DIFF: https://github.com/llvm/llvm-project/commit/b4c5e19da74773b86662cbe5a7437f72116f3615.diff LO

[clang] 419ef38 - Revert "[attributes] Add a facility for enforcing a Trusted Computing Base."

2021-01-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-01-11T09:51:06-05:00 New Revision: 419ef38a50293c58078f830517f5e305068dbee6 URL: https://github.com/llvm/llvm-project/commit/419ef38a50293c58078f830517f5e305068dbee6 DIFF: https://github.com/llvm/llvm-project/commit/419ef38a50293c58078f830517f5e305068dbee6.diff LO

[clang] f9457f1 - [clang] Don't mark _ReadBarrier, _ReadWriteBarrier, _WriteBarrier deprecated

2021-10-06 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-06T10:50:02-04:00 New Revision: f9457f1f88b3e835fca8942b5272f3ecf26d4e98 URL: https://github.com/llvm/llvm-project/commit/f9457f1f88b3e835fca8942b5272f3ecf26d4e98 DIFF: https://github.com/llvm/llvm-project/commit/f9457f1f88b3e835fca8942b5272f3ecf26d4e98.diff LO

[clang] 23d5fe6 - clang: Convert two loops to for-each

2021-10-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-10T14:55:46-04:00 New Revision: 23d5fe6235e599388a1cb3c52596ff22cd557a9c URL: https://github.com/llvm/llvm-project/commit/23d5fe6235e599388a1cb3c52596ff22cd557a9c DIFF: https://github.com/llvm/llvm-project/commit/23d5fe6235e599388a1cb3c52596ff22cd557a9c.diff LO

[clang] 62abc18 - clang: Add range-based CFG::try_blocks()

2021-10-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-10T15:15:37-04:00 New Revision: 62abc1842bc8b4860f9f7c1165164740fccef64e URL: https://github.com/llvm/llvm-project/commit/62abc1842bc8b4860f9f7c1165164740fccef64e DIFF: https://github.com/llvm/llvm-project/commit/62abc1842bc8b4860f9f7c1165164740fccef64e.diff LO

[clang] 144f851 - [clang/CFG] Rewrap a line to 80 columns

2021-10-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-11T14:23:51-04:00 New Revision: 144f851f6f5203969ef8b8052060ad56fcaab934 URL: https://github.com/llvm/llvm-project/commit/144f851f6f5203969ef8b8052060ad56fcaab934 DIFF: https://github.com/llvm/llvm-project/commit/144f851f6f5203969ef8b8052060ad56fcaab934.diff LO

[clang] 00ca004 - [clang] Convert a few loops to for-each

2021-10-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-11T14:24:32-04:00 New Revision: 00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6 URL: https://github.com/llvm/llvm-project/commit/00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6 DIFF: https://github.com/llvm/llvm-project/commit/00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6.diff LO

[clang] 5ab2a95 - [clang] Remove an else-after-return

2021-10-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-11T14:24:58-04:00 New Revision: 5ab2a95edb62e67478095e4e5619a07efc95ee21 URL: https://github.com/llvm/llvm-project/commit/5ab2a95edb62e67478095e4e5619a07efc95ee21 DIFF: https://github.com/llvm/llvm-project/commit/5ab2a95edb62e67478095e4e5619a07efc95ee21.diff LO

[clang] c74ab84 - [clang] Omit most AttributedStatements from the CFG

2021-10-12 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-12T09:15:45-04:00 New Revision: c74ab84ea23f497ac83501473220cd9cfefe81e8 URL: https://github.com/llvm/llvm-project/commit/c74ab84ea23f497ac83501473220cd9cfefe81e8 DIFF: https://github.com/llvm/llvm-project/commit/c74ab84ea23f497ac83501473220cd9cfefe81e8.diff LO

[clang] 2cc4275 - [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

2021-10-12 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-12T13:29:19-04:00 New Revision: 2cc42758a9d89da7c726b78232dfba02314957a9 URL: https://github.com/llvm/llvm-project/commit/2cc42758a9d89da7c726b78232dfba02314957a9 DIFF: https://github.com/llvm/llvm-project/commit/2cc42758a9d89da7c726b78232dfba02314957a9.diff LO

[clang] 1bef229 - [clang] Delete unused class DiagsUninitializedSeveretyRAII

2021-10-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-13T14:27:26-04:00 New Revision: 1bef22950a5c72fe630f4d6aa7f161bc1e2cb2d1 URL: https://github.com/llvm/llvm-project/commit/1bef22950a5c72fe630f4d6aa7f161bc1e2cb2d1 DIFF: https://github.com/llvm/llvm-project/commit/1bef22950a5c72fe630f4d6aa7f161bc1e2cb2d1.diff LO

[clang] fb88297 - [clang] Disallow mixing SEH and Objective-C exceptions

2021-10-20 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-10-20T14:18:12-04:00 New Revision: fb8829768d774689c368c49cb3ca17339378cd91 URL: https://github.com/llvm/llvm-project/commit/fb8829768d774689c368c49cb3ca17339378cd91 DIFF: https://github.com/llvm/llvm-project/commit/fb8829768d774689c368c49cb3ca17339378cd91.diff LO

[clang] 9b6c813 - Revert "Reland "[clang-repl] Re-implement clang-interpreter as a test case.""

2021-09-01 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-01T08:35:33-04:00 New Revision: 9b6c8132d3785269512803ff51cb421f8d8bcf0e URL: https://github.com/llvm/llvm-project/commit/9b6c8132d3785269512803ff51cb421f8d8bcf0e DIFF: https://github.com/llvm/llvm-project/commit/9b6c8132d3785269512803ff51cb421f8d8bcf0e.diff LO

[clang] 3d157cf - [clang] Add a -canonical-prefixes option

2021-09-01 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-01T14:51:06-04:00 New Revision: 3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7 URL: https://github.com/llvm/llvm-project/commit/3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7 DIFF: https://github.com/llvm/llvm-project/commit/3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7.diff LO

[clang] 9735198 - [clang-cl] Emit nicer warning on unknown /arch: arguments

2021-09-02 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-02T10:37:32-04:00 New Revision: 973519826edb7690270261a5b3512f32ae64063c URL: https://github.com/llvm/llvm-project/commit/973519826edb7690270261a5b3512f32ae64063c DIFF: https://github.com/llvm/llvm-project/commit/973519826edb7690270261a5b3512f32ae64063c.diff LO

[clang] 123f811 - Try to unbreak Win build after 973519826edb76

2021-09-02 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-02T12:06:53-04:00 New Revision: 123f811fe5b0ba33f271c1c6172e6dff1463717a URL: https://github.com/llvm/llvm-project/commit/123f811fe5b0ba33f271c1c6172e6dff1463717a DIFF: https://github.com/llvm/llvm-project/commit/123f811fe5b0ba33f271c1c6172e6dff1463717a.diff LO

[clang] e5438f3 - clang/win: Add __readfsdword to intrin.h

2021-09-02 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-02T12:22:07-04:00 New Revision: e5438f386854136d848989315f53788808afa37a URL: https://github.com/llvm/llvm-project/commit/e5438f386854136d848989315f53788808afa37a DIFF: https://github.com/llvm/llvm-project/commit/e5438f386854136d848989315f53788808afa37a.diff LO

[clang] 5881dcf - Try to unbreak Win build differently after 973519826edb76

2021-09-02 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-02T14:45:56-04:00 New Revision: 5881dcff7e76a68323edc8bb3c6e14420ad9cf7c URL: https://github.com/llvm/llvm-project/commit/5881dcff7e76a68323edc8bb3c6e14420ad9cf7c DIFF: https://github.com/llvm/llvm-project/commit/5881dcff7e76a68323edc8bb3c6e14420ad9cf7c.diff LO

[clang] 23f256f - [clang] Fix typo in test from a723310b4

2021-09-10 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-10T14:16:45-04:00 New Revision: 23f256f2b19843fa08f83dce43bab362e8ce2235 URL: https://github.com/llvm/llvm-project/commit/23f256f2b19843fa08f83dce43bab362e8ce2235 DIFF: https://github.com/llvm/llvm-project/commit/23f256f2b19843fa08f83dce43bab362e8ce2235.diff LO

[clang] 648feab - [clang] Make the driver not diagnose errors on nonexistent linker inputs

2021-09-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-13T08:57:38-04:00 New Revision: 648feabc65d8ec20e5d39ac88e019d310955a6e6 URL: https://github.com/llvm/llvm-project/commit/648feabc65d8ec20e5d39ac88e019d310955a6e6 DIFF: https://github.com/llvm/llvm-project/commit/648feabc65d8ec20e5d39ac88e019d310955a6e6.diff LO

[clang] b7bac5a - [clang] Revert gcc-driver part of 648feabc65d8

2021-09-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-13T19:04:29-04:00 New Revision: b7bac5a172e51ed065b3b4dc64cc2d8831e8081c URL: https://github.com/llvm/llvm-project/commit/b7bac5a172e51ed065b3b4dc64cc2d8831e8081c DIFF: https://github.com/llvm/llvm-project/commit/b7bac5a172e51ed065b3b4dc64cc2d8831e8081c.diff LO

[clang-tools-extra] 76dc8ac - Revert "clang-tidy: introduce readability-containter-data-pointer check"

2021-09-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-14T12:37:10-04:00 New Revision: 76dc8ac36d07cebe8cfe8fe757323562bb36df94 URL: https://github.com/llvm/llvm-project/commit/76dc8ac36d07cebe8cfe8fe757323562bb36df94 DIFF: https://github.com/llvm/llvm-project/commit/76dc8ac36d07cebe8cfe8fe757323562bb36df94.diff LO

[clang-tools-extra] 626586f - Re-Revert "clang-tidy: introduce readability-containter-data-pointer check"

2021-09-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-14T22:27:59-04:00 New Revision: 626586fc253c6f032aedb325dba6b1ff3f11875e URL: https://github.com/llvm/llvm-project/commit/626586fc253c6f032aedb325dba6b1ff3f11875e DIFF: https://github.com/llvm/llvm-project/commit/626586fc253c6f032aedb325dba6b1ff3f11875e.diff LO

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-21 Thread Nico Weber via cfe-commits
nico wrote: The test added here was tweaked a bit and then deleted in https://github.com/llvm/llvm-project/commit/07a8cbaf8dc16bebf6e875173d20299d9cc47cc5 What gives? Instead of deleting tests, we should revert the PR that adds them and then reland the PR with working tests. https://github.c

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
nico wrote: Sorry, I'm confused, how is this build-system dependent? The patch doesn't change any cmake files, and it changes the behavior of an existing test. I'm not saying it can't be build-system dependent, but it isn't clear to me why it is. Do you have a few more words on what's happenin

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
nico wrote: Ah, I see now, the failing test is also very new (70ec8419dd7), and it depends on ade28a77ed177 which the GN build doesn't yet have. But my bot points at this change here for breaking that fairly new end-to-end test. I think it's probably because absence of the css file wasn't an e

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -182,23 +258,9 @@ Example usage for a project using a compile commands database: {"index.js", "index_json.js"}}; if (Format == "html") { -void *MainAddr = (void *)(intptr_t)GetExecutablePath; -std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr);

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -127,16 +133,86 @@ std::string getFormatString() { // GetMainExecutable (since some platforms don't support taking the // address of main, and some platforms can't implement GetMainExecutable // without being given the address of a function in the main executable). -std::str

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -0,0 +1,2 @@ +// RUN: clang-doc --format=html --executor=standalone %s -output=%t/docs | FileCheck %s +// CHECK: Using default asset: {{.*}}{{[\/]}}share{{[\/]}}clang nico wrote: A test that only tests for logspam doesn't seem very useful. I would've expecte

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -0,0 +1,358 @@ +// RUN: rm -rf %t && mkdir -p %t/docs %t/build +// RUN: sed 's|$test_dir|%/S|g' %S/Inputs/basic-project/database_template.json > %t/build/compile_commands.json +// RUN: clang-doc --format=html --output=%t/docs --executor=all-TUs %t/build/compile_commands.json

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -182,23 +258,9 @@ Example usage for a project using a compile commands database: {"index.js", "index_json.js"}}; if (Format == "html") { -void *MainAddr = (void *)(intptr_t)GetExecutablePath; -std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr);

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -0,0 +1,21 @@ +#include "Calculator.h" +#include nico wrote: Tests must be freestanding and cannot include system headers. https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list cfe-commits@li

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -127,16 +133,86 @@ std::string getFormatString() { // GetMainExecutable (since some platforms don't support taking the // address of main, and some platforms can't implement GetMainExecutable // without being given the address of a function in the main executable). -std::str

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
nico wrote: (I now ported ade28a77ed17760bf2fde57c6571b69489b0bac0 to the GN build in 3ba7599842be. Again, apologies for missing this – the GN build shouldn't affect other people. But I'm kind of glad it did since I found several GN-unrelated issues both here and on #93928. Feel free to do wit

[clang-tools-extra] 7878d9c - [clangd] Replace an include with a forward declaration

2024-06-28 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2024-06-28T13:38:14+02:00 New Revision: 7878d9c0363528c44effe55aae2843fbabb6dd0e URL: https://github.com/llvm/llvm-project/commit/7878d9c0363528c44effe55aae2843fbabb6dd0e DIFF: https://github.com/llvm/llvm-project/commit/7878d9c0363528c44effe55aae2843fbabb6dd0e.diff LO

[clang-tools-extra] 69c99ad - [clangd] Fix build on linux after 7878d9c036352

2024-06-28 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2024-06-28T13:42:54+02:00 New Revision: 69c99ad7e84b075bbafc541a2e4397e18975391d URL: https://github.com/llvm/llvm-project/commit/69c99ad7e84b075bbafc541a2e4397e18975391d DIFF: https://github.com/llvm/llvm-project/commit/69c99ad7e84b075bbafc541a2e4397e18975391d.diff LO

[clang] [clang][test] Fix some windows driver tests with legacy runtime dir layout (PR #108452)

2024-09-12 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. https://github.com/llvm/llvm-project/pull/108452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test] Fix some windows driver tests with legacy runtime dir layout (PR #108452)

2024-09-12 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/108452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Utils] add update-verify-tests.py (PR #97369)

2024-09-13 Thread Nico Weber via cfe-commits
nico wrote: This breaks tests on windows: http://45.33.8.238/win/94083/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Nico Weber via cfe-commits
nico wrote: Looks like this breaks check-clang: http://45.33.8.238/linux/149333/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@list

[clang] [clang][dataflow] Add a lattice to help cache const accessor methods (PR #111006)

2024-10-25 Thread Nico Weber via cfe-commits
@@ -0,0 +1,218 @@ +//===-- CachedConstAccessorsLattice.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-tools-extra] [flang] [llvm] Reland 'Update llvm::Registry to work for LLVM shared library builds on windows' (#109024) (PR #112640)

2024-10-25 Thread Nico Weber via cfe-commits
nico wrote: This seems to break building of clang-tools-extra binaries: http://45.33.8.238/win/95986/step_3.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/112640 ___ cfe-commits mailing

[clang] [clang][dataflow] Disambiguate a ref to "internal" in CachedConstAccessorsLattice (PR #113601)

2024-10-24 Thread Nico Weber via cfe-commits
nico wrote: I think this'll fix the build, thanks! However, the root cause is probably that the `AST_MATCHER_P_OVERLOAD` instantiation in clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp is in an unnamed namespace that's inside namespace `clang::dataflow`, right? Shoul

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

2024-11-08 Thread Nico Weber via cfe-commits
@@ -0,0 +1,111 @@ +// REQUIRES: amdgpu-registered-target +// RUN: %clang -xhip --offload-arch=gfx1030 --offload-host-only -pedantic -nogpuinc -nogpulib -nobuiltininc -fsyntax-only -Xclang -verify %s +// RUN: %clang -xhip --offload-arch=gfx1030 --offload-device-only -pedantic -no

[clang] [Driver] Add toolchain for X86_64 UEFI target (PR #76838)

2024-09-19 Thread Nico Weber via cfe-commits
nico wrote: Looks like this breaks tests on Mac: http://45.33.8.238/macm1/92471/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/76838 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang-tools-extra] Remove clang-pseudo (PR #109154)

2024-09-18 Thread Nico Weber via cfe-commits
@@ -181,16 +181,16 @@ llvm::Expected> getFoldingRanges(ParsedAST &AST) { // Related issue: https://github.com/clangd/clangd/issues/310 llvm::Expected> getFoldingRanges(const std::string &Code, bool LineFoldingOnly) { nico wrote: Should we revert 70914aa631561

[clang] [llvm] [AArch64] Implement intrinsics for SME2 FSCALE (PR #100128)

2024-09-25 Thread Nico Weber via cfe-commits
nico wrote: The test is broken on trunk. It won't get more broken if you merge the fix. So please merge, and if it helps, great. https://github.com/llvm/llvm-project/pull/100128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [llvm] [AArch64] Implement intrinsics for SME2 FSCALE (PR #100128)

2024-09-25 Thread Nico Weber via cfe-commits
nico wrote: Thanks for merging the fix! At least on one of my bots, it helped and it's green again :) https://github.com/llvm/llvm-project/pull/100128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

<    11   12   13   14   15   16   17   >