Author: nico
Date: Wed Mar 2 13:28:54 2016
New Revision: 262506
URL: http://llvm.org/viewvc/llvm-project?rev=262506&view=rev
Log:
Serialize `#pragma detect_mismatch`.
This is like r262493, but for pragma detect_mismatch instead of pragma comment.
The two pragmas have similar behavior, so use the
thakis added a comment.
Also landed a very similar change for the very similar detect_mismatch pragma
in r262506. (The other missing serialized pragmas will use a different
approach.)
http://reviews.llvm.org/D17799
___
cfe-commits mailing list
cfe
Author: nico
Date: Wed Mar 2 13:38:24 2016
New Revision: 262508
URL: http://llvm.org/viewvc/llvm-project?rev=262508&view=rev
Log:
fix test from r262506
Modified:
cfe/trunk/test/PCH/pragma-detect_mismatch.c
Modified: cfe/trunk/test/PCH/pragma-detect_mismatch.c
URL:
http://llvm.org/viewvc/ll
(A different fix would've been to just add /Fp%.pch to set the output path
to be not next to the inputs.)
On Wed, Mar 2, 2016 at 6:27 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Wed Mar 2 08:26:59 2016
> New Revision: 262487
>
> URL: http://ll
Thanks!
On Wed, Mar 2, 2016 at 6:27 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Wed Mar 2 08:26:59 2016
> New Revision: 262487
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262487&view=rev
> Log:
> test/Driver/cl-pch-errorhandling.cpp: Copy
Author: nico
Date: Wed Mar 2 17:22:00 2016
New Revision: 262539
URL: http://llvm.org/viewvc/llvm-project?rev=262539&view=rev
Log:
Serialize `pragma ms_struct` state.
pragma ms_struct has an effect on struct decls, and the effect is serialized
correctly already. But the "is ms_struct currently o
Author: nico
Date: Wed Mar 2 17:29:29 2016
New Revision: 262541
URL: http://llvm.org/viewvc/llvm-project?rev=262541&view=rev
Log:
clang-cl pch test: Instead of copying the input, use /Fp to not write into the
test directory.
Also fix a bug with /Fp and absolute paths uncovered by this.
Follow-u
Ok, gave that a try in r262541.
On Wed, Mar 2, 2016 at 1:20 PM, Daniel Jasper wrote:
> Feel free to change. I have no idea what I am doing here.
>
> On Wed, Mar 2, 2016 at 12:55 PM, Nico Weber wrote:
>
>> (A different fix would've been to just add /Fp%.pch to set the output
>> path to be not ne
Author: nico
Date: Wed Mar 2 18:17:35 2016
New Revision: 262552
URL: http://llvm.org/viewvc/llvm-project?rev=262552&view=rev
Log:
Serialize `pragma pointers_to_members` state.
Like r262539, but for pointers_to_members.
Added:
cfe/trunk/test/PCH/pragma-pointers_to_members.cpp
Modified:
c
Is it possible to test this?
On Mar 2, 2016 6:26 PM, "Sean Callanan via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Wed Mar 2 20:22:05 2016
> New Revision: 262576
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262576&view=rev
> Log:
> Caught and fixed a typo in r2
On Thu, Mar 3, 2016 at 1:50 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Mar 03, 2016 at 07:39:04PM +, Weiming Zhao via cfe-commits
> wrote:
> > Change the option name to -ffile-macro-prefix-to-remove
>
> This still sounds to me like a solution for a ve
On Thu, Mar 3, 2016 at 4:28 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Mar 03, 2016 at 02:09:17PM -0800, Nico Weber via cfe-commits wrote:
> > On Thu, Mar 3, 2016 at 1:50 PM, Joerg Sonnenberger via cfe-commits <
> > cfe-commi
Author: nico
Date: Fri Mar 4 15:59:42 2016
New Revision: 262749
URL: http://llvm.org/viewvc/llvm-project?rev=262749&view=rev
Log:
clang-cl: Enable PCH flags by default.
Now that pragma comment and pragma detect_mismatch are implemented, this might
just work.
Some pragmas aren't serialized yet (
Looks like the new tests don't pass on Windows:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10365
On Mar 4, 2016 12:29 PM, "Carlo Bertolli via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: cbertol
> Date: Fri Mar 4 14:24:58 2016
> New Revision: 262741
>
> URL: http
This causes clang to warn on
default: assert (false); HB_FALLTHROUGH;
The fallthrough needs to be there for release builds, but now it must not
be there for debug builds. I suppose this means projects now need an
UNREACHED_CASE macro that expands to assert(false) in debug and to
fallthrough in
On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith wrote:
> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote:
> > This causes clang to warn on
> >
> > default: assert (false); HB_FALLTHROUGH;
>
> What follows this? (A case label?) What warning is being produced?
>
A case label. Full snippet:
https
On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith wrote:
> On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote:
> > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith
> wrote:
> >>
> >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote:
> >> > This causes clang to warn on
> >> >
> >> > default: assert (
On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote:
> On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith
> wrote:
>
>> On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote:
>> > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith
>> wrote:
>> >>
>> >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber
>> wrote:
>>
I think this is ABI-breaking. On OS X, new libc++ headers must work with
old system libc++.dylibs. When I build in this setup with this change, I get
Undefined symbols for architecture x86_64:
"std::__1::basic_string,
std::__1::allocator >::basic_string(std::__1::basic_string, std::__1::allocato
Author: nico
Date: Thu Mar 10 12:42:37 2016
New Revision: 263138
URL: http://llvm.org/viewvc/llvm-project?rev=263138&view=rev
Log:
Make remaining ImplicitFallthrough warning DefaultIgnore.
Follow-up to r262881, which caused this to fire more often.
Modified:
cfe/trunk/include/clang/Basic/Dia
On Wed, Mar 9, 2016 at 6:44 PM, Nico Weber wrote:
> On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote:
>
>> On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith
>> wrote:
>>
>>> On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote:
>>> > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith
>>> wrote:
>>> >>
>
Thank you!
On Thu, Mar 10, 2016 at 2:22 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Mar 10 13:22:21 2016
> New Revision: 263155
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263155&view=rev
> Log:
> Add test for r263138.
>
> Added:
>
Author: nico
Date: Thu Mar 10 16:40:02 2016
New Revision: 263168
URL: http://llvm.org/viewvc/llvm-project?rev=263168&view=rev
Log:
Reenable asm-errors.c
r134811 made the test pass and reenabled it, but r134831
accidentally disabled it again due to a bad merge.
Modified:
cfe/trunk/test/CodeGe
Author: nico
Date: Fri Mar 11 09:26:06 2016
New Revision: 263246
URL: http://llvm.org/viewvc/llvm-project?rev=263246&view=rev
Log:
Revert r263036, it's ABI-breaking.
Modified:
libcxx/trunk/include/string
libcxx/trunk/test/std/strings/basic.string/string.cons/substr.pass.cpp
libcxx/tru
I reverted this in 263246 for now. I think the right fix is just to
add _LIBCPP_INLINE_VISIBILITY to the new constructor, but I'm not 100% sure.
On Thu, Mar 10, 2016 at 10:21 AM, Nico Weber wrote:
> I think this is ABI-breaking. On OS X, new libc++ headers must work with
> old system libc++.dyli
I think http://clang.llvm.org/docs/InternalsManual.html#fix-it-hints says
that if a fixit is on a warning, then clang should process the code as if
the fixit had been applied. That's not the case here, so I think the fixit
should be on a note instead.
On Fri, Mar 11, 2016 at 4:55 PM, Bob Wilson vi
Author: nico
Date: Sat Mar 12 13:55:59 2016
New Revision: 263344
URL: http://llvm.org/viewvc/llvm-project?rev=263344&view=rev
Log:
clang-cl: Add a test for the interaction of /Yc and /showIncludes.
We almost get this right, but not completely (see FIXME). It looks like /FI
headers generally aren
Author: nico
Date: Sat Mar 12 20:44:13 2016
New Revision: 263352
URL: http://llvm.org/viewvc/llvm-project?rev=263352&view=rev
Log:
clang-cl: Add /Yc argument to /showIncludes output.
To make this work, delay printing of ExtraDeps in HeaderIncludesCallback a bit,
so that it happens after CompilerI
Author: nico
Date: Sat Mar 12 20:48:51 2016
New Revision: 263353
URL: http://llvm.org/viewvc/llvm-project?rev=263353&view=rev
Log:
Make test a bit stricter to check not just the file basename is printed.
Modified:
cfe/trunk/test/Driver/cl-pch-showincludes.cpp
Modified: cfe/trunk/test/Driver/
Author: nico
Date: Sat Mar 12 21:04:46 2016
New Revision: 263355
URL: http://llvm.org/viewvc/llvm-project?rev=263355&view=rev
Log:
Also test that the pch file is not printed in /showIncludes
Modified:
cfe/trunk/test/Driver/cl-pch-showincludes.cpp
Modified: cfe/trunk/test/Driver/cl-pch-showin
On Thu, Aug 8, 2013 at 8:32 PM, Hans Wennborg wrote:
> Author: hans
> Date: Thu Aug 8 19:32:23 2013
> New Revision: 188037
>
> URL: http://llvm.org/viewvc/llvm-project?rev=188037&view=rev
> Log:
> clang-cl: Support /showIncludes
>
> This option prints information about #included files to stderr.
Author: nico
Date: Sun Mar 13 17:26:26 2016
New Revision: 263400
URL: http://llvm.org/viewvc/llvm-project?rev=263400&view=rev
Log:
Try to get cl-pch-showincludes passing on AArch64 bots.
Modified:
cfe/trunk/test/Driver/cl-pch-showincludes.cpp
Modified: cfe/trunk/test/Driver/cl-pch-showinclud
ake a look.
On Sun, Mar 13, 2016 at 5:26 AM, Renato Golin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 13 March 2016 at 02:56, Nico Weber via cfe-commits
> wrote:
> > Author: nico
> > Date: Sat Mar 12 13:55:59 2016
> > New Revision: 263344
> >
> &g
Author: nico
Date: Sun Mar 20 21:48:05 2016
New Revision: 263920
URL: http://llvm.org/viewvc/llvm-project?rev=263920&view=rev
Log:
clang-cl: Add a comment about /Oy- (see r245913).
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
Modified: cfe/trunk/include/clang/Driver/CLCompatOp
Author: nico
Date: Mon Mar 21 12:19:31 2016
New Revision: 263953
URL: http://llvm.org/viewvc/llvm-project?rev=263953&view=rev
Log:
clang-cl: Move /FC from "Unsupported" to "Ignored" list.
/FC affects if diagnostics print with full paths and if __FILE__ expands with a
full path. clang-cl does bot
Author: nico
Date: Mon Mar 21 14:44:18 2016
New Revision: 263974
URL: http://llvm.org/viewvc/llvm-project?rev=263974&view=rev
Log:
clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/lib/Frontend/TextDiagnostic.cpp
cfe/tr
and then we
default to the 2013 behavior.
...bleh, I was just running `svn commit` with a fix, but got a conflict.
Seems like somewhat reverted the change at the same time I was fixing. Will
try again some other time.
>
> On Mon, Mar 21, 2016 at 12:44 PM, Nico Weber via cfe-commits
>
t reverted the change at the same time I was fixing. Will
> try again some other time.
>
To be clear, the "bleh" here was directed at myself. It's always ok to
revert changes that break stuff, and it's entirely on me that I didn't fix
this earlier. So thanks for the r
thakis created this revision.
thakis added reviewers: hans, rnk.
thakis added a subscriber: cfe-commits.
http://reviews.llvm.org/D18392
Files:
lib/Driver/MSVCToolChain.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
===
thakis closed this revision.
thakis added a comment.
r264163, thanks!
http://reviews.llvm.org/D18392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Wed Mar 23 10:37:41 2016
New Revision: 264163
URL: http://llvm.org/viewvc/llvm-project?rev=264163&view=rev
Log:
clang-cl: Don't warn about /Oy- being unused in 64-bit builds.
http://reviews.llvm.org/D18392
Modified:
cfe/trunk/lib/Driver/MSVCToolChain.cpp
cfe/trunk/test
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
`-H` in gcc mode doesn't print `-include` headers, but they are included in
depfiles written by MMD and friends. Since `/showIncludes` is what's used
instead of depfiles, printing `/FI` there see
thakis added a comment.
On second thought, and after looking at -E output with -include and gch files,
and at CC_PRINT_HEADERS behavior (it prints but doesn't indent),
I think I like the alternative implementation I'm mentioning better. Let me
make that change.
http://reviews.llvm.org/D18401
thakis updated the summary for this revision.
thakis updated this revision to Diff 51442.
http://reviews.llvm.org/D18401
Files:
lib/Frontend/CompilerInstance.cpp
lib/Frontend/HeaderIncludeGen.cpp
lib/Frontend/InitPreprocessor.cpp
test/Driver/cl-pch-showincludes.cpp
test/Frontend/print-h
thakis updated this revision to Diff 51448.
thakis marked 2 inline comments as done.
thakis added a comment.
Thanks! All done.
http://reviews.llvm.org/D18401
Files:
lib/Frontend/CompilerInstance.cpp
lib/Frontend/HeaderIncludeGen.cpp
lib/Frontend/InitPreprocessor.cpp
test/Driver/cl-pch-s
Author: nico
Date: Wed Mar 23 13:00:22 2016
New Revision: 264174
URL: http://llvm.org/viewvc/llvm-project?rev=264174&view=rev
Log:
clang-cl: Include /FI headers in /showIncludes output.
-H in gcc mode doesn't print -include headers, but they are included in
depfiles written by MMD and friends. Si
thakis closed this revision.
thakis added a comment.
…and landed in r264174.
http://reviews.llvm.org/D18401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a subscriber: thakis.
thakis added a comment.
FWIW we don't currently use this warning on Chromium because it's way to noisy.
So something like this looks like a great change to me.
dblaikie, are you aware of any codebases that use this warning in its current
form?
http://reviews
Author: nico
Date: Wed Mar 23 13:17:02 2016
New Revision: 264178
URL: http://llvm.org/viewvc/llvm-project?rev=264178&view=rev
Log:
clang-cl: Add more tests for the interaction of /FI and /Yc /Yu.
Most things even work; see the included FIXMEs for things that need polishing.
Also don't warn about
thakis added a comment.
In http://reviews.llvm.org/D18271#381758, @bcraig wrote:
> In http://reviews.llvm.org/D18271#381744, @thakis wrote:
>
> > FWIW we don't currently use this warning on Chromium because it's way to
> > noisy. So something like this looks like a great change to me.
> >
> > db
Author: nico
Date: Wed Mar 23 13:46:57 2016
New Revision: 264182
URL: http://llvm.org/viewvc/llvm-project?rev=264182&view=rev
Log:
clang-cl: Fix remaining bugs in interaction of /Yc and /FI /showIncludes.
Instead of putting the /Yc header into ExtraDeps, give DependencyOutputOptions
a dedicated f
Author: nico
Date: Wed Mar 23 17:57:55 2016
New Revision: 264210
URL: http://llvm.org/viewvc/llvm-project?rev=264210&view=rev
Log:
clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.
Remove tests that have neither a triple nor an explicit -fmsc-version flag,
since in the absence of a
Author: nico
Date: Wed Mar 23 18:01:38 2016
New Revision: 264211
URL: http://llvm.org/viewvc/llvm-project?rev=264211&view=rev
Log:
Fix typo in test from r264210, sigh.
(The test passes both with and without this change, but it's confusing without
it.)
Modified:
cfe/trunk/test/Misc/diag-forma
Author: nico
Date: Wed Mar 23 18:26:59 2016
New Revision: 264216
URL: http://llvm.org/viewvc/llvm-project?rev=264216&view=rev
Log:
clang-cl: Add a FIXME for bumping the default msc version.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.or
Won't this still be broken in mingw (GCC, but on Windows)?
On Mar 24, 2016 9:28 AM, "Eric Liu via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Thu Mar 24 08:22:42 2016
> New Revision: 264277
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264277&view=rev
> Log:
> Add
Author: nico
Date: Mon Mar 28 09:55:24 2016
New Revision: 264582
URL: http://llvm.org/viewvc/llvm-project?rev=264582&view=rev
Log:
Reduce size of DefinitionData from 120 to 96 bytes on Windows.
In the Microsoft ABI, only bitfields with identical types get
packed together, so use unsigned consiste
Author: nico
Date: Mon Mar 28 12:28:06 2016
New Revision: 264597
URL: http://llvm.org/viewvc/llvm-project?rev=264597&view=rev
Log:
Windows: Shrink sizeof(MacroInfo) from 256 to 248, MacroDirective 24 to 16
In the Microsoft ABI, only bitfields with identical types get packed together,
so use consi
Author: nico
Date: Tue Dec 29 17:06:17 2015
New Revision: 256595
URL: http://llvm.org/viewvc/llvm-project?rev=256595&view=rev
Log:
Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/cl
Author: nico
Date: Tue Dec 29 17:17:27 2015
New Revision: 256596
URL: http://llvm.org/viewvc/llvm-project?rev=256596&view=rev
Log:
Emit a -Wmicrosoft warning when treating ^Z as EOF in MS mode.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/clang/Basic/Diagn
On Tue, Dec 29, 2015 at 6:16 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Dec 29, 2015 at 3:06 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: nico
>> Date: Tue Dec 29 17:06:17 2015
>&g
Author: nico
Date: Tue Dec 29 17:23:38 2015
New Revision: 256599
URL: http://llvm.org/viewvc/llvm-project?rev=256599&view=rev
Log:
Fix test from r256596
Modified:
cfe/trunk/test/Lexer/msdos-cpm-eof.c
Modified: cfe/trunk/test/Lexer/msdos-cpm-eof.c
URL:
http://llvm.org/viewvc/llvm-project/cfe
Author: nico
Date: Tue Dec 29 17:30:42 2015
New Revision: 256600
URL: http://llvm.org/viewvc/llvm-project?rev=256600&view=rev
Log:
Address review comment on r256595
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
URL
On Tue, Dec 29, 2015 at 6:28 PM, Richard Smith
wrote:
> On Tue, Dec 29, 2015 at 3:23 PM, Nico Weber wrote:
>
>> On Tue, Dec 29, 2015 at 6:16 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Tue, Dec 29, 2015 at 3:06 P
gen_link_script.py is missing a license header.
On Thu, Oct 22, 2015 at 5:39 PM, Alexey Samsonov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Seems to work now, thanks for the quick fix!
>
> On Thu, Oct 22, 2015 at 1:57 PM, Eric Fiselier wrote:
>
>> Hi Alexey,
>>
>> Please confirm that
One problem with this patch: stdio.h can be used in .c files, and when
building .c files with -gnu99 -pedantic, clang will complain about //
comments. Not only does this stdio.h have // comments, it also pulls in
some libc++ headers (__config) that have // comments as well. I suppose all
the commen
On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
wrote:
> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>
>> One problem with this patch: stdio.h can be used in .c files, and when
>> building .c files with -gnu99 -pedantic,
>>
>
> Do you mean -std=gnu89?
>
Sorry, I meant -std=gnu99 -pedantic
On Thu, Dec 31, 2015 at 10:52 AM, Nico Weber wrote:
> On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
> wrote:
>
>> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>>
>>> One problem with this patch: stdio.h can be used in .c files, and when
>>> building .c files with -gnu99 -pedantic,
>>>
>>
On Wed, Dec 30, 2015 at 12:28 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Dec 29, 2015 at 11:17:28PM -0000, Nico Weber via cfe-commits wrote:
> > Author: nico
> > Date: Tue Dec 29 17:17:27 2015
> > New Revision: 256596
> >
thakis created this revision.
thakis added a reviewer: rsmith.
thakis added a subscriber: cfe-commits.
As far as I can tell, doing
#define HAVE_FOO_BAR defined(FOO) && defined(BAR)
#if HAVE_FOO
...
#endif
has undefined behavior per [cpp.cond]p4. In practice, it can have different
On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
wrote:
> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>
>> One problem with this patch: stdio.h can be used in .c files, and when
>> building .c files with -gnu99 -pedantic,
>>
>
> Do you mean -std=gnu89?
>
>
>> clang will complain about // co
thakis created this revision.
thakis added a reviewer: rtrieu.
thakis added a subscriber: cfe-commits.
Every time I try this warning, it finds a few bugs (I think about 4 total in
Chromium so far), with 0 false positives. I couldn't measure any build
performance degradation when turning it on; I
Author: nico
Date: Wed Jan 6 13:13:49 2016
New Revision: 256960
URL: http://llvm.org/viewvc/llvm-project?rev=256960&view=rev
Log:
Fix -Wdocumentation warning after r256933
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
URL:
http://llvm.o
Author: nico
Date: Wed Jan 6 14:55:00 2016
New Revision: 256975
URL: http://llvm.org/viewvc/llvm-project?rev=256975&view=rev
Log:
Add -Wfor-loop-analysis to -Wall.
This warning seems to have 0 false positives and some true positives in
practice, without a measurable compile time cost. It should
thakis closed this revision.
thakis added a comment.
r256975, thanks!
http://reviews.llvm.org/D15928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sputcEc
(and others) are a hidden symbol in libc++.1.dylib. This means:
* If I use streambuf::sputc() and link against the 10.8 SDK, and the
compiler decides to not inline the call, I will get linker errors.
* If I do the same with t
Thank you!
On Fri, Jan 8, 2016 at 2:24 PM, Evgenii Stepanov
wrote:
> Reverted in r257193.
>
> On Fri, Jan 8, 2016 at 11:12 AM, Evgenii Stepanov
> wrote:
> > On Fri, Jan 8, 2016 at 11:02 AM, Duncan P. N. Exon Smith
> > wrote:
> >>
> >>> On 2016
thakis created this revision.
thakis added a reviewer: djasper.
thakis added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
It always takes me a while to understand how clang-format's pieces fit together
-- hopefully this will save me some time the next time I need it.
http://revi
thakis created this revision.
thakis added a reviewer: rtrieu.
thakis added a subscriber: cfe-commits.
-Wdelete-non-virtual-dtor warns if A is a type with virtual functions but
without virtual dtor has its constructor called via `delete a`. This makes the
warning also fire if the dtor is called
thakis updated this revision to Diff 44958.
thakis added a comment.
For function-type macros, make the warning only show up with -pedantic
http://reviews.llvm.org/D15866
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPExpressions.cpp
te
Thanks for the review!
I tweaked it a bit so that this only warns on function-type macros in
-pedantic mode. That way, the warning can even be used in practice :-)
On Thu, Jan 14, 2016 at 10:33 PM, Nico Weber wrote:
> thakis updated this revision to Diff 44958.
> thakis added a comment.
>
> For
thakis updated this revision to Diff 44959.
thakis added a comment.
Address review comment.
http://reviews.llvm.org/D15866
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/PPExpressions.cpp
test/Lexer/cxx-features.cpp
test/Preprocessor/e
thakis marked an inline comment as done.
thakis added a comment.
Also addressed your comment and added a test for that.
http://reviews.llvm.org/D15866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
This test fails on OS X for me:
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
FAIL: libc++abi :: incomplete_type.sh.cpp (29529 of 29545)
TEST 'libc++abi :: incomplete_type.sh.cpp' FAILED
Script:
--
/Applications/Xcode.app/Contents/Developer/T
I reverted this and 322 for now in 257896.
On Fri, Jan 15, 2016 at 10:36 AM, Nico Weber wrote:
> This test fails on OS X for me:
>
>
> Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
> FAIL: libc++abi :: incomplete_type.sh.cpp (29529 of 29545)
> TEST 'libc++abi ::
Author: nico
Date: Fri Jan 15 09:44:14 2016
New Revision: 257896
URL: http://llvm.org/viewvc/llvm-project?rev=257896&view=rev
Log:
Revert r256322 (and follow-up 256323), the test it added does not pass on OS X.
Removed:
libcxxabi/trunk/test/incomplete_type.sh.cpp
Modified:
libcxxabi/trunk
thakis added a comment.
This test is failing again when it runs as part of llvm's tests when I
build a clang package for chromium. It passes when I run it in my regular
llvm build directory (where I ran it to test my "fix") -- this explains why
the fix didn't work when I tried it in the chrome cas
thakis added a comment.
In http://reviews.llvm.org/D15363#321941, @samsonov wrote:
> Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on
> Windows? Seems so: I don't see an XFAIL there, and it also uses
> suppressions, but with single quote, followed by double quote:
>
> %
Author: nico
Date: Fri Jan 15 15:45:31 2016
New Revision: 257939
URL: http://llvm.org/viewvc/llvm-project?rev=257939&view=rev
Log:
Make -Wdelete-non-virtual-dtor warn on explicit `a->~A()` dtor calls too.
-Wdelete-non-virtual-dtor warns if A is a type with virtual functions but
without virtual dt
thakis closed this revision.
thakis added a comment.
r257939, thanks!
http://reviews.llvm.org/D16206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
I figured out the difference. If I set up my environment by running
`setenv.cmd` in the windows sdk, the test fails. If I set it up by running
`vcvarsall.bat`, the test succeeds. Not clear yet why. But with the setenv.cmd
setup, the asan suppression test fails too.
Rep
thakis added a comment.
I re-disabled the test in 257952.
Repository:
rL LLVM
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Tue Jan 19 09:15:31 2016
New Revision: 258128
URL: http://llvm.org/viewvc/llvm-project?rev=258128&view=rev
Log:
Add -Wexpansion-to-undefined: warn when using `defined` in a macro definition.
[cpp.cond]p4:
Prior to evaluation, macro invocations in the list of preprocessing
t
thakis closed this revision.
thakis added a comment.
r258128
http://reviews.llvm.org/D15866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Tue Jan 19 09:32:55 2016
New Revision: 258131
URL: http://llvm.org/viewvc/llvm-project?rev=258131&view=rev
Log:
Rename -Wexpansion-to-undefined to -Wexpansion-to-defined.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/clang/Basic/Diagnosti
ng our internal builds (we build with -Werror).
>
> I fixed one file that was producing this, but there are several that have
> the same problem (e.g., gtest-port.h). Could you fix them or rollback?
>
>
> Thanks. Diego.
>
> On Tue, Jan 19, 2016 at 10:15 AM, Nico Weber via c
I mean you could pass a -Wno flag. It's undefined behavior that's actually
causing bugs in practice; it should probably be on by default.
On Jan 19, 2016 3:38 PM, "Diego Novillo" wrote:
>
>
> On Tue, Jan 19, 2016 at 3:30 PM, Nico Weber wrote:
>
>> I'll take a look. If it's urgent it's also possi
Back at my desk now, looking.
On Tue, Jan 19, 2016 at 3:44 PM, Diego Novillo wrote:
>
>
> On Tue, Jan 19, 2016 at 3:43 PM, Nico Weber wrote:
>
>> I mean you could pass a -Wno flag. It's undefined behavior that's
>> actually causing bugs in practice; it should probably be on by default.
>>
>
> B
r258181 should stop the bleeding. I'll look at fixing the warnings now.
On Tue, Jan 19, 2016 at 3:46 PM, Nico Weber wrote:
> Back at my desk now, looking.
>
> On Tue, Jan 19, 2016 at 3:44 PM, Diego Novillo
> wrote:
>
>>
>>
>> On Tue, Jan 19, 2016 at 3:43 PM, Nico Weber wrote:
>>
>>> I mean you
I think I've fixed all warnings by now, and I've reenabled the warning for
LLVM builds (in r258210; that commit's commit message links to the
individual fixes.)
On Tue, Jan 19, 2016 at 3:56 PM, Nico Weber wrote:
> r258181 should stop the bleeding. I'll look at fixing the warnings now.
>
> On Tue
Eric, Marshall: another ping. This should be fixed on the 3.8 branch, so it
needs to be resolved soon.
On Jan 5, 2016 5:25 PM, "Nico Weber" wrote:
> On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
> wrote:
>
>> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>>
>>> One problem with this patch
1301 - 1400 of 1693 matches
Mail list logo
