thakis added a comment.
Ah, you answered my question while I was writing it.
Doesn't that mean whatever feature this test is testing is broken on Windows?
http://reviews.llvm.org/D20369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
thakis added a comment.
(If so, maybe add a FIXME comment to make things work without delayed template
parsing. In any case, getting the bot green is the most important thing, so
landing this as is is definitely fine.)
http://reviews.llvm.org/D20369
_
thakis added a subscriber: thakis.
thakis added a comment.
Did you see http://reviews.llvm.org/D19815 ? Does that help? Warren might have
opinions on this.
http://reviews.llvm.org/D20243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: nico
Date: Tue Mar 29 14:41:02 2016
New Revision: 264774
URL: http://llvm.org/viewvc/llvm-project?rev=264774&view=rev
Log:
clang-cl: Silently ignore /d2FastFail flag.
It's some debugging flag for cl.exe related to how it writes crash dumps.
Modified:
cfe/trunk/include/clang/Driver/CL
This doesn't build on Windows:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11018/steps/build%20stage%201/logs/stdio
d:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\tools\extra\clang-tidy\readability\../ClangTidyModule.h(61)
: error C2660:
'clang::tidy::readability::AvoidCons
Looks like this broke clang-tidy/misc-dangling-handle.cpp (
http://lab.llvm.org:8011/builders/clang-bpf-build/builds/9704). Can you
take a look?
On Wed, Mar 30, 2016 at 4:22 AM, Gabor Horvath via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: xazax
> Date: Wed Mar 30 06:22:14 2016
> N
Author: nico
Date: Sat Apr 2 14:10:07 2016
New Revision: 265238
URL: http://llvm.org/viewvc/llvm-project?rev=265238&view=rev
Log:
clang-cl: Don't skip i_group flags other than -include when building pchs.
Before this change, e.g. -isystem flags in front of the /FI corresponding to the
pch file w
Thanks, r265324 fixed the assert.
On Fri, Apr 1, 2016 at 8:25 PM, John McCall wrote:
> On Apr 1, 2016, at 3:50 PM, Nico Weber wrote:
> On Thu, Mar 10, 2016 at 8:30 PM, John McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rjmccall
>> Date: Thu Mar 10 22:30:31 2016
>> N
Hi,
r260990 exposed -isystem in clang-cl. -isystem adds a directory to the
front of the system include search path. The idea was to use this to point
to a hermetic msvc install, but as it turns out this doesn't work: -isystem
then adds the hermetic headers in front of clang's builtin headers, and
Author: nico
Date: Tue Apr 12 11:38:07 2016
New Revision: 266090
URL: http://llvm.org/viewvc/llvm-project?rev=266090&view=rev
Log:
clang-cl: Expose -nostdlibinc.
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/include/clang/Drive
Author: nico
Date: Tue Apr 12 11:52:30 2016
New Revision: 266091
URL: http://llvm.org/viewvc/llvm-project?rev=266091&view=rev
Log:
Revert 266090, needs more testing first.
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/include/c
All done. phab's back, but since we started with a patch attachment, let's
keep it that way.
On Tue, Apr 12, 2016 at 12:12 PM, Hans Wennborg wrote:
> On Mon, Apr 11, 2016 at 7:16 PM, Nico Weber wrote:
> > r260990 exposed -isystem in clang-cl. -isystem adds a directory to the
> front
> > of th
Author: nico
Date: Tue Apr 12 14:04:37 2016
New Revision: 266108
URL: http://llvm.org/viewvc/llvm-project?rev=266108&view=rev
Log:
clang-cl: Remove -isystem, add -imsvc.
r260990 exposed -isystem in clang-cl. -isystem adds a directory to the front of
the system include search path. The idea was to
On Thu, Apr 14, 2016 at 4:09 AM, Ismail Donmez via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> On Tue, Apr 12, 2016 at 10:04 PM, Nico Weber via cfe-commits
> wrote:
> > Author: nico
> > Date: Tue Apr 12 14:04:37 2016
> > New Revision: 266108
Author: nico
Date: Thu Apr 14 06:12:32 2016
New Revision: 266290
URL: http://llvm.org/viewvc/llvm-project?rev=266290&view=rev
Log:
Reapply r258505 after r266254, this time with a comment to make it more sticky.
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
Modified: cfe/trunk/i
This broke building on
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7 . I tried fixing in
r266290.
On Wed, Apr 13, 2016 at 5:57 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Wed Apr 13 16:57:08 2016
> New Revision: 266254
>
> URL: http://l
thakis added a subscriber: thakis.
thakis added a comment.
> I want to replace all unsigned that are 1 bits with bool.
MSVC only packs bitfields of the same type together, so doing that change would
make clang use much more memory on Windows.
http://reviews.llvm.org/D19105
On Thu, Apr 14, 2016 at 10:32 AM, Ismail Donmez wrote:
> On Thu, Apr 14, 2016 at 2:09 PM, Nico Weber wrote:
> > It's supposed to match the
> >
> > "-internal-isystem"
> >
> "/home/abuild/rpmbuild/BUILD/llvm/stage2/bin/../lib64/clang/3.9.0/include"
> > "-internal-isystem" "myincludedir"
> >
> > b
This very likely caused https://llvm.org/bugs/show_bug.cgi?id=27367
On Fri, Apr 15, 2016 at 4:03 AM, Andrey Bokhanko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: asbokhan
> Date: Fri Apr 15 03:03:51 2016
> New Revision: 266415
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266
On Fri, Apr 15, 2016 at 12:27 AM, Hal Finkel wrote:
> - Original Message -
> > From: "Hans Wennborg via cfe-commits"
> > To: "Nemanja Ivanovic" , "Nico Weber" <
> tha...@chromium.org>
> > Cc: "cfe-commits"
> > Sent: Thursday, April 14, 2016 8:07:58 PM
> > Subject: Re: r266186 - Enable s
Author: nico
Date: Fri Apr 15 09:35:06 2016
New Revision: 266431
URL: http://llvm.org/viewvc/llvm-project?rev=266431&view=rev
Log:
Revert r266415, it broke parsing SDK headers (PR27367).
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/include/clang/Basic/AddressSpaces.h
cfe/tru
I've looked into this a bit, and this breaks compiling programs like
`#include ` on linux, without passing any special flags (other than
`-std=gnu++11`). That seems like a very big regression :-) I think this
should be reverted, so that there's no rush for getting your other patch in.
LLVM tries t
Hi Serge,
this complains on this snippet from v8:
template
class LSubKindOperand final : public LOperand {
public:
static LSubKindOperand* Create(int index, Zone* zone) {
if (index < kNumCachedOperands) return &cache[index];
return new(zone) LSubKindOperand(index);
}
private:
sta
(sorry, accidentally sent this mid-mail)
../../v8/src/crankshaft/lithium.h:322:45: error: instantiation of variable
'v8::internal::LSubKindOperand::cache' required here, but no definition is available
[-Werror,-Wundefined-var-template]
if (index < kNumCachedOperands) return &cache[index];
Author: nico
Date: Thu Apr 21 14:59:10 2016
New Revision: 267040
URL: http://llvm.org/viewvc/llvm-project?rev=267040&view=rev
Log:
clang-cl: Don't assert on using /Yc with non-source files, PR27450
Move phase handling after input type validation.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
nused" warning may be suppressed somehow.
>
> I'd appreciate any help looking into this.
>
> thanks,
> vedant
>
> > On Apr 21, 2016, at 12:59 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: nico
>
(stderr):
> >> --
> >> /Users/buildslave/jenkins/sharedspace/phase1@2/llvm/tools/clang/test/Driver/cl-pch.cpp:314:20:
> error: expected string not found in input
> >> // CHECK-NoSource: file.prof:{{.*}}input unused
> >> :5:7: note: possible intended match here
&g
Author: nico
Date: Thu Apr 21 19:38:09 2016
New Revision: 267089
URL: http://llvm.org/viewvc/llvm-project?rev=267089&view=rev
Log:
Try to get test passing on OS X (see comment at top of file).
Modified:
cfe/trunk/test/Driver/cl-pch.cpp
Modified: cfe/trunk/test/Driver/cl-pch.cpp
URL:
http://
Hi Richard,
1.) Are these new warnings in -Wconversion? If not, they probably should
be, right?
2.) It looks like -Wfloat-bool-constant-conversion is on by default and
warns on things like
if (kHotspotRadius)
if kHotspotRadius is a float. Do you have data that suggests that this is a
common b
thakis created this revision.
thakis added a reviewer: rnk.
thakis added a subscriber: cfe-commits.
Currently, clang-cl always uses Windows style for unquoting, and clang always
uses POSIX style for unquoting.
In general, response file quoting should match the shell the response file is
used in
thakis added a comment.
Thanks!
Comment at: tools/driver/driver.cpp:350
@@ +349,3 @@
+ for (const char *F : argv) {
+if (strcmp(F, "--rsp-quoting=posix") == 0)
+ RSPQuoting = POSIX;
rnk wrote:
> Should we call it "posix" or "gnu"? The reference impleme
Author: nico
Date: Mon Apr 25 16:15:49 2016
New Revision: 267474
URL: http://llvm.org/viewvc/llvm-project?rev=267474&view=rev
Log:
driver: Add a `--rsp-quoting` flag to pick response file quoting.
Currently, clang-cl always uses Windows style for unquoting, and clang always
uses POSIX style for u
thakis closed this revision.
thakis added a comment.
Landed the new flag and its tests in r267474, thanks! (Didn't land the test
updates needed after http://reviews.llvm.org/D19417 yet, since that's not in
yet.)
http://reviews.llvm.org/D19425
___
Looks like this broke
http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/13793/steps/docs-clang-html/logs/stdio
/home/llvmbb/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UndefinedBehaviorSanitizer.rst:96:
WARNING: Bullet list ends without a blank line; unexpected unindent.
Author: nico
Date: Tue Apr 26 08:54:29 2016
New Revision: 267557
URL: http://llvm.org/viewvc/llvm-project?rev=267557&view=rev
Log:
Update test after LLVM r267556.
Modified:
cfe/trunk/test/Driver/at_file.c
cfe/trunk/test/Driver/at_file.c.args
Modified: cfe/trunk/test/Driver/at_file.c
URL:
Next time, please use real commit messages: Describe what the change does,
and why it's being done. Include a link to the review link at the end of
the commit message. If every change just had a phab link as commit message,
people bisecting changes would have to click through for every change in
`s
thakis added a comment.
Hm, the ASTReader code this works around is over 6 years old (r100866). Maybe
we could try enabling the access time check instead?
http://reviews.llvm.org/D20243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: nico
Date: Wed May 25 09:15:08 2016
New Revision: 270702
URL: http://llvm.org/viewvc/llvm-project?rev=270702&view=rev
Log:
Fix mangled name of method with ns_consumed parameters.
When a function/method use a parameter with "ns_consumed" attribute,
ensure that the mangled name is the same
thakis added a subscriber: thakis.
thakis accepted this revision.
thakis added a reviewer: thakis.
thakis added a comment.
This revision is now accepted and ready to land.
We use phabricator not very dogmatically. If John says this looks good, then
this looks good, even if phab didn't get the mes
thakis added a comment.
Looks great, thanks! A few minor questions below.
I verified that this has the same effect as my brute-force patch I tried
locally.
Do we have test coverage for `template class __declspec(dllexport)
codecvt;` somewhere already?
Comment at: lib/Sema/Se
Zombie review comment: ".test" isn't part of test/lit.cfg::config.suffixes,
so the two .test files added in this change never run unless you explicitly
run them (e.g. with `bin/llvm-lit
../llvm-rw/tools/clang/test/CodeGenCXX/*.test`).
CodeGenCXX/debug-info-class-limited.test fails when I run it lik
thakis accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaTemplate.cpp:7382
@@ +7381,3 @@
+ if (A->getKind() == AttributeList::AT_DLLExport) {
+// dllexport trumps dllexport here.
+DLLImport = false;
-
thakis added a subscriber: thakis.
thakis accepted this revision.
thakis added a reviewer: thakis.
thakis added a comment.
This revision is now accepted and ready to land.
s/retiring/requiring/, right?
http://reviews.llvm.org/D20828
___
cfe-commits
Can you add this to the release notes? It'll for example break chromium's
crash server (we can fix this on our end by explicitly passing
-Wl,--build-id for release builds, but we only saw this commit fly by by
chance.)
On Fri, Jun 3, 2016 at 1:26 PM, Rafael Espindola via cfe-commits <
cfe-commits@
I'm getting lots of warnings like so:
In file included from
..\..\tools\win\static_initializers\static_initializers.cc:5:
C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\DIA
SDK\include\dia2.h(30,10): error: non-portable path to file '"Windows.h"';
specified path
Also, once that is resolved, this warning tells people that #include
is wrong:
..\..\third_party\ffmpeg\compat/w32pthreads.h(39,10): warning:
non-portable path to file ''; specified path differs in case
from file name on disk [-Wnonportable-include-path]
#include
^~~
It's not just windows.h, but windows sdk headers in general (#include
, #include #include #include
etc). Here's what the warning does on the first few files in
Chromium:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/8155/steps/compile/logs/stdio
(We add /FIIntrin.h -- but
On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote:
> I just checked, and warnings are not emitted from files in an -isystem
> path. I didn’t have to do anything special to get that behavior. I don’t
> know about -imsvc. Is that a clang-cl thing? I can’t say at this point why
> the diagnostics sy
On Fri, Jun 3, 2016 at 7:07 PM, Eric Niebler wrote:
> On 6/3/16, 3:24 PM, "tha...@google.com on behalf of Nico Weber" <
> tha...@google.com on behalf of tha...@chromium.org> wrote:
> > On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote:
> >> I just checked, and warnings are not emitted from file
Hi,
please write better change descriptions. I just looked through a regression
range with `svn log -r271271:271293`, and for this change I had to look up
the change instead of skimming the change description before I could be
sure that this change isn't related to what I'm currently looking at.
lgtm
On Sun, Jun 5, 2016 at 3:31 PM, Rafael Espíndola wrote:
> Patch attached. What do you think?
>
> Cheers,
> Rafael
>
>
> On 3 June 2016 at 16:11, Ed Maste wrote:
> > On 3 June 2016 at 15:53, Nico Weber via cfe-commits
> > wrote:
> >> Can yo
thakis added a comment.
For performance: Can you check how build times for some large target in
Chromium on Linux targeting Windows compares with this vs having the sdk in a
fat mount? That would give us some data.
The discussion in the include case warning thread sounds like MS might update
i
It looks like we're starting to be more careful about header case. MSVC's
intrin.h is called intrin.h with a lower-case 'i'; ours starts with an
upper-case 'I' for no good reason.
It looks like file-only renames work fine as of svn 1.7 without any
workarounds (
http://subversion.apache.org/docs/re
On Wed, Jun 8, 2016 at 1:27 PM, Hans Wennborg wrote:
> On Wed, Jun 8, 2016 at 10:20 AM, Nico Weber wrote:
> > It looks like we're starting to be more careful about header case. MSVC's
> > intrin.h is called intrin.h with a lower-case 'i'; ours starts with an
> > upper-case 'I' for no good reason
On Wed, Jun 8, 2016 at 1:56 PM, Eric Niebler wrote:
> (adding back cfe-commits, answers inline)
>
> On 6/8/16, 10:11 AM, "tha...@google.com on behalf of Nico Weber" <
> tha...@google.com on behalf of tha...@chromium.org> wrote:
> >Sounds like "commit to the current file case and fix all the world
thakis added a comment.
Can you try building a few more files? Say, v8_base?
http://reviews.llvm.org/D21113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
Not sure if we want a flag that adds 50% overhead, no matter how convenient it
might be :-/
http://reviews.llvm.org/D21113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
thakis added a comment.
probably at least the "the XOR with RSP/EBP/ESP" bit still (and maybe EH
function upgrades instead of bailing)
Comment at: lib/Driver/Tools.cpp:9990
@@ +9989,3 @@
+ /*default=*/false))
+CmdArgs.push_back("/GS-");
+
Author: nico
Date: Fri Jun 10 13:53:04 2016
New Revision: 272415
URL: http://llvm.org/viewvc/llvm-project?rev=272415&view=rev
Log:
Remove a few gendered pronouns.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
I locally set up an SVN repo with a file called "File.txt" and then renamed
it with `svn mv` using a new svn client (1.8).
Then I tried updating several local checkouts of my local repo with svn
1.6.6 clients. All methods of updating I tried (`svn up`, `svn co
current_checkout_url@2`) worked witho
Author: nico
Date: Tue Jun 14 14:54:40 2016
New Revision: 272701
URL: http://llvm.org/viewvc/llvm-project?rev=272701&view=rev
Log:
Rename Intrin.h to intrin.h, that's how all the documentation calls it.
Added:
cfe/trunk/lib/Headers/intrin.h (props changed)
- copied unchanged from r272
manually do anything with that svn:mergeinfo chunk.
On Tue, Jun 14, 2016 at 9:54 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Tue Jun 14 14:54:40 2016
> New Revision: 272701
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272701&
r272701, thanks!
On Tue, Jun 14, 2016 at 9:34 PM, Hans Wennborg wrote:
> SGTM, then :-)
>
> On Tue, Jun 14, 2016 at 11:54 AM, Nico Weber wrote:
> > I locally set up an SVN repo with a file called "File.txt" and then
> renamed
> > it with `svn mv` using a new svn client (1.8).
> >
> > Then I tri
Thank you!
On Tue, Jun 14, 2016 at 10:14 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Tue Jun 14 15:14:24 2016
> New Revision: 272702
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272702&view=rev
> Log:
> s/Intrin.h/intrin.h/, trying to fix the
Maybe this should use the marketing name ("before msvc 2013")? People might
be more familiar with that.
On Jun 15, 2016 2:34 AM, "Saleem Abdulrasool via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Tue Jun 14 19:28:15 2016
> New Revision: 272741
>
> URL: http://llvm
thanks!
On Fri, Jun 17, 2016 at 2:27 AM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Thu Jun 16 19:27:02 2016
> New Revision: 272979
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272979&view=rev
> Log:
> Headers: wordsmith error message
>
Did you land this intentionally? What was the commit message supposed to be?
On Mon, Jun 27, 2016 at 6:11 PM, Chris Dewhurst via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: lerochris
> Date: Mon Jun 27 17:11:12 2016
> New Revision: 273950
>
> URL: http://llvm.org/viewvc/llvm-projec
For clang-cl, we should follow cl's model of selecting a standard. Before
C++17, this was "use newest language the compiler knows about" (keyed off
-fmsc-version; clang-cl detects the system msvc version by default if
that's not passed in). After C++17, there's an explicit language flag, and
we use
On Wed, Jun 29, 2016 at 3:25 PM, Richard Smith
wrote:
> On Wed, Jun 29, 2016 at 12:14 PM, Nico Weber wrote:
>
>> For clang-cl, we should follow cl's model of selecting a standard. Before
>> C++17, this was "use newest language the compiler knows about" (keyed off
>> -fmsc-version; clang-cl detec
thakis created this revision.
thakis added a reviewer: alexfh.
thakis added a subscriber: cfe-commits.
Currently, to be able to process a source file including e.g. stddef.h with
clang-tidy, one has to build both clang-tidy and the clang-headers target.
Since stddef.h is needed for virtually an
When reverting something, please say why in the commit description.
On Wed, Jul 6, 2016 at 11:15 AM, Adrian McCarthy via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: amccarth
> Date: Wed Jul 6 10:15:38 2016
> New Revision: 274633
>
> URL: http://llvm.org/viewvc/llvm-project?rev=274
thakis added a comment.
r274751, thanks!
http://reviews.llvm.org/D22046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Jul 7 08:19:45 2016
New Revision: 274751
URL: http://llvm.org/viewvc/llvm-project?rev=274751&view=rev
Log:
[clang-tidy] Add dependency on clang-headers
Currently, to be able to process a source file including e.g. stddef.h with
clang-tidy, one has to build both clang-tidy
On Fri, Jul 8, 2016 at 3:57 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Thu, Jul 7, 2016 at 4:10 PM, Reid Kleckner wrote:
>
>> On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie wrote:
>>
>>> Yeah - is this necessary for CodeView? (does something break, or do you
>
This breaks existing users of -gline-tables-only. What's the motivation for
this change?
On Sat, Jul 9, 2016 at 5:49 PM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: majnemer
> Date: Sat Jul 9 16:49:16 2016
> New Revision: 274991
>
> URL: http://llvm.org/viewvc/l
VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This means
people who want to ask clang-cl for line tables only will have to add this
flag in some if(is_clang) block in their build file anyways. What's the
advantage of giving this flag a spelling that's different from both cl and
cla
On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer
wrote:
>
>
> On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote:
>
>> VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This means
>> people who want to ask clang-cl for line tables only will have to add this
>> flag in some if(is_clan
On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer
wrote:
>
>
> On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote:
>
>> On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer <
>> david.majne...@gmail.com> wrote:
>>
>>>
>>>
>>> On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote:
>>>
VS2013's cl.exe
On Mon, Jul 11, 2016 at 12:19 PM, David Majnemer
wrote:
>
>
> On Mon, Jul 11, 2016 at 9:03 AM, Nico Weber wrote:
>
>> On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer <
>> david.majne...@gmail.com> wrote:
>>
>>>
>>>
>>> On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote:
>>>
On Mon, Jul 11,
Hi,
this fires on (at least) usrsctplib [1]:
FAILED: obj/third_party/usrsctp/usrsctp/sctp_input.o
../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:1708:15:
error: taking address of packed member 'time_entered' of class or structure
'sctp_state_cookie' may result in an unaligne
On Thu, Jul 14, 2016 at 5:07 PM, Richard Smith
wrote:
> On Thu, Jul 14, 2016 at 10:15 AM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi,
>>
>> this fires on (at least) usrsctplib [1]:
>>
>> FAILED: obj/third_party/usrs
*Sent:* 14 July 2016 22:14:10
> *To:* Richard Smith
> *Cc:* Roger Ferrer Ibanez; cfe-commits
> *Subject:* Re: r275417 - Diagnose taking address and reference binding of
> packed members
>
> On Thu, Jul 14, 2016 at 5:07 PM, Richard Smith
> wrote:
>
>> On Thu, Jul 14, 2016
On Wed, Oct 14, 2015 at 5:25 AM, Filipe Cabecinhas via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: filcab
> Date: Wed Oct 14 07:25:43 2015
> New Revision: 250293
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250293&view=rev
> Log:
> Bring back r250262: PS4 toolchain
>
> There was
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
In the gcc precompiled header model, one explicitly runs clang with `-x
c++-header` on a .h file to produce a gch file, and then includes the header
with `-include foo.h` and if a .gch file exist
thakis updated this revision to Diff 49325.
thakis added a comment.
clean up accidentally duplicate if block
http://reviews.llvm.org/D17695
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/Action.h
include/clang/Driver/CLCo
Do you think something like the implicit inputs thing in
http://reviews.llvm.org/D17695 could work for you as well, instead of this
patch? Then we don't have to forever promise to compile all .cc input files
serially.
On Wed, Feb 24, 2016 at 4:49 PM, Justin Lebar via cfe-commits <
cfe-commits@list
On Sun, Feb 28, 2016 at 3:40 PM, Justin Lebar wrote:
> On Sun, Feb 28, 2016 at 1:46 PM, Nico Weber wrote:
> > Do you think something like the implicit inputs thing in
> > http://reviews.llvm.org/D17695 could work for you as well, instead of
> this
> > patch?
>
> Having read just the patch descri
thakis added a subscriber: thakis.
thakis added a comment.
I don't understand the changes to Driver.cpp lines 1760 and down. The rest
looks good to me.
Comment at: lib/Driver/Driver.cpp:1761
@@ -1747,1 +1760,3 @@
+const ActionList *BackendInputs =
+ (EmbedBitcode ? Inp
thakis added a subscriber: thakis.
thakis added a comment.
Instead of doing this, would it make sense to have a flag like -ffile-basename
that changes what __FILE__ expands to?
I had wished I'd be able to have some control over __FILE__ (I'd like to say
"make all __FILE__s relative to this give
thakis accepted this revision.
thakis added a reviewer: thakis.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks, that's much clearer :-)
http://reviews.llvm.org/D17390
___
cfe-commits mailing list
cfe-commits@lists.ll
thakis added a comment.
In http://reviews.llvm.org/D17741#364931, @weimingz wrote:
> In http://reviews.llvm.org/D17741#364756, @thakis wrote:
>
> > Instead of doing this, would it make sense to have a flag like
> > -ffile-basename that changes what __FILE__ expands to?
> >
> > I had wished I'd b
thakis added a comment.
> I think we can do this separately. A "basename" macro is easier for
> programmers to use and no build system change needed.
Hm, I would think that adding a flag to your CFLAGS is easier than getting all
your dependencies to use a clang-only new macro…
http://reviews
thakis updated the summary for this revision.
thakis updated this revision to Diff 49541.
thakis marked 5 inline comments as done.
thakis added a comment.
- rebase across jlebar's r261774 => implicit_inputs gone, ForceSuccessCommand
is new
- .h file is found relative to include paths => introduce
thakis added inline comments.
Comment at: lib/Driver/Driver.cpp:2355
@@ +2354,3 @@
+
+// Add pch if needed: "If you do not specify an extension as part of the
+// path name, an extension of .pch is assumed. "
hans wrote:
> Maybe add .pch if needed?
It alre
thakis updated this revision to Diff 49544.
thakis added a comment.
forgot to `svn add` two new test files
http://reviews.llvm.org/D17695
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/CC1Options.td
include/clang/Driver/C
thakis closed this revision.
thakis marked 3 inline comments as done.
thakis added a comment.
r262420, thanks!
http://reviews.llvm.org/D17695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: nico
Date: Tue Mar 1 17:16:44 2016
New Revision: 262420
URL: http://llvm.org/viewvc/llvm-project?rev=262420&view=rev
Log:
clang-cl: Implement initial limited support for precompiled headers.
In the gcc precompiled header model, one explicitly runs clang with `-x
c++-header` on a .h file
thakis created this revision.
thakis added a reviewer: rnk.
thakis added a subscriber: cfe-commits.
`#pragma comment` was handled by Sema calling a function on ASTConsumer, and
CodeGen then implementing this function and writing things to its output.
Instead, introduce a PragmaCommentDecl AST no
Author: nico
Date: Wed Mar 2 11:28:48 2016
New Revision: 262493
URL: http://llvm.org/viewvc/llvm-project?rev=262493&view=rev
Log:
Serialize `#pragma comment`.
`#pragma comment` was handled by Sema calling a function on ASTConsumer, and
CodeGen then implementing this function and writing things t
thakis closed this revision.
thakis added a comment.
r262493, thanks!
http://reviews.llvm.org/D17799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1201 - 1300 of 1693 matches
Mail list logo
