Author: nico
Date: Fri Dec 9 11:32:52 2016
New Revision: 289228
URL: http://llvm.org/viewvc/llvm-project?rev=289228&view=rev
Log:
Don't assert when redefining a built-in macro in a PCH, PR29119
PCH files store the macro history for a given macro, and the whole history list
for one identifier is
I never heard "class specifier" outside of compilerese either…
On Fri, Dec 9, 2016 at 2:47 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Fri Dec 9 13:47:58 2016
> New Revision: 289259
>
> URL: http://llvm.org/viewvc/llvm-project?rev=289259&view=rev
Shouldn't this at least use >=? (But it feels like there is probably a way
that doesn't have to do UA sniffing, so to speak)
On Dec 9, 2016 8:04 PM, "Vedant Kumar via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: vedantk
> Date: Fri Dec 9 18:54:13 2016
> New Revision: 289308
>
> UR
Author: nico
Date: Fri Apr 21 15:12:26 2017
New Revision: 301032
URL: http://llvm.org/viewvc/llvm-project?rev=301032&view=rev
Log:
[ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl,
PR32736
clang-cl sets MicrosoftCompat. In that mode, we always give enums a fixed
underlyi
Author: nico
Date: Fri Apr 21 15:55:00 2017
New Revision: 301039
URL: http://llvm.org/viewvc/llvm-project?rev=301039&view=rev
Log:
Add comments to the diagnostic kinds in Diagnostic.td.
https://reviews.llvm.org/D32371
Modified:
cfe/trunk/include/clang/Basic/Diagnostic.td
Modified: cfe/trunk
On Sat, Apr 22, 2017 at 8:40 PM, Duncan P. N. Exon Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> [Some necromancy here...]
>
> This commit effectively reverted r173361 and r173825, breaking UNIX
> conformance for our c99 wrapper.
>
> See:
> http://pubs.opengroup.org/onlinepubs/96999
It does sound pretty similar to me from the blog post. I think this is a
decent place to start from.
On Apr 24, 2017 11:55 AM, "David Majnemer via Phabricator via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> majnemer requested changes to this revision.
> majnemer added a comment.
> This re
"Opting into the conforming mode, /permissive-, during the series of VS
2017 update is a commitment to keeping your code base clean and to fixing
non-conforming constructs we fix conformance issues in Visual C++." [...]
"By contrast /permissive- offers a useful conformance mode where input C++
code
majnemer: opinion on the above?
On Apr 24, 2017 2:56 PM, "Nico Weber" wrote:
> "Opting into the conforming mode, /permissive-, during the series of VS
> 2017 update is a commitment to keeping your code base clean and to fixing
> non-conforming constructs we fix conformance issues in Visual C++."
On Mon, Apr 24, 2017 at 10:00 PM, David Majnemer
wrote:
>
>
> On Mon, Apr 24, 2017 at 11:56 AM, Nico Weber wrote:
>
>> "Opting into the conforming mode, /permissive-, during the series of VS
>> 2017 update is a commitment to keeping your code base clean and to fixing
>> non-conforming constructs
On Tue, Apr 25, 2017 at 2:06 PM, David Majnemer
wrote:
>
>
> On Tue, Apr 25, 2017 at 8:46 AM, Nico Weber wrote:
>
>> On Mon, Apr 24, 2017 at 10:00 PM, David Majnemer <
>> david.majne...@gmail.com> wrote:
>>
>>>
>>>
>>> On Mon, Apr 24, 2017 at 11:56 AM, Nico Weber
>>> wrote:
>>>
"Opting int
On Tue, Apr 25, 2017 at 4:14 PM, David Majnemer
wrote:
>
>
> On Tue, Apr 25, 2017 at 11:42 AM, Nico Weber wrote:
>
>> On Tue, Apr 25, 2017 at 2:06 PM, David Majnemer > > wrote:
>>
>>>
>>>
>>> On Tue, Apr 25, 2017 at 8:46 AM, Nico Weber wrote:
>>>
On Mon, Apr 24, 2017 at 10:00 PM, David Maj
On Tue, Apr 25, 2017 at 5:28 PM, David Majnemer
wrote:
>
>
> On Tue, Apr 25, 2017 at 2:12 PM, Nico Weber wrote:
>
>> On Tue, Apr 25, 2017 at 4:14 PM, David Majnemer > > wrote:
>>
>>>
>>>
>>> On Tue, Apr 25, 2017 at 11:42 AM, Nico Weber
>>> wrote:
>>>
On Tue, Apr 25, 2017 at 2:06 PM, David
See https://bugs.chromium.org/p/chromium/issues/detail?id=715315
Looks good, please land to get the tree back green while we investigate.
On Apr 25, 2017 8:51 PM, "Evgeniy Stepanov via Phabricator via cfe-commits"
wrote:
> eugenis added a comment.
>
> Apparently the ODR detector in Asan on Wind
Author: nico
Date: Thu May 4 14:36:26 2017
New Revision: 302187
URL: http://llvm.org/viewvc/llvm-project?rev=302187&view=rev
Log:
Turn -Wmicrosoft-enum-value off by default.
The warning is currently way too noisy to be useful. The plan is
to make it warn when an MS enum that's negative is compar
Author: nico
Date: Thu May 4 14:54:50 2017
New Revision: 302190
URL: http://llvm.org/viewvc/llvm-project?rev=302190&view=rev
Log:
Turn on -Wmicrosoft-enum-forward-reference by default.
clang-cl already errs or warns on everything that cl
warns on in /permissive- mode, except for enum foward
decl
Author: nico
Date: Fri May 5 11:11:08 2017
New Revision: 302247
URL: http://llvm.org/viewvc/llvm-project?rev=302247&view=rev
Log:
Introduce Wzero-as-null-pointer-constant.
Add an opt-in warning that fires when 0 is used as a null pointer.
gcc has this warning, and there's some demand for it.
h
Author: nico
Date: Fri May 5 12:05:56 2017
New Revision: 302255
URL: http://llvm.org/viewvc/llvm-project?rev=302255&view=rev
Log:
Warn that the [] spelling of uuid(...) is deprecated.
https://reviews.llvm.org/D32879
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trun
Timestamps on cfe-commits are a bit messed up. I landed that just now, but
the timestamp is from 13 minutes in the past. Maybe the clock on the mail
server is off by 13 min?
On Fri, May 5, 2017 at 1:05 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
&g
Author: nico
Date: Fri May 5 12:15:08 2017
New Revision: 302258
URL: http://llvm.org/viewvc/llvm-project?rev=302258&view=rev
Log:
ANSIfy. No behavior change.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
cfe/trunk/lib/Sema/SemaStmt.cpp
Modified: c
On Fri, May 5, 2017 at 1:21 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, May 5, 2017 at 1:05 PM, Nico Weber via cfe-commits
> wrote:
> > Author: nico
> > Date: Fri May 5 12:05:56 2017
> > New Revision: 302255
> >
> >
Author: nico
Date: Fri May 5 12:16:58 2017
New Revision: 302259
URL: http://llvm.org/viewvc/llvm-project?rev=302259&view=rev
Log:
ANSIfy more. Still no behavior change.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/viewvc/l
I had run `ack "[\x80-\xFF]" lib` to find these, and didn't expect that it
can fire more than once on a given line. (We had 4 instance in all of
clang, 2 in this line.)
On Fri, May 5, 2017 at 1:16 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Auth
The inline snippet doesn't show the actual code change, but
http://llvm.org/viewvc/llvm-project?view=revision&revision=302835 does show
it. Is the email sender broken?
On Thu, May 11, 2017 at 6:43 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Thu May
Now that r262420 is landed. Is there any plan to move CUDA to the new
> approach so we can fix the UNIX conformance test?
>
> Thanks
>
> Steven
>
> On Apr 22, 2017, at 8:08 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> On Sat, Apr 22, 2
could be used for CUDA. Justin should reply here.
>
> On Mon, May 15, 2017 at 1:32 PM, Steven Wu wrote:
>
>> Hi Nico
>>
>> Now that r262420 is landed. Is there any plan to move CUDA to the new
>> approach so we can fix the UNIX conformance test?
>>
>> Th
Looks like things are still unexpectedly passing at r284389 on macOS (but
we currently only build and test libc++ on macOS, so maybe it's broken
elsewhere too).
https://codereview.chromium.org/2429533002/
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang/builds/106/step
Did you find real-world code triggering this, or did you happen to see the
implementation of the warning? I'm not sure if omitting just the note or
the whole warning is more useful in practice. Intuitively I'd say that
people "never" will compare the result of memcpy, so I'd guess that it
doesn't m
thakis added a comment.
Erik, are you planning on adding the later phases soon? At the moment, due to
this patch, clang emits "enclose 'setAllowsAutomaticWindowTabbing:' in an
@available check to silence this warning" but then errors out when trying to
use @available. This is proving to be conf
If you're working on it, let's just wait for that :-)
On Wed, Oct 26, 2016 at 12:01 PM, Erik Pilkington wrote:
> Hi Nico,
> All that is left for the diagnostic to make sense it CodeGen support for
> @available, which is something I’m working on now. I should have a patch up
> for it in a couple
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
This is a misspelling of the intended `!(x & A)` negated bit test that happens
in practice every now and then.
I ran this on Chromium and all its dependencies, and it fired 0 times -- no
false o
thakis added a comment.
Thanks! Landing…
Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224
+ // These already err, don't also warn.
+ !x &= 1; // expected-error{{expression is not assignable}}
+ !x |= 1; // expected-error{{expression is not assignable}}
-
Author: nico
Date: Thu Oct 27 11:32:06 2016
New Revision: 285310
URL: http://llvm.org/viewvc/llvm-project?rev=285310&view=rev
Log:
Expand -Wlogical-not-parentheses to also fire on `!x & A`.
This is a misspelling of the intended !(x & A) negated bit test that happens in
practice every now and then
thakis closed this revision.
thakis added a comment.
285310
https://reviews.llvm.org/D26035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
https://reviews.llvm.org/D26335
Files:
lib/Headers/x86intrin.h
test/Headers/tzcnt.c
Index: test/Headers/tzcnt.c
===
--- test/H
This apparently caused https://llvm.org/bugs/show_bug.cgi?id=30527
On Tue, Jun 14, 2016 at 9:54 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Tue Jun 14 08:54:38 2016
> New Revision: 272668
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272668&
Oh, looks like someone already sent a fix: https://reviews.llvm.org/D26163
On Wed, Nov 9, 2016 at 4:41 PM, Nico Weber wrote:
> This apparently caused https://llvm.org/bugs/show_bug.cgi?id=30527
>
> On Tue, Jun 14, 2016 at 9:54 AM, Daniel Jasper via cfe-commits <
> cfe-commits@lists.llvm.org> wro
thakis closed this revision.
thakis added a comment.
Landed in r286507. Thanks!
https://reviews.llvm.org/D26163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Nov 10 15:49:25 2016
New Revision: 286507
URL: http://llvm.org/viewvc/llvm-project?rev=286507&view=rev
Log:
[clang-format] Fix PR30527: Regression when clang-format insert spaces in []
when in template
Actual regression was introduced in r272668. This revision fixes JS scr
thakis added a comment.
(Maybe implementing real support isn't so difficult? From a quick glance, it
sounds like this is a sema-only attribute?)
Repository:
rL LLVM
https://reviews.llvm.org/D26540
___
cfe-commits mailing list
cfe-commits@lists.l
thakis added a comment.
In http://reviews.llvm.org/D12646#241318, @hintonda wrote:
> In http://reviews.llvm.org/D12646#241308, @kubabrecka wrote:
>
> > In what scenario exactly are you seeing an issue? If it's a just-built
> > clang that can't find C++ headers, then you should just build the li
Author: nico
Date: Thu Sep 10 14:35:31 2015
New Revision: 247327
URL: http://llvm.org/viewvc/llvm-project?rev=247327&view=rev
Log:
Move sel-address.mm from test/CodeGenCXX to test/SemaObjCXX, it's not a codegen
test.
Added:
cfe/trunk/test/SemaObjCXX/sel-address.mm
- copied, changed fro
Author: nico
Date: Fri Sep 11 16:24:40 2015
New Revision: 247477
URL: http://llvm.org/viewvc/llvm-project?rev=247477&view=rev
Log:
Let selector-expr-lvalue.mm actually test something.
I accidentally introduced a bug locally, and noticed that none of the tests
caught it. No longer!
Modified:
This also fires for bool in C++ files, even though the commit message
saying C11 and _Bool. Given the test changes, I suppose that's intentional?
This fires a lot on existing code, for example protobuf:
../../third_party/protobuf/src/google/protobuf/extension_set.h:465:10:
error: width of bit-fiel
On Mon, Sep 14, 2015 at 5:28 PM, Richard Smith
wrote:
> On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> This also fires for bool in C++ files, even though the commit message
>> saying C11 and _Bool. Given the tes
Author: nico
Date: Tue Sep 15 13:49:51 2015
New Revision: 247712
URL: http://llvm.org/viewvc/llvm-project?rev=247712&view=rev
Log:
Rebase tests after LLVM r247707.
Modified:
cfe/trunk/test/CodeGenCXX/init-invariant.cpp
cfe/trunk/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp
cfe/trunk
ield diagnostic
>> Sent by: tha...@google.com
>> --
>>
>>
>>
>> On Mon, Sep 14, 2015 at 5:28 PM, Richard Smith <*rich...@metafoo.co.uk*
>> > wrote:
>>
>>On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-
Author: nico
Date: Tue Sep 15 15:05:20 2015
New Revision: 247717
URL: http://llvm.org/viewvc/llvm-project?rev=247717&view=rev
Log:
Add test coverage for @encode(SEL); completely untested until now.
Modified:
cfe/trunk/test/CodeGenObjC/encode-test.m
Modified: cfe/trunk/test/CodeGenObjC/encode
Author: nico
Date: Tue Sep 15 18:17:17 2015
New Revision: 247740
URL: http://llvm.org/viewvc/llvm-project?rev=247740&view=rev
Log:
Don't crash when passing &@selector to a _Nonnull parameter. Fixes PR24774.
The root cause here is that ObjCSelectorExpr is an rvalue, yet it can have its
address tak
Author: nico
Date: Tue Sep 15 18:48:17 2015
New Revision: 247750
URL: http://llvm.org/viewvc/llvm-project?rev=247750&view=rev
Log:
clang-format: In Java, `assert` is followed by an expression.
Before: assert a&& b;
Now:assert a && b;
Modified:
cfe/trunk/lib/Format/FormatToken.h
cfe/t
Author: nico
Date: Tue Sep 15 18:51:08 2015
New Revision: 247752
URL: http://llvm.org/viewvc/llvm-project?rev=247752&view=rev
Log:
Remove accidental superfluous newline added in r247750.
Modified:
cfe/trunk/unittests/Format/FormatTestJava.cpp
Modified: cfe/trunk/unittests/Format/FormatTestJa
thakis created this revision.
thakis added a reviewer: mclow.lists.
thakis added a subscriber: cfe-commits.
I wanted a demangler that can demangle both Itanium-style and Microsoft-style
mangled symbols, and that runs on all of Windows, Linux, and Mac OS X. I used
libcxxabi's cxa_demangle for the
on, Sep 14, 2015 at 5:28 PM, Richard Smith >>> Weber ---09/14/2015 09:53:25 PM---On Mon, Sep 14, 2015 at 5:28 PM, Richard
>>>> Smith wrote:
>>>>
>>>> From: Nico Weber
>>>> To: Richard Smith
>>>> Cc: Rachel Craik/Toronto/IBM@IBMCA
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
LLVM r217812 made it so that clang-cl implicitly creates bigobj files when
needed, independent of this flag. It looks like cl has this flag to produce obj
flags compatible with MSVS 2003's linker
Author: nico
Date: Fri Sep 18 15:49:33 2015
New Revision: 248034
URL: http://llvm.org/viewvc/llvm-project?rev=248034&view=rev
Log:
clang-cl: Don't warn on /bigobj flag
LLVM r217812 made it so that clang-cl implicitly creates bigobj files when
needed, independent of this flag. It looks like cl has
thakis closed this revision.
thakis added a comment.
r248034, thanks! (with test)
http://reviews.llvm.org/D12981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Sep 18, 2015 at 5:06 PM, Richard Smith
wrote:
> On Wed, Sep 16, 2015 at 5:33 PM, Richard Smith
> wrote:
>
>> On Wed, Sep 16, 2015 at 5:27 PM, Nico Weber via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Tue, Sep 15, 2015 at 5:50
t-field would change the struct layout.
>>>>
>>>>
>>>>> On Mon, Sep 14, 2015 at 11:06 PM, Richard Smith >>>>>> > wrote:
>>>>>>>
>>>>>>>> On Mon, Sep 14, 2015 at 7:07 PM, Rachel Craik
>>>&g
Author: nico
Date: Sat Sep 19 16:36:51 2015
New Revision: 248100
URL: http://llvm.org/viewvc/llvm-project?rev=248100&view=rev
Log:
Convert two loops to range-based loops. No behavior change.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
Modified: cfe/trunk/lib/Driver/Driver.cpp
URL:
http://llvm
thakis added a subscriber: thakis.
thakis added a comment.
Is the idea that this loads plugins that link against clang's C++ api? That api
isn't considered stable, so not having an "official" flag for this always
looked by design to me. Also, C++ doesn't make for a good ABI. Also also, this
app
Author: nico
Date: Sun Sep 20 13:10:46 2015
New Revision: 248129
URL: http://llvm.org/viewvc/llvm-project?rev=248129&view=rev
Log:
Let cxa_demangle.cpp compile with gcc/libstdc++ 4.8 and clang-cl/MSVC2013's STL.
libstdc++ needs a few typedefs in malloc_alloc. MSVC's STL needs rebind(),
construct(
thakis closed this revision.
thakis added a comment.
r248129, thanks!
http://reviews.llvm.org/D12895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Mon Sep 21 15:06:42 2015
New Revision: 248205
URL: http://llvm.org/viewvc/llvm-project?rev=248205&view=rev
Log:
clang-format: Remove ChromiumStyle.MacroBlockBegin.
We prefer setting these in our .clang-format file as the macros change over
time. (Also, the code was setting Mac
Author: nico
Date: Mon Sep 21 19:46:21 2015
New Revision: 248234
URL: http://llvm.org/viewvc/llvm-project?rev=248234&view=rev
Log:
ms Intrin.h: Fix __movsw's and __stosw's inline asm.
Before, clang's internal assembler would reject the inline asm in clang's
Intrin.h. To make sure this doesn't ha
Author: nico
Date: Mon Sep 21 19:51:10 2015
New Revision: 248235
URL: http://llvm.org/viewvc/llvm-project?rev=248235&view=rev
Log:
Add bug number to FIXME comment.
Modified:
cfe/trunk/test/Headers/ms-intrin.cpp
Modified: cfe/trunk/test/Headers/ms-intrin.cpp
URL:
http://llvm.org/viewvc/llvm-
vm.org> wrote:
> On 21 September 2015 at 17:46, Nico Weber via cfe-commits
> wrote:
> > Author: nico
> > Date: Mon Sep 21 19:46:21 2015
> > New Revision: 248234
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=248234&view=rev
> > Log:
> &
Author: nico
Date: Tue Sep 22 19:24:34 2015
New Revision: 248355
URL: http://llvm.org/viewvc/llvm-project?rev=248355&view=rev
Log:
Make ms-intrin.cpp test require the x86 target.
Modified:
cfe/trunk/test/Headers/ms-intrin.cpp
Modified: cfe/trunk/test/Headers/ms-intrin.cpp
URL:
http://llvm.o
?
>
> On Tue, Sep 22, 2015 at 6:00 PM, Renato Golin via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On 21 September 2015 at 17:46, Nico Weber via cfe-commits
>> wrote:
>> > Author: nico
>> > Date: Mon Sep 21 19:46:21 2015
>> > N
thakis added a subscriber: thakis.
thakis added a comment.
mclow should review this, not me.
http://reviews.llvm.org/D13080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Wed Sep 23 20:34:27 2015
New Revision: 248456
URL: http://llvm.org/viewvc/llvm-project?rev=248456&view=rev
Log:
Make a test a bit shorter. No behavior change.
Modified:
cfe/trunk/test/Sema/warn-sizeof-arrayarg.c
Modified: cfe/trunk/test/Sema/warn-sizeof-arrayarg.c
URL:
ht
t) #else __attr... #endif` then it
compiles with 2015. (I want to send out something for this soon too.)
>
>
> 2015-09-20 21:10 GMT+03:00 Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org>:
>
>> Author: nico
>> Date: Sun Sep 20 13:10:46 2015
>> New
Can't you just change your signature to
virtual void a(int /* x */) {}
in these cases?
On Tue, Aug 11, 2015 at 6:43 AM, Daniel Marjamäki <
cfe-commits@lists.llvm.org> wrote:
> danielmarjamaki created this revision.
> danielmarjamaki added a reviewer: krememek.
> danielmarjamaki added a subscr
thakis added a subscriber: thakis.
thakis added a comment.
Can't you just change your signature to
virtual void a(int /* x */) {}
in these cases?
http://reviews.llvm.org/D11940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
On Tue, Aug 11, 2015 at 11:32 AM, David Blaikie wrote:
>
>
> On Tue, Aug 11, 2015 at 8:46 AM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Can't you just change your signature to
>>
>> virtual void a(int /* x */) {}
>>
s@lists.llvm.org
> Ämne: Re: [PATCH] D11940: don't diagnose -Wunused-parameter in virtual
> method or method that overrides base class method
>
> On Tue, Aug 11, 2015 at 11:32 AM, David Blaikie <mailto:dblai...@gmail.com>> wrote:
>
>
> On Tue, Aug 11, 2015 at 8:46 AM, Nico
; Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden
>>>
>>> Mobile: +46 (0)709 12 42 62
>>> E-mail: daniel.marjam...@evidente.se
>>>
>>> www.evidente.se
>>>
>>> ___
s using constants.
>>>>> etc
>>>>>
>>>>> Best regards,
>>>>> Daniel Marjamäki
>>>>>
>>>>>
>>>>> ..
thakis added a subscriber: thakis.
Comment at: Makefile:68
@@ -67,3 +67,3 @@
# http://gcc.gnu.org/PR41874
# http://gcc.gnu.org/PR41838
#
The first of these is marked fixed, the second has a "works on trunk" comment
(from 2010). Maybe this isn't needed with
thakis added a subscriber: thakis.
Comment at: lib/Driver/Tools.cpp:398
@@ +397,3 @@
+ FoundPTH = !UsePCH;
+}
+ }
kimgr wrote:
> kimgr wrote:
> > kimgr wrote:
> > > kimgr wrote:
> > > > Add a `break;` here so we don't continue sea
On Tue, Aug 18, 2015 at 9:15 AM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Tue Aug 18 11:15:44 2015
> New Revision: 245304
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245304&view=rev
> Log:
> We shouldn't need to pass -fno-strict-aliasing
Author: nico
Date: Tue Aug 18 13:29:33 2015
New Revision: 245325
URL: http://llvm.org/viewvc/llvm-project?rev=245325&view=rev
Log:
Revert r243752, it broke running tests on OS X (PR24491).
Modified:
libcxxabi/trunk/test/lit.cfg
Modified: libcxxabi/trunk/test/lit.cfg
URL:
http://llvm.org/vie
Author: nico
Date: Tue Aug 18 15:32:55 2015
New Revision: 245342
URL: http://llvm.org/viewvc/llvm-project?rev=245342&view=rev
Log:
Revert r245323, it caused PR24493.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/test/CodeGen/object-size.c
cfe/trunk/test/Sema/const-eval.c
Mod
On Fri, Jun 19, 2015 at 4:18 PM, Douglas Gregor wrote:
> Author: dgregor
> Date: Fri Jun 19 18:18:00 2015
> New Revision: 240188
>
> URL: http://llvm.org/viewvc/llvm-project?rev=240188&view=rev
> Log:
> Handle 'instancetype' in ParseDeclarationSpecifiers.
>
> ...instead of as a special case in Pa
thakis added a subscriber: thakis.
This revision is now accepted and ready to land.
Comment at: include/clang/Driver/Options.td:1853
@@ -1853,1 +1852,3 @@
+def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker ">,
Group;
+def linker_EQ : Joined<["-"], "linker=">, Alias
Author: nico
Date: Tue Aug 25 13:43:32 2015
New Revision: 245965
URL: http://llvm.org/viewvc/llvm-project?rev=245965&view=rev
Log:
Revert r245879. Speculative, might have caused crbug.com/524604
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/CodeGen/CGCall.h
cfe/trunk/test/C
Author: nico
Date: Tue Sep 1 16:13:14 2015
New Revision: 246589
URL: http://llvm.org/viewvc/llvm-project?rev=246589&view=rev
Log:
Make trunk release notes point to 3.7, not 3.6
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/l
libcxx is needed to run compiler-rt tests, but it shouldn't be needed to
run clang's tests. And to _use_ your self-built compiler, you need to add
`-isysroot $(xcrun -show-sdk-path)` to the compile flags to let the
compiler find C headers anyway, which also makes it find the libc++ headers.
For co
On Mon, Sep 7, 2015 at 9:17 AM, Kuba Brecka wrote:
>
> > On 07 Sep 2015, at 17:21, Nico Weber wrote:
> >
> > libcxx is needed to run compiler-rt tests, but it shouldn't be needed to
> run clang's tests. And to _use_ your self-built compiler, you need to add
> `-isysroot $(xcrun -show-sdk-path)`
thakis added a subscriber: thakis.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
Shou
thakis added inline comments.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
comex wro
thakis added inline comments.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
comex wro
Author: nico
Date: Thu Oct 15 11:03:01 2015
New Revision: 250422
URL: http://llvm.org/viewvc/llvm-project?rev=250422&view=rev
Log:
clang-format/java: Break after annotations on fields in Chromium style.
Chromium follows the Android style guide for Java code, and that doesn't make
the distinction
test?
On Thu, Oct 15, 2015 at 11:39 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Thu Oct 15 13:39:31 2015
> New Revision: 250440
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250440&view=rev
> Log:
> clang-format: Basic escaping when outputti
On Wed, Oct 14, 2015 at 5:28 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> On Oct 14, 2015, at 5:07 PM, Richard Smith wrote:
>
> On Wed, Oct 14, 2015 at 3:58 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Oct 14, 2015, at 3:32 PM, Ric
thakis created this revision.
thakis added a reviewer: djasper.
thakis added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This makes the format tests look more like most other FileCheck tests in clang.
The multiple-inputs tests still use temp files, to make sure that the file
in
Author: nico
Date: Sun Oct 18 20:03:19 2015
New Revision: 250671
URL: http://llvm.org/viewvc/llvm-project?rev=250671&view=rev
Log:
Update list of languages advertised in OVERVIEW: A tool to format
C/C++/Java/JavaScript/Objective-C/Protobuf code.
If no arguments are specified, it formats the code
Author: nico
Date: Sun Oct 18 20:08:30 2015
New Revision: 250672
URL: http://llvm.org/viewvc/llvm-project?rev=250672&view=rev
Log:
Update `clang-format -help` output in clang-format docs.
-assume-filename, -fallback-style, and -sort-includes are new. (They're also
longer than the previous option
Oct 18, 2015 at 6:03 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Sun Oct 18 20:03:19 2015
> New Revision: 250671
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250671&view=rev
> Log:
> Update list of languages adv
Author: nico
Date: Sun Oct 18 20:36:09 2015
New Revision: 250675
URL: http://llvm.org/viewvc/llvm-project?rev=250675&view=rev
Log:
clang-format: Extend main header include sorting heuristic to Objective-C files.
Modified:
cfe/trunk/lib/Format/Format.cpp
cfe/trunk/unittests/Format/SortIncl
On Tue, Sep 29, 2015 at 12:53 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Tue Sep 29 02:53:08 2015
> New Revision: 248782
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248782&view=rev
> Log:
> clang-format: Extend #include sorting functionali
1001 - 1100 of 1693 matches
Mail list logo
