derer/platform/scheduler/public/scheduling_lifecycle_state.h"
It looks like FS->getCurrentWorkingDirectory() is set
yet FileSystemOpts.WorkingDir.empty() is also true. Is that expected? But
the output doesn't look like you expect, at least.
>
> I can also try to repro locally
On Wed, Jan 23, 2019 at 9:54 AM Sam McCall wrote:
> (Email is better than IRC if that's OK - I don't know this code that well
> so it takes me a while).
>
> Thanks, that's definitely interesting and not what I expected. I thought
> every call sequence r347205 changed the behavior of would have re
With your patch reverted locally, at the same breakpoint I instead get
$ lsof -p 95842 | wc -l
94
So your patch seems to increase number of open file handles by ~260%.
On Wed, Jan 23, 2019 at 10:27 AM Nico Weber wrote:
> On Wed, Jan 23, 2019 at 9:54 AM Sam McCall wrote:
>
>> (Email is b
Stacks for getFile() from PCH files look like so:
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
* frame #0: 0x00010005a1fb
clang-cl`clang::FileManager::getFile(this=0x0001106111f0,
Filename=(Data =
"/Users/thakis/src/chrome/src/out/gnwin/../../third
The way things worked before your patch is that getFile() calls for headers
that are loaded from a PCH file hit the early-ish return in
if (UFE.isValid()) { // Already have an entry with this inode, return it.
The first stack I posted (with ReadControlBlock() in it) populates
this UniqueRealFil
Here's what I think is a repro:
Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat foo.h
Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat foo2.h
Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat pch.h
#include "foo.h"
Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat pch.cc
Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat client.cc
#in
On Wed, Jan 23, 2019 at 2:17 PM Nico Weber wrote:
> Here's what I think is a repro:
>
> Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat foo.h
> Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat foo2.h
> Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat pch.h
> #include "foo.h"
> Nicos-MacBook-Pro:llvm-mono-2 thakis$ c
This might finally be a repro!
Nicos-MacBook-Pro:llvm-mono-2 thakis$ ls bar
foo.h foo2.h
Nicos-MacBook-Pro:llvm-mono-2 thakis$ type foo.h
-bash: type: foo.h: not found
Nicos-MacBook-Pro:llvm-mono-2 thakis$ ls bar
foo.h foo2.h
Nicos-MacBook-Pro:llvm-mono-2 thakis$ cat bar/foo.h
#include "foo2.h"
Ni
For completeness, in case the construction isn't clear, here's a full repro
of the symptom.
$ cat pch.cc
$ cat pch.h
#include "foo.h"
$ rm bar/foo.h
$ for i in {1..300}; do echo '#include "foo'$i'.h"' >> bar/foo.h; done
$ for i in {1..300}; do touch bar/foo$i.h; done
$ cat client.cc
#include "bar/
Can you measure on macOS and Windows too, and maybe with a larger program?
The open+fstat (instead of stat+open) optimization was I think done with
benchmarking on macOS.
I can see why you say you think the new behavior is more consistent, but
it's basically changing what information goes into the
Author: nico
Date: Fri Jan 25 15:37:57 2019
New Revision: 352253
URL: http://llvm.org/viewvc/llvm-project?rev=352253&view=rev
Log:
Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF
libclang can be built in shared or static mode. On Windows, with
LLVM_ENABLE_PIC=OFF, it was built in neither
I think c-index-test has the same problem:
$ cat test.cc
#include
$ out/gn/bin/c-index-test -write-pch foo.pch test.cc
test.cc:1:10: fatal error: 'iostream' file not found
Since https://reviews.llvm.org/rL350714 was a driver-side fix and
c-index-test doesn't use lib/Driver, it didn't do anything
This seems to fix it, but I don't know if it's the right fix:
diff --git a/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp
b/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp
index b62416ffd9e..d933f8c1b70 100644
--- a/clang/lib/Frontend/CreateInvocationFromCommandLine.cpp
+++ b/clang/
Author: nico
Date: Thu Jan 31 07:26:03 2019
New Revision: 352761
URL: http://llvm.org/viewvc/llvm-project?rev=352761&view=rev
Log:
Accomodate gcc 7.3.0's -Wdangling-else
Modified:
cfe/trunk/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp
Modified: cfe/trunk/unittests/StaticAnalyzer/R
This only prints the warning when /fallback actually happens, right? I
don't think that's good enough: If we build a few TUs with
/dllexportInlines- and don't fall back, those .obj files are not abi
compatible with the cl-built ones. (Consider all dllexport TUs of a header
being built with clang-cl
Ah cool. But the diagnostic is "option /dllexportInlines- is ignored when
/fallback happens" – shouldn't it be ignored regardless of if fallback
happens? Does that happen and the warning text is wrong?
On Fri, Nov 9, 2018 at 11:20 AM Hans Wennborg wrote:
> On Fri, Nov 9, 2018 at 4:53 PM, Nico We
On Mon, Nov 12, 2018 at 4:58 AM Hans Wennborg wrote:
> Hmm, maybe I misunderstood your initial request for this.
>
> The current implementation does what the warnings says: If the
> compiler falls back to cl.exe, /Zc:dllexportInlines- will be ignored.
> This suggests to the user that it's a bad i
Author: nico
Date: Tue Nov 20 07:27:43 2018
New Revision: 347314
URL: http://llvm.org/viewvc/llvm-project?rev=347314&view=rev
Log:
Revert 347294, it turned many bots on lab.llvm.org:8011/console red.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/lib/AST/ASTImporter.cpp
cfe/tr
I reverted this in r347314 for breaking many bots on
lab.llvm.org:8011/console
I've also put a standalone repro at
https://bugs.chromium.org/p/chromium/issues/detail?id=907099#c2.
On Tue, Nov 20, 2018 at 3:56 AM Bill Wendling via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: void
>
Author: nico
Date: Wed Nov 21 04:47:43 2018
New Revision: 347389
URL: http://llvm.org/viewvc/llvm-project?rev=347389&view=rev
Log:
Revert r347364 again, the fix was incomplete.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/lib/AST/ASTImporter.cpp
cfe/trunk/lib/AST/Expr.cpp
Author: nico
Date: Wed Nov 21 04:49:22 2018
New Revision: 347390
URL: http://llvm.org/viewvc/llvm-project?rev=347390&view=rev
Log:
Revert 347366, its prerequisite 347364 got reverted.
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/MisplacedWideningCastCheck.cpp
clang-tools-extra/tr
Author: nico
Date: Thu Dec 6 10:50:39 2018
New Revision: 348515
URL: http://llvm.org/viewvc/llvm-project?rev=348515&view=rev
Log:
Allow forwarding -fdebug-compilation-dir to cc1as
The flag -fdebug-compilation-dir is useful to make generated .o files
independent of the path of the build directory
Do we warn "ignoring flag" or something like that for these, or are these
now silently ignored?
On Wed, Mar 6, 2019 at 4:37 AM Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Wed Mar 6 01:38:04 2019
> New Revision: 355489
>
> URL: http://llvm.org/viewvc/
Author: nico
Date: Mon Mar 11 13:23:40 2019
New Revision: 355862
URL: http://llvm.org/viewvc/llvm-project?rev=355862&view=rev
Log:
Remove esan.
It hasn't seen active development in years, and it hasn't reached a
state where it was useful.
Remove the code until someone is interested in working on
Author: nico
Date: Thu Mar 14 07:18:56 2019
New Revision: 356148
URL: http://llvm.org/viewvc/llvm-project?rev=356148&view=rev
Log:
Objective-C++11: Support static_assert() in @interface/@implementation ivar
lists and method declarations
This adds support for static_assert() (and _Static_assert()
Author: nico
Date: Thu Mar 14 07:40:48 2019
New Revision: 356154
URL: http://llvm.org/viewvc/llvm-project?rev=356154&view=rev
Log:
Fix test after r356148
Modified:
cfe/trunk/test/Parser/objc-static-assert.mm
Modified: cfe/trunk/test/Parser/objc-static-assert.mm
URL:
http://llvm.org/viewvc/l
Author: nico
Date: Fri Mar 15 04:54:01 2019
New Revision: 356254
URL: http://llvm.org/viewvc/llvm-project?rev=356254&view=rev
Log:
Rename directory housing clang-change-namespace to be eponymous
Makes the name of this directory consistent with the names of the other
directories in clang-tools-ext
Author: nico
Date: Wed Mar 20 09:14:16 2019
New Revision: 356567
URL: http://llvm.org/viewvc/llvm-project?rev=356567&view=rev
Log:
gn build: Add build files for some clang-tools-extra
Adds clang-change-namespace, clang-move, clang-query,
clang-reorder-fields.
Differential Revision: https://revie
This breaks Chromium's build. We have a class with a _bswap method, and
this adds a _bswap macro expanding to something that gets in the way. Could
_bswap be an inline function instead?
https://bugs.chromium.org/p/chromium/issues/detail?id=945172
On Sat, Mar 23, 2019 at 8:55 PM Craig Topper via c
Thanks, this helped.
> to hopefully fix the chromium build.
I'd argue it's overall more sane. Single underscore followed by lower-case
letters isn't reserved in non-global scope, so what gcc is doing isn't
quite proper from what I understand.
On Sun, Mar 24, 2019 at 1:58 PM Craig Topper via cfe-
Author: nico
Date: Mon Mar 25 09:50:24 2019
New Revision: 356923
URL: http://llvm.org/viewvc/llvm-project?rev=356923&view=rev
Log:
Attempt to fix sphinx bot after r356897
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
URL:
htt
Author: nico
Date: Thu Mar 28 09:53:32 2019
New Revision: 357182
URL: http://llvm.org/viewvc/llvm-project?rev=357182&view=rev
Log:
gn build: Add some build files for clangd
Enough to build the clangd binaries, but this is still missing build
files for:
- fuzzer
- indexer
- index/dex/dexp
- benchm
Author: nico
Date: Thu Mar 28 19:46:31 2019
New Revision: 357231
URL: http://llvm.org/viewvc/llvm-project?rev=357231&view=rev
Log:
Add .py extension to clang-tools-extra lit cfg files
Follow-up to r313892, which did this for clang and llvm.
Differential Revision: https://reviews.llvm.org/D59953
Author: nico
Date: Thu Mar 28 19:49:13 2019
New Revision: 357232
URL: http://llvm.org/viewvc/llvm-project?rev=357232&view=rev
Log:
gn build: Add check-clang-tools to run clang-tools-extra lit tests
Only runs the clang-tools-extra lit tests; not yet the unit tests.
Add a build file for clangd-ind
(below)
On Fri, Sep 8, 2017 at 9:15 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Fri Sep 8 18:14:04 2017
> New Revision: 312851
>
> URL: http://llvm.org/viewvc/llvm-project?rev=312851&view=rev
> Log:
> Fix ownership of the MemoryBuffer in a Front
Do we still need changes like this now that we have the /clang: switch?
On Fri, Mar 29, 2019 at 10:02 AM Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Fri Mar 29 07:03:34 2019
> New Revision: 357255
>
> URL: http://llvm.org/viewvc/llvm-project?rev=35725
Author: nico
Date: Sat Mar 30 16:09:10 2019
New Revision: 357356
URL: http://llvm.org/viewvc/llvm-project?rev=357356&view=rev
Log:
Rename IncludeFixerTests to ClangIncludeFixerTests and ChangeNamespaceTests to
ClangChangeNamespaceTests
Follow-up to r356897 and r356254.
Modified:
clang-tools
Author: nico
Date: Sun Mar 31 09:49:54 2019
New Revision: 357369
URL: http://llvm.org/viewvc/llvm-project?rev=357369&view=rev
Log:
gn build: Add build files for most clang-tools-extra unit tests
Differential Revision: https://reviews.llvm.org/D60038
Modified:
clang-tools-extra/trunk/unittest
Author: nico
Date: Wed Apr 3 05:33:19 2019
New Revision: 357574
URL: http://llvm.org/viewvc/llvm-project?rev=357574&view=rev
Log:
gn build: Add build files for clangd xpc framework code
This is a bit of a larger change since this is the first (and as far as
I can tell only) place where the LLVM
Author: nico
Date: Wed Apr 3 17:05:53 2019
New Revision: 357654
URL: http://llvm.org/viewvc/llvm-project?rev=357654&view=rev
Log:
Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery
This allows building it even if no fuzzer is enabled. (Sadly, it only
builds on Linux at the moment.)
D
Why would we want this to be different in Obj-C and C++?
On Thu, Apr 4, 2019 at 9:34 AM Krasimir Georgiev via Phabricator via
cfe-commits wrote:
> krasimir marked 2 inline comments as done.
> krasimir added inline comments.
>
>
>
> Comment at: lib/Format/Format.cpp:787
>Goog
Author: nico
Date: Thu Apr 4 06:54:01 2019
New Revision: 357694
URL: http://llvm.org/viewvc/llvm-project?rev=357694&view=rev
Log:
Use a cmake check for linux that actually works.
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt
Author: nico
Date: Thu Apr 4 07:08:35 2019
New Revision: 357696
URL: http://llvm.org/viewvc/llvm-project?rev=357696&view=rev
Log:
Fix clangd-fuzzer build
r357102 made clangd-fuzzer no longer compile, but before
r357654 / r357694 we didn't notice. Fix the compile.
Also add a dep on FuzzMutate wh
Author: nico
Date: Thu Apr 4 07:19:45 2019
New Revision: 357700
URL: http://llvm.org/viewvc/llvm-project?rev=357700&view=rev
Log:
Updating Chromium's Java import order
Adding in androidx as another import group.
Differential Revision: https://reviews.llvm.org/D60203
Patch from Sam Maier !
Mod
Author: nico
Date: Thu Apr 4 13:08:04 2019
New Revision: 357719
URL: http://llvm.org/viewvc/llvm-project?rev=357719&view=rev
Log:
check-clang-tools: Actually build and run XPC test
The CMake variable controlling if XPC code is built is called
CLANGD_BUILD_XPC but three places unintentionally che
Author: nico
Date: Thu Apr 4 14:06:41 2019
New Revision: 357724
URL: http://llvm.org/viewvc/llvm-project?rev=357724&view=rev
Log:
Make SourceManager::createFileID(UnownedTag, ...) take a const
llvm::MemoryBuffer*
Requires making the llvm::MemoryBuffer* stored by SourceManager const,
which in tu
Author: nico
Date: Thu Apr 4 14:06:41 2019
New Revision: 357724
URL: http://llvm.org/viewvc/llvm-project?rev=357724&view=rev
Log:
Make SourceManager::createFileID(UnownedTag, ...) take a const
llvm::MemoryBuffer*
Requires making the llvm::MemoryBuffer* stored by SourceManager const,
which in tu
Hi Jennifer,
this caused https://bugs.llvm.org/show_bug.cgi?id=41471
Do you think this is easy to fix, or should we revert for now?
Thanks,
Nico
On Wed, Apr 3, 2019 at 1:20 PM Jennifer Yu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jyu2
> Date: Wed Apr 3 10:21:40 2019
> New
I tried using this to see why X86ISelLowering.cpp takes so long to build on
my system. The output json produced by this flag is at
http://s000.tinyupload.com/?file_id=00019982161870973700
It looks like this produces lots of useful information for frontend time,
but in this case most time is spent
Author: nico
Date: Thu Apr 11 14:26:34 2019
New Revision: 358232
URL: http://llvm.org/viewvc/llvm-project?rev=358232&view=rev
Log:
Revert r357610, it caused PR41471
Removed:
cfe/trunk/test/CodeGenCXX/microsoft-abi-template-static-init.cpp
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
Mod
Done in 358232. Thanks!
On Thu, Apr 11, 2019 at 5:19 PM Yu, Jennifer wrote:
> Hi Nico,
>
>
>
> Iet’s revert it now. I will try to re-submit latter.
>
> Thanks.
>
> Jennifer
>
>
>
> *From:* Nico Weber [mailto:tha...@chromium.org]
> *Sent:* Thursday, April 11, 2019 2:04 PM
> *To:* Yu, Jennifer
>
I haven't tried -ftime-report here. I tried it in the past and found it
difficult to interpret, as the blog post you link to correctly says :) I
thought -ftime-trace was supposed to be more usable, so I figured I'd try
that instead. And for frontend stuff, it does look much better!
Ideas on how to
Nice! Is adding compat to
https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain&ssr=false#overview
equally easy?
On Mon, Apr 15, 2019 at 9:01 AM Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Mon Apr 15 06:02:03 2019
> New Rev
This breaks building with LLVM_ENABLE_THREADS=OFF. The call probably needs
to be behind a `#if LLVM_ENABLE_THREADS`.
FAILED: bin/c-index-test
...
lib/libclang.a(CIndex.cpp.o): In function `void llvm::function_ref::callback_fn(long)':
CIndex.cpp:(.text._ZN4llvm12function_refIFvvEE11callback_fnIZ25c
Author: nico
Date: Sun Apr 21 12:18:41 2019
New Revision: 358858
URL: http://llvm.org/viewvc/llvm-project?rev=358858&view=rev
Log:
Attempt to fix LLVM_ENABLE_THREADS=OFF build after r358665
Modified:
cfe/trunk/tools/libclang/CIndex.cpp
Modified: cfe/trunk/tools/libclang/CIndex.cpp
URL:
http
r358858 might help with this.
On Sat, Apr 20, 2019 at 7:15 PM Nico Weber wrote:
> This breaks building with LLVM_ENABLE_THREADS=OFF. The call probably needs
> to be behind a `#if LLVM_ENABLE_THREADS`.
>
> FAILED: bin/c-index-test
> ...
> lib/libclang.a(CIndex.cpp.o): In function `void llvm::func
Author: nico
Date: Tue Apr 23 09:37:42 2019
New Revision: 359009
URL: http://llvm.org/viewvc/llvm-project?rev=359009&view=rev
Log:
MS ABI: Support mangling op<=> now that MSVC 2019 has a mangling
Modified:
cfe/trunk/lib/AST/MicrosoftMangle.cpp
cfe/trunk/test/CodeGenCXX/cxx2a-three-way-com
Author: nico
Date: Tue Apr 23 17:48:04 2019
New Revision: 359057
URL: http://llvm.org/viewvc/llvm-project?rev=359057&view=rev
Log:
Fix test after r359009 on platforms where %ms_abi_triple is 32-bit
Modified:
cfe/trunk/test/CodeGenCXX/cxx2a-three-way-comparison.cpp
Modified: cfe/trunk/test/Co
Author: nico
Date: Wed Apr 24 08:31:13 2019
New Revision: 359107
URL: http://llvm.org/viewvc/llvm-project?rev=359107&view=rev
Log:
clang-cl: List valid values for /std: in /? output
Differential Revision: https://reviews.llvm.org/D61029
Modified:
cfe/trunk/include/clang/Driver/CLCompatOption
Author: nico
Date: Wed May 1 12:34:00 2019
New Revision: 359717
URL: http://llvm.org/viewvc/llvm-project?rev=359717&view=rev
Log:
Make check-clang depend on the clang-check binary always
check-clang (the target that runs all clang tests) used to
only depend on clang-check (a binary like clang-ti
Author: nico
Date: Wed May 1 16:32:38 2019
New Revision: 359739
URL: http://llvm.org/viewvc/llvm-project?rev=359739&view=rev
Log:
Revert r359717, "Make check-clang depend on the clang-check binary always"
The Tooling tests do have a lit.local.cfg with
if not config.root.clang_staticanalyzer
Author: nico
Date: Thu May 2 12:47:05 2019
New Revision: 359820
URL: http://llvm.org/viewvc/llvm-project?rev=359820&view=rev
Log:
Another attempt to fix "could not find clang-check" lit warning in
analyzer-less builds
r359717 added clang-check as a dep of check-clang unconditionally
because I h
Author: nico
Date: Thu May 2 20:16:07 2019
New Revision: 359858
URL: http://llvm.org/viewvc/llvm-project?rev=359858&view=rev
Log:
Revert r359814 "[Sema] Emit warning for visibility attribute on
internal-linkage declaration"
See cfe-commits thread for r359814.
Modified:
cfe/trunk/include/cl
This also breaks building libc++ [1]. Reverted for now in r359858.
1:
FAILED: obj/buildtools/third_party/libc++/libc++/new.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/buildtools/third_party/libc++/libc++/new.o.d -D_LIBCPP_BUILDING_LIBRARY
-DLIBCXX_BUILDING_LIBCXXABI -DU
Author: nico
Date: Fri May 3 11:54:18 2019
New Revision: 359916
URL: http://llvm.org/viewvc/llvm-project?rev=359916&view=rev
Log:
Attempt to fix the clang-sphinx-docs bot after r358797
Modified:
cfe/trunk/docs/analyzer/checkers.rst
Modified: cfe/trunk/docs/analyzer/checkers.rst
URL:
http:/
The generic O flag handling doesn't support 0 either. Would you be ok with
removing this?
Does /Od do what you want?
On Wed, Sep 19, 2018 at 4:52 PM Reid Kleckner
wrote:
> I was probably using it myself, and was surprised that /O0 and -O0 had
> different behavior, because -O0 will hit the speci
Hello, please add linebreaks to your commit messages. This commit makes
`git log` look pretty ugly.
On Fri, Sep 21, 2018 at 9:55 AM JF Bastien via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jfb
> Date: Fri Sep 21 06:54:09 2018
> New Revision: 342734
>
> URL: http://llvm.org/viewvc
Sounds great, thanks!
On Wed, Sep 26, 2018 at 8:33 AM Hans Wennborg via Phabricator via
cfe-commits wrote:
> hans added inline comments.
>
>
>
> Comment at: include/clang/Driver/CLCompatOptions.td:94
> +def : CLFlag<"Gs">, HelpText<"Use stack probes (default)">,
> + Alias, Alia
Author: nico
Date: Fri Oct 5 11:22:21 2018
New Revision: 343872
URL: http://llvm.org/viewvc/llvm-project?rev=343872&view=rev
Log:
clang-format: Don't insert spaces in front of :: for Java 8 Method References.
The existing code kept the space if it was there for identifiers, and it didn't
handle
Author: nico
Date: Thu Jan 31 14:15:32 2019
New Revision: 352803
URL: http://llvm.org/viewvc/llvm-project?rev=352803&view=rev
Log:
Make clang/test/Index/pch-from-libclang.c pass in more places
- fixes the test on macOS with LLVM_ENABLE_PIC=OFF
- together with D57343, gets the test to pass on Wind
Author: nico
Date: Thu Jan 31 14:57:52 2019
New Revision: 352809
URL: http://llvm.org/viewvc/llvm-project?rev=352809&view=rev
Log:
Re-disable pch-from-libclang.c after 352803, some buildbots are still unhappy
Modified:
cfe/trunk/test/Index/pch-from-libclang.c
Modified: cfe/trunk/test/Index/p
Author: nico
Date: Sat Feb 2 15:16:30 2019
New Revision: 352971
URL: http://llvm.org/viewvc/llvm-project?rev=352971&view=rev
Log:
Replace uses of %T with %t in from previous frontend test differential
After committing a change I had made to a few frontend tests, it was pointed
out to me that %T
Author: nico
Date: Mon Feb 11 08:37:02 2019
New Revision: 353718
URL: http://llvm.org/viewvc/llvm-project?rev=353718&view=rev
Log:
Make test actually test something (colons were missing)
Modified:
cfe/trunk/test/CodeGen/ms-x86-intrinsics.c
Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c
On Tue, May 8, 2018 at 3:59 AM Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Tue May 8 00:56:05 2018
> New Revision: 331745
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331745&view=rev
> Log:
> [C++2a] Implement operator<=>: Fix another bug in the
On Mon, Feb 11, 2019 at 11:38 AM Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits
> wrote:
> >
> > Author: nico
> > Date: Mon Feb 11 08:37:02 2019
> > New Revision: 353718
>
Author: nico
Date: Mon Feb 11 09:30:25 2019
New Revision: 353725
URL: http://llvm.org/viewvc/llvm-project?rev=353725&view=rev
Log:
Attempt to pacify bots after r353718
Modified:
cfe/trunk/test/CodeGen/ms-x86-intrinsics.c
Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c
URL:
http://llvm.
Author: nico
Date: Mon Feb 11 10:01:27 2019
New Revision: 353729
URL: http://llvm.org/viewvc/llvm-project?rev=353729&view=rev
Log:
Attempt to pacify bots more after r353718 and r353725
Modified:
cfe/trunk/test/CodeGen/ms-x86-intrinsics.c
Modified: cfe/trunk/test/CodeGen/ms-x86-intrinsics.c
U
This still didn't help.
I can't repro the failures onhttp://
lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
, I tried Rel+Asserts and Rel-Asserts builds. Can anyone else repro this?
On Mon, Feb 11, 2019 at 1:01 PM Nico Weber via cfe-commits <
Author: nico
Date: Mon Feb 11 12:33:22 2019
New Revision: 353744
URL: http://llvm.org/viewvc/llvm-project?rev=353744&view=rev
Log:
Fix a few tests that were missing ':' on CHECK lines and weren't testing
anything.
Found by `git grep '\/\/ CHECK-[^: ]* ' clang/test/ | grep -v RUN:`.
Also tweak C
cei-ps4-windows10pro-fast\llvm.src\tools\clang\test\CodeGen\ms-x86-intrinsics.c:144:10:
> note: include the header or explicitly provide a declaration for
> '__shiftleft128'
> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\CodeGen\ms-x
Author: nico
Date: Tue Feb 12 04:40:56 2019
New Revision: 353836
URL: http://llvm.org/viewvc/llvm-project?rev=353836&view=rev
Log:
Disable test after r353718, r353725, r353729 while I investigate
Modified:
cfe/trunk/test/CodeGen/ms-x86-intrinsics.c
Modified: cfe/trunk/test/CodeGen/ms-x86-int
%6 = shl i128 %3, %5
>%7 = lshr i128 %6, 64
> %8 = trunc i128 %7 to i64
>ret i64 %8
> }
>
> /Mikael
>
> On 2/12/19 2:03 AM, Nico Weber via cfe-commits wrote:
> > Thank you for the .ll files!
> >
> > the -4.ll file you sent me contains:
> >
Author: nico
Date: Wed Feb 13 11:04:26 2019
New Revision: 353969
URL: http://llvm.org/viewvc/llvm-project?rev=353969&view=rev
Log:
Re-enable the test disabled in r353836 and hopefully make it pass in gcc builds
Argument evaluation order is different between gcc and clang, so pull out
the Builder
%0 = zext i64 %h to i128
> > %1 = shl nuw i128 %0, 64
> > %2 = zext i64 %l to i128
> > %3 = or i128 %1, %2
> > %4 = and i8 %d, 63
> > %5 = zext i8 %4 to i128
> > %6 = shl i128 %3, %5
> > %7 = lshr
Author: nico
Date: Wed Feb 13 20:13:17 2019
New Revision: 354009
URL: http://llvm.org/viewvc/llvm-project?rev=354009&view=rev
Log:
Print a note to the called macro when diagnosing err_embedded_directive
Fixes PR40713, see there for the motivation for this.
Differential Revision: https://reviews.
Did you do any performance testing to check if this slows down clang?
On Thu, Feb 14, 2019 at 6:02 PM Jan Korous via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jkorous
> Date: Thu Feb 14 15:02:35 2019
> New Revision: 354075
>
> URL: http://llvm.org/viewvc/llvm-project?rev=354075&v
When reverting something, can you say why you're reverting in the commit
message please?
On Fri, Feb 15, 2019 at 4:18 AM Sam McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sammccall
> Date: Fri Feb 15 01:18:49 2019
> New Revision: 354109
>
> URL: http://llvm.org/viewvc/llvm
I didn't realize it just copied a string. I just saw a call to
"fillRealPathName" and the "RealPath" bit sounded slow. From clicking
around in http://llvm-cs.pcc.me.uk/tools/clang/lib/Basic/FileManager.cpp#361
it looks like it's not really computing a realpath (for symlinks). It still
does quite a
On Thu, Aug 24, 2017 at 1:04 PM, Reid Kleckner via Phabricator via
cfe-commits wrote:
> rnk added a comment.
>
> Re: jumps out of __try, I wonder if you can tie __finally into whatever
> the CFG does for C++ destructors.
>
Given
$ cat test.cc
struct C {
C();
~C();
};
bool g();
void h();
vo
Author: nico
Date: Fri Aug 25 11:41:41 2017
New Revision: 311790
URL: http://llvm.org/viewvc/llvm-project?rev=311790&view=rev
Log:
Fix typo in comment, no behavior change.
Modified:
cfe/trunk/lib/CodeGen/CGCleanup.cpp
Modified: cfe/trunk/lib/CodeGen/CGCleanup.cpp
URL:
http://llvm.org/viewvc
I had compiled a bunch of code with this, but right after I sent this out
my local build of something failed with this:
../../buildtools/third_party/libc++/trunk/include/type_traits:2156:51:
error: destructor called on non-final
'Ice::VariableDeclaration::RelocInitializer' that has virtual functio
On Mon, Aug 28, 2017 at 7:40 PM, Richard Smith - zygoloid via Phabricator
via cfe-commits wrote:
> rsmith added inline comments.
>
>
>
> Comment at: test/SemaCXX/destructor.cpp:27
> +#define BE_THE_HEADER
> +#include __FILE__
> +
>
> Do we guarantee that `__FILE_
Author: nico
Date: Wed Aug 30 13:25:22 2017
New Revision: 312167
URL: http://llvm.org/viewvc/llvm-project?rev=312167&view=rev
Log:
Let -Wdelete-non-virtual-dtor fire in system headers too.
Makes the warning useful again in a std::unique_ptr world, PR28460.
Also make the warning not fire in uneva
Author: nico
Date: Wed Aug 30 23:17:08 2017
New Revision: 312216
URL: http://llvm.org/viewvc/llvm-project?rev=312216&view=rev
Log:
Suppress -Wdelete-non-virtual-dtor warnings about classes defined in system
headers.
r312167 made it so that we emit Wdelete-non-virtual-dtor from delete statements
Author: nico
Date: Wed Aug 30 23:18:26 2017
New Revision: 312218
URL: http://llvm.org/viewvc/llvm-project?rev=312218&view=rev
Log:
Remove accidental newline.
Modified:
cfe/trunk/test/SemaCXX/destructor.cpp
Modified: cfe/trunk/test/SemaCXX/destructor.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Test?
On Tue, Sep 5, 2017 at 1:32 PM, Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Tue Sep 5 10:32:36 2017
> New Revision: 312542
>
> URL: http://llvm.org/viewvc/llvm-project?rev=312542&view=rev
> Log:
> [Preprocessor] Correct internal token parsi
Have you checked how much the additional stat()ing added in this patch
slows down builds?
On Sep 16, 2017 11:49 PM, "Peter Wu via Phabricator via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Lekensteyn added a comment.
>
> I tried to contact Simon (the author of the GCC) patch with a quest
Hello,
this causes this diagnostic when building on Windows:
In file included from
../../ui/accessibility/platform/ax_platform_node_textchildprovider_win.cc:10:
../..\ui/accessibility/platform/ax_platform_node_textprovider_win.h(22,3):
error: 'nothrow' attribute conflicts with exception specifica
I'm not sure this is the best fix. From the patch description, it sounds
like this is a Microsoft-specific change. So splitting this into a new
diag group that then everyone using the Microsoft headers has to disable
seems a bit roundabout – don't we get the same behavior by not emitting
this warni
The invented mangling for clang-cl turns out to not be correct :)
https://bugs.llvm.org/show_bug.cgi?id=42093
Maybe it's better to add a "can't yet mangle" error, so that we don't
silently do the wrong thing?
On Sun, Aug 14, 2016 at 9:41 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.o
101 - 200 of 1693 matches
Mail list logo
