[PATCH] D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm Thanks. I moved your new description into the (previously still stale) revision title and put in a new description. lgtm. Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

thakis added a comment. https://webkit.org/code-style-guidelines/ has one instance of `{ }` with a space and one of `{}` without a space, and as far as I can tell no text that says which instance is correct. Are you sure this is the right thing for webkit style? Repository: rC Clang CHANGE

[PATCH] D66142: clang: Don't warn on unused momit-leaf-frame-pointer when frame pointers are off.

thakis created this revision. thakis added a reviewer: hans. This fixes a regression from r365860: As that commit message states, there are 3 valid states targeted by the combination of -f(no-)omit-frame-pointer and -m(no-)omit-leaf-frame-pointer. After r365860 it's impossible to get from

[PATCH] D66143: Don't use std::errc

thakis added a comment. This isn't in a hot codepath, so the virtual calls aren't super important. This not working in some libstdc++s is important of course, but llvm's Errc.h claims "std::error_code works OK on all platforms we use". I guess that's not true? Can you include more details on wh

[PATCH] D66143: Don't use std::errc

thakis added a comment. That's Trusty and Trusty is on 4.8 which we no longer support, right? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-

[PATCH] D66143: Don't use std::errc

thakis added a comment. As far as I know 4.8 is no longer supported. In D66143#1627168 , @ABataev wrote: > In D66143#1627165 , @thakis wrote: > > > That's Trusty and Trusty is on 4.8 which we no longer support, rig

[PATCH] D66143: Don't use std::errc

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Should we revert the change in lld then? LLVM has a global policy for this; if 4.8 is still supported then regex can't be used yet. Please mention in the commit message that this is a workarou

[PATCH] D66143: Don't use std::errc

thakis added a comment. FWIW it looks like 4.8 support is going away in days, not weeks, see D66188 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143

[PATCH] D52524: Add -Wno-poison-system-directories flag

thakis added a comment. Wouldn't those projects just move to also disabling the warning by passing -Wno-poison-system-directories? If there are projects that are actively adding -I/usr/include, that means they're consciously fighting the build system and you've kind of already lost, no? Can't y

[PATCH] D52524: Add -Wno-poison-system-directories flag

thakis added a comment. Ok, makes sense, thanks for explaining. Please add a summary of that discussion to the patch description / commit message :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 _

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

thakis added a comment. rnk, what's the status here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/ https://reviews.llvm.org/D66040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D66394: clang-cl: Enable /Zc:twoPhase by default if targeting MSVC 2017 update 3 or newer

thakis created this revision. thakis added a reviewer: hans. MSVC 2017 update 3 (_MSC_VER 1911) enables /Zc:twoPhase by default, and so should clang-cl: https://docs.microsoft.com/en-us/cpp/build/reference/zc-twophase clang-cl takes the MSVC version it emulates from the -fmsc-version flag, or if

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

thakis added a comment. Herald added a subscriber: dexonsmith. > I would think that both this change and https://reviews.llvm.org/D35326 are > good. What's the status here and in D35326 ? We still have a workaround in chromium's build files pointing at these two

[PATCH] D63697: clang-format: Fix error return when using inplace with stdin

thakis added a comment. Can you add a lit test for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63697/new/ https://reviews.llvm.org/D63697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

thakis added a comment. Herald added a project: clang. I noticed that this causes memory errors in certain situations. https://bugs.llvm.org/show_bug.cgi?id=42501 has details. Can you take a look? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53457/new/ https://

[PATCH] D64156: Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do

thakis created this revision. thakis added a reviewer: ruiu. Herald added subscribers: MaskRay, aheejin, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. This fixes an 8-year-old regression. r105763 made it so that aliases always refer to

[PATCH] D64156: Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do

thakis added a comment. ruiu: ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64156/new/ https://reviews.llvm.org/D64156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: MaskRay, hiraditya, arichardson, javed.absar, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. With this, `clang-cl /source-charset:utf-16 test.cc` now prints `invalid value 'utf-16' in

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

thakis added inline comments. Comment at: cfe/trunk/unittests/Rewrite/CMakeLists.txt:12 clangRewrite + clangTooling ) This makes RewriteTests depend on clangTooling, and in follow-ups on clangFrontend and clangSerialization. Rewrite used to depend on basi

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

thakis created this revision. thakis added a reviewer: rnk. This is a better fix for the problem fixed in r334972. Also remove the rm'ing of the symlink destination that was there to clean up the bots -- it's over a year later, bots should be happy now. https://reviews.llvm.org/D64301 Files:

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis created this revision. thakis added a reviewer: rnk. https://reviews.llvm.org/D64349 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaAttr.cpp clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis updated this revision to Diff 208538. thakis marked 2 inline comments as done. thakis added a comment. Herald added a subscriber: mstorsjo. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64349/new/ https://reviews.llvm.org/D64349 Files: clang/include/clang/Basic/Attr.t

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis added a comment. Thanks! Comment at: clang/test/Sema/pragma-section.c:57 + +// Not sure if this should warn or not. +__attribute__((section(".drectve"))) int drectve_int; rnk wrote: > I agree it probably shouldn't, I imagine mingw users will want to be a

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis added a comment. In D64349#1574742 , @rnk wrote: > lgtm Thanks! > May I ask what inspired this? :) I was looking through lld/COFF/Driver.cpp for something…ah, right, because D64156 touched it, and because I loo

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

thakis added a comment. > lgtm Thanks! > 5381 361257 out/clang/browser_tests.exe.rsp Looking at that file, that looks like 10554 distinct args from the rsp file. That's ~80kB for the additional pointer, which for a link that's going to consume hundreds of MB isn't all that much overhead. (

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

thakis added inline comments. Comment at: clang-tools-extra/trunk/clangd/refactor/tweaks/CMakeLists.txt:20 SwapIfBranches.cpp + ExtractVariable.cpp (nit: keep in alphabetical order) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis created this revision. thakis added a reviewer: rnk. - Add back indentation I accidentally removed in r364901 - Wrap two lines to 80 cols - Slightly tighten up help text for several flags - Consistently use "Do not" instead of "Don't" - Make every option description start with a verb - Use

[PATCH] D64506: clang-cl: Remove -O0 option

thakis created this revision. thakis added a reviewer: rnk. cl.exe doesn't understand it; there's /Od instead. See also the review thread for r229575. https://reviews.llvm.org/D64506 Files: clang/include/clang/Driver/CLCompatOptions.td Index: clang/include/clang/Driver/CLCompatOptions.td ==

[PATCH] D64506: clang-cl: Remove -O0 option

thakis added a comment. I did check that we now warn, like you had requested: $ out/gn/bin/clang-cl test.cc /O0 /c clang: warning: argument unused during compilation: '/O0' [-Wunused-command-line-argument] Adding a test for that felt weird though, so I didn't. CHANGES SINCE LAST ACTION

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: kristof.beyls, javed.absar. clang currently warns when passing flags for the assembler (e.g. -Wa,-mbig-obj) to an invocation that doesn't run the assembler (e.g. -E). At first sight, that makes sense -- the flag

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

thakis added a comment. (previously: D58061 ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D64506: clang-cl: Remove -O0 option

thakis added a comment. In D64506#1579251 , @rnk wrote: > Does `clang-cl -O0` without a `/` still work, though? It's used: > > $ git grep O0 ../compiler-rt/test/asan/TestCases/Windows/ > ../compiler-rt/test/asan/TestCases/Windows/aligned_mallocs.cc:// RUN

[PATCH] D64506: clang-cl: Remove -O0 option

thakis updated this revision to Diff 209092. thakis added a comment. Herald added subscribers: llvm-commits, kubamracek. Herald added a project: LLVM. update tests (not yet executed, don't have a win machine today) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64506/new/ https://review

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis added inline comments. Comment at: clang/include/clang/Driver/CLCompatOptions.td:250 def _SLASH_Zi : CLFlag<"Zi">, Alias<_SLASH_Z7>, - HelpText<"Alias for /Z7. Does not produce PDBs.">; + HelpText<"Like /Z7">; def _SLASH_Zp : CLJoined<"Zp">, rnk wrote:

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis updated this revision to Diff 209093. thakis marked 4 inline comments as done. thakis added a comment. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64504/new/ https://reviews.llvm.org/D64504 Files: clang/include/clang/Driver/CLCompatOptions.td Index: clang/include/c

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis closed this revision. thakis added a comment. r365721 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64504/new/ https://reviews.llvm.org/D64504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis created this revision. thakis added a reviewer: rjmccall. Slightly less code, uses slightly less stack space, and makes it impossible to mix up the order of all those bools. No behavior change. https://reviews.llvm.org/D61788 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis updated this revision to Diff 199056. thakis edited the summary of this revision. thakis added a comment. Now with more boilerplate! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61788/new/ https://reviews.llvm.org/D61788 Files: clang/include/clang/AST/ASTContext.h clang/lib

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2877 +OCET_EncodePointerToObjCTypedef = 1 << 7, + }; + void getObjCEncodingForTypeImpl(QualType t, std::string &S, unsigned Options, rjmc

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2877 +OCET_EncodePointerToObjCTypedef = 1 << 7, + }; + void getObjCEncodingForTypeImpl(QualType t, std::string &S, unsigned Options, rjmccall wrote: > thakis wrote: > > rjmccall

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis updated this revision to Diff 199116. thakis marked 4 inline comments as done. thakis added a comment. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61788/new/ https://reviews.llvm.org/D61788 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis updated this revision to Diff 199408. thakis added a comment. minor tweaks for landing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61788/new/ https://reviews.llvm.org/D61788 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp Index: clang/lib/AST/ASTC

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

thakis added a comment. Out of interest: The RecursiveASTVisitorTests are part of the ToolingTests binary while this adds a new binary TokensTest. Can you say why? (No change needed, just curious.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https:

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

thakis added a comment. Another comment: The new binary is called TokensTest but is in a directory "Syntax". For consistency with all other unit test binaries, please either rename the binary to SyntaxTests, or rename the directory to "Tokens". (From the patch description, the former seems more

[PATCH] D62201: [LibTooling] Adjust dependencies for unittests.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Maybe say "address post-commit feedback for r" in the description. (But as-is is fine too.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags

thakis created this revision. thakis added a reviewer: rnk. Herald added a project: LLVM. OptTable treats arguments starting with / that aren't a known option as filenames. This means lld-link's and clang-cl's typo correction for unknown flags didn't do spell checking for misspelled options that s

[PATCH] D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags

thakis marked 5 inline comments as done. thakis added a comment. Thanks! Landing with comments addressed. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:177 def warn_drv_unknown_argument_clang_cl_with_suggestion : Warning< - "unknown argument ignored in clang-

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

thakis added a comment. Please see https://clang.llvm.org/docs/InternalsManual.html#fix-it-hints , especially the "need to obey these rules" bit. I'm not sure that's fulfilled here. Maybe the fixit should be on a note instead? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews

[PATCH] D62420: Rename clangToolingRefactor to clangToolingRefactoring for consistency with its directory

thakis created this revision. thakis added a reviewer: rsmith. Herald added subscribers: llvm-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: LLVM. See "[cfe-dev] The name of clang/lib/Tooling/Refactoring". https://reviews.llvm.org/D62420 Files: clang-tools-extra/clang-a

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

thakis added inline comments. Comment at: cfe/trunk/unittests/Tooling/CMakeLists.txt:4 Support TestingSupport ) The library is already up here. Why do we need it twice? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62333/

[PATCH] D62490: clang-cl: Fix mangling of catchable types with names longer than 4kiB

thakis created this revision. thakis added a reviewer: rnk. The mangling used to contain the MD5 name of both the RTTI type descriptor and the name of the copy ctor in MSVC2013, but it changed to just the former in 2015. It looks like it changed back to the old mangling in VS2017 version 15.7 and

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. Hello, this embeds an absolute path into the generated .obj file, which means the output now is no longer deterministic (since it depends on the absolute path to clang_rt.profile-x86_64.lib). This means the output will be different on different machines, which breaks thi

[PATCH] D62523: Add release note entries for recent typo correction changes

thakis created this revision. thakis added a reviewer: hans. Herald added a project: LLVM. https://reviews.llvm.org/D62523 Files: clang/docs/ReleaseNotes.rst lld/docs/ReleaseNotes.rst Index: lld/docs/ReleaseNotes.rst === --- ll

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. After some more reading, it looks like passing `-no-canonical-prefixes` makes this path relative, and as long as compiles and links run from the same CWD things will work and be path-independent. So I think this is all good. Sorry about the false alarm! (Maybe we should

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. It seems to work for me from what I can tell: $ out/gn/bin/clang-cl /c -fprofile-instr-generate /TC /dev/null -### -no-canonical-prefixes 2>&1 | grep -o 'dependent-lib=[^"]*' dependent-lib=libcmt dependent-lib=oldnames dependent-lib=out/gn/lib/clang/9.0.0/lib/wind

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. Since this seems to work with no-canonical-prefixes, I think this is good as-is since people who want build path independent builds need that flag anyway. (At least if Russel can reproduce it working with no-canonical-prefixes; not sure why it wouldn't.) Repository:

[PATCH] D54681: [Driver] Avoid including -lm on the link line with -nostdlib++

thakis added a comment. -lm is kind of the reason -nostdlib++ exists at all -- if you don't want _any_ stdlibs, you can just -nostdlib, no? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54681/new/ https://reviews.llvm.org/D54681 __

[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Firefox is good enough. Thanks for finding http://comments.gmane.org/gmane.comp.compilers.clang.scm/47203 -- this was from before we did reviews on phab, so I was able to find the review in m

[PATCH] D55847: [gn build] Add build file for clang/lib/Basic and dependencies

thakis created this revision. Herald added subscribers: fedor.sergeev, aheejin, dschuff. Adds a build file for clang-tblgen and an action for running it, and uses that to process all the .td files in include/clang/Basic. Also adds an action to write include/clang/Config/config.h and include/cla

[PATCH] D55912: [gn build] Add build files for clang/lib/Lex and clang/lib/AST

thakis created this revision. thakis added a reviewer: phosek. Nothing interesting. https://reviews.llvm.org/D55912 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/include/clang/AST/BUILD.gn llvm/utils/gn/secondary/clang/lib/AST/BUILD.gn llvm/utils/gn/secondary/cla

[PATCH] D55913: [gn build] Add build files for clang/lib/{Analysis, Edit, Sema}

thakis created this revision. thakis added a reviewer: phosek. Nothing interesting. https://reviews.llvm.org/D55913 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/include/clang/Sema/BUILD.gn llvm/utils/gn/secondary/clang/lib/Analysis/BUILD.gn llvm/utils/gn/seconda

[PATCH] D55924: [gn build] Add build files for clang-format and lib/{Format, Rewrite, Tooling/Core, Tooling/Inclusions}

thakis created this revision. thakis added a reviewer: phosek. https://reviews.llvm.org/D55924 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/Format/BUILD.gn llvm/utils/gn/secondary/clang/lib/Rewrite/BUILD.gn llvm/utils/gn/secondary/clang/lib/Tooling/Core/BUILD.

[PATCH] D55925: [gn build] Add build file for clang/lib/Parse

thakis created this revision. thakis added a reviewer: phosek. Nothing really interesting. One thing to consider is where the clang_tablegen() invocations that generate files that are private to a library should be. The CMake build puts them in clang/include/clang/Parse (in this case), but maybe

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: fedor.sergeev, aheejin, dschuff. Mostly boring, except for the spurious dependency on StaticAnalyzer/Checkers -- see comments in the code. https://reviews.llvm.org/D55927 Files: llvm/utils/gn/secondary/B

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

thakis updated this revision to Diff 179067. thakis added a comment. sync CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55927/new/ https://reviews.llvm.org/D55927 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/include/clang/Driver/BUILD.gn llvm/utils/gn/sec

[PATCH] D55930: [gn build] Add build files for clang/lib/{Frontend, Frontend/Rewrite, Serialization}

thakis created this revision. thakis added a reviewer: phosek. https://reviews.llvm.org/D55930 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/include/clang/Serialization/BUILD.gn llvm/utils/gn/secondary/clang/lib/Frontend/BUILD.gn llvm/utils/gn/secondary/clang/lib/F

[PATCH] D55931: [gn build] Add build file for clang/lib/CodeGen and llvm/lib/ProfileData/Coverage

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: jfb, hiraditya. https://reviews.llvm.org/D55931 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn llvm/utils/gn/secondary/llvm/lib/ProfileData/Coverage/BUILD.gn

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: dkrupp, donat.nagy, jfb, Szelethus, arphaman, a.sidorin, baloghadamsoftware. Herald added a reviewer: george.karpenkov. The intent is to add the build file for clang/lib/StaticAnalyzer/Frontend; everything e

[PATCH] D55979: [gn build] Add build file for clang/lib/ARCMigrate

thakis created this revision. thakis added a reviewer: phosek. thakis added a parent revision: D55978: [gn build] Add build files for clang/lib/{ASTMatchers,CrossTU}, clang/lib/StaticAnalyzer/{Checkers,Core,Frontend}. https://reviews.llvm.org/D55979 Files: llvm/utils/gn/secondary/BUILD.gn l

[PATCH] D55980: [gn build] Add build file for clang/lib/FrontendTool

thakis created this revision. thakis added a reviewer: phosek. https://reviews.llvm.org/D55980 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/FrontendTool/BUILD.gn Index: llvm/utils/gn/secondary/clang/lib/FrontendTool/BUILD.gn =

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis added a comment. Thanks for taking a look! In D55978#1338654 , @george.karpenkov wrote: > > I might want to default to clang_enable_static_analyzer=false when I add > > the clang/lib/FrontendTool build file. > > I don't think that quite makes sen

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis added a comment. In D55978#1338651 , @george.karpenkov wrote: > Looks reasonable, what about linking with Z3? Or is your goal just to get a > minimally working functionality? Sorry, forgot to reply to this. I don't use this, so I feel someone wh

[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

thakis added a comment. Herald added a subscriber: guansong. Sorry about the years-later question, but what's the motivation for shelling out to an external command here? In general, LLVM tries to use a library-based approach, and LLVM went e.g. through great lengths do use an integrated assemb

[PATCH] D55981: [gn build] Add build files for clang, clang-offload-bundler, and clang/lib/Headers

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: jfb. thakis added a parent revision: D55980: [gn build] Add build file for clang/lib/FrontendTool. With this, the GN build can build clang! https://reviews.llvm.org/D55981 Files: llvm/utils/gn/secondary

[PATCH] D55984: [gn build] Embed __TEXT __info_plist section into clang binary on macOS

thakis created this revision. thakis added a reviewer: phosek. Verified by comparing the output of `otool -P bin/clang` between the GN and the CMake build. https://reviews.llvm.org/D55984 Files: llvm/utils/gn/secondary/clang/tools/driver/BUILD.gn Index: llvm/utils/gn/secondary/clang/tools/

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

thakis added a comment. In D54565#1331293 , @Quuxplusone wrote: > @rsmith ping! > > @thakis: You said, //"From a user point of view, I have no idea what "CTAD" > means, and I sometimes work on a C++ compiler."// Did you mean "I think the > command-line o

[PATCH] D55981: [gn build] Add build files for clang, clang-offload-bundler, and clang/lib/Headers

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn:6 + +files = [ + "adxintrin.h", phosek wrote: > Why not just inline this? This variable doesn't seem to be used from anywhere >

[PATCH] D55981: [gn build] Add build files for clang, clang-offload-bundler, and clang/lib/Headers

thakis updated this revision to Diff 179404. thakis marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55981/new/ https://reviews.llvm.org/D55981 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn llvm/utils/gn/se

[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

thakis accepted this revision. thakis added a comment. Still looks fine to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55382/new/ https://reviews.llvm.org/D55382 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D56054: [gn build] Add build files for clang/tools/{clang-diff, clang-import-test, diagtool and clang/lib/Tooling, clang/lib/Tooling/ASTDiff

thakis created this revision. thakis added a reviewer: phosek. Needed by check-clang. https://reviews.llvm.org/D56054 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/Tooling/ASTDiff/BUILD.gn llvm/utils/gn/secondary/clang/lib/Tooling/BUILD.gn llvm/utils/gn/secon

[PATCH] D56055: [gn build] Add build files for clang/tools/{clang-refactor, clang-rename}, clang/utils/hmaptool, clang/lib/Tooling/Refactoring

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: jfb. Needed for check-clang. https://reviews.llvm.org/D56055 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/Tooling/Refactoring/BUILD.gn llvm/utils/gn/secondary/clang/tools

[PATCH] D56056: [gn build] Add build files for clang/tools/{arcmt-test, clang-check, clang-func-mapping}

thakis created this revision. thakis added a reviewer: phosek. Needed for check-clang. https://reviews.llvm.org/D56056 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/tools/arcmt-test/BUILD.gn llvm/utils/gn/secondary/clang/tools/clang-check/BUILD.gn llvm/utils/gn/s

[PATCH] D56059: [gn build] Add build files for clang/tools/{c-arcmt-test, c-index-test} and their dependency clang/tools/libclang

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: arphaman. libclang is somewhat incomplete. It's just enough to get check-clang to pass, but that requires it to be pretty complete. The biggest thing is that it's not built as a shared library on Linux. The

[PATCH] D56059: [gn build] Add build files for clang/tools/{c-arcmt-test, c-index-test} and their dependency clang/tools/libclang

thakis marked an inline comment as done. thakis added a comment. Thanks Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16-17 +if (host_os == "linux") { + # Linux needs -fPIC to build shared libs but they aren't on by default. + # For now, make libclang a st

[PATCH] D56065: [gn build] Make NOSORT line actually work

thakis created this revision. thakis added a reviewer: phosek. GN wants the NOSORT line to be the first line of a comment block, not the last line. I sent https://gn-review.googlesource.com/c/gn/+/3560 to support having it in the last line too, but since it will be a while until everyone has th

[PATCH] D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

thakis created this revision. thakis added a reviewer: arphaman. For some reason, the cmake build on my macbook has LLVM_HOST_TRIPLE:STRING=i386-apple-darwin16.7.0 . test/Driver/darwin-sdk-version.c assumed that the host triple is 64-bit, so make it resilient against 32-bit host triples. http

[PATCH] D56086: Pass a concrete triple for two OpenMP tests that depend on TLS

thakis created this revision. thakis added reviewers: ABataev, sfantao. Herald added a subscriber: guansong. Not all %itanium_abi_triple values support TLS. Makes OpenMP/declare_reduction_codegen.cpp, OpenMP/parallel_copyin_codegen.cpp for %itanium_abi_triples without TLS support. Fixes PR40156

[PATCH] D56095: [gn build] Add check-clang target and make it work

thakis created this revision. thakis added a reviewer: phosek. With this, check-clang runs and passes all of clang's lit tests. It doesn't run any of its unit tests yet. Like with check-lld, running just ninja -C out/gn will build all prerequisites needed to run tests, but it won't run the test

[PATCH] D56095: [gn build] Add check-clang target and make it work

thakis marked an inline comment as done. thakis added inline comments. Comment at: llvm/utils/gn/secondary/clang/test/BUILD.gn:23 + + "LIT_SITE_CFG_IN_HEADER=## Autogenerated from ${sources[0]}, do not edit", + "CLANG_BINARY_DIR=" + As you can see, thi

[PATCH] D56095: [gn build] Add check-clang target and make it work

thakis marked an inline comment as done. thakis added inline comments. Comment at: llvm/utils/gn/secondary/llvm/triples.gni:10 +} else { + assert(false, "missing host_cpu " + host_cpu) } phosek wrote: > I don't think `host_cpu` would ever be missing since it's

[PATCH] D56095: [gn build] Add check-clang target and make it work

thakis updated this revision to Diff 179563. thakis added a comment. s/missing/unimplemented/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56095/new/ https://reviews.llvm.org/D56095 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/test/BUILD.gn llvm/utils/gn

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: arphaman. Also add a build file for clang/lib/ASTMatchers/Dynamic, which is only needed by tests (and clang/tools/extra). With this, the build files for //clang are complete. - I'm sending this out before

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis updated this revision to Diff 179667. thakis edited the summary of this revision. thakis added a comment. Herald added a subscriber: mgorny. - add test BUILD.gn support to sync script - remove bigobj fixme since that issue isn't specific to that file CHANGES SINCE LAST ACTION https://re

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis updated this revision to Diff 179736. thakis edited the summary of this revision. thakis added a comment. Add unittest template. This is now ready to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56116/new/ https://reviews.llvm.org/D56116 Files: llvm/utils/gn/build/BUILDCO

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis added a comment. Thanks for the fast turnaround! Comment at: llvm/utils/gn/secondary/llvm/utils/unittest/unittest.gni:34 +# out/gn/obj/clang/unittests/Format/FormatTests, which seems fine. +output_dir = target_out_dir +deps += [ phosek wrote:

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis updated this revision to Diff 179744. thakis marked 2 inline comments as done. thakis added a comment. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56116/new/ https://reviews.llvm.org/D56116 Files: llvm/utils/gn/build/BUILDCONFIG.gn llvm/utils/gn/build/sync_source_

[PATCH] D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

thakis added a comment. arphaman: 2019 ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56067/new/ https://reviews.llvm.org/D56067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D56273: Validate -add-plugin arguments.

thakis created this revision. thakis added a reviewer: rnk. -plugin already prints an error if the name of an unknown plugin is passed. -add-plugin used to silently ignore that, now it errors too. https://reviews.llvm.org/D56273 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang

[PATCH] D56273: Validate -add-plugin arguments.

thakis updated this revision to Diff 180084. thakis added a comment. forgot to add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56273/new/ https://reviews.llvm.org/D56273 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/Frontend/plugin-unknown.c Index: clang/test

[PATCH] D56273: Validate -add-plugin arguments.

thakis updated this revision to Diff 180085. thakis added a comment. remove require CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56273/new/ https://reviews.llvm.org/D56273 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/Frontend/plugin-unknown.c Index: clang/test/Fro

<    1   2   3   4   5   6   7   8   9   10   >