[PATCH] D39317: Use -fuse-init-array if no gcc installation is found.

thakis closed this revision. thakis added a comment. r316713, thanks! https://reviews.llvm.org/D39317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

thakis added a comment. Sounds like this ended up being useful for Android too: https://github.com/android-ndk/ndk/issues/105#issuecomment-324179958 https://reviews.llvm.org/D35780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146280/new/ https://reviews.llvm.org/D146280 ___ c

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

thakis added a comment. (if the presubmit is related, maybe some flang test needs updating? Weird that flang uses clang's diags.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146280/new/ https://reviews.llvm.org/D146280 _

[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

thakis added a comment. This breaks tests: http://45.33.8.238/linux/102084/step_9.txt Please take a look and revert for now if it takes a while to fix. Did you not run tests before commiting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134827/ne

[PATCH] D146417: [clangd] Fix AddUsing in the face of typo-correction

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/76177/step_9.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146417/new/ https://reviews.llvm.org/D146

[PATCH] D143496: [clangd] Add support for missing includes analysis.

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/75486/step_9.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143

[PATCH] D143496: [clangd] Add support for missing includes analysis.

thakis added a comment. Oh, that was reported a while ago already. Reverted in 2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/63504/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

thakis added a comment. Reverted in b851308b870a67ccb606d0d33f159a70fd3522c7 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 ___ cfe-commits mailing li

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/80283/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149280/new/ https://reviews.llvm.org/D149

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

thakis added a comment. None i know of, but given the bot's already red, you won't make it worse :) Tests shouldn't include any headers generally, not even inttypes.h (unless the test tests that header). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

thakis added a comment. This breaks tests: http://45.33.8.238/linux/104455/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 ___

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

thakis added a comment. This breaks check-clang on windows: http://45.33.8.238/win/78827/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151042/new/ https://reviews.llvm.or

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

thakis added a comment. On my bots (which cover linux, mac/arm, and windows), it's only failing on the windows bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151042/new/ https://reviews.llvm.org/D151042 ___

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

thakis added a comment. In D151042#4364131 , @Endill wrote: > All tests pass for me on Linux. > As far as I understand, diagnostics on Windows are not supposed to be > different given the same `-cc1` flags. Reverting for further investigation. Thanks fo

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm, thanks! (clicky: https://reviews.llvm.org/rG6625680a581c5e29c53d9f58d864cc6cd3cd05f6) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151609

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

thakis added subscribers: sammccall, thakis. thakis added inline comments. Comment at: clang-tools-extra/pseudo/lib/grammar/CMakeLists.txt:5 -# Dependencies should be minimal to avoid long dep paths in the build graph. -# It does use clangBasic headers (tok::TokenKind), but linki

[PATCH] D151608: [Sema] Remove unused function getFloat128Identifier

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151608/new/ https://reviews.llvm.org/D151608 ___

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

thakis added inline comments. Comment at: clang/unittests/Lex/CMakeLists.txt:21 clangBasic + clangFrontend clangLex It seems strange layering-wise that the Lex unit tests would depend on Frontend. Is there any way to prevent that dep? Repository: rG L

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

thakis added a comment. Either this or D139168 is breaking tests on Windows: http://45.33.8.238/win/74780/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

thakis added a comment. This broke check-clang on windows: http://45.33.8.238/win/78359/step_7.txt (The Driver/split-debug.c failure is something else and since fixed, but the other two tests are due to this change.) Please take a look and revert for now if it takes a while to fix. Repository

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

thakis added a comment. Fails with cmake too: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8781510258907322449/+/u/package_clang/stdout?format=raw Reverted in 56bac6c87a2d9046dbac36aae4910b4b90edf643 for

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/78516/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150282/new/ https://reviews.llvm.org/D150

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

thakis added a comment. Apologies for the noise, looks like my win bot hasn't built in a while. Looks like this is already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150282/new/ https://reviews.llvm.org/D150282 _

[PATCH] D150668: Add doc link to missing include diagnostics.

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/107099/step_9.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150668/new/ https://reviews.llvm.org/D15

[PATCH] D150668: Add doc link to missing include diagnostics.

thakis added a comment. For the records: Fixed in 76941b68ecd9 . Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150668/new/ https://reviews.llvm.org/D15

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 for now. Sorry this is such a pain to land :( (See also discussion over in D150688 ) Reposit

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

thakis added a comment. In D144654#4349908 , @john.brawn wrote: > This patch caused a failure in AArch64 buildbots due to > AArch64TargetInfo::getTargetDefines redefining _LP64 and __LP64__. Fixed in > https://reviews.llvm.org/rGe55d52cd34fb7a6a6617639

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

thakis added a comment. Reverted in cf8c358dc9414e3de9f65eebdfdcb66dd5817857 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 ___ cfe-commits mailing li

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. https://github.com/llvm/llvm-project/issues/62719 is independent of chromium and others have reported problems above too, from what I understand. Is that not accurate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/ne

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. Is https://reviews.llvm.org/D144509#4347562 fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 ___ cfe-commits mailing list cfe-comm

[PATCH] D146664: Apply the same fallbacks as runtimes search for stdlib search

thakis added a comment. Is it possible to test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146664/new/ https://reviews.llvm.org/D146664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

thakis added a comment. This makes lld crash when linking a libc++ with object files built by a clang that also contains the patch. Here's a reduced (to just libc++), stand-alone repro that repros the crash in 6 seconds on my m1 mbp: https://bugs.chromium.org/p/chromium/issues/detail?id=1446967

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

thakis added a comment. Reverted in 4980eead4d0b4666d53dad07afb091375b3a13a0 for now. (The assert only happens when targeting x86_64, not arm64. The repro script above has the right `-arch` flag to toggle it.) Repository:

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

thakis added inline comments. Comment at: clang/utils/bundle_resources.py:6 +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception ---

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

thakis added a comment. Herald added a subscriber: wlei. >> Another point: having a diagnostic fire (failing a `-Werror` build) >> depending on the content of the profile passed to `-fprofile-use` seems >> pretty hostile to build workflows. > > Okay, this last point is especially compelling to m

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

thakis added a comment. > ASTMatchers have been baked into clang binary for at least a few years > already, actively used by the static analyzer (some backstory in D25429 > ). This warning is, however, probably the > first use in clang proper, so they'll be ther

[PATCH] D147281: Stop modifying trailing return types.

thakis added a comment. Looks like this caused a change in behavior: https://github.com/llvm/llvm-project/issues/62361 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147281/new/ https://reviews.llvm.org/D147281

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

thakis added a comment. In D148769#4311232 , @dblaikie wrote: > I wouldn't mind a follow-up commit that creates a new/separate directory > (llvm/{lib,include/llvm}/CodeGenTypes) but that's probably a lot of > unnecessary churn too, so I can appreciate t

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

thakis added a comment. Looks like the revert broke tests: http://45.33.8.238/linux/109159/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 ___ cfe-co

[PATCH] D150023: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

thakis added a comment. Looks like this breaks check-clang on Mac: http://45.33.8.238/macm1/62779/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150023/new/ https://revie

[PATCH] D150023: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

thakis added a comment. Reverted in dbdd6372b7af2f6df5f41d19d966e6bac1b30208 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150023/new/ https://reviews.llvm.org/D150023

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

thakis added a comment. Also on http://45.33.8.238/win/79874/step_7.txt Reverted in 9c560350dd57d0dcb849c5915fa7c50b139ce671 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152472/new/ https://reviews.llvm.org/D152472 _

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

thakis added a comment. This is still breaking check-clang on windows: http://45.33.8.238/win/79908/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152472/new/ https://rev

[PATCH] D136078: Use-after-return sanitizer binary metadata

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/93224/step_12.txt Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/93300/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ https://reviews.llvm.org/D137275

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

thakis added a comment. This breaks building lldb: http://45.33.8.238/linux/93366/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139274/new/ https://reviews.llvm.org/D139274 ___ cfe-commits mai

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

thakis added a comment. Reverted in de4b6a1bc64db33643f001ad45fae7b92b4a4688 for now. (Note that there was a follow-up fix in e50a60d7349de151bd2b06d85a79201ebc372d8a

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

thakis added a comment. In D137275#3972773 , @thakis wrote: > This breaks check-clang: http://45.33.8.238/linux/93300/step_7.txt > > Please take a look and revert for now if it takes a while to fix. This ended up being a local config thing that I fixed i

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

thakis added a comment. …but even after that, things are still broken on macOS: http://45.33.8.238/macm1/50243/step_7.txt ar: no archive members specified usage: ar -d [-TLsv] archive file ... ar -m [-TLsv] archive file ... ar -m [-abiTLsv] position archive file ...

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

thakis added a comment. Reverted this in 8e7994b9b513497589d4bf911f061378f517fb16 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ https://reviews.llvm.org/D13

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. I think this is obsolete now that D139107 is in, right? Marking as "request changes" to get it off my dashboard. Ideally you'll hit "Abandon" (whic

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

thakis added a comment. In D137269#3925163 , @thakis wrote: > Heads-up: This very visibly broke web page rendering in Chromium (but only > when using LTO) (https://crbug.com/1383873) . Not clear yet if this exposed > UB on our end or not. After looking

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/71451/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/ https://reviews.ll

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. LG (except for thieta's nit.) Do you have commit permissions, or do you need someone to land this for you? If the latter, which name and email should we use for landing it? Repository: rG

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

thakis added a comment. > Can we get more specific about what Chromium is seeing? https://github.com/llvm/llvm-project/issues/59473 has a standalone repro. What else would you like to see? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136100/new/

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis created this revision. thakis added a reviewer: rnk. thakis added a subscriber: cfe-commits. https://reviews.llvm.org/D27769 Files: docs/MSVCCompatibility.rst Index: docs/MSVCCompatibility.rst === --- docs/MSVCCompatibilit

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis added inline comments. Comment at: docs/MSVCCompatibility.rst:80 + Windows debuggers and tools like ETW. + There is no way to request DWARF debug info in clang-cl mode, so linking + with either binutils' ld or LLVM's lld won't produce debug info. Work to --

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis added inline comments. Comment at: docs/MSVCCompatibility.rst:80 + Windows debuggers and tools like ETW. + There is no way to request DWARF debug info in clang-cl mode, so linking + with either binutils' ld or LLVM's lld won't produce debug info. Work to --

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis updated this revision to Diff 81443. thakis added a comment. no dwarf or gcc mode https://reviews.llvm.org/D27769 Files: docs/MSVCCompatibility.rst Index: docs/MSVCCompatibility.rst === --- docs/MSVCCompatibility.rst +++

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis added inline comments. Comment at: docs/MSVCCompatibility.rst:77 + debug information if ``/Z7`` or ``/Zi`` is passed. Microsoft's link.exe will + transform the CodeView debug information into a PDB that works in modern + Windows debuggers and tools like ETW. Work to te

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis updated this revision to Diff 81448. thakis added a comment. reword slightly https://reviews.llvm.org/D27769 Files: docs/MSVCCompatibility.rst Index: docs/MSVCCompatibility.rst === --- docs/MSVCCompatibility.rst +++ docs

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

thakis added a comment. Huh, I'm surprised this has a runtime component, I missed that. I thought this would be a statically-checked thing. But having this does seem useful :-) I'm also surprised that this compiles down to Gestalt – Gestalt is deprecated in newer SDKs, and in Chromium we invest

[PATCH] D27858: Default to standalone debug info on Windows

thakis added a comment. Did you measure what this does to link times? https://reviews.llvm.org/D27858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27909: Add a lit test for PR31374

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: test/CodeGenObjC/nullptr-assert.m:1 +// RUN: %clang_cc1 -Wno-objc-root-class -triple x86_64-- -emit-llvm -o - %s +// REQUIRES: asserts If

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis closed this revision. thakis added a comment. r289712 https://reviews.llvm.org/D27769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28165: Change clang-format's Chromium JavaScript defaults

thakis added inline comments. Comment at: lib/Format/Format.cpp:643 +ChromiumStyle.AllowShortIfStatementsOnASingleLine = false; +ChromiumStyle.AllowShortLoopsOnASingleLine = false; + } Thanks for the patch! Do we want these as false in Chromium's JS? I w

[PATCH] D28165: Change clang-format's Chromium JavaScript defaults

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I'd rather we don't deviate from google style at all, but this brings us closer from where we are to that, so lgtm :-) https://reviews.llvm.org/D28165 _

[PATCH] D28165: Change clang-format's Chromium JavaScript defaults

thakis closed this revision. thakis added a comment. http://llvm.org/viewvc/llvm-project?view=revision&revision=290930 https://reviews.llvm.org/D28165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

thakis added a comment. One consequence from this that I just realized is that linking a binary depending on clang stuff with (morally): c++ -o foo foo.o $($LLVMBUILD/bin/llvm-config --ldflags) -lclangFrontend -lclangDriver -lclangParse -lclangSema -lclangSerialization -lclangAnalysis -lclan

[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

thakis added a comment. Aha, looks like this did have a `#pragma comment(lib` when it went in (for version.lib which is actually the correct one), but takumi removed it in http://llvm.org/viewvc/llvm-project?rev=269557&view=rev Repository: rL LLVM https://reviews.llvm.org/D20136

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

thakis added a comment. Thanks! Can you add a test somewhere? `grep -R W.*uninitialized test/Sema*` will probably show you the existing test for this code. (Another technique: Comment some of the existing tests, run `ninja check-clang`, and see which tests start failing.) You can run an indiv

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

thakis added a comment. Thanks for the test! Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:907 else DiagUninitUse(S, VD, Use, true); } lethalantidote wrote: > thakis wrote: > > Should the check be in DiagUninitUse()? Or is there a reason t

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

thakis added a comment. Thanks, this is looking pretty good! From clicking around a bit on cs, do you think it's better to put the check where you have it, or is maybe http://llvm-cs.pcc.me.uk/tools/clang/lib/Analysis/UninitializedValues.cpp#36 more appropriate? I think having it where you have

[PATCH] D30991: [Driver] Fix cross compiling with Visual Studio 2017

thakis added a comment. What env vars are needed here? Reading an env file seems a bit inelegant, could we pass the values of these env vars as flags instead? For example, MSVC2015 needs %INCLUDE%, but for cross-compiling (and for building on Windows without requiring env vars to be set we adde

[PATCH] D30991: [Driver] Fix cross compiling with Visual Studio 2017

thakis added a comment. When you say "cross-compiling", you mean targeting Windows while running on non-Windows, right? How do dlls get loaded there at all? Also, when does clang invoke link.exe? Normally on Windows the linker is invoked directly, no through the compiler driver. Are you using c

[PATCH] D30991: [Driver] Fix cross compiling with Visual Studio 2017

thakis added a comment. Ah ok, thanks for explaining. In that case, this sounds fine and I'll leave the review to zturner. https://reviews.llvm.org/D30991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

thakis added inline comments. Comment at: include/clang/Basic/TokenKinds.def:230 +PUNCTUATOR(greatergreatergreaterequal, ">>>=") +PUNCTUATOR(lesslesslessequal, "<<<=") + I think this is the wrong approach to go about this. clang is a C compiler, and its tokenize

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit access? Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

thakis closed this revision. thakis added a comment. Landed in r299952: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170410/189882.html Repository: rL LLVM https://reviews.llvm.org/D31652 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks great to me, thanks! Unless someone else shouts, I'll land this for you soon. https://reviews.llvm.org/D28543 ___ cfe-commits mailing list

[PATCH] D35379: Add documentation for @available

thakis created this revision. Based on https://devstreaming-cdn.apple.com/videos/wwdc/2017/411a7o9phe4uekm/411/411_whats_new_in_llvm.pdf (I couldn't find a way to play the corresponding video on linux, so I didn't look at that.) https://reviews.llvm.org/D35379 Files: docs/LanguageExtension

[PATCH] D35379: Add documentation for @available

thakis updated this revision to Diff 106513. thakis marked an inline comment as done. thakis added a comment. comments https://reviews.llvm.org/D35379 Files: docs/LanguageExtensions.rst include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td =

[PATCH] D35379: Add documentation for @available

thakis added inline comments. Comment at: docs/LanguageExtensions.rst:1290 -.. _langext-overloading: - erik.pilkington wrote: > did you mean to remove this? I meant to move it above the "protocol-qualifier mangling of parameters" section; I think that's where

[PATCH] D35379: Add documentation for @available

thakis updated this revision to Diff 106528. thakis marked an inline comment as done. thakis added a comment. Document *, add example with multiple platforms https://reviews.llvm.org/D35379 Files: docs/LanguageExtensions.rst include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDo

[PATCH] D35379: Add documentation for @available

thakis marked 7 inline comments as done. thakis added a comment. Thanks, all done, much better! Comment at: docs/LanguageExtensions.rst:1347 + +In rare cases, the availability annotation on an API might be overly +conservative. For example, ``[NSProcessInfo processInfo]`` secr

[PATCH] D35379: Add documentation for @available

thakis updated this revision to Diff 106650. thakis marked an inline comment as done. thakis added a comment. arphaman comments https://reviews.llvm.org/D35379 Files: docs/LanguageExtensions.rst include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

[PATCH] D35379: Add documentation for @available

thakis updated this revision to Diff 106652. thakis marked 3 inline comments as done. thakis added a comment. sdy comments https://reviews.llvm.org/D35379 Files: docs/LanguageExtensions.rst include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td =

[PATCH] D35379: Add documentation for @available

thakis added a comment. Mostly done, thanks! Comment at: docs/LanguageExtensions.rst:1274 +Objective-C @available +-- sdy wrote: > sdy wrote: > > I think "Objective-C" is redundant, this is already in the ObjC section and > > most of the

[PATCH] D35379: Add documentation for @available

thakis added a comment. I went ahead and landed this in r308044, given that I addressed the nits and removed the possibly contentious bits. Happy to address remaining nits in a follow-up. https://reviews.llvm.org/D35379 ___ cfe-commits mailing lis

[PATCH] D35379: Add documentation for @available

thakis marked an inline comment as done. thakis added inline comments. Comment at: docs/LanguageExtensions.rst:1278 +It is possible use the newest SDK but still build a program that can run on +older macOS and iOS versions, by passing ``-mmacosx-version-info=`` / +``--miphoneos-v

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

thakis created this revision. MSVC2017 update 3 produces a clang that crashes when compiling clang. Disabling optimizations for StmtProfiler::VisitCXXOperatorCallExpr() makes the crash go away. Patch from Bruce Dawson ! https://reviews.llvm.org/D35757 Files: lib/AST/StmtProfile.cpp Index

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

thakis added a comment. From what I understand, _MSC_VER changes with each 2017 update. https://reviews.llvm.org/D35757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

thakis created this revision. Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff, jfb, emaste. Projects that want to statically link their own C++ standard library currently need to pass -nostdlib or -nodefaultlibs, which also disables linking of the builtins library, -lm, and

[PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

thakis added a comment. Most of the patch is unifying all the toolchains to call the newly-introduced ToolChain::ShouldLinkCXXStdlib() instead of all manually checking for `D.CCIsCXX() && !getFlag(nostdlib, nodefaultlibs)`. The actual behavior change is to make that function check the new nostd

[PATCH] D33900: Print registered targets in clang's version information

thakis added a comment. Sorry, I just noticed this weeks later. Why are we adding this to `--version` instead of adding some new flag for printing this? When I pass `--version`, I'm usually interested in clang's version and don't need a screenful of other information below it (which makes the o

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

thakis closed this revision. thakis added a comment. r308897. https://reviews.llvm.org/D35757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33900: Print registered targets in clang's version information

thakis added a comment. In https://reviews.llvm.org/D33900#819234, @dim wrote: > In https://reviews.llvm.org/D33900#818957, @thakis wrote: > > > Sorry, I just noticed this weeks later. Why are we adding this to > > `--version` instead of adding some new flag for printing this? When I pass > > `

[PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

thakis closed this revision. thakis added a comment. r308997, thanks! https://reviews.llvm.org/D35780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    12   13   14   15   16   17   18   19   20   >