Author: comex
Date: Mon Sep 16 18:43:33 2019
New Revision: 372058
URL: http://llvm.org/viewvc/llvm-project?rev=372058&view=rev
Log:
Push lambda scope earlier when transforming lambda expression
Differential Revision: https://reviews.llvm.org/D66067
Modified:
cfe/trunk/lib/Sema/TreeTransform
Author: comex
Date: Thu Sep 19 16:00:31 2019
New Revision: 372361
URL: http://llvm.org/viewvc/llvm-project?rev=372361&view=rev
Log:
[Consumed] Treat by-value class arguments as consuming by default, like rvalue
refs.
Differential Revision: https://reviews.llvm.org/D67743
Modified:
cfe/trunk
Author: comex
Date: Thu Sep 26 16:47:18 2019
New Revision: 373034
URL: http://llvm.org/viewvc/llvm-project?rev=373034&view=rev
Log:
[Consumed][NFC] Refactor handleCall to take function argument list.
Differential Revision: https://reviews.llvm.org/D67569
Modified:
cfe/trunk/include/clang/AS
Author: comex
Date: Thu Sep 26 18:58:31 2019
New Revision: 373039
URL: http://llvm.org/viewvc/llvm-project?rev=373039&view=rev
Log:
Revert r373034
It breaks the build on MSVC.
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/trunk/lib/Analysis/Consumed.cpp
Modified: cfe/trunk/include/c
comex updated the summary for this revision.
comex updated this revision to Diff 34787.
comex added a comment.
Per vsk:
- Changed to an explicit switch, and changed ContainsPlaceholderType logic.
Note: Currently, GetDeclSpecTypeForDeclarator determines
ContainsPlaceholderType at two different l
comex added a comment.
Ping?
http://reviews.llvm.org/D12686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
comex created this revision.
comex added a subscriber: cfe-commits.
Herald added subscribers: aemerson, klimek.
Add support for GCC's '__auto_type' extension.
As per the GCC manual: https://gcc.gnu.org/onlinedocs/gcc/Typeof.html
Implemented in GCC 4.9, __auto_type is similar to C++11 auto but wo
comex added a comment.
Ping again.
http://reviews.llvm.org/D12686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
comex marked 5 inline comments as done.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1726
@@ -1720,1 +1725,3 @@
+def err_auto_bitfield : Error<
+ "cannot pass bit-field as __auto_type initializer in C">;
rsmith wrote:
> pass -> use
>
> Also, why not?
comex updated the summary for this revision.
comex updated this revision to Diff 37202.
comex marked 3 inline comments as done.
comex added a comment.
Fixed raised issues.
(I don't have commit rights.)
http://reviews.llvm.org/D12686
Files:
include/clang/AST/ASTContext.h
include/clang/AST/T
comex updated this revision to Diff 37215.
comex added a comment.
Okay.
http://reviews.llvm.org/D12686
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/DiagnosticSemaK
comex added inline comments.
Comment at: lib/Sema/SemaType.cpp:2654-2655
@@ -2648,4 +2653,4 @@
case Declarator::ConversionIdContext:
if (!SemaRef.getLangOpts().CPlusPlus14)
-Error = 12; // conversion-type-id
+Error = 14; // conversion-type-id
bre
comex added inline comments.
Comment at: lib/Sema/SemaType.cpp:2675-2678
@@ -2671,5 +2674,6 @@
break;
case Declarator::ConversionIdContext:
- if (!SemaRef.getLangOpts().CPlusPlus14)
-Error = 12; // conversion-type-id
+ if (!SemaRef.getLangOpts().CPlus
comex added inline comments.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
thakis wro
comex added a comment.
One more ping. As far as I know, everything has been addressed.
http://reviews.llvm.org/D12686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
comex added a comment.
(Ping? I verified yesterday that the patch still applies and passes regression
tests.)
http://reviews.llvm.org/D12686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
comex updated this revision to Diff 39838.
comex marked 16 inline comments as done.
http://reviews.llvm.org/D12686
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/Diagn
comex added a comment.
Addressed comments. Thanks, rsmith!
Comment at: lib/Sema/SemaType.cpp:3756-3760
@@ -3743,2 +3755,7 @@
}
+} else if (D.getDeclSpec().getTypeSpecType() ==
DeclSpec::TST_auto_type) {
+ S.Diag(D.getDeclSpec().getTypeSpecTypeLoc(),
comex added a comment.
I don't have SVN access. If you want to commit it, feel free to remove that
comment, or else I'll update the diff tomorrow.
I just tried the test case in 25449 and it now gives a proper error rather than
crashing. (Though when trying to reduce a test failure I was encou
comex created this revision.
comex added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This mostly "just works" by adding Block to the subject list, but there is an
issue with warnings in attribute handlers tied to the return type, which for
blocks can be inferred. My solution t
comex added reviewers: aaron.ballman, rsmith.
comex added a comment.
Ping, and adding potential reviewers like I was supposed to do in the first
place.
http://reviews.llvm.org/D15907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
comex created this revision.
comex added a subscriber: cfe-commits.
When a function parameter is declared `__attribute__((cleanup))`, neither Clang
nor GCC actually executes the cleanup function, but Clang didn't warn about it.
For the sake of compatibility, add a warning rather than making the
22 matches
Mail list logo
