Author: Nemanja Ivanovic
Date: 2021-07-12T04:59:00-05:00
New Revision: 41ce5ec5f6f3a03d70e0010e3a140fe129800637
URL:
https://github.com/llvm/llvm-project/commit/41ce5ec5f6f3a03d70e0010e3a140fe129800637
DIFF:
https://github.com/llvm/llvm-project/commit/41ce5ec5f6f3a03d70e0010e3a140fe129800637.di
Author: Nemanja Ivanovic
Date: 2021-07-12T06:11:27-05:00
New Revision: 84e429693fe5f225fe68b9dd54043cddb9c4cd4c
URL:
https://github.com/llvm/llvm-project/commit/84e429693fe5f225fe68b9dd54043cddb9c4cd4c
DIFF:
https://github.com/llvm/llvm-project/commit/84e429693fe5f225fe68b9dd54043cddb9c4cd4c.di
Author: Nemanja Ivanovic
Date: 2021-03-01T19:49:26-06:00
New Revision: 38a34e207f30747a4b0288d97ce67e422bf5f363
URL:
https://github.com/llvm/llvm-project/commit/38a34e207f30747a4b0288d97ce67e422bf5f363
DIFF:
https://github.com/llvm/llvm-project/commit/38a34e207f30747a4b0288d97ce67e422bf5f363.di
Author: Nemanja Ivanovic
Date: 2021-03-01T21:40:30-06:00
New Revision: 1ff93618e58df210def48d26878c20a1b414d900
URL:
https://github.com/llvm/llvm-project/commit/1ff93618e58df210def48d26878c20a1b414d900
DIFF:
https://github.com/llvm/llvm-project/commit/1ff93618e58df210def48d26878c20a1b414d900.di
Author: Nemanja Ivanovic
Date: 2021-03-05T18:42:12-06:00
New Revision: f4ad7a1a15b7378522a17df7278856449005b8e1
URL:
https://github.com/llvm/llvm-project/commit/f4ad7a1a15b7378522a17df7278856449005b8e1
DIFF:
https://github.com/llvm/llvm-project/commit/f4ad7a1a15b7378522a17df7278856449005b8e1.di
Author: Nemanja Ivanovic
Date: 2021-03-12T10:51:57-06:00
New Revision: b5fae4b9b2fd0ac8f0ad99178f876dc78ba5613f
URL:
https://github.com/llvm/llvm-project/commit/b5fae4b9b2fd0ac8f0ad99178f876dc78ba5613f
DIFF:
https://github.com/llvm/llvm-project/commit/b5fae4b9b2fd0ac8f0ad99178f876dc78ba5613f.di
Author: Nemanja Ivanovic
Date: 2021-11-24T06:43:56-06:00
New Revision: b7bf937bbee38c2db0c0640176ef618d9c746538
URL:
https://github.com/llvm/llvm-project/commit/b7bf937bbee38c2db0c0640176ef618d9c746538
DIFF:
https://github.com/llvm/llvm-project/commit/b7bf937bbee38c2db0c0640176ef618d9c746538.di
Author: Nemanja Ivanovic
Date: 2021-11-24T12:42:58-06:00
New Revision: dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea
URL:
https://github.com/llvm/llvm-project/commit/dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea
DIFF:
https://github.com/llvm/llvm-project/commit/dc1aa8eacd1e0e554f206cc15d730f37ea90c4ea.di
Author: Nemanja Ivanovic
Date: 2022-05-31T21:51:15-05:00
New Revision: 1013967436694f362097a7c12f675c0ad7de90b7
URL:
https://github.com/llvm/llvm-project/commit/1013967436694f362097a7c12f675c0ad7de90b7
DIFF:
https://github.com/llvm/llvm-project/commit/1013967436694f362097a7c12f675c0ad7de90b7.di
https://github.com/nemanjai created
https://github.com/llvm/llvm-project/pull/68919
Make __builtin_cpu_{init|supports|is} target independent and provide an opt-in
query for targets that want to support it. Each target is still responsible for
their specific lowering/code-gen. Also provide code
https://github.com/nemanjai updated
https://github.com/llvm/llvm-project/pull/68919
>From 71f1352bf00d6a9eefa3f199859d47d093f272f8 Mon Sep 17 00:00:00 2001
From: Nemanja Ivanovic
Date: Thu, 12 Oct 2023 14:08:42 -0400
Subject: [PATCH 1/2] [PowerPC][X86] Make cpu id builtins target independent
a
@@ -11595,6 +11595,50 @@ SDValue PPCTargetLowering::LowerFP_EXTEND(SDValue Op,
SelectionDAG &DAG) const {
llvm_unreachable("ERROR:Should return for all cases within swtich.");
}
+// Lower mffsl intrinsic with mffs in targets without ISA 3.0
+static SDValue lowerMFFSL(SDValu
Author: Nemanja Ivanovic
Date: 2019-11-07T20:40:32-06:00
New Revision: 070e4027b02453f0962e5b61335a517581c5528f
URL:
https://github.com/llvm/llvm-project/commit/070e4027b02453f0962e5b61335a517581c5528f
DIFF:
https://github.com/llvm/llvm-project/commit/070e4027b02453f0962e5b61335a517581c5528f.di
Author: Nemanja Ivanovic
Date: 2019-11-07T20:58:11-06:00
New Revision: e0407f54965318247c8fece2dfa5c9023acf0973
URL:
https://github.com/llvm/llvm-project/commit/e0407f54965318247c8fece2dfa5c9023acf0973
DIFF:
https://github.com/llvm/llvm-project/commit/e0407f54965318247c8fece2dfa5c9023acf0973.di
Hi Michael,
We are happy to help troubleshoot the issue this caused on our bot. Unfortunately, this bot is not one where we can give you access so we'll have to try and work together to debug this.
Can you provide the link to the failing build so we can see which test case it was that caused the pr
Hi Michael,
this turns out to be an assert failure:
clang/tools/clang-scan-deps/ClangScanDeps.cpp:340: const clang::tooling::dependencies::ModuleDeps& FullDeps::lookupModuleDeps(clang::tooling::dependencies::ClangModuleDep): Assertion `I != Modules.end()' failed.
Does this help with debugging a
Author: Nemanja Ivanovic
Date: 2023-03-02T14:29:40-05:00
New Revision: 59cd692454c9430f0fb77ca14b65cb9afcfe2776
URL:
https://github.com/llvm/llvm-project/commit/59cd692454c9430f0fb77ca14b65cb9afcfe2776
DIFF:
https://github.com/llvm/llvm-project/commit/59cd692454c9430f0fb77ca14b65cb9afcfe2776.di
Author: Nemanja Ivanovic
Date: 2023-02-16T13:37:58-05:00
New Revision: 372820bf571c8d32c8165cfc74b0439c7bb397f9
URL:
https://github.com/llvm/llvm-project/commit/372820bf571c8d32c8165cfc74b0439c7bb397f9
DIFF:
https://github.com/llvm/llvm-project/commit/372820bf571c8d32c8165cfc74b0439c7bb397f9.di
Author: Nemanja Ivanovic
Date: 2023-06-14T06:47:34-05:00
New Revision: ffd7a200fdfbd01ef296101647d2f2da91ddfd41
URL:
https://github.com/llvm/llvm-project/commit/ffd7a200fdfbd01ef296101647d2f2da91ddfd41
DIFF:
https://github.com/llvm/llvm-project/commit/ffd7a200fdfbd01ef296101647d2f2da91ddfd41.di
nemanjai created this revision.
nemanjai added reviewers: hfinkel, kbarton, wschmidt, amehsan, seurer.
nemanjai added subscribers: cfe-commits, echristo.
nemanjai set the repository for this revision to rL LLVM.
Herald added a subscriber: nemanjai.
This patch introduces the following builtins:
uns
nemanjai added a comment.
Looking over the patch, I realized that I forgot to add a test case for the
__POWER9_VECTOR__ macro and the builtins that target the record forms of the
instructions. I'll add those on the next revision along with addressing any
review comments.
Repository:
rL LLVM
Author: nemanjai
Date: Tue Jul 25 10:04:12 2017
New Revision: 308985
URL: http://llvm.org/viewvc/llvm-project?rev=308985&view=rev
Log:
This test case is causing all PPC and SystemZ bots to remain red.
Notifying the author via Diffusion did not yield any answer. Therefore, I'm
adding the missing t
Author: nemanjai
Date: Thu Jul 27 01:58:28 2017
New Revision: 309256
URL: http://llvm.org/viewvc/llvm-project?rev=309256&view=rev
Log:
[PowerPC] Pass CPU to assembler with -no-integrated-as
This just adds the CPU to a list of commands passed to GAS when not using the
integrated assembler.
Differ
Author: nemanjai
Date: Fri Mar 3 03:49:17 2017
New Revision: 296861
URL: http://llvm.org/viewvc/llvm-project?rev=296861&view=rev
Log:
[PowerPC] Enable -fomit-frame-pointer by default for PPC
As is the case on platforms like Mips, X86 and SystemZ, the -fomit-frame-pointer
should be enabled by def
nemanjai added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8182
+ConstantInt *ArgCI = dyn_cast(Ops[2]);
+assert(ArgCI);
+int64_t index = clamp(ArgCI->getSExtValue(), 0, 12);
```assert(ArgCI && "The third operand of this intrinsic must be a
nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.
Overall, I'd like to see another revision of this. This is not because I feel
the patch requires major rework, but because there is a number of minor
comments that I'd like to ma
Author: nemanjai
Date: Wed Oct 26 13:25:45 2016
New Revision: 285218
URL: http://llvm.org/viewvc/llvm-project?rev=285218&view=rev
Log:
[PPC] Implement vector reverse elements builtins (vec_reve)
This patch corresponds to review https://reviews.llvm.org/D25906.
Committing on behalf of Tony Jiang.
Author: nemanjai
Date: Wed Oct 26 14:27:11 2016
New Revision: 285229
URL: http://llvm.org/viewvc/llvm-project?rev=285229&view=rev
Log:
[PowerPC] Implement vector_insert_exp builtins - clang portion
This patch corresponds to review https://reviews.llvm.org/D25956.
Committing on behalf of Zaara Sye
Author: nemanjai
Date: Thu Oct 27 01:23:57 2016
New Revision: 285268
URL: http://llvm.org/viewvc/llvm-project?rev=285268&view=rev
Log:
[PPC] add vector byte reverse functions to altivec.h
This patch corresponds to review https://reviews.llvm.org/D25915.
Committing on behalf of Sean Fertile.
Modi
nemanjai added a comment.
Other than the minor nit, this LGTM.
Comment at: include/clang/Basic/BuiltinsPPC.def:275
+
+BUILTIN(__builtin_altivec_vclzlsbb, "SiV16Uc", "")
No need for this extra blank line.
https://reviews.llvm.org/D26002
__
nemanjai added a comment.
This patch LGTM. I'll let @kbarton/@echristo have a look as well and have the
final say.
https://reviews.llvm.org/D26073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: nemanjai
Date: Fri Oct 28 14:49:03 2016
New Revision: 285436
URL: http://llvm.org/viewvc/llvm-project?rev=285436&view=rev
Log:
Implement vector count leading/trailing bytes with zero lsb and vector parity
builtins - clang portion
This patch corresponds to review: https://reviews.llvm.org/
nemanjai added a comment.
Committed revision 285436.
Zaara, please close this review if there are no buildbot failures.
https://reviews.llvm.org/D26002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: nemanjai
Date: Fri Oct 28 15:04:53 2016
New Revision: 285439
URL: http://llvm.org/viewvc/llvm-project?rev=285439&view=rev
Log:
[PPC] add float and double overloads for vec_orc and vec_nand in altivec.h
This patch corresponds to review https://reviews.llvm.org/D25950.
Committing on behalf
Author: nemanjai
Date: Mon Oct 31 14:02:54 2016
New Revision: 285623
URL: http://llvm.org/viewvc/llvm-project?rev=285623&view=rev
Log:
NFC - Reorder test case names in a PPC test case
A few recent commits have messed up the order of some tests
in a PPC test case. This just reorders them in a sens
Author: nemanjai
Date: Tue Nov 1 03:39:56 2016
New Revision: 285679
URL: http://llvm.org/viewvc/llvm-project?rev=285679&view=rev
Log:
[PPC] Add vec_absd functions to altivec.h
This patch corresponds to review https://reviews.llvm.org/D26073.
Committing on behalf of Sean Fertile.
Modified:
c
nemanjai added a comment.
Committed revision 285679.
Sean, please close this review pending no buildbot failures.
https://reviews.llvm.org/D26073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: nemanjai
Date: Tue Nov 1 09:46:20 2016
New Revision: 285694
URL: http://llvm.org/viewvc/llvm-project?rev=285694&view=rev
Log:
[PowerPC] Implement vector shift builtins - clang portion
This patch corresponds to review https://reviews.llvm.org/D26092.
Committing on behalf of Tony Jiang.
M
nemanjai added a comment.
LGTM but I'll let @kbarton have a look and provide the final approval.
Comment at: lib/Headers/altivec.h:15629
+#define vec_test_data_class(__a, __b) \
+_Generic((__a),
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:15618
+
+#if defined(__POWER8_VECTOR__) && defined(__powerpc64__)
+static inline __ATTRS_o_ai vector signed __int128
Please move the __int128 overloads below the 64-bit ones to keep the overloads
nemanjai created this revision.
nemanjai added reviewers: hfinkel, echristo, kbarton, amehsan, syzaara,
sfertile, jtony, lei.
nemanjai added a subscriber: cfe-commits.
nemanjai set the repository for this revision to rL LLVM.
Herald added a subscriber: mehdi_amini.
This patch adds the following i
nemanjai added a comment.
Zaara, prior to committing this patch, can you write a test case that will
actually use these builtins in an executable test case and confirm the results.
We'll then run it on the simulator to ensure functional correctness.
Comment at: lib/Headers/al
nemanjai added inline comments.
Comment at: include/clang/Basic/BuiltinsPPC.def:304
+BUILTIN(__builtin_vsx_lxvl, "V4ivC*Ui", "")
+BUILTIN(__builtin_vsx_lxvll, "V4ivC*Ui", "")
Also, in addition to guarding for 64-bit, these should be defined to take the
length
nemanjai created this revision.
nemanjai added reviewers: hfinkel, kbarton, syzaara, lei, jtony, sfertile,
amehsan.
nemanjai added subscribers: cfe-commits, echristo.
nemanjai set the repository for this revision to rL LLVM.
This adds the following signatures into altivec.h:
vector bool long lon
nemanjai added a comment.
In https://reviews.llvm.org/D26479#591723, @amehsan wrote:
> more context?
Really sorry. It appears that I uploaded the wrong patch file. Updating now.
Repository:
rL LLVM
https://reviews.llvm.org/D26479
___
cfe-commi
nemanjai updated this revision to Diff 77494.
nemanjai added a comment.
Accidentally uploaded the wrong patch so it was missing full context.
Repository:
rL LLVM
https://reviews.llvm.org/D26479
Files:
include/clang/Basic/BuiltinsPPC.def
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-c
Author: nemanjai
Date: Fri Nov 11 13:56:17 2016
New Revision: 286627
URL: http://llvm.org/viewvc/llvm-project?rev=286627&view=rev
Log:
[PowerPC] Add vector conversion builtins to altivec.h - clang portion
This patch corresponds to review:
https://reviews.llvm.org/D26308
It adds a number of vecto
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 286627.
Repository:
rL LLVM
https://reviews.llvm.org/D26308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
nemanjai added inline comments.
Comment at: include/clang/Basic/BuiltinsPPC.def:385-388
+BUILTIN(__builtin_altivec_vrlwmi, "V4UiV4UiV4UiV4Ui", "")
+BUILTIN(__builtin_altivec_vrldmi, "V2ULLiV2ULLiV2ULLiV2ULLi", "")
+BUILTIN(__builtin_altivec_vrlwnm, "V4UiV4UiV4Ui", "")
+BUILTIN(__
Author: nemanjai
Date: Fri Nov 11 16:34:44 2016
New Revision: 286650
URL: http://llvm.org/viewvc/llvm-project?rev=286650&view=rev
Log:
[PowerPC] Implement remaining permute builtins in altivec.h - Clang portion
This patch corresponds to review:
https://reviews.llvm.org/D26479
It adds the remaini
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 286650.
Repository:
rL LLVM
https://reviews.llvm.org/D26479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:12014
+#define vec_insert4b(__a, __b, __c) \
+ ((vector unsigned char)__builtin_vsx_xxinsertw((__a), (__b), (__c) & 0xF))
+#endif
As far as I can tell by looking at this patch and the correspondin
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:11908
+#define vec_extract4b(__a, __b)
\
+ vec_reve((vector unsigned long long)
\
+__builtin_vsx_xxextractuw
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:314
+ vector signed int __carry = __c & __mask;
+ return vec_add(vec_add(__a, __b), __mask);
+}
I don't understand why we're adding `__mask` to the sum of `__a` and `__b`.
Shouldn't that be `__c
nemanjai created this revision.
nemanjai added reviewers: wschmidt, seurer, kbarton, hfinkel.
nemanjai added a subscriber: cfe-commits.
nemanjai set the repository for this revision to rL LLVM.
Implemented the following interfaces to conform to ELF V2 ABI version 1.1.
vector signed __int128 vec_
nemanjai updated this revision to Diff 35838.
nemanjai added a comment.
I forgot the test cases in the original upload. This patch contains the test
cases and is ready for review.
Repository:
rL LLVM
http://reviews.llvm.org/D13190
Files:
include/clang/Basic/BuiltinsPPC.def
lib/Headers/a
Author: nemanjai
Date: Tue Sep 29 13:13:34 2015
New Revision: 248813
URL: http://llvm.org/viewvc/llvm-project?rev=248813&view=rev
Log:
Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1
This patch corresponds to review:
http://reviews.llvm.org/D13190
Implemented the followi
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 248813.
Repository:
rL LLVM
http://reviews.llvm.org/D13190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: nemanjai
Date: Tue Sep 29 13:20:59 2015
New Revision: 248815
URL: http://llvm.org/viewvc/llvm-project?rev=248815&view=rev
Log:
Forgot to remove a FIXME that has been fixed. NFC.
Modified:
cfe/trunk/lib/Headers/altivec.h
Modified: cfe/trunk/lib/Headers/altivec.h
URL:
http://llvm.org/
nemanjai added a comment.
If the reviewers don't mind, I would like to keep this patch with diagnostics
for interoperability between the two types for now. This is simply because
enabling such interoperability requires changes to some of the conversion
infrastructure (i.e. allowing FPTrunc/FPEx
nemanjai updated this revision to Diff 47223.
nemanjai added a comment.
Fixed the naming, indentation and removed the use of dyn_cast for types.
Repository:
rL LLVM
http://reviews.llvm.org/D15120
Files:
bindings/python/clang/cindex.py
include/clang-c/Index.h
include/clang/AST/ASTContex
nemanjai added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:231
@@ +230,3 @@
+if (hasFloat128Type() &&
+&getFloat128Format() == &llvm::APFloat::IEEEquad)
+ return Float128;
hubert.reinterpretcast wrote:
> Is it necessary to check that `__
nemanjai created this revision.
nemanjai added reviewers: hfinkel, wschmidt, kbarton, amehsan, seurer, cycheng.
nemanjai added a subscriber: cfe-commits.
nemanjai set the repository for this revision to rL LLVM.
This patch simply adds support for the new CPU in anticipation of Power9. There
isn't
nemanjai added inline comments.
Comment at: lib/Basic/Targets.cpp:1239
@@ -1227,1 +1238,3 @@
+ if (defs & ArchDefinePwr9)
+Builder.defineMacro("_ARCH_PWR9");
if (defs & ArchDefineA2)
Come to think of it - I should add a test case for this macro. It will be
Author: nemanjai
Date: Mon May 9 03:52:33 2016
New Revision: 268898
URL: http://llvm.org/viewvc/llvm-project?rev=268898&view=rev
Log:
Enable support for __float128 in Clang and enable it on pertinent platforms
This patch corresponds to reviews:
http://reviews.llvm.org/D15120
http://reviews.llvm.
Author: nemanjai
Date: Mon May 9 13:58:02 2016
New Revision: 268951
URL: http://llvm.org/viewvc/llvm-project?rev=268951&view=rev
Log:
[Power9] Enable -mcpu=pwr9 (-mcpu=power9) in the front end
This patch corresponds to review:
http://reviews.llvm.org/D19684
It simply adds the handling for the o
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 268951.
Repository:
rL LLVM
http://reviews.llvm.org/D19684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: nemanjai
Date: Wed Apr 13 04:49:45 2016
New Revision: 266186
URL: http://llvm.org/viewvc/llvm-project?rev=266186&view=rev
Log:
Enable support for __float128 in Clang
This patch corresponds to review:
http://reviews.llvm.org/D15120
It adds support for the __float128 keyword, literals and
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 266186.
Repository:
rL LLVM
http://reviews.llvm.org/D15120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
via cfe-commits"
>> > To: "Nemanja Ivanovic" , "Nico Weber" <
>> tha...@chromium.org>
>> > Cc: "cfe-commits"
>> > Sent: Thursday, April 14, 2016 8:07:58 PM
>> > Subject: Re: r266186 - Enable support for __f
ri, Apr 15, 2016 at 12:27 AM, Hal Finkel wrote:
>>>
>>>> - Original Message -
>>>> > From: "Hans Wennborg via cfe-commits"
>>>> > To: "Nemanja Ivanovic" , "Nico Weber" <
>>>> tha...@chromium.org>
>&g
nux/x86?
>
> On Fri, Apr 15, 2016 at 11:53 AM, Nemanja Ivanovic via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> I have just pinged the patch to see if I can get it approved today. Can I
>> give it a few hours and if it isn't approved by tonight, I&#
Author: nemanjai
Date: Fri Apr 15 13:04:13 2016
New Revision: 266460
URL: http://llvm.org/viewvc/llvm-project?rev=266460&view=rev
Log:
Revert 266186 as it breaks anything that includes type_traits on some platforms
Since this patch provided support for the __float128 type but disabled it
on all p
nemanjai updated this revision to Diff 49508.
nemanjai added a comment.
Removed questionable macro definitions.
Renamed the test function for invalid conversions and changed the semantics so
that it allows __float128 <-> long double conversions only if the two types
have the same representation
nemanjai added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:1658
@@ -1657,1 +1657,3 @@
} else if (FromType->isRealFloatingType() && ToType->isRealFloatingType()) {
+// FIXME: disable conversions between long double and __float128 if
+// their representation is
nemanjai added inline comments.
Comment at: lib/Headers/altivec.h:136
@@ -131,3 +135,3 @@
#if defined(__POWER8_VECTOR__) && defined(__powerpc64__)
static vector double __ATTRS_o_ai vec_abs(vector double __a) {
I thought we were going to change the guard here t
nemanjai added a comment.
All of my comments are just nits and shouldn't hold up approval. As far as I
can tell this looks fine, but I'll let the LGTM come from Kit or Hal.
Comment at: lib/Headers/altivec.h:136
@@ -131,3 +135,3 @@
#if defined(__POWER8_VECTOR__) && defined(__
nemanjai updated the summary for this revision.
nemanjai updated this revision to Diff 44459.
nemanjai added a comment.
Addressed the review comments:
- Added the requested test cases
- Disabled promotion of long double to __float128
- Disabled operations between long double and __float128 if the
nemanjai updated this revision to Diff 45998.
nemanjai added a comment.
Addressed review comments.
The key differences are:
- No assignments or operations between entities of long double and __float128
allowed if the two types have a different representation
- Each type has a distinct rank
This
nemanjai added a comment.
Thank you for the discussion on rank. I'm glad we have an agreement on the rank
of the two types.
However, considering __float128 already has a higher rank in this patch, is
there anything else that you would like me to change here before the patch is
approved?
Do you
nemanjai created this revision.
nemanjai added reviewers: hfinkel, wschmidt, kbarton, rsmith.
nemanjai added a subscriber: cfe-commits.
nemanjai set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
This patch adds support for the __float128 keyword and literals for I
nemanjai added a comment.
Just a friendly reminder to the reviewers that this patch has been up for
almost a week with no review comments. Please take some time to review.
Repository:
rL LLVM
http://reviews.llvm.org/D15120
___
cfe-commits mailin
nemanjai updated this revision to Diff 42414.
nemanjai added a comment.
Updated to address review comments. Rather than listing responses and
justification for some of the changes, I'll provide comments inline for better
readability.
Repository:
rL LLVM
http://reviews.llvm.org/D15120
Files
nemanjai added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:2064
@@ +2063,3 @@
+if (getASTContext().getTargetInfo().useFloat128ManglingForLongDouble())
+ Out << "U10__float128"; // Match the GCC mangling
+else
Please refer to https://gcc.gnu
nemanjai added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:384
@@ +383,3 @@
+ unsigned getFloat128Width() const { return 128; }
+ unsigned getFloat128Align() const { return 128; }
+ const llvm::fltSemantics &getFloat128Format() const {
hubert.
nemanjai added a comment.
I think the correct course of action would be to allow/disallow promotion based
on a condition that the two types are the same/different (respectively). I
think a comparison of the float semantics is a valid way to check this. Also,
should operations between long doubl
Author: Nemanja Ivanovic
Date: 2021-04-22T10:30:59-05:00
New Revision: 3a466670595a9d4d41b1e221ac0f76183c5d096b
URL:
https://github.com/llvm/llvm-project/commit/3a466670595a9d4d41b1e221ac0f76183c5d096b
DIFF:
https://github.com/llvm/llvm-project/commit/3a466670595a9d4d41b1e221ac0f76183c5d096b.di
Author: Nemanja Ivanovic
Date: 2021-04-22T10:30:59-05:00
New Revision: 51692c6c630dfa9521af47b3c0c14d9f05f25375
URL:
https://github.com/llvm/llvm-project/commit/51692c6c630dfa9521af47b3c0c14d9f05f25375
DIFF:
https://github.com/llvm/llvm-project/commit/51692c6c630dfa9521af47b3c0c14d9f05f25375.di
Author: Nemanja Ivanovic
Date: 2021-04-22T10:30:59-05:00
New Revision: 1550c47c18f05800b20af071da50881ffd996254
URL:
https://github.com/llvm/llvm-project/commit/1550c47c18f05800b20af071da50881ffd996254
DIFF:
https://github.com/llvm/llvm-project/commit/1550c47c18f05800b20af071da50881ffd996254.di
Author: Nemanja Ivanovic
Date: 2021-04-22T10:31:00-05:00
New Revision: a1d325af6708ebd8ac9efb8d2d148f16feeda3fd
URL:
https://github.com/llvm/llvm-project/commit/a1d325af6708ebd8ac9efb8d2d148f16feeda3fd
DIFF:
https://github.com/llvm/llvm-project/commit/a1d325af6708ebd8ac9efb8d2d148f16feeda3fd.di
Author: Nemanja Ivanovic
Date: 2021-04-22T10:31:00-05:00
New Revision: a0e6189712297fd9a25723384039418bc68e8e9f
URL:
https://github.com/llvm/llvm-project/commit/a0e6189712297fd9a25723384039418bc68e8e9f
DIFF:
https://github.com/llvm/llvm-project/commit/a0e6189712297fd9a25723384039418bc68e8e9f.di
Author: Nemanja Ivanovic
Date: 2021-04-22T10:31:00-05:00
New Revision: e43963db24f68582edba8b227432714c60eac0c9
URL:
https://github.com/llvm/llvm-project/commit/e43963db24f68582edba8b227432714c60eac0c9
DIFF:
https://github.com/llvm/llvm-project/commit/e43963db24f68582edba8b227432714c60eac0c9.di
Author: Nemanja Ivanovic
Date: 2021-04-22T10:31:00-05:00
New Revision: 1cc1d9db286c7fbd0ff0a0757c2da2a5a6fc54a8
URL:
https://github.com/llvm/llvm-project/commit/1cc1d9db286c7fbd0ff0a0757c2da2a5a6fc54a8
DIFF:
https://github.com/llvm/llvm-project/commit/1cc1d9db286c7fbd0ff0a0757c2da2a5a6fc54a8.di
Author: Nemanja Ivanovic
Date: 2021-04-22T10:31:00-05:00
New Revision: 7a5641d651963e91b05f25667df6cc694503248f
URL:
https://github.com/llvm/llvm-project/commit/7a5641d651963e91b05f25667df6cc694503248f
DIFF:
https://github.com/llvm/llvm-project/commit/7a5641d651963e91b05f25667df6cc694503248f.di
Author: Nemanja Ivanovic
Date: 2021-04-23T11:03:38-05:00
New Revision: 6725b90a02c6d2696385c0328bd000516913ce4b
URL:
https://github.com/llvm/llvm-project/commit/6725b90a02c6d2696385c0328bd000516913ce4b
DIFF:
https://github.com/llvm/llvm-project/commit/6725b90a02c6d2696385c0328bd000516913ce4b.di
Author: Nemanja Ivanovic
Date: 2021-04-23T15:13:46-05:00
New Revision: 19b29b1ed1baa3c91a8e48204a8fb229bf07f548
URL:
https://github.com/llvm/llvm-project/commit/19b29b1ed1baa3c91a8e48204a8fb229bf07f548
DIFF:
https://github.com/llvm/llvm-project/commit/19b29b1ed1baa3c91a8e48204a8fb229bf07f548.di
Author: Nemanja Ivanovic
Date: 2021-04-30T19:17:48-05:00
New Revision: c3da07d216dd20fbdb7302fd085c0a59e189ae3d
URL:
https://github.com/llvm/llvm-project/commit/c3da07d216dd20fbdb7302fd085c0a59e189ae3d
DIFF:
https://github.com/llvm/llvm-project/commit/c3da07d216dd20fbdb7302fd085c0a59e189ae3d.di
Author: Nemanja Ivanovic
Date: 2021-04-30T20:29:03-05:00
New Revision: bfd60b36f825c299971bb0c2bf973031e2e0fc09
URL:
https://github.com/llvm/llvm-project/commit/bfd60b36f825c299971bb0c2bf973031e2e0fc09
DIFF:
https://github.com/llvm/llvm-project/commit/bfd60b36f825c299971bb0c2bf973031e2e0fc09.di
Author: Nemanja Ivanovic
Date: 2021-05-06T08:37:36-05:00
New Revision: ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8
URL:
https://github.com/llvm/llvm-project/commit/ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8
DIFF:
https://github.com/llvm/llvm-project/commit/ed87f512bb9eb5c1d44e9a1182ffeaf23d6c5ae8.di
Author: Nemanja Ivanovic
Date: 2021-05-06T09:50:12-05:00
New Revision: 1faf3b195e71dbc469d658d450949439dbf92f9f
URL:
https://github.com/llvm/llvm-project/commit/1faf3b195e71dbc469d658d450949439dbf92f9f
DIFF:
https://github.com/llvm/llvm-project/commit/1faf3b195e71dbc469d658d450949439dbf92f9f.di
101 - 200 of 213 matches
Mail list logo
