[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

nemanjai added a comment. I assume this also fixes https://bugs.llvm.org/show_bug.cgi?id=31161? https://reviews.llvm.org/D38656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

nemanjai added a comment. In https://reviews.llvm.org/D38656#892072, @Carrot wrote: > I worked on a similar bug as 31161, and then found this one, it should be > same as in comment7. > What is the current status of the work on that bug? No one has had time to finalize a fix to it. Please go a

[PATCH] D38820: [CGExprScalar] Add missing types in function GetIntrinsic

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

nemanjai added a comment. LGTM. Repository: rC Clang https://reviews.llvm.org/D52074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49424: [PowerPC] Handle __builtin_xxpermdi the same way as GCC does

This revision was automatically updated to reflect the committed changes. Closed by commit rC337449: [PowerPC] Handle __builtin_xxpermdi the same way as GCC does (authored by nemanjai, committed by ). Changed prior to commit: https://reviews.llvm.org/D49424?vs=155869&id=156251#toc Repository:

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai created this revision. This just adds the CPU to a list of commands passed to GAS when not using the integrated assembler. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h lib/Driver/ToolChains/Gnu.

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai updated this revision to Diff 101169. nemanjai added a comment. Initially, forgot to add a test case. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h lib/Driver/ToolChains/Gnu.cpp test/Driver/linu

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai updated this revision to Diff 101508. nemanjai added a comment. Remove the temporary string variable for the CPU. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h lib/Driver/ToolChains/Gnu.cpp test

[PATCH] D33981: Only print registered targets for `--version`

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. This cleans up the failures on PPC (and probably SystemZ) so the bots should go back to green. https://reviews.llvm.org/D33981 ___ cfe

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

nemanjai added subscribers: iains, echristo. nemanjai added a comment. I'm not sure how much expertise there is for PPC32-Darwin. Perhaps @iains might be able to offer some insight here. Also, @echristo might have a thing or two to say in this regard. Repository: rL LLVM https://reviews.llv

[PATCH] D54087: [PowerPC] [Clang] [AltiVec] The second parameter of vec_sr function should be modulo the number of bits in the element

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Just for clarification (and please add the text to the commit message), this is actually required by the ABI: Each element of the result vector is the result of logically right shifting

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

nemanjai added a comment. @hubert.reinterpretcast Have your comments been addressed adequately in the latest version of the patch? Do you have an opinion on adding the test case I proposed? Comment at: clang/test/Sema/altivec-generic-overload.c:1 +// RUN: %clang_cc1 %s -tripl

[PATCH] D54787: [PowerPC] Vector load/store builtins overstate alignment of pointers

nemanjai created this revision. nemanjai added reviewers: hfinkel, jsji, wuzish. Herald added subscribers: kristina, kbarton. A number of builtins in altivec.h load/store vectors from pointers to scalar types. Currently they just cast the pointer to a vector pointer, but expressions like that ha

[PATCH] D54787: [PowerPC] Vector load/store builtins overstate alignment of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rL347556: [PowerPC] Vector load/store builtins overstate alignment of pointers (authored by nemanjai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D59304: Fix invocation of Gold plugin with LTO after r355331

nemanjai created this revision. nemanjai added reviewers: xur, tejohnson, davidxl. Herald added subscribers: dexonsmith, steven_wu, inglorion, mehdi_amini. Herald added a project: clang. The above commit tries to access the parameter to the `-fprofile-use` option without checking whether the opti

[PATCH] D59304: Fix invocation of Gold plugin with LTO after r355331

nemanjai added a comment. Thanks Teresa, I'll commit this soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59304/new/ https://reviews.llvm.org/D59304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D59304: Fix invocation of Gold plugin with LTO after r355331

This revision was automatically updated to reflect the committed changes. Closed by commit rL356111: Fix invocation of Gold plugin with LTO after r355331 (authored by nemanjai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. Ping. If there are no objections in the next week or so, I'll commit this and it can be reviewed post-commit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497 _

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Do you plan to follow-up on these questions and comments? At least the full context is needed and for the test case, I imagine it can be similar to other driver test cases. I imagine `tools/clang/test/

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. In D58497#1449306 , @dblaikie wrote: > In D58497#1449243 , @nemanjai wrote: > > > Ping. > > > Unfortunately Richard Smith is out for a few weeks at the moment, so might > take a little bit

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

nemanjai added a comment. > Do you need to build clangd? We explicitly don't aim to support building > everywhere clang can be built, maybe we should just disable in this case? Our environment includes various OS levels running on PowerPC. We certainly wouldn't want to disable building/testing

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. Herald added a subscriber: jsji. Ping. Does anyone think this is a good idea? Bad idea? Have any further comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497 _

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai created this revision. nemanjai added reviewers: rogfer01, bruno, ahatanak, scanon. Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff. Herald added a project: clang. We unconditionally predefine these macros. However, they may be used to determine if the type is suppor

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: lib/Basic/Targets/WebAssembly.h:55 IntPtrType = SignedLong; +HasFloat16 = true; } There are test cases that check for the macros for WebAssembly so I assumed they

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

nemanjai created this revision. nemanjai added reviewers: ilya-biryukov, jfb, takuto.ikuta, rjmccall, rsmith, SjoerdMeijer, t.p.northover, erichkeane. Herald added a subscriber: eraman. Herald added a project: clang. One of the platforms on which we do regular builds has some system headers that

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

nemanjai added a comment. In D57581#1380609 , @ilya-biryukov wrote: > ... > Do have a comment, though. Any, reason to use `-std=gnu++14` and not > `-std=c++14`? > Most (all?) of the tests do not seem to have anything to do with the gnu > extensions, s

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai updated this revision to Diff 185088. nemanjai added a comment. As mentioned in a comment, the WASM tests weren't really meant to indicate that WASM supports the type. Removed the changes to the WASM target. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

nemanjai updated this revision to Diff 185093. nemanjai added a comment. Changed the option to standard C++ rather than GNU extensions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57581/new/ https://reviews.llvm.org/D57581 Files: test/CodeCompletion/crash-sk

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

This revision was automatically updated to reflect the committed changes. Closed by commit rL353163: [NFC] Explicitly add -std=c++14 option to tests that rely on the C++14 default (authored by nemanjai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai added a comment. Does anyone have any further comments or objections to this patch? I would like to commit this and close the PR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57577/new/ https://reviews.llvm.org/D57577 ___

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

nemanjai added a comment. There is a long series of comments in this patch and I am not clear at this point on whether this patch breaks anything or it is fine. Could you please `Request Changes` if this patch is broken or approve if it is fine? Repository: rC Clang CHANGES SINCE LAST ACTIO

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Please, no more patches without context. This one was actually easy to review without context and the comments are minor, so I'm fine with these being addressed on the commit. =

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

nemanjai added a comment. In D49754#1402790 , @vit9696 wrote: > This is a series of patches, which I believe should merged altogether. > Currently the following patches are relevant: No, please don't merge them together. It is much more manageable for r

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

nemanjai marked an inline comment as done. nemanjai added a comment. Herald added a subscriber: jdoerfert. Since I haven't seen any further objections to this, I'll commit this later today. Comment at: test/Preprocessor/init.c:9169 // WEBASSEMBLY-NEXT:#define __FLOAT128__ 1 -

[PATCH] D57577: Make predefined FLT16 macros conditional on support for the type

This revision was automatically updated to reflect the committed changes. Closed by commit rL354512: Make predefined FLT16 macros conditional on support for the type (authored by nemanjai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai created this revision. nemanjai added a reviewer: rsmith. Herald added a subscriber: jdoerfert. Herald added a project: clang. When the `Preprocessor (PP)` in compiler instance is going away, we should clear the cache of any pointers that it owns as they will be destroyed. This is one p

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

nemanjai accepted this revision. nemanjai added subscribers: hfinkel, echristo. nemanjai added a comment. This revision is now accepted and ready to land. I hope I haven't lost track of the patches that precluded this. If I remember correctly, all the X86 80-bit stuff was sorted out. We now know

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

nemanjai created this revision. nemanjai added reviewers: hfinkel, jsji, rzurob, saghir. Herald added a subscriber: kbarton. Herald added a project: clang. As we currently have it implemented in altivec.h, the offsets for these two intrinsics are element offsets. The documentation in the ABI (as

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

nemanjai marked 3 inline comments as done. nemanjai added inline comments. Comment at: lib/Headers/altivec.h:16364 signed short *__ptr) { - return *(unaligned_vec_sshort *)(__ptr + __offset); + signed char *Adjusted = (sign

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

nemanjai updated this revision to Diff 206123. nemanjai added a comment. Remove the double cast. Simplify the test case. Rename the temp. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63636/new/ https://reviews.llvm.org/D63636 Files: lib/Headers/altivec.h te

[PATCH] D64024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne

nemanjai created this revision. nemanjai added reviewers: hfinkel, jsji, rzurob. Herald added subscribers: kristina, kbarton. Herald added a project: clang. We currently emit a double precision comparison instruction for this, whereas we need to emit the single precision version. Repository:

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

nemanjai added a comment. In D33499#1341236 , @ken-cunningham-webuse wrote: > @iains - I have interest in resolving this issue, and also a couple of other > lingering bugs in the PPC32Darwin ABI realm. If you have your WIP available > anywhere, I'd be h

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. A couple of questions since I am not all that familiar with clang and am certainly not familiar with this unusual SUSE 32-bit situation: - We seem to be changing the set of alias

[PATCH] D48044: [Power9] Update fp128 as a valid homogenous aggregate base type

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Other than a few style nits that can be fixed on the commit, this LGTM. Comment at: include/clang/AST/Type.h:1802 bool isFloat16Type() const; // C11 extension ISO

[PATCH] D49424: [PowerPC] Handle __builtin_xxpermdi the same way as GCC does

nemanjai created this revision. nemanjai added reviewers: lu-zero, hfinkel. Herald added a subscriber: kbarton. The codegen for this builtin was initially implemented to match GCC. However, due to interest from users GCC changed behaviour to account for the big endian bias of the instruction and

[PATCH] D49424: [PowerPC] Handle __builtin_xxpermdi the same way as GCC does

nemanjai added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:10780 // endian order so the shuffle mask must be adjusted for this on little // endian platforms (i.e. index is complemented and source vector reversed). +unsigned ElemIdx0 = (Index & 2) >> 1;;

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

nemanjai accepted this revision. nemanjai added subscribers: tstellar, brad, craig.topper, joerg. nemanjai added a comment. This revision is now accepted and ready to land. Thank you for sorting this out. I think it is quite useful to be able to configure the compiler to use complete non-standard

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai created this revision. nemanjai added reviewers: rjmccall, rsmith, PowerPC, hfinkel. Herald added subscribers: dexonsmith, kbarton. Herald added a reviewer: aaron.ballman. Herald added a project: clang. The headers provided with recent GNU toolchains for PPC have code that includes typed

[PATCH] D80294: Add support for vmsumudm

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list cfe-comm

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: clang/test/CodeGen/ppc64-inline-asm.c:50 +// CHECK-LABEL: void @testZwOff(i8* %addr, i64 %off) +// CHEC: %[[VAL:[^ ]+]] = getelementptr i8, i8* %addr, i64 %off +// CHEC: call void asm sideeffec

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rGaede24ecaa08: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D77542?vs=255291&id=265730#toc Repository:

[PATCH] D80533: [Clang] Enable _Complex __float

nemanjai created this revision. nemanjai added reviewers: rjmccall, rsmith, PowerPC. Herald added a subscriber: kbarton. Herald added a project: clang. When I added `__float128` a while ago, I neglected to add support for the complex variant of the type. This patch just adds that. Repository:

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai added a comment. The support for `_Complex __float128` in https://reviews.llvm.org/D80533 I will repurpose leave only the addition of the `KF/KC` modes in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai updated this revision to Diff 266092. nemanjai added a comment. Remove handling for explicit `_Complex __float128`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm.org/D80374 Files: clang/include/clang/AST/

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM aside from a couple of minor nits. Comment at: clang/lib/Basic/Targets/PPC.cpp:319 .Case("ppc64le", true) +.Case("pw

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai updated this revision to Diff 266820. nemanjai added a comment. Handled invalid uses of `KI` as there is no corresponding integer mode and added testing for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai marked 3 inline comments as done. nemanjai added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970 + DestWidth = 128; + break; case 'T': rjmccall wrote: > rjmccall wrote: > > Are there interactions with the other mode speci

[PATCH] D80533: [Clang] Enable _Complex __float

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9e94eb8688d: [Clang] Enable _Complex __float128 (authored by nemanjai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80533/new/ https://reviews.llvm.org/D

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

This revision was automatically updated to reflect the committed changes. nemanjai marked an inline comment as done. Closed by commit rG9021ce9576e4: [Clang] Enable KF and KC mode for [_Complex] __float128 (authored by nemanjai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins in LLVM/Clang

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. In D80941#2066931 , @lebedev.ri wrote: > Why not lower it to `@llvm.cttz(and(a, b))`? That's a great idea. Particularly in the back end

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. The description includes `... however it is more preferable to use bitcast`. It is not a question of preference but of correctness. The fp to int conversions truncate while bitca

[PATCH] D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation

nemanjai accepted this revision. nemanjai added a comment. LGTM. The test case addition can be done on the commit. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py ; RUN: llc -verify-m

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

nemanjai created this revision. nemanjai added reviewers: hfinkel, PowerPC. Herald added subscribers: cfe-commits, shchenz, kbarton. Herald added a project: clang. We currently emit incorrect codegen for this constraint because we set it as a constraint that allows registers. This will cause the

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

nemanjai added a comment. Herald added a subscriber: wuzish. A recent commit has taken down a whole bunch of bots. The build error messages all seem to point to code in this patch. If this is indeed the cause, please revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

nemanjai added a comment. In D77085#1967864 , @njames93 wrote: > In D77085#1967807 , @nemanjai wrote: > > > A recent commit has taken down a whole bunch of bots. The build error > > messages all seem to point to co

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

nemanjai added a comment. According to https://clang.llvm.org/docs/CrossCompilation.html (under `Toolchain Options` option 2) it is quite likely that a user that desires to cross-compile will have the necessary toolchain installed into a directory that will not require the use of `--sysroot`.

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

nemanjai added a comment. Amy, I am really sorry. I initially did not read the description of the instructions in the ISA carefully. The semantics of these instructions are not actually `(op (and a, b))`. The mask is used to determine if a leading/trailing zero is counted or skipped. Take for e

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks Amy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80941/new/ https://reviews.llvm.org/D80941 __

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

nemanjai accepted this revision. nemanjai added a comment. LGTM aside from a minor nit regarding the description. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:324 // P10 Vector Insert built-ins. -BUILTIN(__builtin_altivec_vinsblx, "V16UcV16UcULLiULLi", "") -BUILTIN(__

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

nemanjai added a comment. @rzurob This cannot proceed without your approval since you requested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83497/new/ https://reviews.llvm.org/D83497 ___ cfe

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

nemanjai added a comment. Please re-upload this and provide the missing context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 ___ cfe-commits mailing list cf

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Since clang will now add `+/-mma` to the TargetFeatures list, please add a test case that specifies `-mattr=+/-mma` to `llc` to show that `llc` accepts it. Other than that, LGTM. Reposito

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

nemanjai accepted this revision. nemanjai added a comment. As far as I'm concerned, this is fine for now. We can remove these once all in-tree target have implemented their support. LGTM but maybe give a couple of days for others to chime in. Comment at: clang/lib/Basic/Target

[PATCH] D78308: [NFC][PowerPC] Refactor ppcUserFeaturesCheck()

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for refactoring this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78308/new/ https://reviews.llvm.org/D78308 _

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

nemanjai accepted this revision. nemanjai added a comment. Aside from a couple of minor nits that shouldn't require another review, LGTM. Comment at: clang/docs/ClangCommandLineReference.rst:2631 + +Override the default ABI for 32-bit targets to return small structs in +registe

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:277 break; case 'Q': // Memory operand that is an offset from a register (it is // usually better to use `m' or `es' in asm statements)

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

nemanjai added a comment. This has been sitting in approved state for more than 2 months. As far as I can tell, it wasn't committed. Do you plan to commit this soon or are you abandoning it for some reason? https://reviews.llvm.org/D36431 ___ cfe-

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

nemanjai added a comment. I am not crazy about adding the Boolean parameter here or about the name. Seems somewhat unclear when a caller wants to pass `true` there. What I think would be a more robust solution would be to use the same logic that decides whether to coerce the struct argument to

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

nemanjai added a comment. I am ok with this change overall, I just have a couple of questions about naming of the option. 1. Is there any precedent for options that start with `-maix` or `-m` for any other OS? 2. Is `quadword` the best word to use? There is no type information and this is rest

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

nemanjai added a comment. "Made a new phabricator review because of git issues" is not an appropriate description of a review/revision. Hopefully the description you add will describe what this intrinsic is supposed to do. It seems to me that this is a poorly designed feature if it is meant to

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Please run clang-format, rebase and re-upload. It doesn't apply cleanly to ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12901

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

nemanjai added a comment. In D129855#3667191 , @MaskRay wrote: > In D129855#3662457 , @quinnp wrote: > >> In D129855#3657006 , @MaskRay >> wrote: >> >>> This is not right

[PATCH] D130526: [Driver][PowerPC] Support -mtune=

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Thanks. We'll eventually start doing something with the option in the back end. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130526/n

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

nemanjai added a comment. Why? There are many years of precedent for using `LLVM_FALLTHROUGH` and it is very clear and obvious. What do we gain by getting rid of it? Don't get me wrong, I am not super opposed to using a standard string instead of an LLVM-specific macro. However, it seems that th

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10702 + +// If SafeStack or !StackProtector, kill_canary is not supported. +if (MF.getFunction().hasFnAttribute(Attribute::SafeStack) || Again, this comment is nothing

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 __

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than a couple of nits. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15064 } + case PPC::BI__builtin_ppc_rldimi: + case PPC::BI__builtin_ppc_rlwimi: { -

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. We have encountered an issue with `lwarx/ldarx` that required that they emit inline asm rather than an intrinsic. What makes `lbarx/lharx` different? Comment a

[PATCH] D106065: [Clang] Add an empty builtins.h file.

nemanjai added inline comments. Comment at: clang/lib/Headers/builtins.h:8 +\*===--===*/ + +#ifndef __BUILTINS_H Please describe the purpose of this header file in a comment here. =

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

nemanjai added a comment. Can the test cases that just check for specific IR being produced be merged together? Seems unnecessary to have all of these separate test cases. Perhaps something along the lines of: - Test case for diagnostics of invalid use - Test case for produced IR - Test case for

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than the comment that wasn't addressed (which I assume will be addressed in a subsequent patch). Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 //

[PATCH] D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM as long as the redundant clear is removed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15098 + case PPC::BI__builtin_ppc_poppar8: { +Value *ArgValue = EmitScala

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Taking this off the review queue until `lharx/lbarx` are changed to emit inline asm in line with `lwarx/ldarx`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. This is getting close to approval. The newly added `__stfiw` needs to be fixed and some nits need to be addressed. Comment at: clang/lib/Sema/SemaChecking.cpp:

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Why are `vector-scalar-altivec-init.c` and `vector-scalar-altivec-init2.c` added? There is no initialization of `vector bool` or `vector pixel` in them so I don't really see the

[PATCH] D106065: [Clang] Add an empty builtins.h file.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106065/new/ https://reviews.llvm.org/D106065 __

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 __

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Why does this review have no reviewers listed? Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15586 + case PPC::BI__builtin_ppc_mfspr: { +llvm::Type *RetType

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

nemanjai added a subscriber: jhibbits. nemanjai added a comment. I personally don't see anything wrong with this, but then again I am not really familiar with SPE. I'll defer to @jhibbits for the approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

  1   2   3   4   >