[PATCH] D53457: clang-cl: Add "/Xdriver:" pass-through arg support.

neerajksingh created this revision. neerajksingh added reviewers: rnk, hans. The clang-cl driver disables access to command line options outside of the "Core" and "CLOption" sets of command line arguments. This filtering makes it impossible to pass arguments that are interpreted by the clang drive

[PATCH] D53457: clang-cl: Add "/Xdriver:" pass-through arg support.

neerajksingh added a comment. In https://reviews.llvm.org/D53457#1269769, @hans wrote: > I'm not completely convinced that we want this. So far we've used the > strategy of promoting clang options that are also useful in clang-cl to core > options, and if someone wants to use more clang than th

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 171203. neerajksingh retitled this revision from "clang-cl: Add "/Xdriver:" pass-through arg support." to "clang-cl: Add "/clang:" pass-through arg support.". neerajksingh edited the summary of this revision. neerajksingh added a comment. Change the spe

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 171233. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Driver/cl-options.c Index: test/Driver/cl-options.c ==

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh added a comment. In https://reviews.llvm.org/D53457#1277315, @hans wrote: > One note about flag ordering: the /clang: flags are concatenated to the end > of > the argument list, so in cases where the last flag wins, the /clang: flags > will be chosen regardless of their order

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 171382. neerajksingh added a comment. Fix hans' comments. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Driver/cl-options.c Index:

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh added a comment. In https://reviews.llvm.org/D53457#1278579, @hans wrote: > The `-Xclang` option has the same issue, and I think `/clang:` should work > similarly, i.e. `/clang:-MF /clang:`. It's not pretty, but at least > it's consistent. Yes, that means processing consecutive `/X

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 172615. neerajksingh added a comment. Make it clear in the documentation that the /clang flags are added to the end. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh marked 2 inline comments as done. neerajksingh added a comment. Will update revision... Comment at: test/Driver/cl-options.c:619 + +// RUN: %clang_cl -O2 -### -- %s 2>&1 | FileCheck -check-prefix=NOCLANG %s +// NOCLANG: "--dependent-lib=libcmt" han

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 173072. neerajksingh marked an inline comment as done. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Driver/cl-options.c Index: test

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh added a comment. Reid, Hans, or someone else with commit access. If the revision looks good, could you please submit to SVN? Any particular testing I should run beforehand? I ran the clang tests locally on Windows. https://reviews.llvm.org/D53457 __