[clang] [clang] Robustify openmp test (PR #69739)

2023-10-20 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/69739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Assert not llvm_unreachable (PR #70149)

2023-10-24 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan created https://github.com/llvm/llvm-project/pull/70149 An assert is better here. >From 1120a9bd5490dba672898f6902e60e461792b711 Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Tue, 24 Oct 2023 20:20:18 -0400 Subject: [PATCH] [clang][NFC] Assert not llvm_unreach

[clang] [clang][NFC] Assert not llvm_unreachable (PR #70149)

2023-10-25 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/70149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refactor TBAA Base Info construction (PR #70499)

2023-10-27 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan created https://github.com/llvm/llvm-project/pull/70499 I noticed a few issues with `CodeGenTBAA::getBaseTypeInfo`. 1) `isValidBaseType` explicitly checks for a reference type to return false, but then also returns false for all non-record types. Just remove that r

[clang] 0566f97 - [clang][NFC] remove unused return value

2021-05-14 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-05-14T05:25:47-07:00 New Revision: 0566f979619cf49a62804a7e3530438f1319fa7c URL: https://github.com/llvm/llvm-project/commit/0566f979619cf49a62804a7e3530438f1319fa7c DIFF: https://github.com/llvm/llvm-project/commit/0566f979619cf49a62804a7e3530438f1319fa7c.diff

[clang] c138f3c - [clang] Fix ICE with typeid & polymorphic class (pr50497)

2021-06-01 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-01T12:55:29-07:00 New Revision: c138f3ce5c70ff87a35d77e11f77a77d9d539b49 URL: https://github.com/llvm/llvm-project/commit/c138f3ce5c70ff87a35d77e11f77a77d9d539b49 DIFF: https://github.com/llvm/llvm-project/commit/c138f3ce5c70ff87a35d77e11f77a77d9d539b49.diff

[clang-tools-extra] ddda05a - [clang][NFC] Break out BaseUsingDecl from UsingDecl

2021-06-07 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-07T06:29:28-07:00 New Revision: ddda05add527f7f92a71f387b927f237334f46d9 URL: https://github.com/llvm/llvm-project/commit/ddda05add527f7f92a71f387b927f237334f46d9 DIFF: https://github.com/llvm/llvm-project/commit/ddda05add527f7f92a71f387b927f237334f46d9.diff

[clang] 84ab315 - [clang][NFC] Break out enum completion from other type context completion

2021-06-07 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-07T06:29:29-07:00 New Revision: 84ab315574099dcac8f9fb89fe8558f8ccfbce5f URL: https://github.com/llvm/llvm-project/commit/84ab315574099dcac8f9fb89fe8558f8ccfbce5f DIFF: https://github.com/llvm/llvm-project/commit/84ab315574099dcac8f9fb89fe8558f8ccfbce5f.diff

[clang] 012898b - [clang] p1099 using enum part 1

2021-06-08 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-08T04:40:42-07:00 New Revision: 012898b92cad00e230a960a08a3f418628bec060 URL: https://github.com/llvm/llvm-project/commit/012898b92cad00e230a960a08a3f418628bec060 DIFF: https://github.com/llvm/llvm-project/commit/012898b92cad00e230a960a08a3f418628bec060.diff

[clang] b2d0c16 - [clang] p1099 using enum part 2

2021-06-08 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-08T11:11:46-07:00 New Revision: b2d0c16e91f39def3646b71e5afebfaea262cca1 URL: https://github.com/llvm/llvm-project/commit/b2d0c16e91f39def3646b71e5afebfaea262cca1 DIFF: https://github.com/llvm/llvm-project/commit/b2d0c16e91f39def3646b71e5afebfaea262cca1.diff

[clang] c1cd743 - [clang] p1099 using-enum feature macro & web page

2021-06-09 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-09T05:40:53-07:00 New Revision: c1cd743519af3978b944df88f57c6e523caa10dc URL: https://github.com/llvm/llvm-project/commit/c1cd743519af3978b944df88f57c6e523caa10dc DIFF: https://github.com/llvm/llvm-project/commit/c1cd743519af3978b944df88f57c6e523caa10dc.diff

[clang] 691ba0f - [clang][NFC] Avoid assignment in condition

2021-06-11 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-06-11T03:53:55-07:00 New Revision: 691ba0f8acb511f7da1e78c59fe9560b64c47f3a URL: https://github.com/llvm/llvm-project/commit/691ba0f8acb511f7da1e78c59fe9560b64c47f3a DIFF: https://github.com/llvm/llvm-project/commit/691ba0f8acb511f7da1e78c59fe9560b64c47f3a.diff

[clang] bf6986d - [clang] GCC directive extension extension: Hash NNN lines

2021-11-09 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-11-09T07:31:03-08:00 New Revision: bf6986d99eaa68ad850eb335cb3f98fe6406ccd0 URL: https://github.com/llvm/llvm-project/commit/bf6986d99eaa68ad850eb335cb3f98fe6406ccd0 DIFF: https://github.com/llvm/llvm-project/commit/bf6986d99eaa68ad850eb335cb3f98fe6406ccd0.diff

[clang] ae5c52b - [clang] [docs] Fix markup

2021-11-09 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-11-09T07:40:27-08:00 New Revision: ae5c52b933f45ba9a782909a93d1ae3c7243c6be URL: https://github.com/llvm/llvm-project/commit/ae5c52b933f45ba9a782909a93d1ae3c7243c6be DIFF: https://github.com/llvm/llvm-project/commit/ae5c52b933f45ba9a782909a93d1ae3c7243c6be.diff

[clang] da979f6 - [clang] Fix restructured markup

2021-11-09 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-11-09T18:41:22-05:00 New Revision: da979f6cf82111d58285a96bce1febd486d65b34 URL: https://github.com/llvm/llvm-project/commit/da979f6cf82111d58285a96bce1febd486d65b34 DIFF: https://github.com/llvm/llvm-project/commit/da979f6cf82111d58285a96bce1febd486d65b34.diff

[clang] 53c3664 - [xmm] Remove duplicate #define

2022-09-26 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-09-26T08:59:55-07:00 New Revision: 53c3664f674cc2f33c8214f493c2c17ce9b4d466 URL: https://github.com/llvm/llvm-project/commit/53c3664f674cc2f33c8214f493c2c17ce9b4d466 DIFF: https://github.com/llvm/llvm-project/commit/53c3664f674cc2f33c8214f493c2c17ce9b4d466.diff

[clang] 3d20806 - [clang][DR2621] using enum NAME lookup fix

2022-09-28 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-09-28T08:50:27-07:00 New Revision: 3d2080683f1dc37010fb56cf7d0e1632cda00f15 URL: https://github.com/llvm/llvm-project/commit/3d2080683f1dc37010fb56cf7d0e1632cda00f15 DIFF: https://github.com/llvm/llvm-project/commit/3d2080683f1dc37010fb56cf7d0e1632cda00f15.diff

[clang] 245da0a - [modules] Fix callback argument thinko

2022-10-17 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-10-17T09:30:50-07:00 New Revision: 245da0a451e193dc4229ed8aed28cf34fa083ed4 URL: https://github.com/llvm/llvm-project/commit/245da0a451e193dc4229ed8aed28cf34fa083ed4 DIFF: https://github.com/llvm/llvm-project/commit/245da0a451e193dc4229ed8aed28cf34fa083ed4.diff

[clang] 6b8c6f1 - [clang][PR55406] CFG for coroutine

2022-05-26 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-05-26T06:40:43-07:00 New Revision: 6b8c6f15fdd8c147dfb7b0beb6f3d6eb98bf5772 URL: https://github.com/llvm/llvm-project/commit/6b8c6f15fdd8c147dfb7b0beb6f3d6eb98bf5772 DIFF: https://github.com/llvm/llvm-project/commit/6b8c6f15fdd8c147dfb7b0beb6f3d6eb98bf5772.diff

[clang] 4f8668d - [clang] co_return cleanup

2022-06-08 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-06-08T08:08:42-07:00 New Revision: 4f8668d9f73a0dc234ebf9938bcf24061991e9ae URL: https://github.com/llvm/llvm-project/commit/4f8668d9f73a0dc234ebf9938bcf24061991e9ae DIFF: https://github.com/llvm/llvm-project/commit/4f8668d9f73a0dc234ebf9938bcf24061991e9ae.diff

[clang] 65b34b7 - [clang][pr55896]:co_yield/co_await thread-safety

2022-06-09 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-06-09T04:42:10-07:00 New Revision: 65b34b78f8dafbfd97836af3165e73c5b316c6b5 URL: https://github.com/llvm/llvm-project/commit/65b34b78f8dafbfd97836af3165e73c5b316c6b5 DIFF: https://github.com/llvm/llvm-project/commit/65b34b78f8dafbfd97836af3165e73c5b316c6b5.diff

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-18 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan edited https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-22 Thread Nathan Sidwell via cfe-commits
urnathan wrote: Ping? Anything more I can do to progress this? https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e789bcb - [clang][NFC] Robustify testcase

2023-08-11 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2023-08-11T15:59:52-04:00 New Revision: e789bcbb967f391d4f641bc8fa0403a45039a592 URL: https://github.com/llvm/llvm-project/commit/e789bcbb967f391d4f641bc8fa0403a45039a592 DIFF: https://github.com/llvm/llvm-project/commit/e789bcbb967f391d4f641bc8fa0403a45039a592.diff

[clang] [clang] Better bitfield access units (PR #65742)

2023-10-13 Thread Nathan Sidwell via cfe-commits
urnathan wrote: time for another ping, I think ... https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan converted_to_draft https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-08 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > Note that changing the memory accesses performed by clang (load or store) > _is_ an ABI change at IR level because of UB. Could you clarify why UB is a consideration here? https://github.com/llvm/llvm-project/pull/65742 ___ cfe-com

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan edited https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > Also, please have a look at the existing `-ffine-grained-bitfield-accesses` > flag and the discussions around it and IPO. That flag's behaviour is unchanged here -- it continues to not merge access units. My contention here is that (a) merging units can be advantageous, but

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > > > Note that changing the memory accesses performed by clang (load or store) > > > _is_ an ABI change at IR level because of UB. > > > > > > Could you clarify why UB is a consideration here? > > There's some weirdness with poison values; see > https://reviews.llvm.org/D129

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > The advantage of exposing the wide accesses to the optimizer is that it > allows memory optimizations, like CSE or DSE, to reason about the entire > bitfield as a single unit, and easily eliminate accesses. Reducing the size > of bitfield accesses in the frontend is basically

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
urnathan wrote: thanks for your comments, > When I refer to CSE/DSE, I'm mostly talking about keeping values in registers > for longer. They don't know anything about individual fields in bitfields. If > we split bitfields too narrowly, we end up with extra memory accesses for > accessing mul

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-13 Thread Nathan Sidwell via cfe-commits
@@ -24790,8 +24790,8 @@ static SDValue LowerVACOPY(SDValue Op, const X86Subtarget &Subtarget, return DAG.getMemcpy( Chain, DL, DstPtr, SrcPtr, DAG.getIntPtrConstant(Subtarget.isTarget64BitLP64() ? 24 : 16, DL), - Align(Subtarget.isTarget64BitLP64() ? 8 : 4),

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-13 Thread Nathan Sidwell via cfe-commits
@@ -214,14 +214,14 @@ class LLVM_MemcpyIntrOpBase : /*requiresAccessGroup=*/1, /*requiresAliasAnalysis=*/1> { dag args = (ins Arg:$dst, Arg:$src, - AnySignlessInteger:$len, I1Attr:$isVolatile); urnathan wrote: thanks, l

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-15 Thread Nathan Sidwell via cfe-commits
@@ -24790,8 +24790,8 @@ static SDValue LowerVACOPY(SDValue Op, const X86Subtarget &Subtarget, return DAG.getMemcpy( Chain, DL, DstPtr, SrcPtr, DAG.getIntPtrConstant(Subtarget.isTarget64BitLP64() ? 24 : 16, DL), - Align(Subtarget.isTarget64BitLP64() ? 8 : 4),

[clang] eff9d72 - [clang] NFC: Robustify sret test regex

2022-11-21 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-11-21T14:20:47-05:00 New Revision: eff9d72b9b63b5c2f506581180db34df3b70bec9 URL: https://github.com/llvm/llvm-project/commit/eff9d72b9b63b5c2f506581180db34df3b70bec9 DIFF: https://github.com/llvm/llvm-project/commit/eff9d72b9b63b5c2f506581180db34df3b70bec9.diff

[clang] [clang] Better bitfield access units (PR #65742)

2024-02-23 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > On the target hook, it's a shame we can't easily get this information from > LLVM. I believe it's already there — `TargetLowering` has an > `allowsMisalignedMemoryAccesses` method that includes some approximation of > how fast a particular access would be. In practice, it see

[clang] [clang] Better bitfield access units (PR #65742)

2024-02-23 Thread Nathan Sidwell via cfe-commits
@@ -132,6 +132,7 @@ class LLVM_LIBRARY_VISIBILITY LoongArch64TargetInfo : LoongArchTargetInfo(Triple, Opts) { LongWidth = LongAlign = PointerWidth = PointerAlign = 64; IntMaxType = Int64Type = SignedLong; +HasCheapUnalignedBitfieldAccess = true; --

[clang] [clang][NFC] Adjust TBAA Base Info API (PR #73263)

2024-02-23 Thread Nathan Sidwell via cfe-commits
@@ -95,8 +95,6 @@ static bool TypeHasMayAlias(QualType QTy) { /// Check if the given type is a valid base type to be used in access tags. static bool isValidBaseType(QualType QTy) { - if (QTy->isReferenceType()) -return false; urnathan wrote: would you p

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-10 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan updated https://github.com/llvm/llvm-project/pull/102078 >From 193e704ea21251ea639bfb733671b4047c93c4ea Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Sun, 4 Aug 2024 19:15:20 -0400 Subject: [PATCH 1/3] [clang-format] Adjust requires clause wrapping (#101550) A

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-10 Thread Nathan Sidwell via cfe-commits
@@ -5682,12 +5683,15 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, (Style.BreakTemplateDeclarations == FormatStyle::BTDS_Leave && Right.NewlinesBefore > 0); } - if (Left.ClosesRequiresClause && Right.isNot(tok::semi) && - Rig

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-10 Thread Nathan Sidwell via cfe-commits
urnathan wrote: Thanks for the comments, I think this addresses them https://github.com/llvm/llvm-project/pull/102078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-15 Thread Nathan Sidwell via cfe-commits
urnathan wrote: @mydeveloperday, have I addressed your request -- I think so, as tests are no longer being changed. https://github.com/llvm/llvm-project/pull/102078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [clang][NFC] Adjust TBAA Base Info API (PR #73263)

2024-04-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan closed https://github.com/llvm/llvm-project/pull/73263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move tailclipping to bitfield allocation (PR #87090)

2024-04-15 Thread Nathan Sidwell via cfe-commits
urnathan wrote: @rjmccall can you take a look at this? as the description says, this turns out to not be NFC, but important on (probably only) LP64 machines. https://github.com/llvm/llvm-project/pull/87090 ___ cfe-commits mailing list cfe-commits@list

[clang] [clang] Move tailclipping to bitfield allocation (PR #87090)

2024-04-15 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan closed https://github.com/llvm/llvm-project/pull/87090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Remove class layout scissor (PR #89055)

2024-04-17 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan created https://github.com/llvm/llvm-project/pull/89055 Now that `accumulateBitfields` does the correct clipping, we don't need the scissor any more -- `checkBitfieldClipping` can compute its location directly. >From db5e6456f26ea9b859d3ff24161d7494d58bb7e1 Mon Sep

[clang] [clang][NFC] Remove class layout scissor (PR #89055)

2024-04-17 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan updated https://github.com/llvm/llvm-project/pull/89055 >From db5e6456f26ea9b859d3ff24161d7494d58bb7e1 Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Mon, 1 Apr 2024 16:15:12 -0400 Subject: [PATCH 1/2] [clang] Remove class layout scissor --- clang/lib/CodeGen/

[clang] [clang][NFC] Remove class layout scissor (PR #89055)

2024-04-17 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/89055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Rename variable more sensitively (PR #100943)

2024-07-28 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan created https://github.com/llvm/llvm-project/pull/100943 I noticed the insensitively named `Blacklist` variable when looking at https://github.com/llvm/llvm-project/pull/100852. Let's renaming to `Disallowed`. >From 9159beaeec23ea5336e62ba1b7710d784bba17f3 Mon Sep

[clang] [clang][NFC] Remove class layout scissor (PR #89055)

2024-05-03 Thread Nathan Sidwell via cfe-commits
urnathan wrote: ping? https://github.com/llvm/llvm-project/pull/89055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Remove class layout scissor (PR #89055)

2024-05-06 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan updated https://github.com/llvm/llvm-project/pull/89055 >From db5e6456f26ea9b859d3ff24161d7494d58bb7e1 Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Mon, 1 Apr 2024 16:15:12 -0400 Subject: [PATCH 1/3] [clang] Remove class layout scissor --- clang/lib/CodeGen/

[clang] [clang][NFC] Remove class layout scissor (PR #89055)

2024-05-10 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan updated https://github.com/llvm/llvm-project/pull/89055 >From 9ab483f3451bfcaa7968c5f1cf7115144522f58a Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Mon, 1 Apr 2024 16:15:12 -0400 Subject: [PATCH 1/3] [clang] Remove class layout scissor --- clang/lib/CodeGen/

[clang] [clang][NFC] Remove class layout scissor (PR #89055)

2024-05-12 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan closed https://github.com/llvm/llvm-project/pull/89055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Rename variable more sensitively (PR #100943)

2024-08-01 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan closed https://github.com/llvm/llvm-project/pull/100943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan updated https://github.com/llvm/llvm-project/pull/102078 >From 193e704ea21251ea639bfb733671b4047c93c4ea Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Sun, 4 Aug 2024 19:15:20 -0400 Subject: [PATCH 1/2] [clang-format] Adjust requires clause wrapping (#101550) A

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-08 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > But that would be the way to go, add an option to the enum, don't change the > existing behavior. Sure -- I thought I'd shoot for the simplest change first :) Here's an update that adds `OwnLineWithBrace`, which is like `OwnLine` except it also allows a trailing `{` (and any

[clang] 493c856 - [clang][NFC] Small mangler cleanups

2022-01-20 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-01-20T11:20:15-08:00 New Revision: 493c856484015873737d7c995cac9e34101fb9e9 URL: https://github.com/llvm/llvm-project/commit/493c856484015873737d7c995cac9e34101fb9e9 DIFF: https://github.com/llvm/llvm-project/commit/493c856484015873737d7c995cac9e34101fb9e9.diff

[clang] ccf02cd - [clang][NFC] Remove unreachable code

2022-02-02 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-02-02T05:14:26-08:00 New Revision: ccf02cdf17d68a7dd4411daa74b81fa5b48d0a0c URL: https://github.com/llvm/llvm-project/commit/ccf02cdf17d68a7dd4411daa74b81fa5b48d0a0c DIFF: https://github.com/llvm/llvm-project/commit/ccf02cdf17d68a7dd4411daa74b81fa5b48d0a0c.diff

[clang] 21e16ab - [clang][ABI] New C++20 module mangling scheme

2022-03-08 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-03-08T06:21:50-08:00 New Revision: 21e16ab6b8ddaccb70d2344bb35419e214a32ec9 URL: https://github.com/llvm/llvm-project/commit/21e16ab6b8ddaccb70d2344bb35419e214a32ec9 DIFF: https://github.com/llvm/llvm-project/commit/21e16ab6b8ddaccb70d2344bb35419e214a32ec9.diff

[clang] 6ad7e87 - clang: libstdc++ LWM is 4.8.3

2021-04-22 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-04-22T05:26:07-07:00 New Revision: 6ad7e87806c0af774cf2f8880694f79259925979 URL: https://github.com/llvm/llvm-project/commit/6ad7e87806c0af774cf2f8880694f79259925979 DIFF: https://github.com/llvm/llvm-project/commit/6ad7e87806c0af774cf2f8880694f79259925979.diff

[clang] 0ff41c2 - Update libstdc++ hack comment

2021-04-29 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-04-29T03:57:10-07:00 New Revision: 0ff41c2ebc9904f881c958f9006bbf2b6bdc5d1e URL: https://github.com/llvm/llvm-project/commit/0ff41c2ebc9904f881c958f9006bbf2b6bdc5d1e DIFF: https://github.com/llvm/llvm-project/commit/0ff41c2ebc9904f881c958f9006bbf2b6bdc5d1e.diff

[clang] e90792d - [clang] Update comments on another libstdc++ HACK

2021-04-30 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-04-30T09:29:26-07:00 New Revision: e90792d8c78bac79a1a39f245e222684ea24c7c0 URL: https://github.com/llvm/llvm-project/commit/e90792d8c78bac79a1a39f245e222684ea24c7c0 DIFF: https://github.com/llvm/llvm-project/commit/e90792d8c78bac79a1a39f245e222684ea24c7c0.diff

[clang] fe4c9b3 - [clang] Remove libstdc++ friend template hack

2021-05-03 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-05-03T04:19:30-07:00 New Revision: fe4c9b3cb0c3c0cac6b63de3b47a86e31559bb6d URL: https://github.com/llvm/llvm-project/commit/fe4c9b3cb0c3c0cac6b63de3b47a86e31559bb6d DIFF: https://github.com/llvm/llvm-project/commit/fe4c9b3cb0c3c0cac6b63de3b47a86e31559bb6d.diff

[clang] ab7316f - [clang] Spell correct variable

2021-05-03 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-05-03T05:33:47-07:00 New Revision: ab7316f1c64c3530a6eca2e449c2dd734e83498e URL: https://github.com/llvm/llvm-project/commit/ab7316f1c64c3530a6eca2e449c2dd734e83498e DIFF: https://github.com/llvm/llvm-project/commit/ab7316f1c64c3530a6eca2e449c2dd734e83498e.diff

[clang] d4f0978 - [clang] More informative mixed namespace diagnostics

2022-01-02 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-01-02T12:23:13-05:00 New Revision: d4f09786e079361eba1ade1e351be8771d016f29 URL: https://github.com/llvm/llvm-project/commit/d4f09786e079361eba1ade1e351be8771d016f29 DIFF: https://github.com/llvm/llvm-project/commit/d4f09786e079361eba1ade1e351be8771d016f29.diff

[clang] b50fea4 - [clang] Allow using std::coroutine_traits in std::experimental

2022-01-02 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2022-01-02T15:48:16-05:00 New Revision: b50fea47b6c454581fce89af359f3afe5154986c URL: https://github.com/llvm/llvm-project/commit/b50fea47b6c454581fce89af359f3afe5154986c DIFF: https://github.com/llvm/llvm-project/commit/b50fea47b6c454581fce89af359f3afe5154986c.diff

[clang] 5fbe21a - [clang] p2085 out-of-class comparison operator defaulting

2021-12-16 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-12-16T07:22:46-08:00 New Revision: 5fbe21a7748f91adbd1b16c95bbfe180642320a3 URL: https://github.com/llvm/llvm-project/commit/5fbe21a7748f91adbd1b16c95bbfe180642320a3 DIFF: https://github.com/llvm/llvm-project/commit/5fbe21a7748f91adbd1b16c95bbfe180642320a3.diff

[clang] 23b2045 - [clang] p2085 out-of-class comparison operator defaulting

2021-12-20 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-12-20T08:47:54-08:00 New Revision: 23b2045eef45884566722d06f3e09224a0f6dc6c URL: https://github.com/llvm/llvm-project/commit/23b2045eef45884566722d06f3e09224a0f6dc6c DIFF: https://github.com/llvm/llvm-project/commit/23b2045eef45884566722d06f3e09224a0f6dc6c.diff

[clang] 565c175 - [clang] Adjust coroutine namespace diagnostics

2021-12-20 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-12-20T08:50:16-08:00 New Revision: 565c17574dd062cf3096d578c4a2ab058f494c6d URL: https://github.com/llvm/llvm-project/commit/565c17574dd062cf3096d578c4a2ab058f494c6d DIFF: https://github.com/llvm/llvm-project/commit/565c17574dd062cf3096d578c4a2ab058f494c6d.diff

[clang] d4de2a4 - [clang][NFC] Refactor coroutine_traits lookup

2021-12-21 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-12-21T10:29:01-05:00 New Revision: d4de2a4d5905beb0602a615593daf003378ddb64 URL: https://github.com/llvm/llvm-project/commit/d4de2a4d5905beb0602a615593daf003378ddb64 DIFF: https://github.com/llvm/llvm-project/commit/d4de2a4d5905beb0602a615593daf003378ddb64.diff

[clang] 9249826 - [clang] Tiny format fix

2021-04-09 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-04-09T05:19:51-07:00 New Revision: 92498264269c86fd0f5645d184d9f7e1c0c3acdf URL: https://github.com/llvm/llvm-project/commit/92498264269c86fd0f5645d184d9f7e1c0c3acdf DIFF: https://github.com/llvm/llvm-project/commit/92498264269c86fd0f5645d184d9f7e1c0c3acdf.diff

[clang] 057b6f5 - clang: Update libstdc++ issue workaround

2021-04-20 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-04-20T11:34:12-07:00 New Revision: 057b6f5d0b3ec1c1d0a87eb3d99ac4a46ca68cb4 URL: https://github.com/llvm/llvm-project/commit/057b6f5d0b3ec1c1d0a87eb3d99ac4a46ca68cb4 DIFF: https://github.com/llvm/llvm-project/commit/057b6f5d0b3ec1c1d0a87eb3d99ac4a46ca68cb4.diff

[clang] dcd7471 - [clang] p0388 conversion to incomplete array

2021-10-12 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-10-12T07:35:20-07:00 New Revision: dcd74716f9d18444a17de852a760cc85bd16f825 URL: https://github.com/llvm/llvm-project/commit/dcd74716f9d18444a17de852a760cc85bd16f825 DIFF: https://github.com/llvm/llvm-project/commit/dcd74716f9d18444a17de852a760cc85bd16f825.diff

[clang] 444ec09 - [clang] p0388 array list initialization overloads

2021-10-12 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-10-12T07:35:21-07:00 New Revision: 444ec0957c58492ecce0569bb20b7d3ad59d37bb URL: https://github.com/llvm/llvm-project/commit/444ec0957c58492ecce0569bb20b7d3ad59d37bb DIFF: https://github.com/llvm/llvm-project/commit/444ec0957c58492ecce0569bb20b7d3ad59d37bb.diff

[clang] d45526e - [doc][clang] correct version for p0388 implementation

2021-10-13 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-10-13T04:12:07-07:00 New Revision: d45526e6c34a82376f05b702a2969b4c4970cb1c URL: https://github.com/llvm/llvm-project/commit/d45526e6c34a82376f05b702a2969b4c4970cb1c DIFF: https://github.com/llvm/llvm-project/commit/d45526e6c34a82376f05b702a2969b4c4970cb1c.diff

[clang] b8ff780 - [clang][NFC] Correct doc markup

2021-10-13 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-10-13T04:20:15-07:00 New Revision: b8ff780f205022d354b7604ebf1307e696804ac7 URL: https://github.com/llvm/llvm-project/commit/b8ff780f205022d354b7604ebf1307e696804ac7 DIFF: https://github.com/llvm/llvm-project/commit/b8ff780f205022d354b7604ebf1307e696804ac7.diff

[clang] bb3f5f5 - [clang] Array list initialization (pre-p0388)

2021-09-09 Thread Nathan Sidwell via cfe-commits
Author: Nathan Sidwell Date: 2021-09-09T08:30:04-07:00 New Revision: bb3f5f5d788dd9375ab260f77612fab4a707a1ac URL: https://github.com/llvm/llvm-project/commit/bb3f5f5d788dd9375ab260f77612fab4a707a1ac DIFF: https://github.com/llvm/llvm-project/commit/bb3f5f5d788dd9375ab260f77612fab4a707a1ac.diff

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-16 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan closed https://github.com/llvm/llvm-project/pull/102078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2