[PATCH] D85500: [clangd] Highlight structured bindings at local scope as LocalVariable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57f9518bf032: [clangd] Highlight structured bindings at local scope as LocalVariable (authored by nridge). Repository: rG LLVM Github Monorepo CH

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Ok, sounds reasonable to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85282/new/ https://reviews.llvm.org/D85282 _

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

nridge created this revision. nridge added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. nridge requested review of this revision. The patch also adds a templateArgumentLoc() AST matcher. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

nridge updated this revision to Diff 284245. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85503/new/ https://reviews.llvm.org/D85503 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

nridge added a comment. I've added the matcher and split the clang parts into D85621 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85503/new/ https://reviews.llvm.org/D85503 __

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge updated this revision to Diff 284262. nridge added a comment. Add the requested flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-e

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

nridge updated this revision to Diff 284264. nridge added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Run script to update AST matcher docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85621/new/ https://rev

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

nridge added a comment. In D85621#2205803 , @hokein wrote: > Please run `clang/docs/tools/dump_ast_matchers.py` script to update the > `LibASTMatchersReference.html` file. Done. Note, it looks like this script needs to be run with python 2. Should we do

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1c7f84643ff: [clang] Allow DynTypedNode to store a TemplateArgumentLoc (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

nridge updated this revision to Diff 284271. nridge added a comment. Add Selection test Also simplify the FindTarget test case a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85503/new/ https://reviews.llvm.org/D85503 Files: clang-tools-ext

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

This revision was automatically updated to reflect the committed changes. Closed by commit rG70d583ad1287: [clangd] Have template template arguments target their referenced template decl (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D85635: [clangd] Compute the interactive code range for semantic highlighting.

nridge added a comment. Do you mean "inactive" (instead of "interactive") in the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/new/ https://reviews.llvm.org/D85635 ___ cfe-commits m

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

nridge added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:4587 + return RParenLoc; +return getPattern()->getEndLoc(); + } Wouldn't `EllipsisLoc` be more accurate? Comment at: clang/test/AST/ast-dump-concepts.cpp:16 +

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

nridge added a comment. In D85621#2205944 , @njames93 wrote: > In D85621#2205856 , @nridge wrote: > >> In D85621#2205803 , @hokein wrote: >> >>> Please run `clang/docs/tools/

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge updated this revision to Diff 284576. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 Files: clang-tools-ext

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/ExprCXX.h:4582 +if (isLeftFold()) + return getEllipsisLoc(); +return getLHS()->getBeginLoc(); Can this c

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge updated this revision to Diff 285907. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 Files: clang-tools-ext

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge updated this revision to Diff 285910. nridge added a comment. Only visit the TypeConstraint if the immediately-declared-constraint is null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 Files: cla

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge updated this revision to Diff 285911. nridge added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 Files: clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang/inclu

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint())); TRY_TO(TraverseConceptRe

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge updated this revision to Diff 285920. nridge added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/clangd/Clan

[PATCH] D86047: [clangd] Target member of dependent base made visible via a using-decl

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/307 Repository:

[PATCH] D86047: [clangd] Target member of dependent base made visible via a using-decl

nridge updated this revision to Diff 285922. nridge added a comment. Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86047/new/ https://reviews.llvm.org/D86047 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/cla

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:727 + // Run the collector again with CollectMainFileRefs = true. + InMemoryFileSystem = new llvm::vfs::InMemoryFileSystem(); + CollectorOpts.CollectMainFileRefs = true; -

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG15673d748acd: [clangd] Index refs to main-file symbols as well (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D83536?vs=285920&id=286194#toc Repository: rG LLVM Github Monore

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

This revision was automatically updated to reflect the committed changes. nridge marked an inline comment as done. Closed by commit rG00d7b7d014f9: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter (authored by nridge). Changed prior to commit: https://reviews.llvm.or

[PATCH] D86047: [clangd] Target member of dependent base made visible via a using-decl

nridge updated this revision to Diff 286198. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86047/new/ https://reviews.llvm.org/D86047 Files: clang-tools-ext

[PATCH] D86047: [clangd] Target member of dependent base made visible via a using-decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGe33ec9d90400: [clangd] Target member of dependent base made visible via a using-decl (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8604

[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This matches the clang-tidy behaviour. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79691 Files: clang-tools

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

nridge added a comment. Also, does this mean that patches to vscode-clangd should now be submitted as a Github PR rather than via Phabricator? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78598/new/ https://reviews.llvm.org/D78598

[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

nridge updated this revision to Diff 263361. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79691/new/ https://reviews.llvm.org/D79691 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extr

[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a7276b35485: [clangd] Have suppression comments take precedence over warning-as-error (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D132830: [clangd] Avoid crash when printing call to string literal operator template in hover

nridge created this revision. nridge added reviewers: hokein, kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-ext

[PATCH] D132833: [clangd] Fail more gracefully if QueryDriverDatabase cannot determine file type

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Currently

[PATCH] D132833: [clangd] Fail more gracefully if QueryDriverDatabase cannot determine file type

This revision was automatically updated to reflect the committed changes. Closed by commit rG9af0a142e436: [clangd] Fail more gracefully if QueryDriverDatabase cannot determine file type (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D132830: [clangd] Avoid crash when printing call to string literal operator template in hover

nridge updated this revision to Diff 457891. nridge added a comment. Move test to StmtPrinterTests, add test for literal operator using pack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132830/new/ https://reviews.llvm.org/D132830 Files: clang/

[PATCH] D132830: [clangd] Avoid crash when printing call to string literal operator template in hover

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG898c421975ed: [clangd] Avoid crash when printing call to string literal operator template (authored by nridge). Repository: rG LLVM Github Monorep

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Use it in

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This allo

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added a comment. Herald added a subscriber: ormris. This is a refactoring in preparation for D133757 , please see that for motivation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/new/ https://review

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added a comment. Depends on https://reviews.llvm.org/D133756 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added a comment. So far I've only written a test for https://github.com/clangd/clangd/issues/1089. I plan to add tests for the other two issues as well, but I thought I'd get the review ball rolling in the mean time to get feedback on the fix approach and test approach. Repository:

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp:242 +CompileFlags: + Compiler: gcc + )yaml"; To exercise `QueryDriverDatabase`, this test assumes that the machine running the test will have a `gcc` somewher

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:150-151 clang::tooling::ArgumentsAdjuster( - clang::clangd::CommandMangler::detect())); + [Mangler = std::shared_ptr( + clang::clangd::CommandMangler:

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

nridge added a comment. In D133664#3790144 , @tom-anders wrote: > Yeah I do have commit access now, so I'll land this by myself. > > I don't think I have the permissions to close the corresponding issue on > Github though, so someone else would need to

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added a comment. I think the sticking point for just having `QueryDriverDatabase` run after the entirety of `CommandMangler` is this check in `resolveDriver()`,

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added a comment. Thanks for the feedback! Yeah I'd be wary of introducing a corner case where the user passes `--query-driver`, and there is in fact a driver available to query in `PATH`, but we end up not querying it. Even if the outcome is the same in cases we can think of, it feels li

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

nridge created this revision. nridge added reviewers: hokein, ilya-biryukov, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

nridge added a comment. Thanks for the patch! nit: please make the commit message a bit more specific, e.g. "Also apply the 'mutable' semantic token modifier to arguments of overloaded call operators" Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:540 //

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. Thanks for the update! In D127082#3606746 , @daiyousei-qz wrote: > Therefore, I still put definition in front of the expansion in this update. > > Regarding to the size limit of expansion: > Here I'm using a 2048 bytes buffer. I

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! I'm going to take the liberty of approving this, as it seems straightforward and unlikely to be contentious in any way. Please let me know if you need me to commit it. Repository:

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:483 + !Type.getNonReferenceType().isConstQualified() && + !isExpandedParameterPack(Param); } sammccall wrote: > why is this check needed if we already decline

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc09e53337413: [clangd] Also mark output arguments of operator call expressions (authored by ckandeler, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D128892: [clangd] Also mark output arguments of array subscript expressions

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Makes sense. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128892/new/ https://reviews.llvm.org/D128892 ___

[PATCH] D128892: [clangd] Also mark output arguments of array subscript expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGac511fd4392d: [clangd] Also mark output arguments of array subscript expressions (authored by ckandeler, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. Thanks, this seems like a useful extension of the `usedAsMutableReference` modifier Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:541 + return

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1091 + + // Reformat Macro Expansion + if (!HI->MacroExpansion.empty()) { nridge wrote: > It would be interesting to have a couple of test cases that exercise the > reformatting in no

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

nridge added a comment. Herald added projects: LLVM, clang-tools-extra, All. Herald added a subscriber: llvm-commits. @sammccall should we get this patch landed? The issue of #ifndef-guarded header files that include each other recursively is still tripping up some users. Repository: rG LLVM

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge added a comment. Yes, I plan to. I'm just building it locally to verify the tests are passing. (And sometimes, for reasons I don't understand, LLVM's build system triggers a full rebuild even though I've only applied a patch that touches a couple of files...) Repository: rG LLVM Gith

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fbc0519c52: [clangd] Support "usedAsMutableReference" in member initializations (authored by ckandeler, committed by nridge). Repository: rG LL

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. I would like to apply the updated patch to try it some more, but `arc patch` is failing for me. Applying the raw diff manually with `patch` also fails with the following errors: $ patch -p1 < ../patches/macro-hover.patch patching file clang-tools-extra/clangd/Hover.

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. I fixed it locally by running `dos2unix` on the patch before applying. However, if you're able to, please update the patch to remove the Windows line endings so it can be applied with `arc patch`, otherwise the patch metadata is lost during manual application. Reposito

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

nridge updated this revision to Diff 418140. nridge added a comment. Remove clangd test, remove explicit deduction guide from clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113874/new/ https://reviews.llvm.org/D113874 Files: clang/lib/

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56a54910c597: [clang] Propagate requires-clause from constructor template to implicit… (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

nridge updated this revision to Diff 418789. nridge added a comment. address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122554/new/ https://reviews.llvm.org/D122554 Files: clang-tools-extra/clangd/Format.cpp clang-tools-extra

[PATCH] D122554: [clangd] Handle tabs in getIncrementalChangesAfterNewline()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9325e97a3599: [clangd] Handle tabs in getIncrementalChangesAfterNewline() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall added a comment. nridge updated this revision to Diff 407028. nridge updated this revision to Diff 420107. Herald added a project: All. nridge retitled this revision from "[WIP] [clangd] Attempted fix f

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. In D115187#3192034 , @sammccall wrote: > A change that probably goes along with this one is having RecursiveASTVisitor > traverse the syntactic form instead of the semantic one if traversal of > implicit code is off. I believe t

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

nridge added a comment. Sorry, I'm travelling and probably won't be able to respond promptly, but my first thought here is that this doesn't seem as well motivated as `usedAsMutableReference`, since taking a pointer to an object involves using explicit syntax (`&obj`) that taking a reference do

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

nridge added a comment. @dblaikie now that the dependent patch has been merged and (presumably) stuck, do you think we can proceed with this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 _

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08b289867b5a: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id (authored by nridge). Repository: rG LLVM Github Mon

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

nridge updated this revision to Diff 360714. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105083/new/ https://reviews.llvm.org/D105083 Files: clang-tools-e

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf443793d26c3: [clangd] Ensure Ref::Container refers to an indexed symbol (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106934: [clangd] Do not inlay hints pertaining to code in other files

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/cl

[PATCH] D121775: [clangd] Handle more than two conflicting semantic tokens in resolveConflict()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

nridge added inline comments. Herald added projects: clang-tools-extra, All. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157 +resolveConflict(ArrayRef Tokens) { + if (Tokens.size() != 2) +return llvm::None; nridge wrote: > sammccall wrote:

[PATCH] D121775: [clangd] Handle more than two conflicting semantic tokens in resolveConflict()

This revision was automatically updated to reflect the committed changes. Closed by commit rG606ba8a68f79: [clangd] Handle more than two conflicting semantic tokens in resolveConflict() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

nridge updated this revision to Diff 416827. nridge added a comment. Herald added a project: All. Now with clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113874/new/ https://reviews.llvm.org/D113874 Files: clang-tools-extra/clangd/unit

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

nridge closed this revision. nridge added a comment. Herald added a project: All. This has been committed in https://github.com/llvm/llvm-project/commit/5a6dac66db67225e2443f4e61dfe9d2f96780611. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

nridge created this revision. nridge added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

nridge added a comment. Not sure how to write a test for this, short of writing unit tests for the operator< itself. The consequence of this bug is that the sort/unique pass on the highlighting tokens is buggy, but as of https://github.com/clangd/clangd/issues/1057 `resolveConflict()` fixes up

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

nridge updated this revision to Diff 422410. nridge added a comment. Add semantic highlighting testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123478/new/ https://reviews.llvm.org/D123478 Files: clang-tools-extra/clangd/SemanticHighlighti

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5000624933e: [clangd] Fix incorrect operator< impl for HighlightingToken (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge updated this revision to Diff 423343. nridge marked 5 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115187/new/ https://reviews.llvm.org/D115187 Files: clang-tools-e

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:858 } ExprResult Awaitable = buildOperatorCoawaitCall(*this, Loc, E, Lookup); if (Awaitable.isInvalid()) sammccall wrote: > (aside, this variable name is really unfortunate: I thi

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge added a comment. Thanks for the patch! Could you add some tests to clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp as well? I wrote a bit about how the tests work on Discord, copying for convenience: > In SemanticHighlightingTests.cpp, we have code inputs which are anno

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge added a comment. I haven't looked at the patch in detail, but one high level question: have you considered the possibility of adding these highlightings during the findExplicitReferences

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

nridge added reviewers: kadircet, sammccall. nridge added a comment. Adding some potential reviewers. I'm open to testing this some way other than through clangd, but note that, while the issue is not in AST serialization code, it only trips an assertion after a serialization round-trip. Repo

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Very neat! A few minor suggestions but generally looks good. Comment at: clang-tools-extra/clangd/AST.cpp:519 + if (Spec->getTemplateSpecializationKind() != TSK_Implicit

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks, this seems useful. Comment at: clang-tools-extra/clangd/tool/Check.cpp:195 + // Build Inlay Hints for the entire AST + bool buildInlayHints(llvm::Optional LineRan

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. Update on this: I'm working on getting the failing tests to pass. Some of them just need expected AST dumps updated to reflect the new node, but some others suggest the patch actually causes semantic regressions. Rep

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

nridge added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:201 +for (const auto &Hint : Hints) { + vlog(" {0} {1}", Hint.position, Hint.label); +} upsj wrote: > nridge wrote: > > Might be useful for print the hint kind as well

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. Here is a reduced testcase for the semantic regression: namespace std { template struct coroutine_handle { static coroutine_handle from_address(void *) noexcept; }; template struct coroutine_traits; } // end of namespace std template struct coro {

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

nridge added a comment. Let me know if you'd like me to commit the patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344/new/ https://reviews.llvm.org/D124344 ___ cfe-commits mailing list c

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

nridge added a comment. Thanks for working on this! Could you add some test cases to [InlayHintTests.cpp] to illustrate the new hint please? As in the other patch, uploading the patch with context would also be helpful for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

This revision was automatically updated to reflect the committed changes. Closed by commit rG56058b921bd9: [clangd] Output inlay hints with `clangd --check` (authored by upsj, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124344

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

nridge added reviewers: sammccall, kadircet. nridge added a comment. I'll have a proper look at this when I get a chance but meanwhile adding Sam and Kadir who may have thoughts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://rev

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. Apologies for the slow response here. This generally looks good to me, but I have a couple of suggestions regarding the formatting of the hints and handling type aliases.

<    1   2   3   4   5   6   7   8   9   10   >