[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge added a comment. Is this what you had in mind? I'm not seeing where the `kindForType` part comes in. In particular, it seems like it would be silly to call `kindForType` in `WalkUpFromDependentNameTypeLoc()`, because we //know// the answer will be `HighlightingKind::DependentType`. Re

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224453. nridge added a comment. Updated to use heuristics based on OverloadExpr::decl() Also folded VisitUnresolvedLookupExpr and VisitUnresolvedMemberExpr together into a single VisitOverloadExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 3 inline comments as done. nridge added a comment. I like how we went from using heuristics, to not using heuristics, to using heuristics again :) But admittedly, the new heuristics are more accurate because they're based on phase 1 lookup results rather than just syntax, so I'm h

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge updated this revision to Diff 224480. nridge added a comment. Updated to use as isInactive flag on SemanticHighlightingInformation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. Ok, I updated the patch to convey the line highlight separately from the token highlights. I did use the simplified approach I mentioned, where I use a single `isInactive` flag. If you'd prefer the more general approach where we send an array of line styles, I can do th

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 224483. nridge added a comment. Updated to reflect changes to server side in D67536 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537 Fi

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224767. nridge added a comment. Address final comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224880. nridge marked 2 inline comments as done. nridge added a comment. Address last review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tool

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

This revision was automatically updated to reflect the committed changes. Closed by commit rG37e31e629dc1: [clangd] Improve semantic highlighting in dependent contexts (fixes #154) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous. Herald added a project: clang. This fixes issue #163, among other improvements to go-to-definition. Repository: rG LLVM Github Monorepo htt

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked 3 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const Select

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. Review / feedback ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const Select

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge updated this revision to Diff 226372. nridge marked 4 inline comments as done. nridge added a comment. Removed constructor handling, deferring that to a follow-up Addressed other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69237/n

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:147 } + while ((N = N->Parent)) { +if (N->ASTNode.get() || N->ASTNode.get() || sammccall wrote: > nridge wrote: > > This part is a super

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const Select

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added a comment. So, to summarize my understanding of the way forward here: 1. Land the refactoring without any constructor targeting (i.e. the current patch, which is ready to review in this state). 2. In a follow-up patch: target constructor in c

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge updated this revision to Diff 226561. nridge added a comment. Updated not to use the beginning-of-identifier location as input to SelectionTree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69237/new/ https://reviews.llvm.org/D69237 Files:

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge added a comment. In D69237#1722399 , @nridge wrote: > So, to summarize my understanding of the way forward here: > > 1. Land the refactoring without any constructor targeting (i.e. the current > patch, which is ready to review in this state). > 2.

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge updated this revision to Diff 226563. nridge added a comment. Addressed nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 279051. nridge marked 9 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-ext

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:214 } + if (const auto *CE = dyn_cast(E)) { +const auto *CalleeType = resolveDependentExprToType(CE->getCallee()); hokein wrote: > btw, could you try the case below? it does

[PATCH] D84122: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/463. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84122 Files:

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. There were two problems here: - RecursiveASTVisitor did not traverse TypeConstraint::ImmediatelyDeclaredConstraint - ConceptSpecial

[PATCH] D84122: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector

nridge updated this revision to Diff 279424. nridge marked an inline comment as done. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84122/new/ https://reviews.llvm.org/D84122 Files: clang-tools-extra/clangd/Fi

[PATCH] D84122: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector

This revision was automatically updated to reflect the committed changes. Closed by commit rG100dbd15624c: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 279426. nridge marked 5 inline comments as done. nridge added a comment. Address remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG9946dcd3e9c7: [clangd] Improve heuristic resolution of dependent types in TargetFinder (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D82739?vs=279426&id=279427#toc Repository:

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

nridge added a comment. Is there some additional context for what this patch is aiming to do? The description sounds interesting but I don't really understand it. What is a "feature" in this context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:132 +// there may not be a template argument list. +return ArgsAsWritten->RAngleLoc.isValid() ? ArgsAsWritten->RAngleLoc +

[PATCH] D84461: [Concepts] Fix ast dump for immediately declared constraint.

nridge added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:4 +template +concept not_same_as = true; + nit: perhaps use a more generic name like `binary_concept` (meaning concept that takes two types) Repository: rG LLVM Github Monorepo

[PATCH] D84461: [Concepts] Fix ast dump for immediately declared constraint.

nridge added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:12 + template R> + Foo(R) requires(true); +}; another nit: the `requires(true)` is not relevant to the testcase. (Although, perhaps it is another bug that it does not appear in the

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

nridge added a comment. Spun off from D84136 . Depends on D84461 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84613/new/ https://reviews.llvm.org/D84613 __

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

nridge created this revision. nridge added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. It returned an invalid location in case of a constrained-parameter with no explicit arguments. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge updated this revision to Diff 280771. nridge marked an inline comment as done. nridge added a comment. Spun off the source-location issue to D84613 . Some other review comments remain to be addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint())); TRY_TO(TraverseConceptRe

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge updated this revision to Diff 280797. nridge marked an inline comment as done. nridge added a comment. Herald added a subscriber: mgorny. Finish addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://revi

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:426 + + // constrained-parameter + Code = R"cpp( I'd like to keep this clangd-specific test coverage as I think it's valuab

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

nridge updated this revision to Diff 281123. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84613/new/ https://reviews.llvm.org/D84613 Files: clang/include/clang/AST/ExprConcepts.h clang/test/AST/a

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89247792c5bd: [clang] Fix ConceptSpecializationExpr::getEndLoc() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D84837: [clangd] Fix an assertion failure in TargetFinder's heuristic resolution of dependent type.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:171 // or more declarations that it likely references. -std::vector resolveDependentExprToDecls(const Expr *E) {

[PATCH] D84455: [Concepts] Fix a deserialization crash.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. In D84455#2170461 , @hokein wrote: > btw, `getTypeConstraint` and `hasTypeConstraint` APIs are quite easy to be > misused (there is another similar bug

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the PCH

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b3b7556e9ab: [clang] Persist Attr::IsPackExpansion into the PCH (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77194/new/ https://revi

[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

nridge added a comment. > Tested in VSCode insiders (with a patched client to enable experimental > features). In case it's useful to others: the required change to the client to opt into this appears to be calling `registerProposedFeatures()` on the `LanguageClient` object. Repository: rG

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D76896: Color dependent names based on their heuristic target if they have one

nridge added reviewers: sammccall, kadircet, hokein. nridge added a comment. Adding some reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 ___ cfe-comm

[PATCH] D77702: [clangd] Use token modifiers and more token types for semanticTokens

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The intention here is to allow clients to continue using a different color for each of our Highli

[PATCH] D77702: [clangd] Use token modifiers and more token types for semanticTokens

nridge added a comment. Thanks for your thoughts! In D77702#1972495 , @sammccall wrote: > Some context for me: I did also start some work on supporting modifiers, and > after some experiments with VSCode concluded it was too early (no support in > any s

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

nridge updated this revision to Diff 256502. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 Files: clang-tools-ext

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157 +resolveConflict(ArrayRef Tokens) { + if (Tokens.size() != 2) +return llvm::None; sammccall wrote: > why a limit of 2, vs a loop? I'm not aware of a scenario wher

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

This revision was automatically updated to reflect the committed changes. Closed by commit rGd83541d1b8f7: [clangd] Color dependent names based on their heuristic target if they have one (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D76896?vs=257596&id=257597#toc Repo

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

nridge updated this revision to Diff 257596. nridge added a comment. Address final review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 Files: clang-tools-extra/clangd/FindTarget.cpp clang-too

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

nridge updated this revision to Diff 270769. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81845/new/ https://reviews.llvm.org/D81845 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/clangd

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG7759f70fb0ee: [clangd] Support typeHierarchy/resolve for children of parents as well (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8184

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

nridge added a comment. In D81845#2093056 , @sammccall wrote: > May have broken tests: > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/30458/steps/test-check-all/logs/FAIL%3A%20Clangd%3A%3A%20type-hierarchy.test Sorry about that, pus

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge added reviewers: sammccall, kadircet, hokein. nridge added a comment. Adding some reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 ___ cfe-comm

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Two helpers are introduced: - Some of the logic previously in TargetFinder::Visit*() methods is fac

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge marked an inline comment as done. nridge added a comment. In D82739#2133155 , @hokein wrote: > looks like we use this heuristic for go-to-def, I think we might want to use > it in more places, e.g. libindex (for xrefs), sema code completion (so th

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 276320. nridge added a comment. Split patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/u

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge added a comment. Split out the refactoring into D83371 which this depends on now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

nridge updated this revision to Diff 276321. nridge added a comment. Improve patch split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83371/new/ https://reviews.llvm.org/D83371 Files: clang-tools-extra/clangd/FindTarget.cpp Index: clang-tools-

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 276322. nridge added a comment. Improve patch split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

nridge updated this revision to Diff 276911. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83371/new/ https://reviews.llvm.org/D83371 Files: clang-tools-ext

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG98d763ad051f: [clangd] Factor out some helper functions related to heuristic resolution in… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:196 switch (E->getStmtClass()) { case Stmt::CXXDependentScopeMemberExprClass: { const auto *ME = llvm::cast(E); hokein wrote: > I'm doubting whether we will miss some oth

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 276916. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-ext

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This will be needed to support call hierarchy Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge added a comment. (As per discussion in https://github.com/clangd/clangd/issues/162#issuecomment-648923948 onwards.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge added a comment. In D83536#2143436 , @kadircet wrote: > I can see how this is needed for implementing the full protocol though (we've > already cut on the multi-level callees support), so would you be so kind to > hide this behind an option to sym

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/441 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82739 Files: clang-too

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks, Sam, this looks great! Comment at: clang-tools-extra/clangd/SourceCode.cpp:883 +static bool isLikelyIdentifier(llvm::StringRef Word, StringRef Before, +

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

nridge added a comment. Is there an easy wasy to transplant patches written against the old repo, into the new one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78598/new/ https://reviews.llvm.org/D78598 ___

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge updated this revision to Diff 259160. nridge added a comment. Rebase on top of D75479 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 Files: clang-tools-extra/clan

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge updated this revision to Diff 259483. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 Files: clang-tools-ext

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:569 ASTResults = locateASTReferent(NearbyIdent->location(), NearbyIdent, AST, - *MainFilePath, Index); + *MainFilePath, Inde

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. nridge added a comment. Applies on top of D76451 . Depends on

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge added a comment. Applies on top of D76451 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78784/new/ https://reviews.llvm.org/D78784 ___ cfe-commits mailing list

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge added a comment. The intent is to be able to run a production build on a production codebase and see why a particular instance of navigation failed. However, it's not super important that this land; if you don't think it's useful for others, I can just run with it applied locally. Repo

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

This revision was automatically updated to reflect the committed changes. Closed by commit rG230cae89db3f: [clangd] Enable textual fallback for go-to-definition on dependent names (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge added a comment. (This should be ready for another round of review.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 ___ cfe-commits mailing list cfe-commi

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added a subscriber: ilya-biryukov. Fixes https://github.com/clangd/clangd/is

[PATCH] D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/ast-dump-concepts.cpp:18 // CHECK: TemplateTypeParmDecl {{.*}} referenced Concept {{.*}} 'binary_concept' - // CHECK-NEXT: |-ConceptS

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

nridge updated this revision to Diff 282804. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85108/new/ https://reviews.llvm.org/D85108 Files: clang-tools-extra/clangd/unittests/FindTargetTests.cpp

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

nridge updated this revision to Diff 282805. nridge added a comment. Rebase to avoid dependency on D84136 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85108/new/ https://reviews.llvm.org/D85108 Files: clang-too

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ede39684981: [clang] Include trailing-requires-clause in FunctionDecl's source range (authored by nridge). Repository: rG LLVM Github Monorepo C

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge updated this revision to Diff 282807. nridge added a comment. Rebase on top of D85108 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 Files: clang-tools-extra/clan

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint())); TRY_TO(TraverseConceptReference(*TC)); hokein wr

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge updated this revision to Diff 283134. nridge added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang-tools-extra/cl

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge planned changes to this revision. nridge added a comment. Still need to add the flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 ___ cfe-commits maili

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305 + break; +default:; +} hokein wrote: > nit: move the trailing `;` to a new line. I have done this, but clang-format moves it back... do we really want to

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge added a comment. This patch has helped me understand the difference between the two `ConceptReference`s in the AST (the `TypeConstraint` and the `ConceptSpecializationExpr`). Given that `template R>` is a shorthand for `template requires binary_concept` the `TypeConstraint` is the

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:18 // CHECK: TemplateTypeParmDecl {{.*}} referenced Concept {{.*}} 'binary_concept' - // CHECK-NEXT: |-ConceptSpecializationExpr {{.*}} 'bool' Concept {{.*}} 'binary_concept' - // CHECK-NE

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

nridge updated this revision to Diff 283784. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85272/new/ https://reviews.llvm.org/D85272 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang-tools-extr

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305 + break; +default:; +} nridge wrote: > hokein wrote: > > nit: move the trailing `;` to a new line. > I have done

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4ba7a100a56: [clangd] Semantic highlighting for dependent template name in template argument (authored by nridge). Repository: rG LLVM Github Mon

[PATCH] D85500: [clangd] Highlight structured bindings at local scope as LocalVariable

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. As part of this change, DynTypedNode is enhanced to allow storing

[PATCH] D85500: [clangd] Highlight structured bindings at local scope as LocalVariable

nridge updated this revision to Diff 283827. nridge added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85500/new/ https://reviews.llvm.org/D85500 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang

<    1   2   3   4   5   6   7   8   9   10   >