Author: chapuni
Date: Sat Sep 30 02:16:41 2017
New Revision: 314586
URL: http://llvm.org/viewvc/llvm-project?rev=314586&view=rev
Log:
clang/test/SemaCXX/ms-iunknown-template-function.cpp: Appease for targeting
*-win32.
This expects the warning;
File clang/test/SemaCXX/ms-iunknown-template-fun
On Mon, Oct 2, 2017 at 3:33 PM Andrew Gozillon via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: agozillon
> Date: Sun Oct 1 23:31:25 2017
> New Revision: 314650
>
> URL: http://llvm.org/viewvc/llvm-project?rev=314650&view=rev
> Log:
> Dependent Address Space Support Test File
>
> Ad
FYI, I tweaked the tree in rL315283. Shall we restore it?
On Tue, Oct 10, 2017 at 9:41 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard,
>
> This is breaking the boostrap stage in the internal integration. I'm
> seeing "unsupported: typedef changes linkage of anonymou
Author: chapuni
Date: Tue Oct 10 21:20:19 2017
New Revision: 315428
URL: http://llvm.org/viewvc/llvm-project?rev=315428&view=rev
Log:
ClangCodeGenTests: Update libdeps in rL315392, +clangAST.
Modified:
cfe/trunk/unittests/CodeGen/CMakeLists.txt
Modified: cfe/trunk/unittests/CodeGen/CMakeList
Author: chapuni
Date: Tue Oct 10 21:54:05 2017
New Revision: 315435
URL: http://llvm.org/viewvc/llvm-project?rev=315435&view=rev
Log:
Reorder.
Modified:
cfe/trunk/unittests/CodeGen/CMakeLists.txt
Modified: cfe/trunk/unittests/CodeGen/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/c
Author: chapuni
Date: Wed Oct 11 23:39:44 2017
New Revision: 315566
URL: http://llvm.org/viewvc/llvm-project?rev=315566&view=rev
Log:
clang/module.modulemap: Create Clang_Frontend_CodeGenOptions to remove some
dependencies in clangBasic.
- Clang_Analysis
- Clang_C
- Clang_Frontend
- Clang_Lex
-
Author: chapuni
Date: Thu Oct 12 02:42:14 2017
New Revision: 315573
URL: http://llvm.org/viewvc/llvm-project?rev=315573&view=rev
Log:
Fix warnings. [-Wdocumentation]
Modified:
cfe/trunk/lib/Lex/TokenLexer.cpp
cfe/trunk/lib/Sema/MultiplexExternalSemaSource.cpp
cfe/trunk/lib/Serializati
Author: chapuni
Date: Thu Oct 12 02:42:12 2017
New Revision: 315572
URL: http://llvm.org/viewvc/llvm-project?rev=315572&view=rev
Log:
SVal::getAsSymbol(bool IncludeBaseRegions): Follow
clang/StaticAnalyzer/Core/PathSensitive/SVals.h,
s/IncludeBaseRegion/IncludeBaseRegions/g [-Wdocumentation]
Mo
Author: chapuni
Date: Sat Oct 14 07:46:04 2017
New Revision: 315806
URL: http://llvm.org/viewvc/llvm-project?rev=315806&view=rev
Log:
Revert rL315787, "[Sema] Warn about unused variables if we can constant
evaluate the initializer."
check-libcxx dislikes it.
Modified:
cfe/trunk/lib/Sema/Sem
Author: chapuni
Date: Tue Oct 17 22:21:17 2017
New Revision: 316061
URL: http://llvm.org/viewvc/llvm-project?rev=316061&view=rev
Log:
[CMake] Use #cmakedefine01 for
CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER)
It'd be better that they are #cmakedefine01 rather than #cmakedefine.
(#if FOO r
Author: chapuni
Date: Sat Oct 21 04:02:30 2017
New Revision: 316260
URL: http://llvm.org/viewvc/llvm-project?rev=316260&view=rev
Log:
clang-tidy: Fix deps.
Modified:
clang-tools-extra/trunk/clang-tidy/CMakeLists.txt
clang-tools-extra/trunk/clang-tidy/tool/CMakeLists.txt
Modified: clang-t
Author: chapuni
Date: Sat May 27 03:06:52 2017
New Revision: 304067
URL: http://llvm.org/viewvc/llvm-project?rev=304067&view=rev
Log:
ClangdTests.cpp: Fix a possible typo, it was "if (TmpDir2 != TmpDir2)"
It caused failures in unittests if TmpDir2 is not "/tmp" .
Modified:
clang-tools-extra/
Hopefully fixed in r304067.
See also; https://reviews.llvm.org/D33416#766533
On Sat, May 27, 2017 at 6:12 AM Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Ilya,
>
> The unit test introduced by this commit hits an assertion failure on our
> bots. Could you please take a l
Author: chapuni
Date: Sat May 27 18:19:28 2017
New Revision: 304082
URL: http://llvm.org/viewvc/llvm-project?rev=304082&view=rev
Log:
ClangdTests.cpp: Use "clang/Config/config.h" instead of "llvm/Config/config.h".
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp
Modified: c
Author: chapuni
Date: Fri Jun 2 04:53:05 2017
New Revision: 304535
URL: http://llvm.org/viewvc/llvm-project?rev=304535&view=rev
Log:
clang/test/CodeGenCXX/unaligned-member-qualifier.cpp: Satisfy x86_thiscallcc.
Modified:
cfe/trunk/test/CodeGenCXX/unaligned-member-qualifier.cpp
Modified: cfe
Author: chapuni
Date: Tue Jun 6 23:48:45 2017
New Revision: 304868
URL: http://llvm.org/viewvc/llvm-project?rev=304868&view=rev
Log:
Reorder and reformat.
Modified:
cfe/trunk/lib/AST/CMakeLists.txt
Modified: cfe/trunk/lib/AST/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
Author: chapuni
Date: Tue Jun 6 23:48:49 2017
New Revision: 304869
URL: http://llvm.org/viewvc/llvm-project?rev=304869&view=rev
Log:
Update libdeps to add BinaryFormat, introduced in r304864.
Modified:
cfe/trunk/lib/AST/CMakeLists.txt
cfe/trunk/lib/Driver/CMakeLists.txt
Modified: cfe/tr
It triggered a test failure for targeting i686 (seems also for arm)
See also; http://bb.pgr.jp/builders/test-clang-i686-linux-RA/builds/3566
On Tue, Jun 13, 2017 at 6:59 AM Nick Lewycky via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nicholas
> Date: Mon Jun 12 16:59:18 2017
> New
Author: chapuni
Date: Sun Aug 27 04:46:05 2017
New Revision: 311846
URL: http://llvm.org/viewvc/llvm-project?rev=311846&view=rev
Log:
ClangCodeGenTests: Update libdeps.
Modified:
cfe/trunk/unittests/CodeGen/CMakeLists.txt
Modified: cfe/trunk/unittests/CodeGen/CMakeLists.txt
URL:
http://llvm
Author: chapuni
Date: Wed Aug 30 09:34:51 2017
New Revision: 312137
URL: http://llvm.org/viewvc/llvm-project?rev=312137&view=rev
Log:
clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise.cpp: Appease *-win32 to
add explicit triple.
Modified:
clang-tools-extra/trunk/test/clang-tidy/hicpp-si
Author: chapuni
Date: Wed Sep 13 00:58:46 2017
New Revision: 313128
URL: http://llvm.org/viewvc/llvm-project?rev=313128&view=rev
Log:
clang/lib/Driver/ToolChains/Darwin.h: Add proper style to comments.
[-Wdocumentation]
Modified:
cfe/trunk/lib/Driver/ToolChains/Darwin.h
Modified: cfe/trunk/
This triggered failure in libcxx tests.
http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux/builds/97
On Fri, Sep 15, 2017 at 8:40 AM Douglas Gregor via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dgregor
> Date: Thu Sep 14 16:38:42 2017
> New Revision: 313315
>
> URL:
h
>> wrote:
>>
>>> This is a bug in the libc++ tests. It's OK for them to check that the
>>> static_assert message is produced, but not that they're prefixed with the
>>> exact string "static_assert failed:".
>>>
>>> On 16 Se
Author: chapuni
Date: Sun Sep 17 21:55:31 2017
New Revision: 313510
URL: http://llvm.org/viewvc/llvm-project?rev=313510&view=rev
Log:
Reformat.
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/
Author: chapuni
Date: Sun Sep 17 21:55:33 2017
New Revision: 313511
URL: http://llvm.org/viewvc/llvm-project?rev=313511&view=rev
Log:
Fix a warning discovered by rL313487. [-Wunused-lambda-capture]
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp
UR
Author: chapuni
Date: Sun Sep 17 22:52:57 2017
New Revision: 313513
URL: http://llvm.org/viewvc/llvm-project?rev=313513&view=rev
Log:
Revert rL313511, "Fix a warning discovered by rL313487.
[-Wunused-lambda-capture]"
It was incompatible to msc.
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Seems fixed! Thanks!
On Mon, Sep 18, 2017 at 5:27 PM Vitaly Buka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vitalybuka
> Date: Mon Sep 18 01:26:01 2017
> New Revision: 313521
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313521&view=rev
> Log:
> Another attempt to fix warni
It seems libcxx (with -fmodules) dislikes this change. Any idea?
http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-linux/builds/238
On Fri, Sep 22, 2017 at 1:26 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Sep 21 21:25:05 2017
> New Re
Author: chapuni
Date: Mon Sep 19 19:44:45 2016
New Revision: 281954
URL: http://llvm.org/viewvc/llvm-project?rev=281954&view=rev
Log:
clang-change-namespace: Update libdeps.
FIXME: It seems clangFormat is not referred.
Modified:
clang-tools-extra/trunk/change-namespace/tool/CMakeLists.txt
M
Author: chapuni
Date: Tue Oct 4 03:32:33 2016
New Revision: 283195
URL: http://llvm.org/viewvc/llvm-project?rev=283195&view=rev
Log:
Revert r283106, "Wdocumentation fix"
It should depend on r283094 and r283182.
Modified:
cfe/trunk/lib/Analysis/CloneDetection.cpp
Modified: cfe/trunk/lib/Ana
chapuni added inline comments.
> CloneDetection.cpp:113
>/// \param VarDecl The declaration of the variable that is referenced.
>/// \param Range The SourceRange where this variable is referenced.
> + void addVariableOccurence(const VarDecl *VarDecl, const Stmt *Mention) {
You should up
Author: chapuni
Date: Sun Oct 16 18:00:18 2016
New Revision: 284352
URL: http://llvm.org/viewvc/llvm-project?rev=284352&view=rev
Log:
clang/test/CXX/conv/conv.fctptr/p1.cpp: Appease for targeting i686-win32.
error: 'error' diagnostics seen but not expected:
File clang\test\CXX\conv\conv.fct
Author: chapuni
Date: Mon Oct 17 00:08:49 2016
New Revision: 284359
URL: http://llvm.org/viewvc/llvm-project?rev=284359&view=rev
Log:
Reformat.
Modified:
clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp
Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp
Author: chapuni
Date: Mon Oct 17 00:09:58 2016
New Revision: 284360
URL: http://llvm.org/viewvc/llvm-project?rev=284360&view=rev
Log:
ClangMoveTests.cpp: Appease msc18.
clang-tools-extra\unittests\clang-move\ClangMoveTests.cpp(216) : error C2593:
'operator =' is ambiguous
llvm\includ
chapuni wrote:
I still think this is not a right way to control Bazel's build directory tree.
IMO, we should publish the tree with the archive (with filegroup), or produce
the utility shell script to construct the symlink-ed tree for one's convenience.
https://github.com/llvm/llvm-project/pull
chapuni wrote:
We should not expose prefix-less MACROs.
https://github.com/llvm/llvm-project/pull/75928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chapuni wrote:
Could we take other ways? I think they don't affect external API.
1. Detect stuff in `clang/Config/config.h`
2. Migrate the special logic to `llvm/Support`.
https://github.com/llvm/llvm-project/pull/75637
___
cfe-commits mailing list
cf
https://github.com/chapuni approved this pull request.
Thanks.
https://github.com/llvm/llvm-project/pull/76163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni requested changes to this pull request.
@JonPsson1 I don't have better suggestions right now but I guess you need
redesigning.
https://github.com/llvm/llvm-project/pull/73511
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/73511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,6 +11,7 @@
//===--===//
#include "SystemZ.h"
+#include "clang/AST/Decl.h"
chapuni wrote:
I think we should not depend on `clangAST` here.
https://github.com/llvm/llvm-project/pull/73
Author: NAKAMURA Takumi
Date: 2022-04-30T17:19:26+09:00
New Revision: a60ef98bb11378b24045372a53c55923df13ddc3
URL:
https://github.com/llvm/llvm-project/commit/a60ef98bb11378b24045372a53c55923df13ddc3
DIFF:
https://github.com/llvm/llvm-project/commit/a60ef98bb11378b24045372a53c55923df13ddc3.dif
Author: NAKAMURA Takumi
Date: 2022-07-24T09:32:34+09:00
New Revision: 944cb96429b874e5bf9c672e0013914573227fcd
URL:
https://github.com/llvm/llvm-project/commit/944cb96429b874e5bf9c672e0013914573227fcd
DIFF:
https://github.com/llvm/llvm-project/commit/944cb96429b874e5bf9c672e0013914573227fcd.dif
https://github.com/chapuni created
https://github.com/llvm/llvm-project/pull/81221
Its 0th element corresponds to `FalseID` and 1st to `TrueID`.
CoverageMappingGen.cpp: `DecisionIDPair` is replaced with `ConditionIDs`
>From 66bb6cc3fd339360c16c6a98ce08f34978f665e0 Mon Sep 17 00:00:00 2001
From
https://github.com/chapuni created
https://github.com/llvm/llvm-project/pull/81227
Introduce `MCDCDecisionParameters` and `MCDCBranchParameters` and make sure
them not initialized as zero.
FIXME: Could we make `CoverageMappingRegion` as a smart tagged union?
>From c2b49a5317bf5b8af419cba814f9
@@ -264,9 +266,10 @@ class MCDCRecordProcessor {
MCDCRecordProcessor(const BitVector &Bitmap,
const CounterMappingRegion &Region,
ArrayRef Branches)
- : Bitmap(Bitmap), Region(Region), Branches(Branches),
-NumConditions
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81227
>From c2b49a5317bf5b8af419cba814f95cc9305bec21 Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Thu, 8 Feb 2024 23:12:54 +0900
Subject: [PATCH] [MC/DC] Refactor: Make `MCDCParams` as `std::variant`
Introduce
https://github.com/chapuni created
https://github.com/llvm/llvm-project/pull/81257
Also, Let NumConditions uint16_t
>From b2e8b3eaa067844a5fa5643aca17dbb0f237182e Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Sat, 10 Feb 2024 00:08:36 +0900
Subject: [PATCH] [MC/DC] Refactor: Let MCDCCon
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81257
>From b2e8b3eaa067844a5fa5643aca17dbb0f237182e Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Sat, 10 Feb 2024 00:08:36 +0900
Subject: [PATCH 1/2] [MC/DC] Refactor: Let MCDCConditionID int16_t with
zero-or
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/81257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81221
>From 66bb6cc3fd339360c16c6a98ce08f34978f665e0 Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Fri, 9 Feb 2024 07:56:51 +0900
Subject: [PATCH 1/3] [MC/DC] Refactor: Introduce `ConditionIDs` as
`std::array<2
@@ -217,6 +217,9 @@ class CounterExpressionBuilder {
using LineColPair = std::pair;
+using MCDCConditionID = unsigned int;
+using MCDCConditionIDs = std::array;
chapuni wrote:
`first` and `second` didn't make sense to me.
https://github.com/llvm/llvm-projec
chapuni wrote:
@evodius96 As an experiment, I've made subscripts as `bool`. It works
semantically however I wonder they wouldn't be intuitive to us.
I can rewind it.
https://github.com/llvm/llvm-project/pull/81221
___
cfe-commits mailing list
cfe-com
@@ -250,18 +251,27 @@ struct CounterMappingRegion {
};
using MCDCConditionID = unsigned int;
- struct MCDCParameters {
+ struct MCDCDecisionParameters {
/// Byte Index of Bitmap Coverage Object for a Decision Region.
-unsigned BitmapIdx = 0;
+unsigned Bitmap
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81227
>From c2b49a5317bf5b8af419cba814f95cc9305bec21 Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Thu, 8 Feb 2024 23:12:54 +0900
Subject: [PATCH 1/2] [MC/DC] Refactor: Make `MCDCParams` as `std::variant`
Intro
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/81227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni commented:
@ornata I want to isolate Decision stuff and Branch stuff in `MCDCParams`.
Also I'd like to encapsulate params into each record. Once parameters are set,
they are expected to hold "valid" values. Zeroing really confused me, (possibly
us).
I've found `std::
@@ -308,13 +309,21 @@ Error
RawCoverageMappingReader::readMappingRegionsSubArray(
return Err;
if (auto Err = readIntMax(FID, std::numeric_limits::max()))
return Err;
+ if (ID == 0)
+return make_error(
+cove
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81227
>From c2b49a5317bf5b8af419cba814f95cc9305bec21 Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Thu, 8 Feb 2024 23:12:54 +0900
Subject: [PATCH 1/3] [MC/DC] Refactor: Make `MCDCParams` as `std::variant`
Intro
https://github.com/chapuni created
https://github.com/llvm/llvm-project/pull/81459
They can be also used in `clang`.
Introduce the lightweight header instead of `CoverageMapping.h`.
>From 03bab9acf5aa3bf13c2223e92dbad040202d34bd Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Mon, 12 Feb
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81459
>From 03bab9acf5aa3bf13c2223e92dbad040202d34bd Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Mon, 12 Feb 2024 18:43:56 +0900
Subject: [PATCH 1/2] [MC/DC] Refactor: Introduce `MCDCTypes.h` for the
namespac
https://github.com/chapuni created
https://github.com/llvm/llvm-project/pull/81497
This packs;
* `BitmapBytes`
* `BitmapMap`
* `CondIDMap`
Also imports `mcdc::ConditionID` and `mcdc::Parameters`.
>From 80db8d1d054933a204b8b551687f65a80ea9cafa Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Dat
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81459
>From 03bab9acf5aa3bf13c2223e92dbad040202d34bd Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Mon, 12 Feb 2024 18:43:56 +0900
Subject: [PATCH 1/3] [MC/DC] Refactor: Introduce `MCDCTypes.h` for the
namespac
chapuni wrote:
@evodius96 Thanks. I can wait for other comments for a few days.
Considerations:
* `MCDCState.h` is enough small to be embeded into `CodeGenPGO.h`. I guess it
nasty a bit if I did, though.
* `MCDCState.h` involves `CoverageMapping.h`, that is not small. It shall be
replaced with
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/81459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni closed
https://github.com/llvm/llvm-project/pull/81459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81227
>From c2b49a5317bf5b8af419cba814f95cc9305bec21 Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Thu, 8 Feb 2024 23:12:54 +0900
Subject: [PATCH 1/3] [MC/DC] Refactor: Make `MCDCParams` as `std::variant`
Intro
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/81227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni closed
https://github.com/llvm/llvm-project/pull/81227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81497
>From 80db8d1d054933a204b8b551687f65a80ea9cafa Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Tue, 13 Feb 2024 01:04:50 +0900
Subject: [PATCH] clangCodeGen: Introduce `mcdc::State` with `MCDCState.h`
This
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/81497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/81497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81221
>From 66bb6cc3fd339360c16c6a98ce08f34978f665e0 Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Fri, 9 Feb 2024 07:56:51 +0900
Subject: [PATCH 1/3] [MC/DC] Refactor: Introduce `ConditionIDs` as
`std::array<2
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/81257
>From b2e8b3eaa067844a5fa5643aca17dbb0f237182e Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Sat, 10 Feb 2024 00:08:36 +0900
Subject: [PATCH 1/2] [MC/DC] Refactor: Let MCDCConditionID int16_t with
zero-or
Author: NAKAMURA Takumi
Date: 2024-02-25T11:21:46+09:00
New Revision: cc53707a5c104eb7789829ecdb2e3ae2be1a42da
URL:
https://github.com/llvm/llvm-project/commit/cc53707a5c104eb7789829ecdb2e3ae2be1a42da
DIFF:
https://github.com/llvm/llvm-project/commit/cc53707a5c104eb7789829ecdb2e3ae2be1a42da.dif
Author: NAKAMURA Takumi
Date: 2024-02-25T18:33:53+09:00
New Revision: 1f6a347c8abf8868fb4630c404480226c2efc2c2
URL:
https://github.com/llvm/llvm-project/commit/1f6a347c8abf8868fb4630c404480226c2efc2c2
DIFF:
https://github.com/llvm/llvm-project/commit/1f6a347c8abf8868fb4630c404480226c2efc2c2.dif
Author: NAKAMURA Takumi
Date: 2024-02-26T16:44:19+09:00
New Revision: 0c7a605ada6cb392e6e8c16dbccf2b7e59017399
URL:
https://github.com/llvm/llvm-project/commit/0c7a605ada6cb392e6e8c16dbccf2b7e59017399
DIFF:
https://github.com/llvm/llvm-project/commit/0c7a605ada6cb392e6e8c16dbccf2b7e59017399.dif
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/82448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni ready_for_review
https://github.com/llvm/llvm-project/pull/82448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/82448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni commented:
TODO:
* Version bump in file formats (wip)
* Update documents
https://github.com/llvm/llvm-project/pull/82448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
@@ -973,9 +970,11 @@ void InstrLowerer::lowerMCDCTestVectorBitmapUpdate(
auto *MCDCCondBitmapAddr = Update->getMCDCCondBitmapAddr();
auto *BitmapAddr = getBitmapAddress(Update);
- // Load Temp Val.
+ // Load Temp Val + BitmapIdx.
// %mcdc.temp = load i32, ptr %mcdc.a
@@ -1201,19 +1197,22 @@ void CodeGenPGO::emitMCDCCondBitmapUpdate(CGBuilderTy
&Builder, const Expr *S,
// Extract the ID of the condition we are setting in the bitmap.
const auto &Branch = BranchStateIter->second;
assert(Branch.ID >= 0 && "Condition has no ID!");
+ asse
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/82448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1128,9 +1122,11 @@ void CodeGenPGO::emitMCDCParameters(CGBuilderTy
&Builder) {
// Emit intrinsic representing MCDC bitmap parameters at function entry.
// This is used by the instrumentation pass, but it isn't actually lowered to
// anything.
- llvm::Value *Args[3]
@@ -1201,19 +1197,22 @@ void CodeGenPGO::emitMCDCCondBitmapUpdate(CGBuilderTy
&Builder, const Expr *S,
// Extract the ID of the condition we are setting in the bitmap.
const auto &Branch = BranchStateIter->second;
assert(Branch.ID >= 0 && "Condition has no ID!");
+ asse
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/82448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/82448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1503,38 +1527,53 @@ struct CounterCoverageMappingBuilder
}
// Create Branch Region around condition.
-createBranchRegion(S->getCond(), BodyCount,
- subtractCounters(CondCount, BodyCount));
+if (!llvm::EnableSingleByteCoverage)
+ c
chapuni wrote:
This works for me if #78033 is fixed or reverted.
https://github.com/llvm/llvm-project/pull/76950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1973,6 +1981,8 @@ struct CounterCoverageMappingBuilder
void VisitBinLAnd(const BinaryOperator *E) {
bool IsRootNode = MCDCBuilder.isIdle();
+MCDCDebugCounter++;
chapuni wrote:
I didn't understand the strategy to assign it.
https://github.com/ll
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/80098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -246,16 +248,18 @@ void CoverageMappingWriter::write(raw_ostream &OS) {
encodeULEB128(unsigned(I->MCDCParams.ID), OS);
encodeULEB128(unsigned(I->MCDCParams.TrueID), OS);
encodeULEB128(unsigned(I->MCDCParams.FalseID), OS);
+ encodeULEB128(unsigned(I->MC
https://github.com/chapuni requested changes to this pull request.
I suppose this is still a draft.
https://github.com/llvm/llvm-project/pull/80098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -857,6 +857,8 @@ struct CounterCoverageMappingBuilder
unsigned getRegionBitmap(const Stmt *S) { return MCDCBitmapMap[S]; }
+ unsigned long MCDCDebugCounter;
chapuni wrote:
What is its preferable name? I guess you expects unique ID for debug for now.
h
chapuni wrote:
See also, #78920, I guess it is also relevant to you.
https://github.com/llvm/llvm-project/pull/80098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ManuelvOK
Date: 2024-02-02T18:04:24+09:00
New Revision: c07fcd45f140bb95fb0f1ed10468db2bb6b1a77b
URL:
https://github.com/llvm/llvm-project/commit/c07fcd45f140bb95fb0f1ed10468db2bb6b1a77b
DIFF:
https://github.com/llvm/llvm-project/commit/c07fcd45f140bb95fb0f1ed10468db2bb6b1a77b.diff
LOG
chapuni wrote:
I have restored this since our issue has been resolved in #80292.
https://github.com/llvm/llvm-project/pull/76950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/80676
>From d168e0cb85eb150caa7ab241f136c5a23f79ba38 Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Mon, 5 Feb 2024 00:33:40 +0900
Subject: [PATCH 1/4] Implement MCDCTVIdxBuilder and MCDCTestVectorBuilder
(LLVM
chapuni wrote:
I reworked to align the current implementation.
https://github.com/llvm/llvm-project/pull/80676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 693 matches
Mail list logo
