[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. Could you just rebase, I'm not getting a clean merge of ClangFormatStyleOptions.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765 ___

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:17 +PLURALS_FILE = os.path.join(os.path.dirname(__file__), 'plurals.txt') +print(f'generated plurals (for yaml type) are stored in {PLURALS_FILE}') +print('you can use `git checkout -- plurals

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. I still think the printing is unnecessary, tell me when the plurals will be different otherwise keep quiet? otherwise, it confuses people making them think they have to do something Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D109557: Adds an AlignCloseBracket option

MyDeveloperDay added a comment. Please resubmit the patch with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___ cfe-commits mailing list cfe-com

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. I think the relevance of Left/Right East/West as a setting is less important, as its more about an ordering, allowing some tokens to go to the Left and some to the Right of the "type" QualifierAlignment: Custom QualifierOrder: [ inline, static, type, const,

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 372292. MyDeveloperDay added a comment. QualifierAlignmentFixer need to process all the Left/Right passes internally before return the fixes on the original code. So now QualifierAlignmentFixer has its own inner set of passes which will be processed,

[PATCH] D109557: Adds an AlignCloseBracket option

MyDeveloperDay added a comment. This isn't really `AlignCloseBracket` but `BreakBeforeClosingParen` isn't it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 __

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 372430. MyDeveloperDay added a comment. Allow more QualifierFixer functions to be directly tested, remove some older commented code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/doc

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2101 +**CVQualifierAlignment** (``CVQualifierAlignmentStyle``) + Different ways to arrange const/volatile qualifiers. curd

[PATCH] D105701: [clang-format] test revision (NOT FOR COMMIT) to demonstrate east/west const fixer capability

MyDeveloperDay updated this revision to Diff 372460. MyDeveloperDay added a comment. Herald added subscribers: dexonsmith, jdoerfert, sstefan1, mgrang, martong, aheejin, dschuff. Herald added a reviewer: shafik. Herald added a reviewer: jdoerfert. Further Demonstration of D69764: [clang-format] A

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I guess this will prevent member functions in classes being treated as K&R functions right? if thats the case them this LGTM Repository: rG LLVM Github Monorepo CHANGES SIN

<    20   21   22   23   24   25