[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

miyuki created this revision. miyuki added reviewers: eli.friedman, olista01, SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. On targets that do not support FP16 natively LLVM currently legalizes vectors of FP16 values by scalarizing them and pro

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

miyuki updated this revision to Diff 160121. miyuki edited the summary of this revision. miyuki added a comment. Fix handling of homogeneous aggregates of FP16 vectors https://reviews.llvm.org/D50507 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/arm-vfp16-arguments.c test/CodeGen/arm_neo

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

miyuki updated this revision to Diff 160317. miyuki added a comment. Handle return of homogeneous aggregates https://reviews.llvm.org/D50507 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/arm-vfp16-arguments.c test/CodeGen/arm_neon_intrinsics.c Index: test/CodeGen/arm_neon_intrinsics.c =

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

miyuki added a comment. ping https://reviews.llvm.org/D50507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

This revision was automatically updated to reflect the committed changes. Closed by commit rC342034: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D50507 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D52036: [Analyzer] Make plist tests less fragile

miyuki created this revision. miyuki added reviewers: NoQ, dcoughlin, george.karpenkov. Herald added subscribers: Szelethus, mikhail.ramalho, a.sidorin, szepet, eraman, xazax.hun. A recent change https://reviews.llvm.org/D50545 started using diff to compare plist output against reference output.

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

miyuki updated this revision to Diff 165469. miyuki retitled this revision from "[Analyzer] Make plist tests less fragile" to "[Analyzer] Use diff_plist in tests, NFC". miyuki edited the summary of this revision. miyuki added a comment. Use a different approach (suggested by Artem). https://rev

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

miyuki added a comment. ping https://reviews.llvm.org/D42545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

miyuki added a comment. ping^3 https://reviews.llvm.org/D41992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

miyuki updated this revision to Diff 132974. miyuki added a comment. Removed the changes that are unrelated to the 'enum->float' case from the test. https://reviews.llvm.org/D42545 Files: lib/Sema/SemaOverload.cpp test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp Index: test/CXX/dcl.decl

[PATCH] D42969: [Sema] Fix decltype of static data members

miyuki created this revision. miyuki added reviewers: faisalv, rsmith. miyuki edited the summary of this revision. According to the C++11 standard [dcl.type.simple]p4: The type denoted by decltype(e) is defined as follows: - if e is an unparenthesized id-expression or an unparenthesized c

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added a comment. ping^3 https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX324596: [libcxx] Avoid spurious construction of valarray elements (authored by miyuki, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D41992 Files: include/valarray test/std/n

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki updated this revision to Diff 133408. miyuki added a comment. Added a test for __sqr https://reviews.llvm.org/D41629 Files: include/complex test/libcxx/numerics/complex.number/__sqr.pass.cpp test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp test/std/numerics

[PATCH] D42969: [Sema] Fix decltype of static data members

This revision was automatically updated to reflect the committed changes. Closed by commit rC325117: [Sema] Fix decltype of static data members (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D42969 Files: lib/Sema/SemaType.cpp test/CXX/dcl.dcl/dcl.spec/

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

miyuki added a comment. ping https://reviews.llvm.org/D42545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

miyuki added a comment. ping https://reviews.llvm.org/D42693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added a comment. Herald added a subscriber: christof. ping https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added a comment. No, I'll commit it myself. Thank you for the review. https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX325510: [libcxx] Improve accuracy of complex asinh and acosh (authored by miyuki, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D41629 Files: include/complex test/libcxx/numer

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

miyuki added a comment. In https://reviews.llvm.org/D42545#1010335, @rogfer01 wrote: > Do you plan to submit (in another change) the unscoped enum → integer type > testcases? If this is not currently tested anywhere I think it may be a good > thing to have them too. Yes, I'll submit them in a

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

This revision was automatically updated to reflect the committed changes. Closed by commit rC325668: [Sema] Classify conversions from enum to float as narrowing (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D42545 Files: lib/Sema/SemaOverload.cpp test/

[PATCH] D43572: [Sema] Improve test coverage of narrowing conversion diagnostics

miyuki created this revision. miyuki added reviewers: faisalv, rsmith. This patch adds tests of narrowing conversion diagnostics for the 'unscoped enum -> integer' case.q https://reviews.llvm.org/D43572 Files: test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp Index: test/CXX/dcl.decl/dcl.i

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

miyuki created this revision. miyuki added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Certain C libraries require configuration macros defined in __config to provide the correct functionality for libc++. This patch ensures that the C header math.h is always included after the __conf

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

This revision was automatically updated to reflect the committed changes. Closed by commit rL325760: [libcxx] Do not include the C math.h header before __config (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43579

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki updated this revision to Diff 126915. miyuki added a comment. Added a test for partial specialization. https://reviews.llvm.org/D41179 Files: lib/Sema/SemaTemplate.cpp test/SemaTemplate/class-template-spec.cpp test/SemaTemplate/function-template-specialization.cpp Index: test/Sem

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

miyuki updated this revision to Diff 127324. miyuki added a comment. Merged two diagnostics into one https://reviews.llvm.org/D40705 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseTemplate.cpp test/CXX/temp/temp.param/p2-cpp11.cpp test/CXX/temp/temp.param/p2.cpp Ind

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

miyuki added a comment. I don't have commit access. Please commit the patch on my behalf. https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

miyuki added a comment. I would appreciate, if you make those changes (because I'm very new to Clang and I'm not sure that I understand how to move these checks to Sema correctly). https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-co

[PATCH] D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!)

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing the patch. Repository: rC Clang https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki updated this revision to Diff 128234. miyuki added a comment. Factored out template language linkage check into a separate function https://reviews.llvm.org/D41179 Files: lib/Sema/SemaTemplate.cpp test/SemaTemplate/class-template-spec.cpp test/SemaTemplate/function-template-special

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki added a comment. In https://reviews.llvm.org/D41179#957992, @sepavloff wrote: > Classes do not have language linkage according to 10.5p1, just as > templates, so this code is valid. > > It looks like defining templates inside extern "C" blocks is OK. Currently both Clang and GCC d

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently std::asinh and std::acosh use std::pow to compute x^2. This results in a significant error when computing e.g. asinh(i) or acosh(-1). This patch expresses x^2 directly via x.real() and x.imag(), like it is done i

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added inline comments. Comment at: test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp:59 +{ +assert(r.real() == 0); +assert(!std::signbit(r.real())); Ideally, I would prefer some approximate comparison

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki added a comment. ping https://reviews.llvm.org/D41179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43572: [Sema] Improve test coverage of narrowing conversion diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC326551: [Sema] Improve test coverage of narrowing conversion diagnostics (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D43572 Files: test/CXX/dcl.decl/dcl.init/d

[PATCH] D48021: [Driver] Add aliases for -Qn/-Qy

miyuki created this revision. miyuki added reviewers: aprantl, JDevlieghere. This patch adds aliases for -Qn (-fno-ident) and -Qy (-fident) which look less cryptic than -Qn/-Qy. The aliases are compatible with GCC. https://reviews.llvm.org/D48021 Files: CodeGen/no-ident-version.c clang/Driv

[PATCH] D48021: [Driver] Add aliases for -Qn/-Qy

This revision was automatically updated to reflect the committed changes. Closed by commit rC334414: [Driver] Add aliases for -Qn/-Qy (authored by miyuki, committed by ). Changed prior to commit: https://reviews.llvm.org/D48021?vs=150732&id=150772#toc Repository: rC Clang https://reviews.ll

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

miyuki added inline comments. Comment at: llvm/lib/IR/Value.cpp:651 if (auto *GO = dyn_cast(this)) { // Don't make any assumptions about function pointer alignment. Some // targets use the LSBs to store additional information. This comment needs to b

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rC342365: [Analyzer] Define and use diff_plist in tests, NFC (authored by miyuki, committed by ). Changed prior to commit: https://reviews.llvm.org/D52036?vs=165469&id=165732#toc Repository: rC Clang

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL342365: [Analyzer] Define and use diff_plist in tests, NFC (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52036?vs=16546

[PATCH] D57896: Variable names rule

miyuki added inline comments. Comment at: llvm/docs/CodingStandards.rst:1065 case 'J': { -if (Signed) { - Type = Context.getsigjmp_bufType(); - if (Type.isNull()) { -Error = ASTContext::GE_Missing_sigjmp_buf; +if (signed) { + type = context.getsi

[PATCH] D63437: [CodeGen][ARM] Fix FP16 vector coercion

miyuki created this revision. miyuki added reviewers: eli.friedman, olista01. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. When a function argument or return type is a homogeneous aggregate which contains an FP16 vector but the target does not support FP16 o

[PATCH] D63437: [CodeGen][ARM] Fix FP16 vector coercion

miyuki added a comment. In D63437#1546312 , @ostannard wrote: > This doesn't look like the right pace to fix this - the backend can handle > vectors of i8 and i16, which are also not legal types, so why can't it > correctly handle vectors of f16? IIRC,

[PATCH] D63437: [CodeGen][ARM] Fix FP16 vector coercion

This revision was automatically updated to reflect the committed changes. Closed by commit rL363687: [CodeGen][ARM] Fix FP16 vector coercion (authored by miyuki, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

miyuki added a comment. This caused https://bugs.llvm.org/show_bug.cgi?id=41835 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki updated this revision to Diff 142165. miyuki added a comment. Updated the test case https://reviews.llvm.org/D45255 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CodeGenModule.cpp lib/Driver/ToolChains/C

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki added a comment. One use case for this is debugging: this flag makes it easier to find out which revisions of LLVM introduce changes in codegen and/or debug information without having to filter out .ident/producer metadata. Some users can also use this flag (or an equivalent, -fno-ident)

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki added a comment. ping https://reviews.llvm.org/D45255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki added a comment. In https://reviews.llvm.org/D45255#1072200, @aprantl wrote: > Does gcc's Qy/Qn option also affect the generated debug information? No, it does not. Do you think it would be better to leave debug information unchanged as well? https://reviews.llvm.org/D45255 ___

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki updated this revision to Diff 143327. miyuki added a comment. Updated the test https://reviews.llvm.org/D45255 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CodeGenModule.cpp lib/Driver/ToolChains/Clang.

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

This revision was automatically updated to reflect the committed changes. Closed by commit rC330442: [CodeGen] Add an option to suppress output of llvm.ident (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D45255 Files: include/clang/Driver/Options.td in

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki added a comment. In https://reviews.llvm.org/D45255#1073703, @JDevlieghere wrote: > If it were the other way around I’d agree with you, but given that -Qn > becomes the default, I think we should not strip it from the debug info. No, the default is -Qy Repository: rC Clang https://

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

miyuki created this revision. miyuki added a reviewer: eli.friedman. Herald added subscribers: chrib, kristof.beyls, eraman, rengolin. Herald added a reviewer: javed.absar. The getConstraintRegister method is used by semantic checking of inline assembly statements in order to diagnose conflicts be

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

miyuki added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + thopre wrote: > From what

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

miyuki updated this revision to Diff 143732. miyuki added a comment. Added a comment for getConstraintRegister https://reviews.llvm.org/D45965 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets/AArch64.h lib/Basic/Targets/ARM.h test/Sema/arm-asm.c test/Sema/arm64-inline-asm.c

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rC331164: [Targets] Implement getConstraintRegister for ARM and AArch64 (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D45965 Files: include/clang/Basic/TargetInfo.

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-dotprod-intrinsics.c:8 +// CHECK-LABEL: test_vbfdot_f32 +// CHECK: %0 = bitcast <4 x bfloat> %a to <8 x i8> +// CHECK: %1 = bitcast <4 x bfloat> %b to <8 x i8> Why not `CHECK-NEXT`? ===

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16160 } case WebAssembly::BI__builtin_wasm_narrow_s_i8x16_i16x8: case WebAssembly::BI__builtin_wasm_narrow_u_i8x16_i16x8: This chunk does not belong to the patch

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16160 } case WebAssembly::BI__builtin_wasm_narrow_s_i8x16_i16x8: case WebAssembly::BI__builtin_wasm_narrow_u_i8x16_i16x8: miyuki wrote: > This chunk does not belong to the patch Oo

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

miyuki added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1860 + + def VGET_HIGH_BF : NoTestOpInst<"vget_high", ".Q", "b", OP_HI>; + def VGET_LOW_BF : NoTestOpInst<"vget_low", ".Q", "b", OP_LO>; dmgreen wrote: > Do you know what InstName

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

miyuki updated this revision to Diff 268162. miyuki retitled this revision from "[clang][BFloat] add create/set/get/dup intrinsics" to "[clang][BFloat] Add create/set/get/dup intrinsics". miyuki edited the summary of this revision. miyuki added a comment. Addressed reviewers' comments. CHANGES

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki added inline comments. Comment at: clang/test/CodeGen/arm-v8.6a-neon-intrinsics.c:3 +// RUN: -fallow-half-arguments-and-returns -S -disable-O0-optnone -emit-llvm -o - %s \ +// RUN: | opt -S -mem2reg \ +// RUN: | FileCheck %s Can you try -sroa after -mem2r

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-dotprod-intrinsics.c:2 +// RUN: %clang_cc1 -triple aarch64-arm-none-eabi \ +// RUN: -O2 -target-feature +neon -target-feature +bf16 \ +// RUN: -emit-llvm -o - %s | FileCheck %s Is it po

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:4675 + SDValue Ops[] = { Src, Pred, Reg0 }; + CurDAG->SelectNodeTo(N, ARM::BF16_VCVT, MVT::v4i16, Ops); + return; Why does it return `MVT::v4i16`, not `MVT::v4bf16`?

cfe-commits@lists.llvm.org

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

miyuki updated this revision to Diff 268528. miyuki added a comment. Fixed the "RUN:" line in the A32 test, implemented vduph_lane for A32. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 Files: clang/include/clang/Basic/arm_neon.td clang/li

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/test/CodeGen/arm-bf16-dotprod-intrinsics.c:2 +// RUN: %clang_cc1 -triple armv8-arm-none-eabi \ +// RUN: -O2 -target-feature +neon -target-feature +bf16 \ +// RUN: -mfloat-abi hard \ Would it be sufficient to run

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

miyuki added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:72 +ThunderX3T110, +CortexX1, +CortexA78 I think the new CPUs should be grouped with other Cortex-A CPUs. Comment at: llvm/lib/Target/ARM/ARMSubta

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

miyuki added a comment. I have reproduced the type 1 failure and I confirm that this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 ___

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

miyuki created this revision. miyuki added reviewers: stuij, labrinea, dmgreen, simon_tatham. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. miyuki added a child revision: D80928: [BFloat] Add convert/copy instrinsic support. Currently, in order t

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki updated this revision to Diff 272406. miyuki added a comment. 1. Rebased and fixed failures 2. Added a test for AArch64 codegen of lane copying intrinsics 3. Addressed reviewers' comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80928/new/ https://reviews.llvm.org/D80928 Fi

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki marked 5 inline comments as done. miyuki added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066 if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" || + Name == "vcvt_f32_f64" || Name == "vcvt_f64_f32" || LukeGeeson wrote:

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a4feb1d53df: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8220

cfe-commits@lists.llvm.org

miyuki updated this revision to Diff 272668. miyuki retitled this revision from "[AArch32]: BFloat MatMul Intrinsics&CodeGen" to "[ARM] BFloat MatMul Intrinsics&CodeGen". miyuki edited the summary of this revision. miyuki added a comment. Herald added a subscriber: danielkiss. Addressed the revie

cfe-commits@lists.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c579540ff69: [ARM] BFloat MatMul Intrinsics&CodeGen (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81740/new/ https://reviews.llvm.org

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f353a2e5a98: [BFloat] Add convert/copy instrinsic support (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D80928?vs=272406&id=272731#toc Repository: rG LLVM Github Monorepo

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, but please wait a couple more days before committing to see if anyone wants to chime in (I guess one week since the upload date should be enough). CHANGES SINCE LAST ACTION https://re

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77872/new/ https://reviews.llvm.org/D77872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78481: [ARM] Release notes for the Custom Datapath Extension (CDE)

miyuki created this revision. miyuki added reviewers: kristof.beyls, simon_tatham. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. This change mentions CDE assembly in the LLVM release notes and CDE intrinsics in both Clang and LLVM release notes. Repository:

[PATCH] D78481: [ARM] Release notes for the Custom Datapath Extension (CDE)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7ab9e7c9b30: [ARM] Release notes for the Custom Datapath Extension (CDE) (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78481/new/ htt

[PATCH] D85010: [clang][ARM] Add name-mangling test for direct __fp16 arguments.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. The mangling agrees with https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling-builtin LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

miyuki added a comment. For intrinsics that are plain functions (not macros) you could just check the signatures using assignments to function pointers, e.g.: #include uint16_t (*fp1)(int32_t) = &vqmovuns_s32; $ clang -target=aarch64-arm-none-eabi -march=armv8-a+simd -c neon.c -fsynta

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki created this revision. miyuki added reviewers: dmgreen, simon_tatham, ostannard. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. miyuki requested review of this revision. This patch adjusts the following ARM/AAr

[PATCH] D40415: [libcxx

miyuki created this revision. Herald added a reviewer: EricWF. https://reviews.llvm.org/D40415 Files: include/iterator test/std/iterators/stream.iterators/istream.iterator/istream.iterator.ops/equal.pass.cpp Index: test/std/iterators/stream.iterators/istream.iterator/istream.iterator.ops/

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

miyuki added a comment. In https://reviews.llvm.org/D40415#934939, @EricWF wrote: > LGTM. Thanks. I don't have write access. Please commit the patch on my behalf. https://reviews.llvm.org/D40415 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

miyuki created this revision. [Parser] Diagnose storage classes in template parameter declarations According to the C++ Standard [temp.param]p2: A storage class shall not be specified in a template-parameter declaration. This patch implements a diagnostic for this restriction. https://rev

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

miyuki created this revision. [libcxx] Fix basic_stringbuf constructor The C++ Standard [stringbuf.cons]p1 defines the effects of the basic_stringbuf constructor that takes ios_base::openmode as follows: Effects: Constructs an object of class basic_stringbuf, initializing the base class with

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

miyuki updated this revision to Diff 125119. miyuki added a comment. Use explicit lambda capture list. https://reviews.llvm.org/D40705 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseTemplate.cpp test/CXX/temp/temp.param/p2.cpp Index: test/CXX/temp/temp.param/p2.cpp ==

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

miyuki added a comment. Ping https://reviews.llvm.org/D40415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

miyuki added a comment. Ping https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

miyuki added a comment. Ping https://reviews.llvm.org/D40707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

miyuki added a comment. In https://reviews.llvm.org/D40415#950793, @rogfer01 wrote: > Hi @miyuki I can commit it. Please do so. https://reviews.llvm.org/D40415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

miyuki updated this revision to Diff 126325. miyuki added a comment. Added a test for thead_local. https://reviews.llvm.org/D40705 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseTemplate.cpp test/CXX/temp/temp.param/p2-cpp11.cpp test/CXX/temp/temp.param/p2.cpp Index

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

miyuki updated this revision to Diff 126738. miyuki added a comment. Modified the test to use NULL instead of literal zero. https://reviews.llvm.org/D40707 Files: include/sstream test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp Index: test/std/input.output/s

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

miyuki updated this revision to Diff 126739. miyuki added a comment. Use diff with context. https://reviews.llvm.org/D40707 Files: include/sstream test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp Index: test/std/input.output/string.streams/stringbuf/stringbu

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki created this revision. miyuki added reviewers: faisalv, rsmith, rogfer01. [Sema] Diagnose template specializations with C linkage According to the C++ standard, templates as well as their specializations cannot have C language linkage. Clang currently does not diagnose function template sp

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

miyuki added a comment. Yes, I don't have write access. https://reviews.llvm.org/D40707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7021 + // C++ [temp]p6: + // A template, a template explicit specialization, and a class template + // partial specialization shall not have C linkage. rogfer01 wrote: > Can you add a test

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

miyuki added a comment. Thanks for fixing the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

  1   2   3   >