[clang-tools-extra] [clang-tidy] Add fix-its to `readability-avoid-return-with-void-value` check (PR #81420)

2024-04-25 Thread Mike Rice via cfe-commits
Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= Message-ID: In-Reply-To: @@ -42,10 +44,30 @@ void AvoidReturnWithVoidValueCheck::check( const auto *VoidReturn = Result.Nodes.getNodeAs("void_return"); if (IgnoreMacros &

[clang-tools-extra] [clang-tidy] Ensure nullable variable is not accessed without validity test (PR #90173)

2024-04-26 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/90173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][NFC] Remove executable cases from declaration switch (PR #106438)

2024-08-28 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/106438 The executable directives are handled earlier. >From 3a7f341c33c0f91f2ca6f31762e71fcae6f1a69d Mon Sep 17 00:00:00 2001 From: Mike Rice Date: Wed, 28 Aug 2024 11:38:12 -0700 Subject: [PATCH] [OpenMP][NFC] R

[clang] [OpenMP][NFC] Remove executable cases from declaration switch (PR #106438)

2024-08-28 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/106438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] Replace unchecked dyn_cast with cast (PR #98948)

2024-07-15 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/98948 BI__builtin_hlsl_elementwise_rcp is only invoked with a FixedVectorType so use cast to make this clear and satisfy the static verifier. >From 68b271a07bea190e515fb24e1ec0a833624078bc Mon Sep 17 00:00:00 200

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #87278)

2024-05-09 Thread Mike Rice via cfe-commits
@@ -6135,6 +6137,79 @@ processImplicitMapsWithDefaultMappers(Sema &S, DSAStackTy *Stack, } } +namespace { +/// A 'teams loop' with a nested 'loop bind(parallel)' or generic function +/// call in the associated loop-nest cannot be a 'parallel for'. +class TeamsLoopChecker fi

[clang] [clang] Fix compile-time regression from attribute arg checking change (PR #101768)

2024-08-02 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/101768 In 2acf77f987331c05520c5bfd849326909ffce983 code was added to use the 'full' name including syntax and scope. Instead of building up a large string for each name, add syntax and scope checks to the value

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-08-03 Thread Mike Rice via cfe-commits
mikerice1969 wrote: Proposed fix for compile-time regression https://github.com/llvm/llvm-project/pull/101768 https://github.com/llvm/llvm-project/pull/3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang] Fix compile-time regression from attribute arg checking change (PR #101768)

2024-08-06 Thread Mike Rice via cfe-commits
mikerice1969 wrote: Thanks @nikic! https://github.com/llvm/llvm-project/pull/101768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix compile-time regression from attribute arg checking change (PR #101768)

2024-08-06 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/101768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3d5b9fb - [OpenMP] Fix problems with the declare variant append_args clause

2022-01-14 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2022-01-14T11:09:27-08:00 New Revision: 3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580 URL: https://github.com/llvm/llvm-project/commit/3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580 DIFF: https://github.com/llvm/llvm-project/commit/3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580.diff LOG

[clang] 2d0bf14 - [clang] Cleanup unneeded Function nullptr checks [NFC]

2021-12-16 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2021-12-16T08:28:10-08:00 New Revision: 2d0bf14397276d1ece9db1eb1858a644aad77ff2 URL: https://github.com/llvm/llvm-project/commit/2d0bf14397276d1ece9db1eb1858a644aad77ff2 DIFF: https://github.com/llvm/llvm-project/commit/2d0bf14397276d1ece9db1eb1858a644aad77ff2.diff LOG

[clang] 410f09a - [OPENMP51]Initial support for the interop directive.

2021-03-17 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2021-03-17T09:42:07-07:00 New Revision: 410f09af09b9261f51663773bee01ec7b37e8fd4 URL: https://github.com/llvm/llvm-project/commit/410f09af09b9261f51663773bee01ec7b37e8fd4 DIFF: https://github.com/llvm/llvm-project/commit/410f09af09b9261f51663773bee01ec7b37e8fd4.diff LOG

[clang] c615927 - [OPENMP51]Initial support for the use clause.

2021-03-17 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2021-03-17T15:46:14-07:00 New Revision: c615927c8e38d8608d7b5fa294a25dc44df0eb68 URL: https://github.com/llvm/llvm-project/commit/c615927c8e38d8608d7b5fa294a25dc44df0eb68 DIFF: https://github.com/llvm/llvm-project/commit/c615927c8e38d8608d7b5fa294a25dc44df0eb68.diff LOG

[clang] c2f8e15 - [OPENMP51]Support for the 'destroy' clause with interop variable.

2021-03-18 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2021-03-18T09:12:56-07:00 New Revision: c2f8e158f57c173298ac39db8fd44211604ed003 URL: https://github.com/llvm/llvm-project/commit/c2f8e158f57c173298ac39db8fd44211604ed003 DIFF: https://github.com/llvm/llvm-project/commit/c2f8e158f57c173298ac39db8fd44211604ed003.diff LOG

[clang] b7899ba - [OPENMP51]Initial support for the dispatch directive.

2021-03-30 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2021-03-30T14:12:53-07:00 New Revision: b7899ba0e8b7a7b8fbab06a8b3f2d70f16d7a250 URL: https://github.com/llvm/llvm-project/commit/b7899ba0e8b7a7b8fbab06a8b3f2d70f16d7a250 DIFF: https://github.com/llvm/llvm-project/commit/b7899ba0e8b7a7b8fbab06a8b3f2d70f16d7a250.diff LOG

[clang] 2165c0d - [OPENMP][DOCS]Update status of the supported constructs, NFC.

2021-04-02 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2021-04-02T12:31:36-07:00 New Revision: 2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f URL: https://github.com/llvm/llvm-project/commit/2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f DIFF: https://github.com/llvm/llvm-project/commit/2165c0d389c0b8f7dfd383ea6abd0d9b5d2ee07f.diff LOG

[clang] fb4c451 - [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'

2021-10-13 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2021-10-13T09:34:09-07:00 New Revision: fb4c451001d06c600394382e2c6ad6872f78f646 URL: https://github.com/llvm/llvm-project/commit/fb4c451001d06c600394382e2c6ad6872f78f646 DIFF: https://github.com/llvm/llvm-project/commit/fb4c451001d06c600394382e2c6ad6872f78f646.diff LOG

[clang] d869939 - [OPENMP51]Initial parsing/sema for append_args clause for 'declare variant'

2021-10-25 Thread Mike Rice via cfe-commits
Author: Mike Rice Date: 2021-10-25T09:38:50-07:00 New Revision: d8699391a431af5730fe36ac4b05840020c42203 URL: https://github.com/llvm/llvm-project/commit/d8699391a431af5730fe36ac4b05840020c42203 DIFF: https://github.com/llvm/llvm-project/commit/d8699391a431af5730fe36ac4b05840020c42203.diff LOG

[clang] [clang][OpenMP] Fix teams nesting of region check (PR #94806)

2024-06-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/94806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Fix error handling of the adjust_args clause (PR #94696)

2024-06-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/94696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 edited https://github.com/llvm/llvm-project/pull/94691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-24 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 commented: I both like and hate the huge fully-covered switches we have. I like when I add new directives and know exactly where to add code. I hate having to read code like this though. Seems like this is going in the right direction. https://github.com/llvm/ll

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-24 Thread Mike Rice via cfe-commits
@@ -2374,86 +2374,209 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-24 Thread Mike Rice via cfe-commits
@@ -2374,86 +2374,209 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-06-24 Thread Mike Rice via cfe-commits
@@ -1117,6 +1118,31 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling, if (isImaginary) break; // Cannot be repeated. isImaginary = true; continue; // Success. +case '_': + if (isFPConstant) +break; // Invalid for floats

[clang] [NFC][clang] Replace unreachable code in literal processing with assert (PR #96579)

2024-06-25 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/96579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2