Author: mikerice
Date: Fri Aug 17 14:16:21 2018
New Revision: 340082
URL: http://llvm.org/viewvc/llvm-project?rev=340082&view=rev
Log:
test commit: add a comment
Modified:
cfe/trunk/test/PCH/pch-through3c.cpp
Modified: cfe/trunk/test/PCH/pch-through3c.cpp
URL:
http://llvm.org/viewvc/llvm-pr
Author: mikerice
Date: Wed Aug 29 08:45:11 2018
New Revision: 340934
URL: http://llvm.org/viewvc/llvm-project?rev=340934&view=rev
Log:
[OPENMP] Create non-const ident_t objects.
Currently ident_t objects are created const when debug info is not
enabled, but the libittnotify libray in the OpenMP r
Author: mikerice
Date: Tue Sep 11 10:10:44 2018
New Revision: 341963
URL: http://llvm.org/viewvc/llvm-project?rev=341963&view=rev
Log:
[clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop
With clang-cl, when the user specifies /Yc or /Yu without a filename
the compiler use
Author: mikerice
Date: Mon Apr 29 14:21:17 2019
New Revision: 359506
URL: http://llvm.org/viewvc/llvm-project?rev=359506&view=rev
Log:
When skipping code at the start of a file during PCH use, Preprocessor::Lex
is not used since it consumes all preprocessor directives until it returns
a real token
Author: mikerice
Date: Wed May 8 10:15:21 2019
New Revision: 360271
URL: http://llvm.org/viewvc/llvm-project?rev=360271&view=rev
Log:
Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS
compatibility. This allows some applications developed with MSVC to
compile with clang wit
Author: mikerice
Date: Thu Sep 20 10:19:41 2018
New Revision: 342666
URL: http://llvm.org/viewvc/llvm-project?rev=342666&view=rev
Log:
[OPENMP] Fix spelling of getLoopCounter (NFC)
Modified:
cfe/trunk/include/clang/AST/OpenMPClause.h
cfe/trunk/lib/AST/OpenMPClause.cpp
cfe/trunk/lib/Co
Author: mikerice
Date: Wed Jul 17 08:18:45 2019
New Revision: 366336
URL: http://llvm.org/viewvc/llvm-project?rev=366336&view=rev
Log:
[OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field
checkDecl is only valid for VarDecls or FieldDecls, since getCanonicalDecl
expects
@@ -32,8 +32,8 @@ T tmain(T argc) {
}
switch (argc) {
#pragma omp error // expected-error {{ERROR}}
- case 1:
-#pragma omp error // expected-error {{ERROR}}
+ case 1: // FIXME: error without 'at execution' is not a stand-alone
directive and so this should be accepted.
--
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/71596
None
>From 41f147c79a0a32fa541e7fb99cb2053b8f4b7ea2 Mon Sep 17 00:00:00 2001
From: Mike Rice
Date: Tue, 7 Nov 2023 14:51:55 -0800
Subject: [PATCH] [OpenMP] Add a missing 'const' (NFC)
---
clang/include/cl
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/71596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/74674
Since VD is assigned from a cast it cannot be a nullptr or it would
have asserted. Remove the subsequent checks to clear up any misunderstanding.
>From 6b3b456534c21a74f12ac022ee99365dd3831dec Mon Sep 17 00
@@ -6454,8 +6454,7 @@ ConstantAddress CodeGenModule::GetAddrOfGlobalTemporary(
!EvalResult.hasSideEffects())
Value = &EvalResult.Val;
- LangAS AddrSpace =
- VD ? GetGlobalVarAddressSpace(VD) : MaterializedType.getAddressSpace();
mikerice1969 wr
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/74674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -48,428 +49,365 @@
#include "llvm/Support/ToolOutputFile.h"
#include "llvm/Support/YAMLTraits.h"
#include "llvm/Transforms/IPO/Internalize.h"
+#include "llvm/Transforms/Utils/Cloning.h"
-#include
#include
using namespace clang;
using namespace llvm;
#define DEBUG_T
https://github.com/mikerice1969 approved this pull request.
LGTM. It fixes the performance problems we were seeing. Thanks!
https://github.com/llvm/llvm-project/pull/72478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -359,16 +359,34 @@ static Attr *handleCodeAlignAttr(Sema &S, Stmt *St, const
ParsedAttr &A) {
static void
CheckForDuplicateCodeAlignAttrs(Sema &S,
const SmallVectorImpl &Attrs) {
- const Attr *A = nullptr;
- for (const auto *I : Attrs) {
-
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/72600
Make the code clear that nullptrs are not expected.
>From da715ea17cd3a23894826eac8cc8f7cd880b5e02 Mon Sep 17 00:00:00 2001
From: Mike Rice
Date: Thu, 16 Nov 2023 18:30:47 -0800
Subject: [PATCH] Replace get
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/72600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikerice1969 approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/71398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/70746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Mike Rice
Date: 2022-03-24T09:19:00-07:00
New Revision: f82ec5532b2f303732e547226816d7a668db3050
URL:
https://github.com/llvm/llvm-project/commit/f82ec5532b2f303732e547226816d7a668db3050
DIFF:
https://github.com/llvm/llvm-project/commit/f82ec5532b2f303732e547226816d7a668db3050.diff
LOG
Author: Mike Rice
Date: 2022-03-16T14:39:18-07:00
New Revision: 79f661edc13d389437b83d42f0af04b0615b920e
URL:
https://github.com/llvm/llvm-project/commit/79f661edc13d389437b83d42f0af04b0615b920e
DIFF:
https://github.com/llvm/llvm-project/commit/79f661edc13d389437b83d42f0af04b0615b920e.diff
LOG
Author: Mike Rice
Date: 2022-03-18T13:48:32-07:00
New Revision: 6bd8dc91b89d0b130d8c03174b7b3b0d1cf3b331
URL:
https://github.com/llvm/llvm-project/commit/6bd8dc91b89d0b130d8c03174b7b3b0d1cf3b331
DIFF:
https://github.com/llvm/llvm-project/commit/6bd8dc91b89d0b130d8c03174b7b3b0d1cf3b331.diff
LOG
Author: Mike Rice
Date: 2022-03-22T13:55:47-07:00
New Revision: 2cedaee6f7387b39f7a534883050d66fd78e15a4
URL:
https://github.com/llvm/llvm-project/commit/2cedaee6f7387b39f7a534883050d66fd78e15a4
DIFF:
https://github.com/llvm/llvm-project/commit/2cedaee6f7387b39f7a534883050d66fd78e15a4.diff
LOG
Author: Mike Rice
Date: 2022-02-14T16:15:20-08:00
New Revision: 83a407d176f84c53633a2ef259642ff184e0613f
URL:
https://github.com/llvm/llvm-project/commit/83a407d176f84c53633a2ef259642ff184e0613f
DIFF:
https://github.com/llvm/llvm-project/commit/83a407d176f84c53633a2ef259642ff184e0613f.diff
LOG
Author: Mike Rice
Date: 2022-02-17T10:36:28-08:00
New Revision: 383f3a467c92499956ed804eb2bd69ad8576615b
URL:
https://github.com/llvm/llvm-project/commit/383f3a467c92499956ed804eb2bd69ad8576615b
DIFF:
https://github.com/llvm/llvm-project/commit/383f3a467c92499956ed804eb2bd69ad8576615b.diff
LOG
Author: David Pagan
Date: 2022-05-03T13:10:01-07:00
New Revision: 37471cf2c3fd02fac0b0dc6e513cfe6098f37764
URL:
https://github.com/llvm/llvm-project/commit/37471cf2c3fd02fac0b0dc6e513cfe6098f37764
DIFF:
https://github.com/llvm/llvm-project/commit/37471cf2c3fd02fac0b0dc6e513cfe6098f37764.diff
L
Author: Mike Rice
Date: 2022-05-10T09:56:55-07:00
New Revision: 1a02519bc504a12a12ba875db29c9e5901ed9bef
URL:
https://github.com/llvm/llvm-project/commit/1a02519bc504a12a12ba875db29c9e5901ed9bef
DIFF:
https://github.com/llvm/llvm-project/commit/1a02519bc504a12a12ba875db29c9e5901ed9bef.diff
LOG
Author: Mike Rice
Date: 2022-05-10T14:12:44-07:00
New Revision: 0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff
URL:
https://github.com/llvm/llvm-project/commit/0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff
DIFF:
https://github.com/llvm/llvm-project/commit/0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff.diff
LOG
Author: Mike Rice
Date: 2022-05-11T14:02:09-07:00
New Revision: 772b0c44a4296a34cbc072c2a7cf294410d07a1a
URL:
https://github.com/llvm/llvm-project/commit/772b0c44a4296a34cbc072c2a7cf294410d07a1a
DIFF:
https://github.com/llvm/llvm-project/commit/772b0c44a4296a34cbc072c2a7cf294410d07a1a.diff
LOG
Author: Mike Rice
Date: 2022-05-13T08:24:55-07:00
New Revision: 0d67c8a51d61cb0fac91f265a424767f072c7d5c
URL:
https://github.com/llvm/llvm-project/commit/0d67c8a51d61cb0fac91f265a424767f072c7d5c
DIFF:
https://github.com/llvm/llvm-project/commit/0d67c8a51d61cb0fac91f265a424767f072c7d5c.diff
LOG
Author: Mike Rice
Date: 2022-05-24T10:28:59-07:00
New Revision: 9ba937112fa6d4076e4a98b587a334786b6c0d9c
URL:
https://github.com/llvm/llvm-project/commit/9ba937112fa6d4076e4a98b587a334786b6c0d9c
DIFF:
https://github.com/llvm/llvm-project/commit/9ba937112fa6d4076e4a98b587a334786b6c0d9c.diff
LOG
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/85473
The value of SubExpr is not null since getSubExpr would assert in that case.
Remove the nullptr check. This avoids confusion since SubExpr is used without
check later in the function.
>From 56c3ca2e2cfac7b
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/85473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mikerice1969 wrote:
I mentioned the assert just to make the point that setSubExpr is written so it
doesn't return a nullptr. So it is not expected and the deference is ok.
I went ahead with this change but feel free to update if you like. But adding a
return when nullptr is seen here would co
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/86360
If any return from overwriteChangedFiles is true some fixes were not applied.
>From 492e0fc4e146d7321003470a9cd0b4be4ae39d7a Mon Sep 17 00:00:00 2001
From: Mike Rice
Date: Fri, 22 Mar 2024 16:02:54 -0700
Su
mikerice1969 wrote:
> This could use a test.
I thought about it, but I have no idea how to write that test. Do you have an
idea?
https://github.com/llvm/llvm-project/pull/86360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
mikerice1969 wrote:
Hi @josemonsalve2 if you want to help move this along it would be best to break
this into at least three separate PRs.
1) Parsing/Sema/Serialization
2) CodeGen
3) Extension checking framework
In whatever order makes sense to you.
We've added several extension directives in o
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/80216
Move the diagnostic so it fires only when doing an OpenMP capture, not for
non-OpenMP captures. This allows non-OpenMP code to work when using OpenMP
elsewhere, such as the code reported in
https://github.c
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/80216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Mike Rice
Date: 2021-01-31T17:17:33-08:00
New Revision: e94a35a744b780fcbe18e8bc6a4f774191588d45
URL:
https://github.com/llvm/llvm-project/commit/e94a35a744b780fcbe18e8bc6a4f774191588d45
DIFF:
https://github.com/llvm/llvm-project/commit/e94a35a744b780fcbe18e8bc6a4f774191588d45.diff
LOG
Author: Mike Rice
Date: 2021-02-02T10:09:37-08:00
New Revision: ca98c15f23354520bf689bd5feb333a716159d2c
URL:
https://github.com/llvm/llvm-project/commit/ca98c15f23354520bf689bd5feb333a716159d2c
DIFF:
https://github.com/llvm/llvm-project/commit/ca98c15f23354520bf689bd5feb333a716159d2c.diff
LOG
Author: Mike Rice
Date: 2021-10-28T08:26:43-07:00
New Revision: 6f9c25167d16acff3ff8e4f54a8c14a2a175fc59
URL:
https://github.com/llvm/llvm-project/commit/6f9c25167d16acff3ff8e4f54a8c14a2a175fc59
DIFF:
https://github.com/llvm/llvm-project/commit/6f9c25167d16acff3ff8e4f54a8c14a2a175fc59.diff
LOG
Author: Mike Rice
Date: 2021-10-29T09:20:40-07:00
New Revision: 72c373644fc397e9443200865b58514a3d6cf69d
URL:
https://github.com/llvm/llvm-project/commit/72c373644fc397e9443200865b58514a3d6cf69d
DIFF:
https://github.com/llvm/llvm-project/commit/72c373644fc397e9443200865b58514a3d6cf69d.diff
LOG
Author: Mike Rice
Date: 2021-11-04T14:40:30-07:00
New Revision: 4eac7bcf1af1a94d76aec8d54f4a0f0014dd121c
URL:
https://github.com/llvm/llvm-project/commit/4eac7bcf1af1a94d76aec8d54f4a0f0014dd121c
DIFF:
https://github.com/llvm/llvm-project/commit/4eac7bcf1af1a94d76aec8d54f4a0f0014dd121c.diff
LOG
Author: Mike Rice
Date: 2021-11-17T10:51:08-08:00
New Revision: 69f35f89691255eeed0dac26b2b642fea5c7db93
URL:
https://github.com/llvm/llvm-project/commit/69f35f89691255eeed0dac26b2b642fea5c7db93
DIFF:
https://github.com/llvm/llvm-project/commit/69f35f89691255eeed0dac26b2b642fea5c7db93.diff
LOG
Author: Mike Rice
Date: 2022-08-11T09:39:12-07:00
New Revision: dd4c838da30ad4b6d5dc0f700df0a6629469f719
URL:
https://github.com/llvm/llvm-project/commit/dd4c838da30ad4b6d5dc0f700df0a6629469f719
DIFF:
https://github.com/llvm/llvm-project/commit/dd4c838da30ad4b6d5dc0f700df0a6629469f719.diff
LOG
Author: Mike Rice
Date: 2022-08-18T17:13:30-07:00
New Revision: 89167e3c5b008b44f1fa8a222652e7bdc62cfa8a
URL:
https://github.com/llvm/llvm-project/commit/89167e3c5b008b44f1fa8a222652e7bdc62cfa8a
DIFF:
https://github.com/llvm/llvm-project/commit/89167e3c5b008b44f1fa8a222652e7bdc62cfa8a.diff
LOG
Author: Mike Rice
Date: 2022-08-22T10:41:16-07:00
New Revision: 129904d5041ffad13747fd0ad77e44050d6c6aaa
URL:
https://github.com/llvm/llvm-project/commit/129904d5041ffad13747fd0ad77e44050d6c6aaa
DIFF:
https://github.com/llvm/llvm-project/commit/129904d5041ffad13747fd0ad77e44050d6c6aaa.diff
LOG
Author: Mike Rice
Date: 2022-11-04T12:54:22-07:00
New Revision: c954cfeb57a1c8c0996a34da64243bc7f7fe1107
URL:
https://github.com/llvm/llvm-project/commit/c954cfeb57a1c8c0996a34da64243bc7f7fe1107
DIFF:
https://github.com/llvm/llvm-project/commit/c954cfeb57a1c8c0996a34da64243bc7f7fe1107.diff
LOG
Author: Fazlay Rabbi
Date: 2022-11-17T20:59:07-08:00
New Revision: ab9eac762c35068e77f57795e660d06f578c9614
URL:
https://github.com/llvm/llvm-project/commit/ab9eac762c35068e77f57795e660d06f578c9614
DIFF:
https://github.com/llvm/llvm-project/commit/ab9eac762c35068e77f57795e660d06f578c9614.diff
Author: Fazlay Rabbi
Date: 2022-06-22T17:45:43-07:00
New Revision: a35141d395019c837d16419c6ef57662a6efefc5
URL:
https://github.com/llvm/llvm-project/commit/a35141d395019c837d16419c6ef57662a6efefc5
DIFF:
https://github.com/llvm/llvm-project/commit/a35141d395019c837d16419c6ef57662a6efefc5.diff
Author: Mike Rice
Date: 2022-05-25T10:34:07-07:00
New Revision: ba3f85390bde10eab1cbdb68f744b8f5ab31859b
URL:
https://github.com/llvm/llvm-project/commit/ba3f85390bde10eab1cbdb68f744b8f5ab31859b
DIFF:
https://github.com/llvm/llvm-project/commit/ba3f85390bde10eab1cbdb68f744b8f5ab31859b.diff
LOG
Author: Mike Rice
Date: 2022-05-26T09:51:48-07:00
New Revision: 0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb
URL:
https://github.com/llvm/llvm-project/commit/0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb
DIFF:
https://github.com/llvm/llvm-project/commit/0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb.diff
LOG
Author: Mike Rice
Date: 2022-06-02T17:31:33-07:00
New Revision: 48d6a6c9add90f3684de362907d5f05a0988244a
URL:
https://github.com/llvm/llvm-project/commit/48d6a6c9add90f3684de362907d5f05a0988244a
DIFF:
https://github.com/llvm/llvm-project/commit/48d6a6c9add90f3684de362907d5f05a0988244a.diff
LOG
Author: Fazlay Rabbi
Date: 2022-11-18T16:26:47-08:00
New Revision: 56c166017055595a9f26933e85bfd89e30c528d0
URL:
https://github.com/llvm/llvm-project/commit/56c166017055595a9f26933e85bfd89e30c528d0
DIFF:
https://github.com/llvm/llvm-project/commit/56c166017055595a9f26933e85bfd89e30c528d0.diff
Author: Mike Rice
Date: 2022-11-29T10:51:11-08:00
New Revision: 530eb263c0ec02fe8d107cbdb41ac6e482514a00
URL:
https://github.com/llvm/llvm-project/commit/530eb263c0ec02fe8d107cbdb41ac6e482514a00
DIFF:
https://github.com/llvm/llvm-project/commit/530eb263c0ec02fe8d107cbdb41ac6e482514a00.diff
LOG
Author: Mike Rice
Date: 2022-11-29T11:53:37-08:00
New Revision: c52053bd9961cc1854e86958ffb0f89e2cfe4e5f
URL:
https://github.com/llvm/llvm-project/commit/c52053bd9961cc1854e86958ffb0f89e2cfe4e5f
DIFF:
https://github.com/llvm/llvm-project/commit/c52053bd9961cc1854e86958ffb0f89e2cfe4e5f.diff
LOG
Author: Mike Rice
Date: 2023-04-05T10:29:37-07:00
New Revision: 57caadc57a30f2279099e5b86bb555b4aab621ce
URL:
https://github.com/llvm/llvm-project/commit/57caadc57a30f2279099e5b86bb555b4aab621ce
DIFF:
https://github.com/llvm/llvm-project/commit/57caadc57a30f2279099e5b86bb555b4aab621ce.diff
LOG
Author: Dustin Howett
Date: 2023-02-07T11:37:02-08:00
New Revision: d27fb5efc5f2086fa157e7d836b61bae4d5f3734
URL:
https://github.com/llvm/llvm-project/commit/d27fb5efc5f2086fa157e7d836b61bae4d5f3734
DIFF:
https://github.com/llvm/llvm-project/commit/d27fb5efc5f2086fa157e7d836b61bae4d5f3734.diff
Author: Fazlay Rabbi
Date: 2023-02-07T12:09:52-08:00
New Revision: e716b0204a5ae2a96289a335b2ab30a6c3fb09cf
URL:
https://github.com/llvm/llvm-project/commit/e716b0204a5ae2a96289a335b2ab30a6c3fb09cf
DIFF:
https://github.com/llvm/llvm-project/commit/e716b0204a5ae2a96289a335b2ab30a6c3fb09cf.diff
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/87842
This test is the bottleneck for OpenMP lit tests, running about twice as long
as the others. Break it into five tests based on run lines with the same
version.
>From e184c8ec9b25b3e077a42646775755dd3a4b449
mikerice1969 wrote:
This is one way to improve the overall test time. Open for other suggestions.
```
Before change:
Slowest Tests:
--
144.09s: Clang :: OpenMP/nesting_of_regions.cpp
60.81s: Clang :: OpenMP/target_defaultma
https://github.com/mikerice1969 ready_for_review
https://github.com/llvm/llvm-project/pull/87842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/87842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/88215
In 4d5e834c5b7f0d90a6d543e182df602f6bc8, casts were removed for pointers
but one case was missed. Add missing check.
>From b1eaa2f5b13db4d63390a0358ad0f9b13cbe927f Mon Sep 17 00:00:00 2001
From: Mike Ri
mikerice1969 wrote:
See: https://godbolt.org/z/av7axb9as
https://github.com/llvm/llvm-project/pull/88215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mikerice1969 wrote:
> We should really fix using cmpxchg here. Can you open an IR issue for it?
Sure, I'll look into it and follow-up. Thanks for the review!
https://github.com/llvm/llvm-project/pull/88215
___
cfe-commits mailing list
cfe-commits@list
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/88215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/94680
Static verifier reports unchecked use of pointer after explicitly checking
earlier in the function. It appears the pointer won't be a nullptr, so remove
the unneeded check for consistency.
>From 476c5a8580
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/94696
Static verifier noticed the current code has logically dead code parsing the
clause where IsComma is assigned. Fix this and improve the error message
received when a bad adjust-op is specified.
This will n
@@ -201,14 +211,26 @@ template <> struct DominatingValue {
class saved_type {
enum Kind { ScalarLiteral, ScalarAddress, AggregateLiteral,
AggregateAddress, ComplexAddress };
-
-llvm::Value *Value;
-llvm::Type *ElementType;
+union {
+ struc
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/94777
Static verifier caught passing ColonLoc/LParenLoc in wrong order. Marked as NFC
since these don't seem to be used for anything currently that I can think to
test for.
>From ae0438eda2b5fcffc70b991d2c496bac
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/94806
The static verifier flagged dead code in the check since the loop will only
execute once and never reach the iterator increment.
The loop needs to iterate twice to correctly diagnose when a statement is aft
@@ -1117,6 +1118,31 @@ NumericLiteralParser::NumericLiteralParser(StringRef
TokSpelling,
if (isImaginary) break; // Cannot be repeated.
isImaginary = true;
continue; // Success.
+case '_':
+ if (isFPConstant)
+break; // Invalid for floats
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/94680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/94777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mikerice1969 wrote:
> Does this impact anything user-facing? e.g., should there be an additional
> test somewhere in clang/test/Sema/ for this change?
I don't think there is any user-visible issue with the one attribute that uses
this. At least how the Parse code is written currently. The attr
@@ -314,64 +314,92 @@ void Parser::ParseGNUAttributes(ParsedAttributes &Attrs,
}
/// Determine whether the given attribute has an identifier argument.
-static bool attributeHasIdentifierArg(const IdentifierInfo &II) {
+static bool attributeHasIdentifierArg(const IdentifierInfo
https://github.com/mikerice1969 updated
https://github.com/llvm/llvm-project/pull/3
>From 5f8b68d9dfd7680adeadbae1d761dc03a2455685 Mon Sep 17 00:00:00 2001
From: Mike Rice
Date: Mon, 22 Jul 2024 15:28:15 -0700
Subject: [PATCH 1/2] [clang] Update argument checking tablegen code to use a
'fu
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/100489
Fix static verifer concerns of null pointer checks after dereferencing
the pointer. Update the assert to make it super clear it is not null and
remove the checks.
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/100489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,300 @@
+//===- DirectoryScanner.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -13681,12 +13681,13 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr
*Init, bool DirectInit) {
}
Init = Result.getAs();
+assert(Init && "Init must not be null");
+
IsParenListInit = !InitSeq.steps().empty() &&
InitSeq.step_beg
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/100642
The switch now returns in every case so the end return is unreachable.
>From 8804f18fcaf1a70bad10a8e66414f91556df23bd Mon Sep 17 00:00:00 2001
From: Mike Rice
Date: Thu, 25 Jul 2024 11:35:11 -0700
Subject:
=?utf-8?q?Kristóf?= Umann
Message-ID:
In-Reply-To:
@@ -804,23 +751,21 @@ class NoOwnershipChangeVisitor final : public
NoStateChangeFuncVisitor {
return false;
}
+ bool hasResourceStateChanged(ProgramStateRef CallEnterState,
+ ProgramSt
@@ -290,3 +294,296 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/100642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -290,3 +294,296 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
mikerice1969 wrote:
> That code was added very recently by #94056 and seem to be specific to the
> `ptrauth_vtable_pointer` attribute. Perhaps we're lacking test coverage if
> nothing breaks without that code?
@AaronBallman The code is logically useless so there's no way to add tests that
mak
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/3
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mikerice1969 wrote:
> You probably need to separately match the syntax and the name without
> constructing a temporary `std::string`.
@nikic Thanks. I'll look into improving this. If anyone thinks this should be
reverted until then let me know, or just go ahead and revert it.
https://github.c
mikerice1969 wrote:
The old tablegen produced a single entry per name:
`.Case("unroll", true)`
The new tablegen can produce multiple entries:
```
.Case("Microsoft::unroll", true)
.Case("Pragma::unroll", true)
```
I think we can instead produce something like this, one per name:
```
.Case("un
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/98948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14,10 +14,144 @@
#ifndef LLVM_CLANG_BASIC_POINTERAUTHOPTIONS_H
#define LLVM_CLANG_BASIC_POINTERAUTHOPTIONS_H
+#include "clang/Basic/LLVM.h"
+#include "clang/Basic/LangOptions.h"
+#include "llvm/ADT/STLForwardCompat.h"
+#include "llvm/Support/ErrorHandling.h"
+#include "llv
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/3
In 92fc1eb0c1ae3813f2ac9208e2c74207aae9d23 the HLSLLoopHint attribute was added
with an 'unroll' spelling. There is an existing LoopHint attribute with the
same spelling. These attributes have different arg
@@ -3597,8 +3597,13 @@ class ASTIdentifierTableTrait {
/// doesn't check whether the name has macros defined; use
PublicMacroIterator
/// to check that.
bool isInterestingIdentifier(const IdentifierInfo *II, uint64_t MacroOffset)
{
-if (MacroOffset || II->isPoisoned
https://github.com/mikerice1969 created
https://github.com/llvm/llvm-project/pull/89837
Add an initializer for StreamSym, which is a pointer. The pointers in this
class are set in the Init function, but all should be initialized in the
constructor to avoid confusion and static verifier hits.
https://github.com/mikerice1969 edited
https://github.com/llvm/llvm-project/pull/89837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/89837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 127 matches
Mail list logo
