[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese added a comment. > Drive-by comment on the docs; otherwise this sounds awesome; as long as else > is easy to add later this SGTM (I'll let others do the code review). > (Although, if else {} and else requires {} would be easy to add now/soon, I > feel like it'd be worth it. Modelling a

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese added a comment. In D114206#3221893 , @lenary wrote: > Update: I'm going to revert this on main. This patch was accepted > conditionally on you fixing the windows crash, which you have not done, so > this was landed without being accepted. > >

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04192422c4e3: [Clang][ScanDeps] Use the virtual path for module maps (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D98950: [clang][deps] NFC: Document collector, rename members

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Thanks for the cleanup. Code makes more sense now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98950/new/ https://reviews.llvm.org/D9895

[PATCH] D100533: [clang][deps] Remove the -full-command-line flag

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100533/new/ https://reviews.llvm.org/D100533 _

[PATCH] D100653: [clang][cli] NFC: Move conditional LangOptions parsing/generation

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100653/new/ https://reviews.llvm.org/D100653 _

[PATCH] D100455: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100455/new/ https://reviews.llvm.org/D100455 _

[PATCH] D100473: [clang] Implement CompilerInvocation copy assignment

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. I think this is fine given that we already have a copy constructor with deep copy semantics. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D100942: [clang][deps] Include "-cc1" in the arguments

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100942/new/ https://reviews.llvm.org/D100942

[PATCH] D93700: [clang][cli] Report the actual argument parsing result

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93700/new/ https://reviews.llvm.org/D93700 ___

[PATCH] D93636: [clang][cli] Implement ContainsN Google Test matcher

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. We don't really have anywhere specific to put extra matchers, and we don't want to add stuff to the actual gtest folder so it's easy to merge updates. So this is fine. Repositor

[PATCH] D84674: [clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/ https://reviews.llvm.org/D84674 ___

[PATCH] D94674: [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94674/new/ https://reviews.llvm.org/D94674 __

[PATCH] D94675: [clang][cli] NFC: Decrease the scope of ParseCodeGenArgs parameters

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94675/new/ https://reviews.llvm.org/D94675 __

[PATCH] D94676: [clang][cli] Specify KeyPath prefixes via TableGen classes

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94676/new/ https://reviews.llvm.org/D94676 __

[PATCH] D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM with the comment. Comment at: clang/include/clang/Driver/Options.td:5210-5213 def finclude_default_header : Flag<["-"], "finclude-default-header">, - HelpText<"I

[PATCH] D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94679/new/ https://reviews.llvm.org/D94679 __

[PATCH] D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94680/new/ https://reviews.llvm.org/D94680 __

[PATCH] D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94681/new/ https://reviews.llvm.org/D94681 __

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94682/new/ https://reviews.llvm.org/D94682 __

<    1   2   3