[PATCH] D32515: [libcxx] [test] Changes to accommodate LWG 2904 "Make variant move-assignment more exception safe"

mpark added a comment. Thanks for the tests! I'll try this out with an implementation shortly. https://reviews.llvm.org/D32515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

mpark added a comment. @CaseyCarter: Does this not pass with the current version? Also, have you seen the tests in `test/libcxx/utilities/variant/variant.variant`? If yes, do those tests and the ones in this diff overlap at all? Curious as to how we should merge them. https://reviews.llvm.org/D

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

mpark added a comment. Yes, you're right that fine-grained SMF triviality is implemented but LWG 2904 is not yet. I would love it if you can integrate the currently `libcxx` tests into `std` tests! Thank you :) https://reviews.llvm.org/D32671 ___

[PATCH] D40210: [libc++] Shrink variant's index type when possible

mpark added inline comments. Comment at: include/variant:295 + +template +using __variant_index_t = `s/_NumElem/_NumAlts/` Comment at: include/variant:300-303 + std::tuple_element_t< + __choose_index_type(_NumElem), + std::tuple +

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

mpark accepted this revision. mpark added a reviewer: mpark. mpark added a comment. That was fun =D https://reviews.llvm.org/D28222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27606: [libcxx] Fix tuple construction/assignment from types derived from tuple/pair/array.

mpark added inline comments. Comment at: include/tuple:568 +using _QualType = typename _Deduced::_QualType; + static_assert(__tuple_like::value, ""); +return __tuple_constructible<_QualType, tuple>::value indentation? =