[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-10-28 Thread Michael Kuron via cfe-commits
mkuron added a comment. I think `OffloadAction::DeviceDependences::add(..., ..., /*BoundArch=*/nullptr, Action::OFK_OpenMP)` is never sufficient. The invalid `BoundArch` eventually ends up in `NVPTX::Assembler::ConstructJob` and triggers an assert; I don't think there is any code path with Open

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

2016-03-22 Thread Michael Kuron via cfe-commits
mkuron added a comment. The three smaller patches into which you divided this one appear to be missing some things. For example, `AddOpenMPLinkerScript` in //lib/Driver/Tools.cpp// from this patch appears to still be necessary to get the desired functionality, but it is not present in any of th