kiausch added inline comments.
Comment at: llvm/test/CodeGen/PowerPC/spe.ll:2
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc-unknown-linux-gnu \
-; RUN: -mattr=+spe | FileCheck %s
+;
kiausch created this revision.
kiausch added reviewers: nemanjai, jhibbits.
Herald added subscribers: dang, steven.zhang, shchenz, kbarton, hiraditya.
kiausch requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
PowerPC cores l
kiausch updated this revision to Diff 310853.
kiausch added a comment.
fixed format errors
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92935/new/
https://reviews.llvm.org/D92935
Files:
clang/include/clang/Driver/Options.td
llvm/lib/Target/PowerPC/PPC.td
llvm/lib/Target/PowerPC/
kiausch added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92935/new/
https://reviews.llvm.org/D92935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kiausch added a comment.
Regarding similar GCC options:
AFAIK GCC has had the spe options -msingle-float and -mdouble-float until spe
support was dropped after version 8.3.
These options would kind of match here, but they are already used as MIPS
subtarget features in LLVM and I was not able to
kiausch updated this revision to Diff 314566.
kiausch edited the summary of this revision.
kiausch added a comment.
implemented review suggestions:
- updated clang/docs/ClangCommandLineReference.rst
- removed unneccessary HasEFPU2() wrapper function
- initialize HasEFPU member
- merged tests into
kiausch marked 4 inline comments as done.
kiausch added inline comments.
Comment at: llvm/test/CodeGen/PowerPC/efpu2.ll:6
+; Single tests
+; identical to tests in spe.ll
+
nemanjai wrote:
> It might make sense to just add a RUN line in that test case rather than
kiausch updated this revision to Diff 315119.
kiausch marked an inline comment as done.
kiausch added a comment.
- enable -mspe if -mefpu2 is defined in clang interface
- added clang feature test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92935/new/
https://reviews.llvm.org/D92935
F
kiausch added a comment.
Could somebody with write access please commit this patch if there are no
further objections? Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92935/new/
https://reviews.llvm.org/D92935
___
cfe-commits mailing l