mppf updated this revision to Diff 117579.
mppf added a comment.
Herald added a subscriber: mgorny.
- Add a test of getFieldNumber (and others)
https://reviews.llvm.org/D38473
Files:
include/clang/CodeGen/CodeGenABITypes.h
lib/CodeGen/CodeGenABITypes.cpp
unittests/CodeGen/CMakeLists.txt
mppf updated this revision to Diff 117665.
mppf added a comment.
- Improve comments, rename to getLLVMFieldNumber
https://reviews.llvm.org/D38473
Files:
include/clang/CodeGen/CodeGenABITypes.h
lib/CodeGen/CodeGenABITypes.cpp
unittests/CodeGen/CMakeLists.txt
unittests/CodeGen/CodeGenExte
mppf added a comment.
Thanks for the feedback!
> "Given a non-bitfield struct field, return its index within the elements of
> the struct's converted type."
Done
> I think "getLLVMFieldNumber" is probably the right name for this.
Great suggestion, done.
> This interface does not seem to be s
mppf updated this revision to Diff 117806.
mppf added a comment.
- Update comment for "complete object type"
https://reviews.llvm.org/D38473
Files:
include/clang/CodeGen/CodeGenABITypes.h
lib/CodeGen/CodeGenABITypes.cpp
unittests/CodeGen/CMakeLists.txt
unittests/CodeGen/CodeGenExternalT
mppf added a comment.
@rjmccall , @rsmith - I added a comment about complete object type. I think
I've addressed all the concerns at this point, but speak up if I'm
misunderstanding.
I don't have commit access so I'll need help committing it. Thanks for your
help!
https://reviews.llvm.org/D3
mppf added a comment.
Since I don't have commit access, could somebody commit this for me please?
Thanks.
https://reviews.llvm.org/D38473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
