=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/118466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -3441,13 +3441,33 @@ TEST_P(ASTImporterOptionSpecificTestBase,
ImportParmVarDecl) {
ASSERT_TRUE(FromVar);
ASSERT_TRUE(FromVar->hasUninstantiatedDefaultArg());
ASSERT_TRUE(FromVar->getUninstantiatedDefaultArg());
+ ASSERT_FALSE(FromVar->isExplicitObjectParameter());
Michael137 wrote:
> The C API must remain stable and backward compatible. It's the C++ APIs that
> we are willing to change without worrying.
In that case should we adjust the documentation in the header?
https://github.com/llvm/llvm-project/blob/1c28b9237382b093f477479c993c80181922ca6a/llvm/in
Michael137 wrote:
> This causes a breaking change in the C-API which I believe can easily be
> avoided. I've submitted https://github.com/llvm/llvm-project/pull/124144 as a
> suggestion to keep compatability
Yea that's not unexpected, since the APIs aren't stable not
stable/experimental. I co
Michael137 wrote:
FYI, this also fixed the macOS public matrix bot. Some tests where we built
with `-gmodules` were crashing. Though weirdly just the clang-17 tests (which
build against clang-17 aligned libc++, so might have something to do with
that). Just wanted to mentioned that here in cas
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/124305
Adds test that confirms that we import the explicit object parameter location
for `ParmVarDecl`s. This is how Clang determines whether a parameter
`isExplicitObjectParamater`. The LLDB expression evaluator r
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124305
>From 2fbabc9802e09a175bd71624b2ff89a2d9b7f3a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH] [clang][ASTImporter][test] Add test for importing explicit
ob
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 commented:
So in spirit this is kind of like an ODR violation right? Which the ASTImporter
does try to handle, so this seems reasonable to me. For my own understanding,
where did the crash end up happening?
Also,
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/124262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124262
>From ff885745df0d4842dd4c541ec5e3c6cbb557f6a5 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH 1/2] [clang][ASTImporter] Import explicit object parameter
loc
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/124262
Make sure to import the explicit object parameter location for `ParmVarDecl`s.
This is how Clang determines whether a parameter `isExplicitObjectParamater`.
This will be needed to enable expression evaluatio
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/122928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/124305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124305
>From 2fbabc9802e09a175bd71624b2ff89a2d9b7f3a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH 1/2] [clang][ASTImporter][test] Add test for importing
explici
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124305
>From 2fbabc9802e09a175bd71624b2ff89a2d9b7f3a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH 1/3] [clang][ASTImporter][test] Add test for importing
explici
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/124305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3441,13 +3441,33 @@ TEST_P(ASTImporterOptionSpecificTestBase,
ImportParmVarDecl) {
ASSERT_TRUE(FromVar);
ASSERT_TRUE(FromVar->hasUninstantiatedDefaultArg());
ASSERT_TRUE(FromVar->getUninstantiatedDefaultArg());
+ ASSERT_FALSE(FromVar->isExplicitObjectParameter());
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/124305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/124273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124305
>From 2fbabc9802e09a175bd71624b2ff89a2d9b7f3a1 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 11:59:42 +
Subject: [PATCH 1/4] [clang][ASTImporter][test] Add test for importing
explici
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
Michael137 wrote:
> If this case is not handled, the following `setDescribedFunctionTemplate`
> will run into an assertion. The case happens in the test code. What exactly
> happens is that because of the `__get_first_arg` mismatch a field
>
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
Don't need this change anymore
https://gi
https://github.com/Michael137 commented:
Looks much better
Left some more clarification comments
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/124752
When creating `EnumDecl`s from DWARF for Objective-C `NS_ENUM`s, the Swift
compiler tries to figure out if it should perform "swiftification" of that enum
(which involves renaming the enumerator cases, etc.)
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
I see why you moved it. It's because we're
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 deleted
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
Can we not just leave this whole block in
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/124752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
@mgorny thanks for the ping. I relanded in
https://github.com/llvm/llvm-project/commit/a5fb2bbb2ad8488482843e2298fbe6f6a1d45bbd.
Confirmed that the OCaml bindings build and tests pass.
https://github.com/llvm/llvm-project/pull/122928
__
Author: Michael Buch
Date: 2025-01-18T18:03:41Z
New Revision: a5fb2bbb2ad8488482843e2298fbe6f6a1d45bbd
URL:
https://github.com/llvm/llvm-project/commit/a5fb2bbb2ad8488482843e2298fbe6f6a1d45bbd
DIFF:
https://github.com/llvm/llvm-project/commit/a5fb2bbb2ad8488482843e2298fbe6f6a1d45bbd.diff
LOG:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 1/5] [clang][DebugInfo] Expand detection of structured
bindings
Michael137 wrote:
> > > Did you try to modify `IgnoreUnlessSpelledInSource` to support CallExpr?
> >
> >
> > Yea I was thinking about it initially. But I wasn't sure what that would
> > look like tbh. IIUC `IgnoreImplicitMemberCallSingleStep` will unwrap
> > `CXXMemberCallExpr` into the under
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 1/4] [clang][DebugInfo] Expand detection of structured
bindings
Michael137 wrote:
> Did you try to modify `IgnoreUnlessSpelledInSource` to support CallExpr?
Updated to use this approach in latest commit. Seems to work well (including
the explicit object parameter case). Didn't find a great way to test this in
the clang AST unit-tests yet. Trying to underst
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/122265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 1/6] [clang][DebugInfo] Expand detection of structured
bindings
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/122265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 1/7] [clang][DebugInfo] Expand detection of structured
bindings
Michael137 wrote:
Added tests and updated PR description.
https://github.com/llvm/llvm-project/pull/122265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/122897
We currently don't emit `DW_AT_object_pointer` on function declarations or
definitions. GCC suffers from the same issue: https://godbolt.org/z/h4jeT54G5
If I interpreted the DWARFv5 spec correctly, it doesn'
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/122897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
@dwblaikie @adrian-prantl any thoughts on adjusting the DWARF spec to allow
explicit `this` parameters to be non-artificial but still be valid
`DW_AT_object_pointer`s?
https://github.com/llvm/llvm-project/pull/122897
___
cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/122887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2711,6 +2715,12 @@ class DeclContext {
bool Deserialize = false) const;
private:
+ /// Lookup all external visible declarations and the external declarations
+ /// within the same module specified by \param NamedModule. We can't
Michae
https://github.com/Michael137 commented:
LLDB API adjustments look fine. Just left some minor comments re. documentation
https://github.com/llvm/llvm-project/pull/122887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -145,12 +146,17 @@ class ExternalASTSource : public
RefCountedBase {
/// Find all declarations with the given name in the given context,
/// and add them to the context by calling SetExternalVisibleDeclsForName
/// or SetNoExternalVisibleDeclsForName.
+ /// \param Na
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/122928
In https://github.com/llvm/llvm-project/pull/122897 we started attaching
`DW_AT_object_pointer` to function definitions. This patch does the same but
for function declarations (which we do for implicit objec
Michael137 wrote:
Will be rebased on top of https://github.com/llvm/llvm-project/pull/122897
https://github.com/llvm/llvm-project/pull/122928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
@@ -145,12 +146,18 @@ class ExternalASTSource : public
RefCountedBase {
/// Find all declarations with the given name in the given context,
/// and add them to the context by calling SetExternalVisibleDeclsForName
/// or SetNoExternalVisibleDeclsForName.
- /// \return \
@@ -145,12 +146,18 @@ class ExternalASTSource : public
RefCountedBase {
/// Find all declarations with the given name in the given context,
/// and add them to the context by calling SetExternalVisibleDeclsForName
/// or SetNoExternalVisibleDeclsForName.
- /// \return \
@@ -145,12 +146,17 @@ class ExternalASTSource : public
RefCountedBase {
/// Find all declarations with the given name in the given context,
/// and add them to the context by calling SetExternalVisibleDeclsForName
/// or SetNoExternalVisibleDeclsForName.
+ /// \param Na
Michael137 wrote:
> > FWIW, I came across another no_unique_address-related crash today:
> > ```
> > $ cat a.cc
> > struct S {
> > private:
> > int i;
> > short s;
> > };
> > static_assert(sizeof(S) == 8);
> >
> > struct T {
> > [[no_unique_address]] S s;
> > char c;
> > };
> > static_as
Michael137 wrote:
> FWIW, I came across another no_unique_address-related crash today:
>
> ```
> $ cat a.cc
> struct S {
> private:
> int i;
> short s;
> };
> static_assert(sizeof(S) == 8);
>
> struct T {
> [[no_unique_address]] S s;
> char c;
> };
> static_assert(sizeof(T) == 8);
>
>
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/122897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 1/8] [clang][DebugInfo] Expand detection of structured
bindings
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From b43ffd0c1bb6e4f1ca5b8458848f574480021b08 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 1/8] [clang][DebugInfo] Expand detection of structured
bindings
@@ -3183,10 +3183,24 @@ Expr *Expr::IgnoreUnlessSpelledInSource() {
}
return E;
};
+
+ auto IgnoreImplicitCallSingleStep = [](Expr *E) {
+if (auto *C = dyn_cast(E)) {
+ auto NumArgs = C->getNumArgs();
+ if (NumArgs == 1 ||
+ (NumArgs > 1 && isa
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/123253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/122928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122928
>From 88125a0f3a28d49877cedfd4350ab6e0f37185ed Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 14 Jan 2025 11:33:33 +
Subject: [PATCH] [clang][DebugInfo] Emit DW_AT_object_pointer on function
defi
Michael137 wrote:
Hmm there's a clang-tidy test failing because this codepath gets hit for
`UserDefinedLiteral`, which is a `CallExpr` with a single argument:
```
(lldb) p E->dump()
UserDefinedLiteral 0x15402b738 'unsigned long long'
|-ImplicitCastExpr 0x15402b720 'unsigned long long (*)(unsigne
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/122265
>From f56f9469e5465f38f6252b2c8c2136473187969b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Jan 2025 10:01:31 +
Subject: [PATCH 1/3] [clang][DebugInfo] Expand detection of structured
bindings
Michael137 wrote:
> Did you try to modify `IgnoreUnlessSpelledInSource` to support CallExpr?
Yea I was thinking about it initially. But I wasn't sure what that would look
like tbh. IIUC `IgnoreImplicitMemberCallSingleStep` will unwrap
`CXXMemberCallExpr` into the underlying `MemberExpr`. And t
@@ -20099,73 +20179,13 @@ void Sema::ActOnEnumBody(SourceLocation EnumLoc,
SourceRange BraceRange,
BestPromotionType = BestType;
BestWidth = Context.getIntWidth(BestType);
- }
- else if (NumNegativeBits) {
-// If there is a negative value, figure out the small
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/120965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 commented:
Looks fine to me, thanks! I'll defer approval to one of the maintainers
(lets mark the commit as `[NFC]` so it's clear that this doesn't change
behaviour)
https://github.com/llvm/llvm-project/pull/120965
___
c
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/123253
>From 33b128cc2fd83894506f27ad730c3ac145c49f6f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 16 Jan 2025 23:02:10 +
Subject: [PATCH 1/2] [clang][PCH] Don't try to create standalone debug-info
fo
@@ -0,0 +1,12 @@
+// RUN: %clang_cc1 -std=c++23 -x c++-header -emit-pch -fmodule-format=obj \
+// RUN: -o %t.pch %s \
+// RUN: -mllvm -debug-only=pchcontainer &>%t-pch.ll
+// RUN: cat %t-pch.ll | FileCheck %s
+
+template
Michael137 wrote:
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/123253
Fixes one of the crashes uncovered by
https://github.com/llvm/llvm-project/pull/118710
`getOrCreateStandaloneType` asserts that a `DIType` was created for the
requested type. If the `Decl` was marked `nodebu
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/127056
This exercises the codepath where we create `DITemplateValueParameter`s whose
`TemplateArgument::ArgKind` is `StructuralValue`, which was added in
(https://github.com/llvm/llvm-project/pull/78041). Previousl
https://github.com/Michael137 approved this pull request.
Looks great! Thank you for moving all this functionality into Clang
LGTM (just one minor comment left)
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@
@@ -8476,27 +8476,20 @@ bool TypeSystemClang::CompleteTagDeclarationDefinition(
clang::ASTContext &ast = lldb_ast->getASTContext();
- /// TODO This really needs to be fixed.
+ unsigned NumNegativeBits = 0;
Michael137 wrote:
Can we move this block back in
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127056
>From b84ebf9c696ffc3867a52ed1540d59d18d2e5ece Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 13 Feb 2025 13:00:28 +
Subject: [PATCH 1/2] [clang][DebugInfo][test] Add tests for C++20 non-type
tem
Michael137 wrote:
ah fair enough
lets get that one merged then
https://github.com/llvm/llvm-project/pull/126937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
FYI on macOS CI this is failing with:
```
FAIL: test_dsym (TestCPPEnumPromotion.TestCPPEnumPromotion)
--
Traceback (most recent call last):
File
"/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/127056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
let me know if you need me to merge this for you
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Fixed in `0feb00f17cbaac7428dcb7aed13d903b65974978`
https://github.com/llvm/llvm-project/pull/115005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 commented:
Would be great to have a simpler of getting to the vtable info! I left some nits
Don't see an issue with the the general approach, but i'll let others chime in
https://github.com/llvm/llvm-project/pull/130255
_
401 - 500 of 511 matches
Mail list logo
