https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/70674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/70639
>From 81bd54091451eb2021007bc10b8a7c6965178800 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 27 Oct 2023 16:19:47 +0100
Subject: [PATCH 1/8] [clang][DebugInfo] Emit global variable definitions for
st
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/70639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Michael Buch
Date: 2023-11-06T10:58:02Z
New Revision: 333124cfd6dfa413294e80f9be75460b9a9314f9
URL:
https://github.com/llvm/llvm-project/commit/333124cfd6dfa413294e80f9be75460b9a9314f9
DIFF:
https://github.com/llvm/llvm-project/commit/333124cfd6dfa413294e80f9be75460b9a9314f9.diff
LOG:
Michael137 wrote:
> @Michael137 is this patch ready to land? We (I have took over the bug from
> @ilovepi ) have a few builders that are currently blocked by the behavior
> change introduced in PR #70639 . It would be great if this change can be
> landed timely. Thx.
Nope this isn't ready yet
Michael137 wrote:
> Would confuse `DwarfDebug` without your changes/this patch? Or only with this
> patch? (& hopefully there's some way to reach the merge globals
> functionality/problem/interesting IR from clang itself - but I guess even if
> it isn't, this is still a demonstration of repres
Michael137 wrote:
> Can we add back the constant to the declaration? It's been a week and the
> progress on #72730 seems to have stalled while our builders are still broken.
Yup will do, apologies for the noise
https://github.com/llvm/llvm-project/pull/71780
___
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/73626
In #71780 we started emitting definitions for all static data-members with
constant initialisers, even if they were constants (i.e., didn't have a
location). We also dropped the DW_AT_const_value from the dec
Michael137 wrote:
FYI @petrhosek
https://github.com/llvm/llvm-project/pull/73626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/73626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
I do wonder how feasible it would be for the downstream tests to be adjusted to
look at the `DW_AT_location`..
https://github.com/llvm/llvm-project/pull/73626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
Michael137 wrote:
> > I do wonder how feasible it would be for the downstream tests to be
> > adjusted to look at the `DW_AT_location`..
>
> As I mentioned on the other thread, the point is not to have to read the
> value from the process-under-debug. This is not efficient in a
> remote-debug
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/73626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Looks like LLDB linux buildbot isn't happy, checking...
https://github.com/llvm/llvm-project/pull/73626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
> Looks like LLDB linux buildbot isn't happy, checking...
Fix in https://github.com/llvm/llvm-project/pull/73707
https://github.com/llvm/llvm-project/pull/73626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/72974
>From 012096290352438668d8f4bb7a97179952a87a3a Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sat, 18 Nov 2023 00:20:05 +
Subject: [PATCH] [clang][DebugInfo] Create evaluateConstantInitializer helper
f
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/72974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Test fix in flight...
https://github.com/llvm/llvm-project/pull/72974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Michael Buch
Date: 2023-11-30T11:13:36Z
New Revision: c80b91bce3a5a92281ad1c7e090ac25e7a5bd395
URL:
https://github.com/llvm/llvm-project/commit/c80b91bce3a5a92281ad1c7e090ac25e7a5bd395
DIFF:
https://github.com/llvm/llvm-project/commit/c80b91bce3a5a92281ad1c7e090ac25e7a5bd395.diff
LOG:
Michael137 wrote:
> Should've mentioned this earlier, but we've been seeing crashes in lldb due
> to this change (though possibly related to our use of GALA python/gdb interop
> https://github.com/sivachandra/gala - we haven't isolated the failures from
> that yet (though we've been using it f
Michael137 wrote:
> Yeah, that seems to do it:
>
> ```
>
> struct t1 {
>
> t1();
>
> static int i;
>
> };
>
> int t1::i = 43;
>
> int main() {
>
> }
>
> ```
>
> ```
>
> $ clang++-tot -gsplit-dwarf -g test.cpp
>
> $ lldb ./a.out -o "b main" -o "run" -o "p t1::i" -batch
>
> This is
Michael137 wrote:
Ah looks like in `GetClangDeclForDIE`, when trying to parse the
`DW_AT_specification` that the CU-level `DW_TAG_variable` points to, we now try
to `CreateVariableDeclaration`, because the static member is a
`DW_TAG_variable` too. Whereas previously we would just fall-through
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/77079
Prior to `e9536698720ec524cc8b72599363622bc1a31558`
(https://reviews.llvm.org/D154764) we only re-ordered the fields of
`RecordDecl`s. The change refactored this logic to make sure `FieldDecl`s are
imported
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Need to sort out some test failures
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/77079
>From 544e2b12695fa572b08abc8efdceeadd63ebbde5 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 5 Jan 2024 10:41:55 +
Subject: [PATCH 1/2] [clang][ASTImporter] Only reorder fields of RecordDecls
Pri
Michael137 wrote:
> I can not check what caused exactly the problems but the change looks correct
> and in change D154764 there seems to be no reason for re-ordering at
> non-record objects. As an improvement, some tests could be added that check
> for re-ordering at `RecordDecl` and (this is
Michael137 wrote:
I guess if there's some other type of ObjC decl that could trigger the
re-ordering that would be useful.
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
Michael137 wrote:
> Yes, in the totally reduced reproducer - another debugger might be able to do
> this name lookup with only a declaration, but I understand that at least
> Clang's AST expression evaluator wouldn't be able to handle this case.
> (though perhaps the lldb-eval work will provid
Michael137 wrote:
Proposed fix: https://github.com/llvm/llvm-project/pull/77155
https://github.com/llvm/llvm-project/pull/72235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Tried to find a way to test "objective-c fields aren't reordered". After
talking to some objective-c experts, there doesn't seem to be a good way to
force such "incorrect field order", because it's strictly an in-order language.
Reducing the LLDB crashes has been tricky becau
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/77079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
@dwblaikie merged the fix, let me know if you're still seeing problems
https://github.com/llvm/llvm-project/pull/72235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -9896,9 +9903,13 @@ Expected ASTImporter::Import(FileID FromID, bool
IsBuiltin) {
// FIXME: The filename may be a virtual name that does probably not
// point to a valid file and we get no Entry here. In this case try
with
// the memory buffer below
@@ -9896,9 +9903,13 @@ Expected ASTImporter::Import(FileID FromID, bool
IsBuiltin) {
// FIXME: The filename may be a virtual name that does probably not
// point to a valid file and we get no Entry here. In this case try
with
// the memory buffer below
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/84891
It is not uncommon for LLDB users to dig into internal implementation details
of system types (including the STL). LLDB's expression evaluator makes use of
Clang's code-completion facilities but currently res
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/84891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/77920
>From 4de3716b55a22dc8b7dda621889089f390026739 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 12 Jan 2024 12:34:16 +
Subject: [PATCH 1/2] [lldb][test] Add tests for
target.max-string-summary-lengt
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/77920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Michael Buch
Date: 2022-09-16T12:38:50-04:00
New Revision: e456d2ba8bcadaa63386b339a4f2abcb39505502
URL:
https://github.com/llvm/llvm-project/commit/e456d2ba8bcadaa63386b339a4f2abcb39505502
DIFF:
https://github.com/llvm/llvm-project/commit/e456d2ba8bcadaa63386b339a4f2abcb39505502.diff
Author: Michael Buch
Date: 2023-01-27T02:24:32Z
New Revision: 798494ed4f112bf64dcabbe8b60becb42b23208f
URL:
https://github.com/llvm/llvm-project/commit/798494ed4f112bf64dcabbe8b60becb42b23208f
DIFF:
https://github.com/llvm/llvm-project/commit/798494ed4f112bf64dcabbe8b60becb42b23208f.diff
LOG:
Author: Michael Buch
Date: 2023-01-27T02:24:33Z
New Revision: 8b4279b66fc2f535184642b739b573ead1733711
URL:
https://github.com/llvm/llvm-project/commit/8b4279b66fc2f535184642b739b573ead1733711
DIFF:
https://github.com/llvm/llvm-project/commit/8b4279b66fc2f535184642b739b573ead1733711.diff
LOG:
Author: Michael Buch
Date: 2023-01-27T02:24:33Z
New Revision: 3d7dcec5db2f86bd8b9142d180716725a8fc0b0f
URL:
https://github.com/llvm/llvm-project/commit/3d7dcec5db2f86bd8b9142d180716725a8fc0b0f
DIFF:
https://github.com/llvm/llvm-project/commit/3d7dcec5db2f86bd8b9142d180716725a8fc0b0f.diff
LOG:
Author: Michael Buch
Date: 2023-01-27T02:24:34Z
New Revision: 29ecf0e62cd7899dee84732a31875179ec4d5a80
URL:
https://github.com/llvm/llvm-project/commit/29ecf0e62cd7899dee84732a31875179ec4d5a80
DIFF:
https://github.com/llvm/llvm-project/commit/29ecf0e62cd7899dee84732a31875179ec4d5a80.diff
LOG:
Author: Michael Buch
Date: 2023-01-27T16:39:17Z
New Revision: d194d817b0b29c6e244d01cf7b836b9e4bbe2794
URL:
https://github.com/llvm/llvm-project/commit/d194d817b0b29c6e244d01cf7b836b9e4bbe2794
DIFF:
https://github.com/llvm/llvm-project/commit/d194d817b0b29c6e244d01cf7b836b9e4bbe2794.diff
LOG:
Author: Michael Buch
Date: 2023-01-23T09:43:17Z
New Revision: bee8860525acbfe33f5b32870ad5e13de07fa6ff
URL:
https://github.com/llvm/llvm-project/commit/bee8860525acbfe33f5b32870ad5e13de07fa6ff
DIFF:
https://github.com/llvm/llvm-project/commit/bee8860525acbfe33f5b32870ad5e13de07fa6ff.diff
LOG:
@@ -574,6 +574,20 @@ benchmarks)
generate-cmake
check-cxx-benchmarks
;;
+check-lldb-data-formatters)
+clean
+${CMAKE}\
+-S "${MONOREPO_ROOT}/llvm" \
+-B "${BUILD_DIR}"
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/65174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/65174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Michael Buch
Date: 2023-06-20T09:19:19+01:00
New Revision: c146df9618764d5548c38ce61edc45147094b26f
URL:
https://github.com/llvm/llvm-project/commit/c146df9618764d5548c38ce61edc45147094b26f
DIFF:
https://github.com/llvm/llvm-project/commit/c146df9618764d5548c38ce61edc45147094b26f.diff
Author: Michael Buch
Date: 2023-04-07T01:37:36+01:00
New Revision: 711a64412749ae73709562b591ab1609a3ee7751
URL:
https://github.com/llvm/llvm-project/commit/711a64412749ae73709562b591ab1609a3ee7751
DIFF:
https://github.com/llvm/llvm-project/commit/711a64412749ae73709562b591ab1609a3ee7751.diff
Author: Michael Buch
Date: 2022-12-14T22:31:45Z
New Revision: 5996ce17fb265e461b5d580c1873cb8e3ff8d62d
URL:
https://github.com/llvm/llvm-project/commit/5996ce17fb265e461b5d580c1873cb8e3ff8d62d
DIFF:
https://github.com/llvm/llvm-project/commit/5996ce17fb265e461b5d580c1873cb8e3ff8d62d.diff
LOG:
Author: Michael Buch
Date: 2022-12-14T22:31:46Z
New Revision: c9861e5718f6352bb1ee9fe6b5c3e16a0e649360
URL:
https://github.com/llvm/llvm-project/commit/c9861e5718f6352bb1ee9fe6b5c3e16a0e649360
DIFF:
https://github.com/llvm/llvm-project/commit/c9861e5718f6352bb1ee9fe6b5c3e16a0e649360.diff
LOG:
Author: Michael Buch
Date: 2022-12-15T02:57:08Z
New Revision: 738bfbce09e700124dbcea55b2cfe7f499250b9c
URL:
https://github.com/llvm/llvm-project/commit/738bfbce09e700124dbcea55b2cfe7f499250b9c
DIFF:
https://github.com/llvm/llvm-project/commit/738bfbce09e700124dbcea55b2cfe7f499250b9c.diff
LOG:
Author: Michael Buch
Date: 2022-12-16T11:38:50Z
New Revision: 98afcbab66505661045dccb85ee9acdbf9410047
URL:
https://github.com/llvm/llvm-project/commit/98afcbab66505661045dccb85ee9acdbf9410047
DIFF:
https://github.com/llvm/llvm-project/commit/98afcbab66505661045dccb85ee9acdbf9410047.diff
LOG:
Author: Michael Buch
Date: 2022-12-16T11:38:51Z
New Revision: 1706f34d604ec304af58a7b95dbc127bd77e17fa
URL:
https://github.com/llvm/llvm-project/commit/1706f34d604ec304af58a7b95dbc127bd77e17fa
DIFF:
https://github.com/llvm/llvm-project/commit/1706f34d604ec304af58a7b95dbc127bd77e17fa.diff
LOG:
Author: Michael Buch
Date: 2022-12-16T11:38:52Z
New Revision: 8d3843badb8a32a56531e383a2a9eb5b07ae8b0d
URL:
https://github.com/llvm/llvm-project/commit/8d3843badb8a32a56531e383a2a9eb5b07ae8b0d
DIFF:
https://github.com/llvm/llvm-project/commit/8d3843badb8a32a56531e383a2a9eb5b07ae8b0d.diff
LOG:
Author: Michael Buch
Date: 2022-12-16T11:38:54Z
New Revision: 2c22cfd4c95606adec311dece051e95e86e3f0f3
URL:
https://github.com/llvm/llvm-project/commit/2c22cfd4c95606adec311dece051e95e86e3f0f3
DIFF:
https://github.com/llvm/llvm-project/commit/2c22cfd4c95606adec311dece051e95e86e3f0f3.diff
LOG:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/96422
>From 419af1b1db2bef88c5145276ffd24ed93bcb15a5 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 21 Jun 2024 12:15:07 +0100
Subject: [PATCH 1/7] [clang][CGRecordLayout] Remove dependency on isZeroSize
Th
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/97443
This patch is motivated by the LLDB support required for:
https://github.com/llvm/llvm-project/issues/93069
In the presence of `[[no_unique_address]]`, LLDB may ask Clang to lay out types
with overlapping fi
@@ -2250,14 +2246,18 @@ void ItaniumRecordLayoutBuilder::UpdateAlignment(
}
}
-uint64_t
-ItaniumRecordLayoutBuilder::updateExternalFieldOffset(const FieldDecl *Field,
- uint64_t ComputedOffset)
{
+uint64_t ItaniumRecordLa
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/97443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Had to adjust `isEmptyFieldForLayout`/`isEmptyRecordForLayout` because
`isEmptyField`/`isEmptyRecord` would call each other recursively, so
dispatching from `isEmptyFieldForLayout` wouldn't have been correct (since the
`isEmptyField`/`isEmptyRecord` have extra checks for unna
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/96422
>From 7fb44b1cd3ffac0a0f509cefa3a141dac50da142 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 21 Jun 2024 12:15:07 +0100
Subject: [PATCH 1/8] [clang][CGRecordLayout] Remove dependency on isZeroSize
Th
Michael137 wrote:
Thanks for taking a stab at this and for the analysis. You rightly point out
that this is the root problem:
> If an implicit import happens between (2) and (3), it may indirectly bring
> the same field into the context. When (3) happens we add it again,
> duplicating the f
Michael137 wrote:
> As I understand it, minimal import is used in LLDB for performance reasons,
> so we don't waste time parsing and loading AST elements that we don't need.
> It sounds like a fine idea in general. Implicit imports of external sources
> in Clang, however, turn import process i
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/100355
>From 2b1255de05856e4c79f58d3e4071384ba80a881d Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 18 Jul 2024 16:26:16 -0500
Subject: [PATCH 1/3] [clang][Sema] Don't mark VarDecls of bindings in
tuple-li
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/100355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,4 +1,4 @@
-// RUN: %clang -g -std=c++11 -S -emit-llvm %s -o - | FileCheck %s
+// RUN: %clang -ggdb -std=c++11 -S -emit-llvm %s -o - | FileCheck %s
Michael137 wrote:
Do we now lose a tiny bit of coverage for `-glldb`? I assume this change is to
make sure th
@@ -5361,7 +5383,56 @@ static bool IsReconstitutableType(QualType QT) {
return T.Reconstitutable;
}
-std::string CGDebugInfo::GetName(const Decl *D, bool Qualified) const {
+bool CGDebugInfo::HasReconstitutableArgs(
+ArrayRef Args) const {
+ return llvm::all_of(Args, [&
@@ -251,15 +423,16 @@ class Qualifiers {
}
// Deserialize qualifiers from an opaque representation.
- static Qualifiers fromOpaqueValue(unsigned opaque) {
+ static Qualifiers fromOpaqueValue(uint64_t Opaque) {
Qualifiers Qs;
-Qs.Mask = opaque;
+Qs.Mask = uin
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/84384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
LGTM, but would like @rjmccall or @AaronBallman (or another code-owner) to give
final approval
https://github.com/llvm/llvm-project/pull/84384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
Michael137 wrote:
> Given the libc++ experience, let's move forward with this PR as-is. If
> there's an issue in practice, we'll disable the tests on changes to Clang at
> that point.
Do note that libc++ CI only runs a subset of the LLDB tests. Only the ones that
are impacted by libc++. We co
Michael137 wrote:
> > > The correct answer here is probably to fix the sizes in the RecordLayout
> > > itself; in particular, the DataSize of the members.
> >
> >
> > That would be ideal, but also means we'd have to reflect the various C++
> > attributes that affect layout in DWARF. Avoiding
Michael137 wrote:
Yea the problem with checking the size reported by the AST layout vs. the LLVM
type layout is that in DWARF we get following representation:
```
// main.cpp
struct A {
long c, d;
};
struct B {
[[no_unique_address]] Empty x;
};
struct C {
[[no_unique_address]] Empty x;
}
Michael137 wrote:
Ah got it, thanks for clarifying.
> so we could instead just check if the field is empty.
Couldn't find an existing API for this on `FieldDecl`. Here "empty" would be
"field is of a type which is empty"? Which might still cause complications
because a `CXXRecordDecl::isEmpty
@@ -27,6 +27,9 @@ namespace llvm {
}
}
+// Prefix for __builtin_verbose_trap.
+#define CLANG_VERBOSE_TRAP_PREFIX "__llvm_verbose_trap"
Michael137 wrote:
Not a big deal for LLDB either way, whatever people prefer here, we can work
around it.
https://github
Michael137 wrote:
I'm going to revert this for now until since the bots have been red for a while
now
https://github.com/llvm/llvm-project/pull/92865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/93809
This is the outcome of the discussions we had in
https://discourse.llvm.org/t/rfc-lldb-handling-no-unique-address-in-lldb/77483
To summarize, LLDB creates AST nodes by parsing debug-info and hands those off
t
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/93809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/93809
>From 91276f5b2dc05032a285b465c0c8a69541bb25c4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 2 May 2024 09:05:01 +0100
Subject: [PATCH 1/2] [clang][lldb] Don't assert structure layout correctness
for
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/93809
>From 91276f5b2dc05032a285b465c0c8a69541bb25c4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 2 May 2024 09:05:01 +0100
Subject: [PATCH 1/3] [clang][lldb] Don't assert structure layout correctness
for
Michael137 wrote:
> The correct answer here is probably to fix the sizes in the RecordLayout
> itself; in particular, the DataSize of the members.
That would be ideal, but also means we'd have to reflect the various C++
attributes that affect layout in DWARF. Avoiding adding such language-spec
Michael137 wrote:
Worth a shot i guess. Though it could be somewhat disruptive if we do in fact
have flaky tests. I don't think we need to run *all* tests. Should we just run
the tests for the LLDB C++ language plugin (i.e., the part of LLDB that invokes
Clang and the JIT). And then we could e
Michael137 wrote:
I.e., also broke the macOS LLDB buildbots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/2637/execution/node/97/log/
```
Assertion failed: (!((*IDAddress) >> 48) && "We should only set the module ID
once"), function setOwningModuleID, file DeclBase.cpp, lin
Michael137 wrote:
> > Should we just run the tests for the LLDB C++ language plugin (i.e., the
> > part of LLDB that invokes Clang and the JIT). And then we could expand the
> > set of tests from there later?
>
> In the bash script that currently handles this, "targets that we need to
> check
Michael137 wrote:
> @Michael137 This is for Linux. Windows works the same way just below those
> lines:
>
> https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255
Ah, so what would the issue be with just adding more
Michael137 wrote:
Unfortunately this is still failing one test on the macOS CI:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/5083/execution/node/97/log
```
==
FAIL: test_duplicate_decls_gmodules
(TestTem
Michael137 wrote:
> Oh, this is not wanted. It should be almost a NFC patch for users. I'll
> revert it.
Thanks!
https://github.com/llvm/llvm-project/pull/92083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -5361,7 +5383,56 @@ static bool IsReconstitutableType(QualType QT) {
return T.Reconstitutable;
}
-std::string CGDebugInfo::GetName(const Decl *D, bool Qualified) const {
+bool CGDebugInfo::HasReconstitutableArgs(
+ArrayRef Args) const {
+ return llvm::all_of(Args, [&
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const
TemplateSpecializationType *Ty,
auto PP = getPrintingPolicy();
Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None);
+ SourceLocation Loc = AliasDecl->getLocation();
+
+ if (CGM.getCodeGenO
Michael137 wrote:
Btw, as a follow-up to this patch should we check that this is compatible with
dsymutil (i.e., running `dsymutil --verify`)? I suspect it might need a fixup
(given LLDB doesn't even support this tag)
https://github.com/llvm/llvm-project/pull/87623
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const
TemplateSpecializationType *Ty,
auto PP = getPrintingPolicy();
Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None);
+ SourceLocation Loc = AliasDecl->getLocation();
+
+ if (CGM.getCodeGenO
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/87623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const
TemplateSpecializationType *Ty,
auto PP = getPrintingPolicy();
Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None);
+ SourceLocation Loc = AliasDecl->getLocation();
+
+ if (CGM.getCodeGenO
@@ -1313,6 +1313,61 @@ llvm::DIType *CGDebugInfo::CreateType(const
BlockPointerType *Ty,
return DBuilder.createPointerType(EltTy, Size);
}
+static llvm::SmallVector
+GetTemplateArgs(const TemplateDecl *TD, const TemplateSpecializationType *Ty) {
+ assert(Ty->isTypeAlias())
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const
TemplateSpecializationType *Ty,
auto PP = getPrintingPolicy();
Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None);
+ SourceLocation Loc = AliasDecl->getLocation();
+
+ if (CGM.getCodeGenO
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const
TemplateSpecializationType *Ty,
auto PP = getPrintingPolicy();
Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None);
+ SourceLocation Loc = AliasDecl->getLocation();
+
+ if (CGM.getCodeGenO
101 - 200 of 511 matches
Mail list logo
