[PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 created this revision. Michael137 added reviewers: aprantl, martong. Herald added a subscriber: rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLDB. He

[PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: clang/lib/AST/DeclBase.cpp:1781 if (Name && !hasLazyLocalLexicalLookups() && !hasLazyExternalLexicalLookups()) { if (StoredDeclsMap *Map = LookupPtr) { Could mer

[PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 updated this revision to Diff 460420. Michael137 added a comment. - Merge if-blocks - Reword commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp clang/u

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 updated this revision to Diff 460429. Michael137 added a comment. - Undo incorrect previous change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp clang/un

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1781 if (Name && !hasLazyLocalLexicalLookups() && !hasLazyExternalLexicalLookups()) { if (StoredDeclsMap *Map = LookupPtr) { Michael137 wrote: > Could merge the two if-blocks

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. In D123319#3680169 , @aprantl wrote: > Sorry for the silence — I was out on vacation. > > @Michael137 has recently started looking into improving support for C++ > lambdas in LLDB. > Michael, would you be interested in taking

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. In D123319#3682929 , @dblaikie wrote: > In D123319#3681884 , @Michael137 > wrote: > >> In D123319#3680169 , @aprantl >> wrote: >> >>> Sorry f

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. FYI, had an offline chat with @dblaikie and we decided that the best way forward would be to try stop emitting auto return types in DWARF, instead of relying on lambda/member-function specific hacks. Not sure what the timeline on this will be but tracking it internal

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. FYI, this broke the LLDB build bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46324/execution/node/74/log/ Looks like we're testing that unused parameters optimise out but that's not the case anymore `AssertionError: '(void *) unused1 = ' not found i

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added subscribers: aprantl, dblaikie. Michael137 added a comment. In D128830#3745069 , @psamolysov wrote: > @Michael137 Thank you very much for the information! > > I'm not sure, but it looks like the introduced change of the `readnone` > att

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. In D128830#3746153 , @aprantl wrote: > I think we can "fix" the test with the following patch: > > diff --git a/lldb/test/API/functionalities/unused-inlined-parameters/main.c > b/lldb/test/API/functionalities/unused-inlined-

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. Noted, thanks for the heads up AFAIK, the only test that'd now fail on the debug-info side is: https://reviews.llvm.org/D132664 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 updated this revision to Diff 460718. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp clang/unittests/AST/ASTImporterT

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGe456d2ba8bca: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 added a comment. Michael137 updated this revision to Diff 484341. Michael137 added a reviewer: labath. Michael137 edited the summary of this revision. Michael137 added a reviewer

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492182. Michael137 added a comment. - Set `IsDefaulted` when checking template arguments in `clang::Sema` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492184. Michael137 added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/PropertiesBase.td clang/inc

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492187. Michael137 added a comment. - Don't need to pass flag to NewArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/Propertie

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. Latest diff now sets the `IsDefaulted` flag from `Sema::CheckTemplateArgumentList`, which is the best point I could find for creation of `TemplateArgument` which are fed into the various specialization decls (and later on the `TypePrinter`). The review description h

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492306. Michael137 added a comment. - Remove redundant constructor call change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/Pro

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for `TemplateArgumen

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 abandoned this revision. Michael137 added a comment. Abandoning in favour of https://reviews.llvm.org/D141826 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140423/new/ https://reviews.llvm.org/D140423 ___

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2020 + Expr const *pattern_expr = Pattern.getAsExpr(); + pattern_expr->dump(); + if (pattern_expr->isValueDependent() || erichkeane wrote: > this left over from debugging? Yes! Good ca

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 updated this revision to Diff 492458. Michael137 added a comment. - Remove `dump()` leftover from debugging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142632/new/ https://reviews.llvm.org/D142632 Files: clang/lib/AST/TypePrinter.cp

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2031 +if (args_expr->isValueDependent() || !args_expr->isIntegerConstantExpr(Ctx)) + return false; + aprantl wrote: > Just for my own education: what's an example for a value-de

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2019 + // Can't evaluate value-dependent expressions so bail early + Expr const *pattern_expr = Pattern.getAsExpr(); + if (pattern_expr->isValueDependent() || aprantl wrote: > I assume

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG798494ed4f11: [clang][TypePrinter] Support expression template arguments when checking… (authored by Michael137). Repository: rG LLVM Github Monor

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4279b66fc2: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29ecf0e62cd7: [clang][DebugInfo] Check TemplateArgument::IsDefaulted (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141827: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7dcec5db2f: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default… (authored by Michael137). Repository: rG LLVM Github

[PATCH] D141827: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 added a comment. This caused some LLDB test failures for the `import-std-module` setting. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ We construct `TemplateArgument`s manually in the `CxxModuleHandler`. Fix is in-flight. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

Michael137 created this revision. Michael137 added reviewers: martong, aprantl. Herald added a subscriber: rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

Michael137 updated this revision to Diff 492728. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142713/new/ https://reviews.llvm.org/D142713 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/AST

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd194d817b0b2: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import (authored by Michael137). Repository: rG LLVM Github Mono

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. From a first glance looks ok but ideally the clang changes would be a separate review. Particularly the ASTImporter change could use a unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.l

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch adds a `IsDefaulted` field to

[PATCH] D141827: [WIP][clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch allows clients who can't prop

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 added a comment. In D140423#4052442 , @aaron.ballman wrote: > In D140423#4052271 , @dblaikie > wrote: > >> In D140423#4051262 , >> @aaron.ballman wrote: >> >

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. In D141826#4058866 , @erichkeane wrote: > This seems innocuous enough/easy enough to use. I'd like a comment on the > functions at least and types in TemplateBase.h to specify that this is for > printing-policy only? Alter

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch c

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 updated this revision to Diff 491015. Michael137 added a comment. - Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142268/new/ https://reviews.llvm.org/D142268 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 added a comment. @dblaikie suggested that the best way to go about the recurring "how do we print template names" question is to turn on `-gsimple-template-names` on by default. For alias templates this means we would have to attach template parameters to their DIEs too. Repository

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 491251. Michael137 added a comment. - `setIsDefaulted` when constructing `ClassTemplateSpecializationDecl`s - Propagate `IsDefaulted` on serialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/

[PATCH] D141827: [WIP][clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 updated this revision to Diff 491254. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141827/new/ https://reviews.llvm.org/D141827 Files: clang/lib/AST/TypePrinter.cpp Index: clang/lib/AST/TypePrin

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since `ClassTemplateSpecializationDecl`s now set the `TemplateArgument:

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbee8860525ac: [clang][DebugInfo] Don't canonicalize names in template argument list for alias… (authored by Michael137). Repository: rG LLVM Githu

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. In D141826#4059088 , @erichkeane wrote: > In D141826#4059073 , @Michael137 > wrote: > >> In D141826#4058866 , @erichkeane >> wrote: >> >>> T

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 added a comment. In D142268#4072358 , @dblaikie wrote: > So @Michael137 and I talked about this offline, and a few extra details: > > - Generally it's important that types have identical names. Templates try to > do this, but get it wrong in a

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

Michael137 updated this revision to Diff 491257. Michael137 added a comment. - Make variable `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142333/new/ https://reviews.llvm.org/D142333 Files: clang/lib/CodeGen/CGDebugInfo.cpp Index: cla

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 491265. Michael137 added a comment. - Rename test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/PropertiesBase.td clang/includ

[PATCH] D142024: [clang] Optimize clang::Builtin::Info density

Michael137 added a comment. Seems like this broke the LLDB incremental build: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/50184/execution/node/43/log/?consoleFull We build with `LLVM_ENABLE_MODULES` by default While building module 'Clang_Basic' imported from /Users/buildslave/

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

Michael137 added a comment. Could you please elaborate in the commit message what exactly the issue currently is and how the patch addresses it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 __

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 created this revision. Michael137 added reviewers: martong, balazske. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: cla

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 updated this revision to Diff 538110. Michael137 added a comment. - Remove redundant header additions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154709/new/ https://reviews.llvm.org/D154709 Files: clang/include/clang/AST/ASTImportE

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 added a comment. Didn't add tests for this since checking the contents of the error message didn't seem worth testing. But don't mind adding tests if reviewers feel more comfortable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154709/ne

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError and use it throughout ASTImporter

Michael137 updated this revision to Diff 538111. Michael137 added a comment. - Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154709/new/ https://reviews.llvm.org/D154709 Files: clang/include/clang/AST/ASTImportError.h clang/

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError and use it throughout ASTImporter

Michael137 added a comment. In D154709#4487776 , @balazske wrote: > The goal is to have a message always in `ASTImportError`? Then probably the > constructor without message can be removed, at least to check if really the > message is added at all place

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 506588. Michael137 added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Fix cycle in `DIDerivedType` when we deal with forward declarations and complete explicitly via `completeClassData` (e.g., with `-gmodules`) - Add

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2640 if (!D || !D->isCompleteDefinition()) -return FwdDecl; +return {FwdDecl, nullptr}; aprantl wrote: > I'm curious if this works if we encounter a forward declaration,

[PATCH] D144651: [Serialization] Place command line defines in the correct file

Michael137 added a comment. FWIW here's some info on how we get to the assert. Maybe someone with more understanding of the `clang::SourceManager` and how it interacts with `.pcm`s will be able to spot something. Here's a bit more of the stack trace: frame #41: 0x00013844c7e0 liblldb.17

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + probinson wrote: > This doesn't become `Foo` ? The name stays as `Foo>` but the type of the template parameter becomes `BarInt`. So the dwarf would lo

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508562. Michael137 added a comment. - Refine tests: - Check for type of template parameter - Add test for chained typedefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508563. Michael137 added a comment. - Fix function docstring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + dblaikie wrote: > Michael137 wrote: > > probinson wrote: > > > This doesn't become `Foo` ? > > The nam

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. In D145803#4220124 , @wolfgangp wrote: > In D145803#4219894 , @probinson > wrote: > >> This is pretty different from the "always desugar to the canonical type" >> habit that has alway

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, we now emit a `DW_AT_LLVM_preferred_name` for the `[cl

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501540. Michael137 added a comment. - Remove redundant TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501544. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/C

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Since the new attribute only gets attached to a structure definition, and the preferred_name attribute is currently only really used in a handful of places in libcxx, this practically doesn't affect debug-info size Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501568. Michael137 added a comment. - Add test case for multiple alias templates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebug

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501569. Michael137 added a comment. - Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CG

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 added a comment. Michael137 updated this revision to Diff 504274. Michael137 updated this revision to Diff 504276. Michael137 edited the summary of this revision. Michael137 added a revie

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Making use of this in LLDB (see https://reviews.llvm.org/D145078) was a bit too finicky for my taste, so I prepared an alternative which doesn't require adding a new attribute and no LLDB changes. I *think* this is what @aprantl and @dblaikie had in mind couple of we

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. In D145803#4186805 , @dblaikie wrote: > Yeah, can't say this had occurred to me - but totally makes sense/reckon it's > OK. Any reason to limit this to lldb? I'd expect it'd probably "Just > Work(tm)" on any DWARF consumer?

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. Apparently some Objective-C/gmodules LLDB tests aren't happy with this change Investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 _

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently we emit `DW_AT_deleted` for `deleted` speci

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Michael137 updated this revision to Diff 532664. Michael137 added a comment. - fix test comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153282/new/ https://reviews.llvm.org/D153282 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Code

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

This revision was automatically updated to reflect the committed changes. Closed by commit rGc146df961876: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch impl

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 updated this revision to Diff 532952. Michael137 added a comment. Herald added a subscriber: ormris. - remove redundant includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 Files: clang/l

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 updated this revision to Diff 532957. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenC

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1482 +if (prev_base) { + clang::CXXRecordDecl *prev_base_decl = + prev_base->getType()->getAsCXXRecordDecl(); Should we add a comment desc

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. I'll submit later today then if nobody has any other objections Will add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1481 +// To fix this we scan base classes in reverse order to determine +// overlapping offsets. Wnen found we consider such class as empty +// base with all fie

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { + clang::CXXReco

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/test/API/types/TestEmptyBase.py:25-42 +def test(self): +"""Test that recursive structs are displayed correctly.""" +self.build(dictionary=self.sources) +self.setTearDownCleanup(dictionary=self.sources)

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. FYI, this bugfix was attempted back in 2021 here: https://reviews.llvm.org/D101237 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG711a64412749: [clang][DebugInfo] Emit DW_AT_type of preferred name if available (authored by Michael137). Repository: r

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

Michael137 added a comment. Thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. Looks like `gmodules` isn't supported on AIX (based on other tests that use `-dwarf-ext-refs`. So I'll just disable the new tests Thanks for notifying @aaron.ballman , email notifications got lost in the inbox Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a subscriber: Jake-Egan. Michael137 added a comment. Oh looks like @Jake-Egan already did Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___ c

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added subscribers: aprantl, dblaikie. Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/no_unique_address/main.cpp:38 + long v = 42; +} _f3; + I haven't checked the reworked logic yet, but it still crashes on this: ``` self.expect_e

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true; Generally

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. **Summary** This patch makes debug-info generation a

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. Herald added a subscriber: JDevlieghere. The alternative would be attaching the preferred name as a new attribute or an existing attribute like `DW_AT_description`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143501/ne

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61 if self.expectedCompilerVersion(['>', '16.0']): +string_type = "std::string"

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: clang/test/CodeGen/debug-info-preferred-names.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o - -debugger-tuning=lldb | FileCheck --check-prefixes=COMMON,LLDB %s +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=lim

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. In D143501#4113347 , @aprantl wrote: > Nice! Does `expr -- std::basic_string s` still work after this change? > Not that anyone would want to type this over `std::string` ... Yup that still works. We would still emit it as `b

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 updated this revision to Diff 496089. Michael137 added a comment. - Reword commit - Use different debuginfo kind in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143501/new/ https://reviews.llvm.org/D143501 Files: clang/lib/Code

  1   2   >