W dniu pon, 02.10.2017 o godzinie 13∶33 -0700, użytkownik George
Karpenkov napisał:
> > On Oct 2, 2017, at 12:57 PM, Michał Górny via Phabricator
> > wrote:
> >
> > mgorny added a comment.
> >
> > In https://reviews.llvm.org/D38444#886138, @george.karpenkov wrote:
> >
> > > > breaking stand-al
On Tue, 2019-01-15 at 13:10 -0500, Nico Weber wrote:
> The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since
> they all fail there (due to lib/libclang.so not existing).
Hmm, maybe we could make them conditional to the existence
of libclang.so target? Would that work for you?
>
On Wed, 2019-08-07 at 17:10 -0300, Adhemerval Zanella wrote:
> On 05/06/2019 05:19, Michał Górny via Phabricator via llvm-commits wrote:
> > This revision was automatically updated to reflect the committed changes.
> > Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027
> >
On Wed, 2019-08-07 at 17:10 -0300, Adhemerval Zanella wrote:
> On 05/06/2019 05:19, Michał Górny via Phabricator via llvm-commits wrote:
> > This revision was automatically updated to reflect the committed changes.
> > Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027
> >
On Wed, 2018-12-19 at 21:51 +0100, Joerg Sonnenberger wrote:
> On Tue, Dec 18, 2018 at 04:35:54PM +, Michał Górny via Phabricator via
> cfe-commits wrote:
> > mgorny created this revision.
> > mgorny added reviewers: krytarowski, pcc.
> >
> > Avoid passing -faddrsig by default on NetBSD. Thi
Author: Michał Górny
Date: 2020-06-17T19:00:26+02:00
New Revision: d4f298c8206b435ce627b022efa0d5da620019cd
URL:
https://github.com/llvm/llvm-project/commit/d4f298c8206b435ce627b022efa0d5da620019cd
DIFF:
https://github.com/llvm/llvm-project/commit/d4f298c8206b435ce627b022efa0d5da620019cd.diff
Author: Michał Górny
Date: 2020-05-01T21:22:51+02:00
New Revision: cac8cd0a16e9c0410e33aaca93c760c503eeb68e
URL:
https://github.com/llvm/llvm-project/commit/cac8cd0a16e9c0410e33aaca93c760c503eeb68e
DIFF:
https://github.com/llvm/llvm-project/commit/cac8cd0a16e9c0410e33aaca93c760c503eeb68e.diff
Author: Michał Górny
Date: 2020-08-02T08:32:05+02:00
New Revision: 21c165de2a1bcca9dceb452f637d9e8959fba113
URL:
https://github.com/llvm/llvm-project/commit/21c165de2a1bcca9dceb452f637d9e8959fba113
DIFF:
https://github.com/llvm/llvm-project/commit/21c165de2a1bcca9dceb452f637d9e8959fba113.diff
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Stop stripping -m32 from the user-supplied flags. There is no valid reason to
do that, stripping it silently is thoroughly confusing and makes it impossi
mgorny created this revision.
mgorny added reviewers: rsmith, beanz, samsonov.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Fix the test run to declare missing HAVE_LIBZ value in stand-alone builds,
using the LLVM_ENABLE_ZLIB that is exported in LLVMConfig.cmak
mgorny added a comment.
For the record: I've tested the patch with and without zlib installed, using
in-tree and stand-alone builds.
https://reviews.llvm.org/D24869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Declare __STDC_FORMAT_MACROS, __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS
before including real inttypes.h/stdint.h when the wrapper-header is included
in C++11, in order to enable the neces
mgorny added a comment.
In https://reviews.llvm.org/D24903#551890, @rmaprath wrote:
> When the `` headers where split into `` and `` headers in
> https://reviews.llvm.org/D12747, we have left out `` and ``.
> I was going to put up a patch to fix this but couldn't get to it. It's good
> that yo
mgorny updated this revision to Diff 72441.
https://reviews.llvm.org/D24903
Files:
include/inttypes.h
include/stdint.h
Index: include/stdint.h
===
--- /dev/null
+++ include/stdint.h
@@ -0,0 +1,121 @@
+// -*- C++ -*-
+//===--
mgorny marked an inline comment as done.
mgorny added a comment.
In https://reviews.llvm.org/D24903#551890, @rmaprath wrote:
> When the `` headers where split into `` and `` headers in
> https://reviews.llvm.org/D12747, we have left out `` and ``.
> I was going to put up a patch to fix this but
mgorny added inline comments.
Comment at: include/stdint.h:25
@@ +24,3 @@
+INT8_MAX
+INT16_MAX
+INT32_MAX
Are you referring to the way __STDC_LIMIT_MACROS etc. is handled there? Or
something more?
https://reviews.llvm.org/D24903
_
mgorny updated this revision to Diff 72492.
https://reviews.llvm.org/D24903
Files:
include/inttypes.h
include/stdint.h
Index: include/stdint.h
===
--- /dev/null
+++ include/stdint.h
@@ -0,0 +1,132 @@
+// -*- C++ -*-
+//===--
mgorny added a comment.
@EricWF, I've copied the additional unset logic from clang. Does this address
all of your concerns?
By the way, I think clang misses __STDC_FORMAT_MACROS for inttypes.h. I'll
write a patch for that as well, for consistency.
https://reviews.llvm.org/D24903
__
mgorny created this revision.
mgorny added a reviewer: rsmith.
mgorny added a subscriber: cfe-commits.
Define `__STDC_FORMAT_MACROS` in order to enable all macros defined by
inttypes.h in C++ mode, as was required by the C99 standard and was enforced by
multiple old glibc versions. This extends
mgorny added a comment.
By the way, if anyone happens to have a 'more final' copy of the standards
handy, feel free to provide a more consistent footnote numbers ;-).
https://reviews.llvm.org/D24921
___
cfe-commits mailing list
cfe-commits@lists.ll
mgorny added a comment.
Ok. Thanks for the review.
https://reviews.llvm.org/D24903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282435: [include] Declare __STDC_*_MACROS for C++11 compat
in old libc (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24903?vs=72492&id=72552#toc
Repository:
rL LLVM
https:
mgorny added a comment.
In https://reviews.llvm.org/D24809#553415, @EricWF wrote:
> > Stop stripping -m32 from the user-supplied flags. There is no valid reason
> > to do that, stripping it silently is thoroughly confusing and makes it
> > impossible to do distribution multi-ABI builds without
mgorny retitled this revision from "[libcxx] [cmake] Stop stripping -m32 from
compiler flags" to "[libcxx] [cmake] Strip possibly-inherited compiler flags in
in-tree build only".
mgorny updated the summary for this revision.
mgorny added a reviewer: beanz.
mgorny updated this revision to Diff 726
mgorny added a comment.
@rafael, ping. Could you review this, please? This is the solution you
suggested on the bug.
https://reviews.llvm.org/D23754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
mgorny created this revision.
mgorny added reviewers: rafael, theraven, ismail.
mgorny added a subscriber: cfe-commits.
Assume OpenSUSE distribution only when /etc/SuSE-release indicates OpenSUSE,
rather than for any SUSE distribution. This reverts the behavior change from
rL185537 which -- alon
This revision was automatically updated to reflect the committed changes.
mgorny marked an inline comment as done.
Closed by commit rL282475: [cmake] Strip possibly-inherited compiler flags in
in-tree build only (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24809?vs=7
mgorny marked an inline comment as done.
mgorny added a comment.
Thanks for the review. Tested and committing now.
Comment at: CMakeLists.txt:310
@@ -309,4 +309,3 @@
-# Remove flags that may have snuck in.
-remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG
- -stdlib=libc++ -
mgorny retitled this revision from "[ToolChains] Do not assume OpenSUSE for
other SUSE variants" to "[ToolChains] Disable OpenSUSE rules for SLES10".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 72609.
mgorny added a comment.
Does this one look better for you
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282483: [cmake] Add linker option "-Wl,-z,defs" in
standalone build (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24119?vs=69944&id=72632#toc
Repository:
rL LLVM
https://r
mgorny reopened this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
I'm starting to regret that I've committed this. It breaks horribly any
pure-LLVM build, i.e. without linking to libgcc_s. It seems that the build
system is completely unprepared to link to co
mgorny added a comment.
In https://reviews.llvm.org/D24119#554251, @rmaprath wrote:
> Doesn't `-DLIBCXXABI_USE_LLVM_UNWINDER=ON` make it possible to build without
> `libgcc_s`? Or is this something else?
It's supposed to but it doesn't add the necessary libraries when linking
libc++.so.
Rep
mgorny created this revision.
mgorny added reviewers: danalbert, EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Update LLVM_CMAKE_PATH in stand-alone builds to match the new install layout
used by LLVM 3.9+ where CMake files are installed into lib*/cmake/
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Include an appropriate unwinder library (-lunwind or -lgcc_s) when constructing
a linker script for libc++. This is necessary since otherwise clang++ set
mgorny added a comment.
In https://reviews.llvm.org/D25008#555041, @rmaprath wrote:
> The patch generally makes sense to me.
>
> I wonder if the test configuration can also benefit from this;
> `test/libcxx/test/target_info.py` manually updates the link line to use
> `-lgcc_s` or `-lunwind` dep
mgorny added a comment.
Side note: I see that gcc is solving similar problem via .spec files for its
libraries, e.g.:
$ cat /usr/lib/gcc/x86_64-pc-linux-gnu/5.4.0/libgomp.spec
# This spec file is read by gcc when linking. It is used to specify the
# standard libraries we need in order to
mgorny added a comment.
@ismail, ping.
https://reviews.llvm.org/D24954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny created this revision.
mgorny added reviewers: EricWF, beanz.
mgorny added a subscriber: cfe-commits.
Adjust the stand-alone build files to accept either CMake files from
LLVM_CMAKE_PATH or from LLVM_MAIN_SRC_DIR instead of requiring both. This
makes it possible to run libcxx tests on t
mgorny added a comment.
Combined with https://reviews.llvm.org/D25076 (on llvm), this lets me run
libcxx test suite on top of installed LLVM+lit, without LLVM sources.
https://reviews.llvm.org/D25093
___
cfe-commits mailing list
cfe-commits@lists.l
mgorny retitled this revision from "cmake: Adjust llvm-lit search to match the
one in LLVM" to "[cmake] Update lit search to match the one in LLVM".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 73192.
Herald added a subscriber: beanz.
https://reviews.llvm.org
mgorny created this revision.
mgorny added reviewers: beanz, samsonov.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, kubabrecka, srhines, danalbert, tberghammer.
Refactor the code to respect COMPILER_RT_BUILD_SANITIZERS and
COMPILER_RT_BUILD_XRAY consistently for both
mgorny retitled this revision from "[compiler-rt] [cmake] Respect
COMPILER_RT_BUILD_* consistently for libs & tests" to "[compiler-rt] [cmake]
Respect COMPILER_RT_BUILD_* for libs, headers and tests".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 73198.
mgorny
mgorny created this revision.
mgorny added reviewers: beanz, doug.gregor.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
Install the 'clang-cpp' symlink used to spawn the preprocessor. The code
handling this suffix is already included in Driver. FreeBSD is already crea
mgorny planned changes to this revision.
mgorny added a comment.
I will be reworking this to use CMake's PRIVATE and PUBLIC linked libs
consistently across the build, linker scripts and possibly tests.
@EricWF, would you prefer if I killed the `add_library_flags*` macros or
extended them to sup
mgorny requested changes to this revision.
mgorny added a reviewer: mgorny.
mgorny added a comment.
This revision now requires changes to proceed.
Few minor nits. However, I'd like to say that I like the idea in general and
see forward to deploy it in Gentoo.
One use case which doesn't seem to h
mgorny added a comment.
Thanks for the review. Proceeding with the commit now.
https://reviews.llvm.org/D25161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny closed this revision.
mgorny added a comment.
I'm going to close this manually since it seems that Phabricator commit
processing is stuck somehow.
https://reviews.llvm.org/D25161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
mgorny abandoned this revision.
mgorny added a comment.
Independently fixed in rL283100.
https://reviews.llvm.org/D25003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, 3 Oct 2016 13:47:08 +
Sjoerd Meijer via cfe-commits wrote:
> I just committed to Clang and noticed that the corresponding Phabricator
> ticket does not get automatically closed (I have "Differential Revision:" in
> my commit message and believe I didn't make a typo).
> Is it just me
mgorny abandoned this revision.
mgorny added a comment.
This is no longer necessary since updated patch to
https://reviews.llvm.org/D23755 handles all the projects using the functions.
https://reviews.llvm.org/D23832
___
cfe-commits mailing list
cf
mgorny added inline comments.
> driver.cpp:314
> +
> +static llvm::cl::SearchResult findConfigFileFromProgramName(
> +llvm::SmallVectorImpl &ConfigName, StringRef ProgramName) {
Please document what this function does, exactly. I see you've documented it in
call site but a doc here would be
mgorny added a comment.
I presume you copied it out of LLVM. If that's the case, please add an comment
above stating where it's been copied from.
https://reviews.llvm.org/D25267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
mgorny created this revision.
mgorny added reviewers: EricWF, asl.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: beanz.
Add LIBUNWIND_* directories to include path only if they were actually
found, in order to fix the CMake error. Both of the directories are
usually unnecessar
mgorny created this revision.
mgorny added a reviewer: ddunbar.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: dberris.
Make the -print-libgcc-file-name option print an appropriate compiler
runtime library, that is libgcc.a if gcc runtime is used
and an appropriate compiler-rt
mgorny retitled this revision from "[libcxx] Include unwinder library in the
linker script" to "[cmake] Split linked libraries into private & public, for
linker script".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 73840.
mgorny added a comment.
Herald added
mgorny updated this revision to Diff 73855.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cpp
+
mgorny marked 2 inline comments as done.
mgorny added a comment.
Updated the docs. I'll look into the test case tomorrow.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
mgorny updated this revision to Diff 73887.
mgorny added a comment.
A simple test case included.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/print-libgcc-file-name.c
Index: test/Driver/print-libgc
mgorny added a comment.
Thanks for the review.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283572: [Driver] Make -print-libgcc-file-name print
compiler-rt lib when used (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25338?vs=73887&id=73953#toc
Repository:
rL LLVM
mgorny added a comment.
It seems that my test doesn't work on Darwin, and I should exclude the libgcc
part there. Do you happen to have any suggestion how to do that?
I'm going to wait for other buildbots to finish to see if I haven't broken any
other platform, then revert it and look for a pro
mgorny planned changes to this revision.
mgorny added a comment.
Reverted, I need to update it to run libgcc part of the test only on platforms
supporting that.
Repository:
rL LLVM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe
mgorny removed rL LLVM as the repository for this revision.
mgorny updated this revision to Diff 73979.
This revision is now accepted and ready to land.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/pri
mgorny requested a review of this revision.
mgorny added a comment.
I have updated the patch to include a feature check for platforms rejecting
`-rtlib=libgcc` and split the test appropriately. Could you re-review, please?
https://reviews.llvm.org/D25338
_
mgorny marked 2 inline comments as done.
mgorny added inline comments.
Comment at: lib/CMakeLists.txt:86
+elseif (LIBCXX_HAS_GCC_S_LIB)
+ list(APPEND LIBCXX_LIBRARIES_PUBLIC gcc_s)
+endif()
EricWF wrote:
> I don't think `libgcc_s` should be considered a public l
mgorny updated this revision to Diff 74019.
mgorny added a comment.
Apple re-export and PRIVATE/PUBLIC covered.
https://reviews.llvm.org/D25008
Files:
CMakeLists.txt
lib/CMakeLists.txt
utils/gen_link_script/gen_link_script.py
Index: utils/gen_link_script/gen_link_script.py
==
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74020.
https://reviews.llvm.org/D25008
Files:
CMakeLists.txt
lib/CMakeLists.txt
utils/gen_link_script/gen_link_script.py
Index: utils/gen_link_script/gen_link_script.py
==
mgorny marked 2 inline comments as done.
mgorny added a comment.
As discussed on IRC, limited the unwinder deps to -lunwind, and I'll work on
making clang include -lunwind by default.
https://reviews.llvm.org/D25008
___
cfe-commits mailing list
cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283659: [cmake] Split linked libraries into private &
public, for linker script (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25008?vs=74020&id=74034#toc
Repository:
rL LLV
mgorny created this revision.
mgorny added reviewers: ddunbar, EricWF, rsmith, phosek.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: dberris.
Include -lunwind by default when libc++ is used as the standard C++
library and compiler-rt used as the runtime library. This aims to m
mgorny planned changes to this revision.
mgorny added a comment.
I knew this looked too easy ;-).
https://reviews.llvm.org/D25402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a reviewer: ggreif.
mgorny updated this revision to Diff 74062.
mgorny added a comment.
Including a fix for montavista toolchain checks that miss passing -rtlib= and
therefore could fail depending on DEFAULT_* value.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang
mgorny updated this revision to Diff 74063.
mgorny added a comment.
I'm sorry, I mixed branches up. Here's the correct patch with both updates.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/montavista
mgorny added a reviewer: joerg.
mgorny updated this revision to Diff 74064.
mgorny added a comment.
I've updated the NetBSD tests (@joerg, please confirm if it's desired), and
added a Linux test for the case. AFAICS most of the other targets override the
method, some of them adding -lunwind alre
mgorny resigned from this revision.
mgorny removed a reviewer: mgorny.
mgorny added a comment.
I have no further comments. However, I'm quite a fresh contributor, so I'm not
really in a position to accept it.
https://reviews.llvm.org/D24933
___
cfe
mgorny updated this revision to Diff 74111.
mgorny added a comment.
Updated to use TC.getCompilerRT().
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/montavista-gcc-toolchain.c
test/Driver/print-libg
mgorny added inline comments.
Comment at: CMakeLists.txt:198
+set(CLANG_DEFAULT_LINKER "" CACHE STRING
+ "Default linker to use (\"bfd\" or \"gold\" or \"lld\", empty for platform
default")
Is there a reason not to allow using the absolute path here, like for
mgorny added a comment.
In https://reviews.llvm.org/D25402#565557, @joerg wrote:
> No, they are not desirable, in fact, they pretty much break clang. That's why
> I wanted to see the test diff...
Thank you for your feedback. However, I would really appreciate if you kindly
said what you meant
mgorny retitled this revision from "[Driver] Pass -lunwind when using libc++ +
compiler-rt" to "[Driver] Pass -lunwind when using libc++ + compiler-rt on
Linux".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74115.
https://reviews.llvm.org/D25402
Files:
li
mgorny added a comment.
I've updated the patch to apply to Linux toolchain only.
https://reviews.llvm.org/D25402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
In https://reviews.llvm.org/D25402#566070, @joerg wrote:
> It's difficult to say whether if one change to certain driver functions
> affect some target or not. That's one reason why the test change is so
> important.
>
> Looking at the latest version, I still don't under
mgorny added a comment.
Thanks for the review.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny created this revision.
mgorny added reviewers: EricWF, theraven.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: beanz.
Build the Solaris compatibility code (C) as a separate static library
rather than appending it to libc++ sources, in order to prevent
the -std=c++11 fla
mgorny added a comment.
In https://reviews.llvm.org/D25431#566096, @theraven wrote:
> It sounds as if the bug here is either that the .c files are being treated as
> c++, or that we're sticking -std=c++{whatever} in CFLAGS as well as CXXFLAGS.
> This is probably the bug that should be fixed.
mgorny closed this revision.
mgorny added a comment.
r283746
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
bruno wrote:
> You should keep using the VFS t
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: modocache, beanz.
Use the -print-libgcc-file-name compiler option to obtain the path to
libgcc or an equivalent compiler runtime library, rather than hardcoding
-lgcc_s.
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74536.
https://reviews.llvm.org/D25568
Files:
cmake/Modules/HandleLibcxxFlags.cmake
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
--- lib/CMa
mgorny updated this revision to Diff 74538.
mgorny added a comment.
Fixed indentation.
https://reviews.llvm.org/D25568
Files:
cmake/Modules/HandleLibcxxFlags.cmake
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
--- lib/CMak
mgorny added a comment.
In https://reviews.llvm.org/D25568#570222, @EricWF wrote:
> This doesn't seem right seeing as `print-libgcc_file-name` prints the
> `libgcc.a` path, and we were previously linking `libgcc_s`.
Do you have any other solution in mind? There is no switch to print the share
mgorny added a comment.
In https://reviews.llvm.org/D25431#570227, @EricWF wrote:
> Why not just compile the sources files as C++ by changing their extensions?
> This change seems all kinds of wrong because we're throwing away *all* of our
> flags, including things like `-m32` or `-target `.
mgorny retitled this revision from "[libcxx] [CMake] Build Solaris compat as
separate C lib, to avoid -std= issues" to "[libcxx] Convert Solaris support
library to C++ to fix -std=c++11 build
".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74666.
mgorny added
mgorny created this revision.
mgorny added reviewers: bruno, rafael, bkramer.
mgorny added subscribers: cfe-commits, bruno.
Use the VFS provided by D.getVFS() for all distribution checks,
including those performing read of the release file. Requested
by @bruno on https://reviews.llvm.org/D24954.
mgorny created this revision.
mgorny added reviewers: rafael, chandlerc, bruno, bkramer.
mgorny added a subscriber: cfe-commits.
Support using gcc-config to determine the correct GCC toolchain location
on Gentoo. In order to do that, attempt to read gcc-config configuration
form [[sysroot]]/etc/en
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1446-1463
+ // CURRENT=triple-version
+ if (Line.startswith("CURRENT=")) {
+const std::pair ActiveVersion =
+ Line.substr(8).rsplit('-');
+// Note: Strictly
https://github.com/mgorny approved this pull request.
Code LGTM but please add a note to the release notes, as was requested.
https://github.com/llvm/llvm-project/pull/74025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
Author: Frederic Cambus
Date: 2021-07-29T20:33:39+02:00
New Revision: bc96aa9f2c9b25ae65a7e05dbbff8c28079db9c9
URL:
https://github.com/llvm/llvm-project/commit/bc96aa9f2c9b25ae65a7e05dbbff8c28079db9c9
DIFF:
https://github.com/llvm/llvm-project/commit/bc96aa9f2c9b25ae65a7e05dbbff8c28079db9c9.dif
Author: Frederic Cambus
Date: 2021-07-29T20:34:43+02:00
New Revision: 1862ffe25a2e927ecae012f5f0c4cdf7c3fc1b67
URL:
https://github.com/llvm/llvm-project/commit/1862ffe25a2e927ecae012f5f0c4cdf7c3fc1b67
DIFF:
https://github.com/llvm/llvm-project/commit/1862ffe25a2e927ecae012f5f0c4cdf7c3fc1b67.dif
https://github.com/mgorny created
https://github.com/llvm/llvm-project/pull/86386
Move the code adding top-level cmake/Modules directory to CMAKE_MODULE_PATH
prior to including `GetDarwinLinkerVersion`, in order to fix standalone builds.
Fixes a regression introduced by 3bc71c2abfa00413fd15cf0
mgorny wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/86386
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 304 matches
Mail list logo
