[PATCH] D38441: [compiler-rt] [cmake] Add a separate CMake var to control profile runtime

mgorny created this revision. Herald added a subscriber: dberris. Make it possible to control building profile runtime separately from other options. Before r313549, the profile runtime building was controlled along with sanitizers. However, since that commit it is built unconditionally which resu

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

mgorny created this revision. Herald added a subscriber: dberris. Create a dummy 'gtest' target to satisfy the test dependencies while doing stand-alone builds. Historically those dependencies were conditional to non-stand-alone builds but the refactoring in https://reviews.llvm.org/rL310971 has m

[PATCH] D38441: [compiler-rt] [cmake] Add a separate CMake var to control profile runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rL314646: [cmake] Add a separate CMake var to control profile runtime (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38441?vs=117255&id=117299#toc Repository: rL LLVM https:/

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

mgorny added a comment. In https://reviews.llvm.org/D38444#886138, @george.karpenkov wrote: > > breaking stand-alone builds as a result > > That's a strong statement. Could you clarify? We have a lot of buildbots > performing standalone builds, and they are still green. I didn't know anyone ac

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

mgorny added a comment. In https://reviews.llvm.org/D38444#895403, @george.karpenkov wrote: > @mgorny I've replied via email, but the message didn't seem to appear here. > > From my (maybe limited) understanding, running tests on standalone > compiler-rt builds was never something which was supp

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

mgorny abandoned this revision. mgorny added a comment. Ok, I think I've found a better solution. Will start submitting patches soonish. Repository: rL LLVM https://reviews.llvm.org/D38444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()

mgorny created this revision. Herald added a subscriber: dberris. Fix typo in variable assignment inside sanitizer_test_compile() that resulted in TEST_DEPS parameter not being included in the clang_compile() call. Spotted by George Karpenkov in https://reviews.llvm.org/D38444. https://reviews.l

[PATCH] D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

mgorny created this revision. Herald added a subscriber: dberris. Fix the gtest dependency to be included in DEPS only, rather than in COMPILE_DEPS + DEPS. The former variable is apparently used to provide unconditional dependencies, while the latter are only used for non-standalone builds. Since

[PATCH] D38840: [compiler-rt] [cmake] [asan] Reuse generate_asan_tests for dynamic tests

mgorny created this revision. Herald added subscribers: dberris, kubamracek. Unify the ASAN dynamic test logic to use generate_asan_tests() in both MSVC and non-MSVC branch. It is unclear why this particular branch used add_compiler_rt_test() directly. However, it skipped the COMPILE_DEPS/DEPS log

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

mgorny added a comment. https://reviews.llvm.org/D38838 addresses the typo. Now that I know how it's supposed to work, https://reviews.llvm.org/D38839 and https://reviews.llvm.org/D38840 address the issues, and fix it for me. Repository: rL LLVM https://reviews.llvm.org/D38444 __

[PATCH] D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()

This revision was automatically updated to reflect the committed changes. Closed by commit rL315604: [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile() (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38838?vs=118752&id=118820#toc Repository: rL LLVM https:

[PATCH] D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

This revision was automatically updated to reflect the committed changes. Closed by commit rL315605: [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38839?vs=118754&id=118821#toc Repository: rL LLVM

[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

mgorny updated this revision to Diff 118826. mgorny retitled this revision from "[compiler-rt] [cmake] [asan] Reuse generate_asan_tests for dynamic tests" to "[compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests". mgorny edited the summary of this revision. mgorny added a

[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL315620: [cmake] [asan] Remove unnecessary gtest dep from dynamic tests (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38840?vs=118826&id=118842#toc Repository: rL LLVM http

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

mgorny added a comment. Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for everyone who has LLVM configured. Repository: rC Clang https://reviews.llvm.org/D51714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

mgorny added a comment. I don't have a strong opinion here. Repository: rC Clang https://reviews.llvm.org/D51714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D50171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny updated this revision to Diff 164871. mgorny added a comment. Ai, sorry about that. Uploaded the proper diff now. I suppose it's not going to make it for 7.0.0 anymore, so it's not a priority. I'll try to bisect it today once I finish testing RC3. https://reviews.llvm.org/D50171 Files:

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. Apparently the first change changing the completion results is: commit a408f8d27bfd5bab55c39ef2a6fff6850be4a351 Author: Ilya Biryukov Date: Tue Apr 24 15:48:53 2018 [CodeComplete] Fix completion at the end of keywords Summary: Make comp

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. ...and unless I'm mistaken, this commit is responsible for both changes (that is, I need to apply all of this patch to make tests pass at its point). https://reviews.llvm.org/D50171 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D49765: [CMake] Use LIBCXXABI_LIBDIR_SUFFIX in libc++abi build

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rCXXA libc++abi https://reviews.llvm.org/D49765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D50156: [test] Fix %hmaptool path for standalone builds

mgorny created this revision. mgorny added reviewers: bkramer, bruno. Fix %hmaptool path to refer to clang_tools_dir instead of llvm_tools_dir, in order to fix standalone builds. The tool is built as part of clang, so it won't be found in installed LLVM tools. Repository: rC Clang https://re

[PATCH] D50156: [test] Fix %hmaptool path for standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rC338627: [test] Fix %hmaptool path for standalone builds (authored by mgorny, committed by ). Repository: rC Clang https://reviews.llvm.org/D50156 Files: test/lit.cfg.py Index: test/lit.cfg.py

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny created this revision. mgorny added reviewers: ilya-biryukov, arphaman, bkramer, gribozavr. Update expected completions to match output generated by clang-7.0. Disclaimer: I have no clue if the results are correct. I'm kinda wondering why the '::' part is no longer included immediately.

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny added a comment. Ping for the third time. https://reviews.llvm.org/D34365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

mgorny added a comment. This is going to break Gentoo. We're relying on the ability to specify LLVM_MAIN_SRC_DIR to provide unpacked LLVM sources with gtest. Without that, I don't see how we can use tests. https://reviews.llvm.org/D32595 ___ cfe-c

[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

mgorny added a comment. (note that I don't mind removing the llvm-config bit for it; but we need the cache variable to stay) https://reviews.llvm.org/D32595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

mgorny added a comment. This causes a test failure with non-standard CLANG_RESOURCE_DIR: Command Output (stderr): -- /var/tmp/portage/sys-devel/clang-/work/x/y/clang-/test/Driver/baremetal.cpp:8:22: error: expected string not found in input // CHECK-V6M-C-SAME: "-resource-dir"

[PATCH] D33877: [test] Fix baremetal test to allow any -resource-dir

mgorny created this revision. The baremetal test (r303873) has been added with expectance of very specific -resource-dir. However, the test itself nor the BareMetal driver does not enforce any specific -resource-dir, making this constraint invalid. It already has been altered twice -- in r303910 f

[PATCH] D33877: [test] Fix baremetal test to allow any -resource-dir

This revision was automatically updated to reflect the committed changes. Closed by commit rL304715: [test] Fix baremetal test to allow any -resource-dir (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D33877?vs=101351&id=101403#toc Repository: rL LLVM https://review

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny created this revision. Provide two new CMake cache variables -- CLANG_DEFAULT_STD_C and CLANG_DEFAULT_STD_CXX -- that can be used to override the default C/ObjC and C++/ObjC++ standards appropriately. They can be set to one of the identifiers from LangStandards.def, or left unset (the defau

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny updated this revision to Diff 137227. mgorny added a comment. @rnk, could you confirm the rebased patch? I'm not sure if I should override `InputKind::RenderScript` as well. https://reviews.llvm.org/D34365 Files: CMakeLists.txt include/clang/Config/config.h.cmake lib/Frontend/Comp

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

This revision was automatically updated to reflect the committed changes. Closed by commit rL326836: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny created this revision. mgorny added a reviewer: eugenis. Herald added subscribers: dberris, srhines. mgorny added inline comments. Comment at: test/Driver/sanitizer-ld.c:517 // CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}" // CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclan

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny added inline comments. Comment at: test/Driver/sanitizer-ld.c:517 // CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}" // CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclang_rt. (an alternative would be to replace this 'NOT' clause with more specific library n

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny updated this revision to Diff 139135. mgorny edited the summary of this revision. https://reviews.llvm.org/D44645 Files: test/Driver/sanitizer-ld.c Index: test/Driver/sanitizer-ld.c === --- test/Driver/sanitizer-ld.c +++ t

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

mgorny marked 2 inline comments as done. mgorny added a comment. @eugenis, updated. https://reviews.llvm.org/D44645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47817: [sanitizer_common] Fix using libtirpc on Linux

mgorny created this revision. mgorny added reviewers: ygribov, kcc. mgorny added a project: Sanitizers. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. mgorny added a reviewer: samsonov. Fix using libtirpc on Linux by using pkg-config to detect it, and append appropriate include di

[PATCH] D47819: [test] Support using libtirpc on Linux

mgorny created this revision. mgorny added reviewers: ygribov, kcc, samsonov. mgorny added a project: Sanitizers. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Add compiler flags necessary for using libtirpc on Linux (RPC headers split out of glibc). The flags are obtained via p

[PATCH] D47817: [sanitizer_common] Fix using libtirpc on Linux

mgorny added a comment. Gentle ping. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D47817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47819: [test] Support using libtirpc on Linux

mgorny added a comment. Gentle ping. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D47819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52806: [python] Support overriding library path via environment

mgorny added a reviewer: steveire. mgorny added a comment. Gentle ping. https://reviews.llvm.org/D52806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

mgorny added a comment. @bebuch, I agree with @mclow.lists here that the new errors are completely unrelated to the problem solved by this patch, and the fix to it belongs in a separate changeset. Can we get the original problem fixed first then? https://reviews.llvm.org/D42242

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

mgorny added inline comments. Comment at: lib/Driver/Distro.cpp:139 + File = VFS.getBufferForFile("/usr/lib/os-release"); + if (File) { Technically speaking, the spec says you are supposed to read `/etc/os-release` first and fall back to `/usr/lib/os-release

[PATCH] D52840: Include Python binding tests in CMake rules

This revision was automatically updated to reflect the committed changes. Closed by commit rL344241: [tests] Include Python binding tests in CMake rules (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52840?vs=1681

[PATCH] D52806: [python] [tests] Support overriding library path via environment

This revision was automatically updated to reflect the committed changes. Closed by commit rL344240: [python] [tests] Support overriding library path via environment (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny updated this revision to Diff 169218. mgorny added a comment. v2: fixed appending to check-all to make it compatible both with in-tree and standalone builds https://reviews.llvm.org/D52840 Files: CMakeLists.txt bindings/python/tests/CMakeLists.txt Index: bindings/python/tests/CMak

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny updated this revision to Diff 169219. mgorny added a comment. v3: one more correction for stand-alone builds. https://reviews.llvm.org/D52840 Files: CMakeLists.txt bindings/python/tests/CMakeLists.txt Index: bindings/python/tests/CMakeLists.txt =

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny requested review of this revision. mgorny added a comment. Please review the new version, addressing the issue caught by buildbots. https://reviews.llvm.org/D52840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D52840: Include Python binding tests in CMake rules

This revision was automatically updated to reflect the committed changes. Closed by commit rC344258: [tests] Include Python binding tests in CMake rules (authored by mgorny, committed by ). Repository: rC Clang https://reviews.llvm.org/D52840 Files: CMakeLists.txt bindings/python/tests/CM

[PATCH] D53151: [python] [tests] Fix calling pytest on Windows (hopefully)

mgorny created this revision. mgorny added a reviewer: rnk. Fix passing arguments to the pytest command to use 'env' builtin CMake command, in order to fix compatibility with Windows. NB: I don't have a Windows environment to test it Repository: rC Clang https://reviews.llvm.org/D53151 File

[PATCH] D53151: [python] [tests] Fix calling tests on Windows (hopefully)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL344288: [python] [tests] Fix calling tests on Windows (authored by mgorny, committed by ). Herald added a subscriber: llvm

[PATCH] D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files

mgorny added a comment. Unless my bisect is mistaken, this broke Clang Python binding test: https://github.com/llvm-mirror/clang/blob/master/bindings/python/tests/cindex/test_cdb.py#L34 The test apparently assumes that compilation database will not return anything for a file that does not exist.

[PATCH] D53202: [python] [tests] Remove cdb lookup failure test

mgorny created this revision. mgorny added reviewers: sammccall, bkramer, aadg. Herald added a subscriber: arphaman. Remove the test checking for compilation db lookup failure. Since r342228, JSONCompilationDatabasePlugin infers compile commands for missing files, therefore making the lookup alway

[PATCH] D53202: [python] [tests] Remove cdb lookup failure test

mgorny added a comment. Thanks for the review! Repository: rC Clang https://reviews.llvm.org/D53202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53202: [python] [tests] Remove cdb lookup failure test

This revision was automatically updated to reflect the committed changes. Closed by commit rL344364: [python] [tests] Remove cdb lookup failure test (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53202?vs=169427&i

[PATCH] D53212: inhereit LLVM_ENABLE_LIBXML2

mgorny added inline comments. Comment at: CMakeLists.txt:92 option(CLANG_ENABLE_BOOTSTRAP "Generate the clang bootstrap target" OFF) + option(LLVM_ENABLE_LIBXM2 "Use libxml2 if available." ON) I suppose it will work better without typos. Repository: rC

[PATCH] D53239: [python] [tests] Disable python binding tests when building with LLVM_USE_SANITIZER=Address

mgorny accepted this revision. mgorny added a comment. WFM. Thanks for analyzing the problem. Comment at: bindings/python/tests/CMakeLists.txt:27 +# with ASan. +if((NOT WIN32) AND (NOT LLVM_USE_ASAN)) set_property(GLOBAL APPEND PROPERTY Hmm, I don't think

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny added a comment. The first one seems to indicate that your `libclang.so` is broken in release mode (optimization error?). The second one is correct (some of the tests test for errors, and apparently don't silence the messages). Repository: rC Clang https://reviews.llvm.org/D52840

[PATCH] D53326: [python] [tests] Disable on known-broken arches

mgorny created this revision. mgorny added reviewers: uweigand, yroux, kparzysz, steveire, aaron.ballman. Herald added a reviewer: javed.absar. Herald added a subscriber: kristof.beyls. Disable the Python binding tests on AArch64, Hexagon and SystemZ following reports on test failures. The first

[PATCH] D52840: Include Python binding tests in CMake rules

mgorny added a comment. Thanks for all your reports. I have filed https://reviews.llvm.org/D53326 to disable the tests on all three known-broken arches. Repository: rC Clang https://reviews.llvm.org/D52840 ___ cfe-commits mailing list cfe-commit

[PATCH] D53326: [python] [tests] Disable on known-broken arches

This revision was automatically updated to reflect the committed changes. Closed by commit rC344666: [python] [tests] Disable on known-broken arches (authored by mgorny, committed by ). Repository: rC Clang https://reviews.llvm.org/D53326 Files: bindings/python/tests/CMakeLists.txt Index:

[PATCH] D53326: [python] [tests] Disable on known-broken arches

This revision was automatically updated to reflect the committed changes. Closed by commit rL344666: [python] [tests] Disable on known-broken arches (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53326?vs=169832&i

[PATCH] D53326: [python] [tests] Disable on known-broken arches

mgorny added a comment. Thanks for the review. I'm going to be away most of the day today, so if it breaks something (worse), feel free to revert. Repository: rL LLVM https://reviews.llvm.org/D53326 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D47819: [test] Support using libtirpc on Linux

mgorny updated this revision to Diff 171647. mgorny added a comment. Rebased. https://reviews.llvm.org/D47819 Files: cmake/base-config-ix.cmake lib/sanitizer_common/CMakeLists.txt test/msan/lit.cfg test/msan/lit.site.cfg.in test/tsan/lit.cfg test/tsan/lit.site.cfg.in Index: test/t

[PATCH] D47817: [sanitizer_common] Fix using libtirpc on Linux

mgorny updated this revision to Diff 171646. mgorny added a comment. Rebased. https://reviews.llvm.org/D47817 Files: lib/sanitizer_common/CMakeLists.txt lib/sanitizer_common/sanitizer_platform_limits_posix.cc Index: lib/sanitizer_common/sanitizer_platform_limits_posix.cc =

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM, presuming the tests pass for you. https://reviews.llvm.org/D53125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

mgorny added a comment. @philip.pfaffe, did you establish whether this is still necessary or can be abandoned? https://reviews.llvm.org/D49486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. @ruiu, what if one of the systems changes defaults (e.g. due to Hardening) and starts defaulting to noexecstack? In that case we'd want `-z execstack' to actually emit PT_GNU_STACK, and I don't think we really are able to 100% detect the default in clang. I'd really see

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Actually, I've just researched a bit and default stack permissions depend on arch in glibc, so assuming it's RWX by default is wrong. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 181268. mgorny added a comment. Implemented checking the triple against target registry. Also made `--version` output the detected target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 Files: ELF/Config.

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

mgorny created this revision. mgorny added a reviewer: krytarowski. Repository: rC Clang https://reviews.llvm.org/D56607 Files: lib/Driver/ToolChains/NetBSD.cpp Index: lib/Driver/ToolChains/NetBSD.cpp === --- lib/Driver/ToolCh

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

mgorny updated this revision to Diff 181356. mgorny added a comment. Herald added a subscriber: cryptoad. Updated the tests to account for most of the known sanitizer types. Notes/TODO: 1. I wasn't able to get a sane match for `-fsanitize=undefined`, so I just check if it enables anything. 2. `

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

This revision was automatically updated to reflect the committed changes. Closed by commit rL351002: [NetBSD] Enable additional sanitizer types (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56607?vs=181356&id=181

[PATCH] D56647: [WIP] [ELF] Implement --copy-dt-needed-entries

mgorny created this revision. mgorny added reviewers: ruiu, krytarowski. Herald added subscribers: llvm-commits, jfb, arichardson, emaste. Herald added a reviewer: espindola. This is my proof-of-concept on making `--copy-dt-needed-entries` work. Apparently, i've been able to hack on it hard enoug

[PATCH] D56650: [lld] [ELF] Support inferring target triple from filename

mgorny created this revision. mgorny added reviewers: ruiu, joerg, krytarowski, arichardson. Herald added subscribers: llvm-commits, emaste. Herald added a reviewer: espindola. Support inferring the target triple from linker filename (e.g. ${triple}-ld.lld), and customizing the linker behavior bas

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny added inline comments. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + krytarowski wrote: > krytarowski wrote: > > arichardson wrote: > > > arichardson wrote: > >

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 181484. mgorny marked 7 inline comments as done. mgorny set the repository for this revision to rLLD LLVM Linker. mgorny added a comment. Herald added a subscriber: fedor.sergeev. Split target logic into D56650 , switched to us

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

mgorny added a comment. Ping. I'd really like to merge this before the branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47819/new/ https://reviews.llvm.org/D47819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny updated this revision to Diff 181552. mgorny retitled this revision from "[lld] [ELF] Support inferring target triple from filename" to "[lld] [ELF] Support customizing behavior on target triple". mgorny edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: ELF/Driver.cpp:757 + if (!TargetOpt.empty()) { +// TODO: do we want to verify it and fail on unsupported? +Config->TargetTriple = llvm::Triple(TargetOpt); arichardson wrot

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny updated this revision to Diff 181554. mgorny marked an inline comment as done. mgorny added a comment. Fixed leaving triple unset on invalid `--target`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56650/new/ https://reviews.llvm.org/D56650 Files: ELF/Config.h ELF/Driver.cp

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

mgorny marked 2 inline comments as done. mgorny added a comment. In D47819#1356347 , @Lekensteyn wrote: > The direction of this patch looks reasonable to me. Is it worth mentioning > the issue (https://github.com/google/sanitizers/issues/974) in the commi

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

mgorny added a comment. PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_bytes.cc (2932 of 6195) PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_string.cc (2935 of 6195) PASS: MemorySanitizer-X86_64 :: Linux/sunrpc.cc (2974 of 6195) PASS: ThreadSanitizer-x86_64 :: sunrpc.cc (5110 of 6195) So yep

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT351109: [test] Disable sunrpc tests when rpc/xdr.h is missing (authored by mgorny, committed by ). Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47819/new/

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny marked 2 inline comments as done. mgorny added a comment. @ruiu, what do you think? The current logic forces some precedence, i.e. if you pass `-z nognustack`, further `-z {no,}execstack` are ignored. I suppose we could just force passing `-z nognustack` as last option clang-wise. Repos

[PATCH] D56732: [clang] [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF

mgorny created this revision. mgorny added a reviewer: thakis. Disable Python binding tests when LLVM_ENABLE_PIC is disabled, as libclang.so is not being built in that case. Reported by Nico Weber. @thakis, could you test it, please? Repository: rC Clang https://reviews.llvm.org/D56732 Fil

[PATCH] D56732: [clang] [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF

This revision was automatically updated to reflect the committed changes. Closed by commit rC351304: [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF (authored by mgorny, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56732/new/ https://re

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, ruiu, chandlerc, rsmith. Pass library search paths to linker as -L options, similarly to how other toolchain drivers do it. This fixes compatibility with vanilla LLD. Bug report: https://bugs.llvm.org/show_bug.cgi?id=33155

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny created this revision. mgorny added reviewers: krytarowski, sammccall, hokein, ilya-biryukov, rnk. Pass -ccc-install-dir explicitly as the compilation database code does not pass argv[0] to getMainExecutable(), while some systems require it to return the correct path. Since the relevant co

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny added a comment. In D56976#1365001 , @ilya-biryukov wrote: > LGTM to unbreak the tests on *BSD, but could you please leave a comment? > It would probably be best to take `argv[0]` into account on *BSD systems as > well (possibly only if `clang` c

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny marked an inline comment as done. mgorny added a comment. In D56976#1365190 , @ilya-biryukov wrote: > Was confused about your comment, so it works on other systems because they > don't rely on `argv[0]` to get the path to main executable. Got you.

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny updated this revision to Diff 182785. mgorny added a comment. Added a comment as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56976/new/ https://reviews.llvm.org/D56976 Files: test/Tooling/clang-check-mac-libcxx-fixed-compilation-db.cpp Index: test/Tooling/clang-

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

This revision was automatically updated to reflect the committed changes. Closed by commit rL351752: [test] Pass -ccc-install-dir in mac compilation db test (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56976?vs=

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Just to be clear, are you suggesting that I add `-z gnustack` as well? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. In D56554#1369592 , @ruiu wrote: > No, I'm suggesting you add execstack, noexecstack and nognustack as a > tri-state -z flag. Does this sound good? Do you mean that of those three options, the last one specified should take prec

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

mgorny added a comment. Gentle ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56932/new/ https://reviews.llvm.org/D56932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. In D56554#1369606 , @mgorny wrote: > In D56554#1369592 , @ruiu wrote: > > > No, I'm suggesting you add execstack, noexecstack and nognustack as a > > tri-state -z flag. Does this sound good?

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny updated this revision to Diff 183729. mgorny added a comment. Ok, here's my proposition of using trinary enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 Files: ELF/Config.h ELF/Driver.cpp ELF/Writer.cpp docs/ld.lld.1 test/

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, phosek, dlj. Herald added a subscriber: dberris. Append appropriate -rpath when using shared compiler-rt runtimes, e.g. '-fsanitize=address -shared-libasan'. There's already a similar logic in CommonArgs.cpp but it uses non

  1   2   3   4   5   6   7   8   9   >