[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary

mibintc added a comment. There's a bug in this patch that i haven't solved yet. I think it's just 1 bug. The bug is that the AST statement visitor is going to the "fallback" instead of the right destination when walking CompoundAssignmentOperator. This patch collapses CompoundAssignmentOperato

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary

mibintc created this revision. mibintc added reviewers: rjmccall, sepavloff. Herald added subscribers: martong, jfb, arphaman. Herald added a reviewer: shafik. Herald added a project: clang. mibintc added a comment. There's a bug in this patch that i haven't solved yet. I think it's just 1 bug. T

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 243888. mibintc added a comment. Herald added subscribers: kbarton, jvesely, nemanjai. This patch is a work in progress. The problem that I want to work on next is that the scope is wrong when the pragma token is seen following the right brace of a function

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#1869931 , @lebedev.ri wrote: > I would think `contract` change can be separated from the rest of the > changes, and therefore should be a separate review (to reduce noise)? I split off that change to https://reviews.ll

[PATCH] D74436: Change clang default to -ffp-model=precise

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, lebedev.ri, rjmccall, sepavloff. Herald added subscribers: kbarton, nemanjai. Herald added a project: clang. This patch establishes the default option for -ffp-model to select "precise". Further, -ffp-model=precise also ena

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. mibintc marked 2 inline comments as done. Closed by commit rG3fcdf2fa945a: Change clang option -ffp-model=precise to select ffp-contract=on (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc marked 2 inline comments as done. mibintc added a comment. some replies to Andy. I'll upload another patch here which passed check-all locally. then i'll re-commit it. Comment at: clang/docs/UsersManual.rst:1388 - * ``precise`` Disables optimizations that are not v

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc updated this revision to Diff 244178. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ppc-emmintrin.c

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#1875273 , @jsji wrote: > This is also breaking test-suites in our internal buildbots .. > > This change is actually changing the default behavior: if user does NOT > supply `-ffp-contract`, it becomes `-ffp-contract=on`.

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. @jsji Will your backend tolerate -ffp-contract=on if optimizations are not disabled, e.g. -O2? We are proposing that the default floating point model be -ffp-model=precise, and with precise model, the ffp-contract=on. However you are right we don't want the frontend to

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 244894. mibintc added a comment. I found the problem in the #pragma float_control (push/pop) stack, it was just a dumb bug. I also added -include-pch test cases, and added code to ASTWriter ASTReader to preserve the floatcontrol pragma stack For 2 of the n

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, kpn, rjmccall, sepavloff. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Intel would like to support #pragma float_control which allows control over precision and exception behavior

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 3 inline comments as done. mibintc added a comment. @sepavloff Thanks a lot for your comments. I added a few replies and I have one question, added inline. Comment at: clang/lib/Parse/ParsePragma.cpp:2522 + IdentifierInfo *II = Tok.getIdentifierInfo(); + Pragm

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. Added inline reply Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:111 // the corresponding enum in the IR. -static llvm::fp::RoundingMode ToConstrainedRoundingMD( +llvm::fp::RoundingMode clang::ToConstrained

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the wrong way to check file-scope +//since the token immediately following a fu

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 239409. mibintc added a comment. Respond to review from @sepavloff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/in

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13129 if (FunctionDecl *F = dyn_cast(CurContext)) { + // If the expression occurs inside an internal global_var_init_function + // then the FunctionDecl

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. A couple inline replies to @sepavloff ; I'll be uploading another revision. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the wro

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 240245. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Diagnostic

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 3 inline comments as done. mibintc added a comment. In D72841#1833022 , @sepavloff wrote: > I don't see tests for correctness of the pragma stack (`pragma > float_control(... push)`, `pragma float_control(pop)`). Can you add them? I added

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 240638. mibintc added a comment. rebase per @sepavloff request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/includ

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 6 inline comments as done. mibintc added a comment. In D72841#1842772 , @andrew.w.kaylor wrote: > It's not clear to me from reading this how the "precise" control is going to > work with relation to the fast math flags. I don't think MSVC

[PATCH] D44426: Fix llvm + clang build with Intel compiler

mibintc added inline comments. Comment at: include/llvm-c/Target.h:25 -#if defined(_MSC_VER) && !defined(inline) +#if defined(_MSC_VER) && !defined(inline) && !defined(__INTEL_COMPILER) #define inline __inline yvvan wrote: > mibintc wrote: > > I really think a

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 120581. mibintc added a comment. The patch to clang is the same as before. The modifications are to the test cases, I verified that all these test cases need modifications. I will also be updating the associated diff for clang/tools/extra, please review that

[PATCH] D34624: extra test modifications for D34158

mibintc updated this revision to Diff 120584. mibintc added a comment. Updated the test diff to correspond to the https://reviews.llvm.org/D34158 patch uploaded today. https://reviews.llvm.org/D34624 Files: test/pp-trace/pp-trace-pragma-general.cpp test/pp-trace/pp-trace-pragma-opencl.cpp

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc added a comment. @fedor.sergeev do you have time to review my (hopefully) final revision? Also can you recommend someone to review the extra test changes? Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc added a comment. In https://reviews.llvm.org/D34158#792858, @fedor.sergeev wrote: > > I will take a look at the final version tomorrow. Fedor, let me address the comments from Jonas (with another revision!) before you take a look. Repository: rL LLVM https://reviews.llvm.org/D3415

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc planned changes to this revision. mibintc added a comment. I'm planning to rework this patch again. sorry for the churn. Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 104911. mibintc added a subscriber: ilya-biryukov. mibintc added a comment. The previous (n-1) version didn't work: I wanted to iterate through the system include directories to check for the existence of stdc-predef.h but clang is using a different kind of

[PATCH] D34936: [clangd] Add -ffreestanding on VFS tests.

mibintc added a comment. Thanks so much! Repository: rL LLVM https://reviews.llvm.org/D34936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc added a comment. In https://reviews.llvm.org/D34158#797968, @Hahnfeld wrote: > In https://reviews.llvm.org/D34158#797170, @mibintc wrote: > > > The other test that fails is my own new test! It fails because I don't know > > how to set it up so the test thinks it has a gcc toolchain with

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 105329. mibintc added a comment. I responded to the review from Jonas Hahnfeld: I moved the entire change into ToolChains/Linux and removed the modifications to Gnu.h and Gnu.cpp; I modified the new tests to use -### with FileCheck, and added a tree in Input

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc added a comment. Jonas asked about adding a new test to ensure that "-include stdc-predef.h" does not get added if the file doesn't exist. I added a reply to that but I can't see where it went. So I'm writing the reply again. The current version of the patch doesn't check for the exist

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 105526. mibintc added a comment. I rewrote the patch the way that Richard suggested, adding a cc1 option "finclude-if-exists" and injecting #if __has_include etc. [OK to use finclude? include-if-exists preferred?] I responded to James' remarks and removed th

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 105671. mibintc added a comment. I updated the patch as James directed, moving the preinclude of stdc-predef.h into clang.cpp and out of the Linux toolchain entirely. I also needed to update a couple more tests in tools/extra, so I will need to update that

[PATCH] D34624: extra test modifications for D34158

mibintc updated this revision to Diff 105852. mibintc added a comment. With the latest proposed fix for https://reviews.llvm.org/D34158, a few more test corrections are needed. The correction consists of suppressing the new preprocessor behavior. https://reviews.llvm.org/D34158 preincludes the f

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc added a comment. In https://reviews.llvm.org/D34158#803752, @jyknight wrote: > This version is still disabling upon -nostdinc, which doesn't make sense to > me. > > You didn't remove that, nor respond explaining why you think it does make > sense? You're right, I should remove the che

[PATCH] D34624: extra test modifications for D34158

mibintc planned changes to this revision. mibintc added a comment. I need to redo the test changes. Will resubmit the diff. https://reviews.llvm.org/D34624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc updated this revision to Diff 105904. mibintc edited the summary of this revision. mibintc added a comment. I removed the check on -nostdinc; and made some updates to the test cases Repository: rL LLVM https://reviews.llvm.org/D34158 Files: include/clang/Driver/CC1Options.td incl

[PATCH] D34624: extra test modifications for D34158

mibintc updated this revision to Diff 105906. mibintc edited the summary of this revision. mibintc added a comment. This patch corresponds to these modifications to clang: https://reviews.llvm.org/D34158?id=105904 Repository: rL LLVM https://reviews.llvm.org/D34624 Files: test/clang-tidy/

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc added a comment. OK folks, I was off the grid last week but I'm back now, and at my grindstone again. I haven't received any comments since I updated the patch to remove the checks on "-nostdinc". Look OK to commit? Many thanks for all your reviews --Melanie Repository: rL LLVM ht

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc planned changes to this revision. mibintc added a comment. I'm going to rebase the patch to latest. Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc updated this revision to Diff 108519. mibintc added a comment. Here is an updated diff which is rebased to current trunk per @fedor.sergeev 's suggestion (thank you). make check-all and check-clang are working for me on Linux with no unexpected failures. The associated patch for test

[PATCH] D101192: Add support for #elifdef and #elifndef

mibintc added a comment. Wow thanks for doing this! I worked on it a couple days a while ago but I abandoned the effort and went back to my day job. It seems like preprocessing ought to be something like a "state machine" but I couldn't figure out the mechanism. Would it make sense to add some

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 340598. mibintc added a reviewer: aaron.ballman. mibintc added a comment. Herald added subscribers: jansvoboda11, dexonsmith, lxfind, dang, kerbowa, kbarton, aheejin, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. I think this patch is compl

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. some inline comments for reviewers Comment at: clang/include/clang/Basic/TargetInfo.h:1162 /// the language based on the target options where applicable. - virtual void adjust(LangOptions &Opts); + virtual void adjust(DiagnosticsEngine &Diags, Lang

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc abandoned this revision. mibintc added a comment. There was no resolution about what option name would be acceptable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 _

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls

mibintc created this revision. mibintc added reviewers: kbsmith1, erichkeane. mibintc added a project: clang-c. Herald added subscribers: dexonsmith, dang, Anastasia. mibintc requested review of this revision. Herald added a project: clang. The Intel C++ and Fortran compilers support the option -

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. @erichkeane Can you suggest reviewers for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 ___ cfe-commits mailing list cfe-

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 342478. mibintc retitled this revision from "[clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls" to "[clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arg

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 342750. mibintc added a comment. Responded to suggestions from @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 Files: clang/include/clang/Basic/LangOp

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 342792. mibintc added a comment. I rebased the patch and responded to review comments from @aaron.ballman and @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:234 +FEM_Extended, +/// Use the default float eval method specified by Target +FEM_TargetDefault mibintc wrote: > aaron.ballma

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 343666. mibintc added a comment. Respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769 Files: clang/docs/LanguageExtensions.rst clang/

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc marked 9 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:181 IdentifierInfo *Ident__is_target_environment;// __is_target_environment + IdentifierInfo *Ident__FLT_EVAL_METHOD__;// __FLT_EVAL_METHOD_

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, pengfei, kbsmith1. Herald added subscribers: dexonsmith, jfb, hiraditya. mibintc requested review of this revision. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. This is a proposal to add a new llvm intr

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc added a comment. In D99675#2671924 , @efriedma wrote: >> The expression “llvm.arith.fence(a * b) + c” means that “a * b” must happen >> before “+ c” and FMA guarantees that, but to prevent later optimizations >> from unpacking the FMA the correct

[PATCH] D100118: [clang] RFC Support new arithmetic __fence builtin to control floating point optiization

mibintc created this revision. mibintc added a reviewer: kpn. Herald added a subscriber: jfb. mibintc requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This is a proposal to add a new clang builtin, __arithmetic_fence. The purpose of

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc added a comment. I received a bug report that this patch creates error diagnostics for calls to a builtin, like calling 'abort', 'exit' or one of the target builtins like __builtin_ia32_packssw then that call should be allowed without remark but this patch causes the compilation to fail

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc added a comment. In D97764#2685742 , @craig.topper wrote: > In D97764#2685655 , @mibintc wrote: > >> I received a bug report that this patch creates error diagnostics for calls >> to a builtin, like callin

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc created this revision. mibintc added a reviewer: aaron.ballman. Herald added a subscriber: pengfei. mibintc requested review of this revision. Herald added a project: clang. I got a bug report that https://reviews.llvm.org/D97764 which introduced this diagnostic, was causing problems in i

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc updated this revision to Diff 337731. mibintc added a comment. I removed the diagnostic from InGroup, that's the only change from previous revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/ https://reviews.llvm.org/D100511

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:299 + " with attribute 'no_caller_saved_registers'">, + InGroup; def warn_arm_interrupt_calling_convention : Warning< rsmith

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc updated this revision to Diff 337789. mibintc marked an inline comment as done. mibintc added a comment. I added the InGroup rule for the new warning diagnostic like Aaron requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

This revision was automatically updated to reflect the committed changes. Closed by commit rG938b863bb53f: [clang][patch] Modify diagnostic level from err to warn… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/ http

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 337879. mibintc edited the summary of this revision. mibintc added a comment. This is a minor update from @pengfei which allows simple tests cases to run end-to-end with clang. Also I changed the "summary" to reflect the review discussion around the FMA opti

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 337881. mibintc retitled this revision from "[clang] RFC Support new builtin __arithmetic_fence to control floating point optiization" to "[clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotec

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 338099. mibintc added a comment. I accidentally dropped the test case in previous commit. Just adding it back in -- under the llvm/test directory (previously it was in the wrong location). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc added a comment. In D99675#2695424 , @kpn wrote: > What changes are needed for a backend, and what happens if they aren't done? In the clang patch, I'm planning to add into TargetInfo a function like "does the target support __arithmetic_fence"?

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

mibintc added a comment. The diff appears to be 2 separate commits, so on first glance this is only patching the test files. Usually if I am working on a patch and have responded to comments, I compress the patch+updates into a single commit (git rebase -i) before creating a diff to upload to P

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); kpn wrote: > Does this say that the fence will

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); mibintc wrote: > kpn wrote: > > Does this say

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); mibintc wrote: > mibintc wrote: > > kpn wrote:

[PATCH] D93769: RFC [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. @rjmccall Hoping you can take a look at this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769 ___ cfe-commits mailing list cfe-commi

<    1   2   3   4   5